[GitHub] [kafka] showuon commented on a change in pull request #11120: Add support for infinite endpoints for range queries

showuon commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r677209624 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java ## @@ -63,6 +65,9 @@ final KeyValue next

[jira] [Assigned] (KAFKA-13120) Flesh out `streams_static_membership_test` to be more robust

[ https://issues.apache.org/jira/browse/KAFKA-13120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny reassigned KAFKA-13120: - Assignee: KahnCheny (was: Reggie Hsu) > Flesh out `streams_static_membership_test` to be more

[jira] [Assigned] (KAFKA-13120) Flesh out `streams_static_membership_test` to be more robust

[ https://issues.apache.org/jira/browse/KAFKA-13120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny reassigned KAFKA-13120: - Assignee: Reggie Hsu (was: KahnCheny) > Flesh out `streams_static_membership_test` to be more

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r677285658 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java ## @@ -63,17 +65,20 @@ final KeyVal

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r677285658 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java ## @@ -63,17 +65,20 @@ final KeyVal

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r677292872 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java ## @@ -44,17 +44,19 @@ this.forward

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11120: Add support for infinite endpoints for range queries

patrickstuedi commented on a change in pull request #11120: URL: https://github.com/apache/kafka/pull/11120#discussion_r677296530 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBRangeIterator.java ## @@ -63,6 +65,9 @@ final KeyValue

[jira] [Assigned] (KAFKA-10310) Kafka Raft Snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-10310: -- Assignee: loboxu (was: Jose Armando Garcia Sancio) > Kafka Raft Snapshot > --- > >

[GitHub] [kafka] vvcephei commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

vvcephei commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-887513532 It looks like there's a new conflict. Hopefully, we can merge soon after you fix the conflict this time. By the way, can you let me know the command you used to apply the

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-887524211 Thanks for the review @vvcephei ! Actually, the spotless task executes the scalafmt in this gradle config, this means running `./gradlew spotlessScalaCheck` will analyze all Sc

[GitHub] [kafka] jlprat edited a comment on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

jlprat edited a comment on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-887524211 Thanks for the review @vvcephei ! Actually, the spotless task executes the scalafmt in this gradle config, this means running `./gradlew spotlessScalaCheck` will analyze

[GitHub] [kafka] rondagostino commented on pull request #11131: KAFKA-13137: KRaft Controller Metric MBean names incorrectly quoted

rondagostino commented on pull request #11131: URL: https://github.com/apache/kafka/pull/11131#issuecomment-887525250 Thanks for the reviews @hachikuji and @showuon. The test is revamped so that the method is `private static void assertExpectedMetrics(Set expectedMetricNames, String expec

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-887529961 As new code has been added I need to re-run scalafmt for those. Pushing those changes in a second. -- This is an automated message from the Apache Git Service. To respond to th

[jira] [Commented] (KAFKA-13139) Empty response after requesting to restart a connector without the tasks results in NPE

[ https://issues.apache.org/jira/browse/KAFKA-13139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388116#comment-17388116 ] Randall Hauch commented on KAFKA-13139: --- Just to clarify what appears to have happ

[GitHub] [kafka] rhauch commented on a change in pull request #11132: KAFKA-13139: Empty response after requesting to restart a connector without the tasks results in NPE

rhauch commented on a change in pull request #11132: URL: https://github.com/apache/kafka/pull/11132#discussion_r677530176 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -269,7 +269,7 @@ public Response

[jira] [Created] (KAFKA-13140) KRaft brokers do not expose kafka.controller metrics, breaking backwards compatibility

Ron Dagostino created KAFKA-13140: - Summary: KRaft brokers do not expose kafka.controller metrics, breaking backwards compatibility Key: KAFKA-13140 URL: https://issues.apache.org/jira/browse/KAFKA-13140

[GitHub] [kafka] rondagostino opened a new pull request #11133: KAFKA-13140: KRaft brokers do not expose kafka.controller metrics

rondagostino opened a new pull request #11133: URL: https://github.com/apache/kafka/pull/11133 Several controller metrics are exposed on every broker in a ZooKeeper-based (i.e. non-KRaft) cluster regardless of whether the broker is the active controller or not, but these metrics are not ex

[GitHub] [kafka] douglasawh commented on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

douglasawh commented on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-887607101 Any thoughts on when this might get merged? I see that checks have failed, so I'm guessing the fix is not ideal, but I haven't looked at the code in depth. -- This is an auto

[jira] [Assigned] (KAFKA-10310) Kafka Raft Snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-10310: -- Assignee: Jose Armando Garcia Sancio (was: loboxu) > Kafka R

[GitHub] [kafka] kirktrue commented on pull request #10951: KAFKA-12841: NPE from the provided metadata in client callback in case of ApiException

kirktrue commented on pull request #10951: URL: https://github.com/apache/kafka/pull/10951#issuecomment-887627439 Thanks @cmccabe for looking at this! > If I understand correctly, the PR makes up a fake partition so that `TopicPartition` can be non-null in the callback. I don't think

[GitHub] [kafka] kirktrue commented on pull request #10980: KAFKA-12989: MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

kirktrue commented on pull request #10980: URL: https://github.com/apache/kafka/pull/10980#issuecomment-887635572 > Why is `NetworkClient#send` throwing an exception? It shouldn't be doing that, right? Can you explain more about the problem that this PR fixes? Per [the original issue

[GitHub] [kafka] kirktrue edited a comment on pull request #10980: KAFKA-12989: MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

kirktrue edited a comment on pull request #10980: URL: https://github.com/apache/kafka/pull/10980#issuecomment-887635572 > Why is `NetworkClient#send` throwing an exception? It shouldn't be doing that, right? Can you explain more about the problem that this PR fixes? Per [the origina

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-887638986 Something went wrong during the build, can someone re-trigger the build in Jenkins? Failure was: > [2021-07-27T14:23:53.802Z] FAILURE: Build failed with an exception.

[jira] [Assigned] (KAFKA-12793) Client-side Circuit Breaker for Partition Write Errors

[ https://issues.apache.org/jira/browse/KAFKA-12793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KahnCheny reassigned KAFKA-12793: - Assignee: KahnCheny > Client-side Circuit Breaker for Partition Write Errors >

[GitHub] [kafka] jsancio commented on a change in pull request #11133: KAFKA-13140: KRaft brokers do not expose kafka.controller metrics

jsancio commented on a change in pull request #11133: URL: https://github.com/apache/kafka/pull/11133#discussion_r677612215 ## File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala ## @@ -100,6 +101,9 @@ class KafkaRaftServer( controllerQuorumVotersFuture

[GitHub] [kafka] jsancio opened a new pull request #11134: KAFKA-12851: Fix Raft partition simulation

jsancio opened a new pull request #11134: URL: https://github.com/apache/kafka/pull/11134 Instead of waiting for a high-watermark of 20 after the partition, the test should wait for the high-watermark to reach an offset greater than the largest log end offset at the time of the partiti

[GitHub] [kafka] jsancio commented on a change in pull request #11116: KAFKA-13114: Revert state and reregister raft listener

jsancio commented on a change in pull request #6: URL: https://github.com/apache/kafka/pull/6#discussion_r677635360 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -783,6 +798,11 @@ public void handleLeaderChange(LeaderAndEp

[GitHub] [kafka] guozhangwang commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

guozhangwang commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r677649333 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -161,22 +162,26 @@ class TransactionStateManager

[GitHub] [kafka] hachikuji commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

hachikuji commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r677652114 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -161,22 +162,26 @@ class TransactionStateManager(br

[GitHub] [kafka] vamossagar12 commented on pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on pull request #10798: URL: https://github.com/apache/kafka/pull/10798#issuecomment-887703246 hey @guozhangwang / @cadonna .. sorry for being nosey here but did you get a chance to look at these numbers? -- This is an automated message from the Apache Git Service

[GitHub] [kafka] vamossagar12 commented on pull request #11076: KAFKA-12486: Enforce Rebalance when a TaskCorruptedException is throw…

vamossagar12 commented on pull request #11076: URL: https://github.com/apache/kafka/pull/11076#issuecomment-887710210 @ableegoldman .. sorry to bother you again on this one.. but could you plz review whenever you get the chance.. -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] guozhangwang commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

guozhangwang commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r677680568 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -161,22 +162,26 @@ class TransactionStateManager

[jira] [Assigned] (KAFKA-13095) TransactionsTest is failing in kraft mode

[ https://issues.apache.org/jira/browse/KAFKA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13095: --- Assignee: Jason Gustafson (was: David Arthur) > TransactionsTest is failing in kra

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388235#comment-17388235 ] Sagar Rao commented on KAFKA-8295: -- [~ableegoldman].. wanted to know, if we can have a K

[jira] [Comment Edited] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388235#comment-17388235 ] Sagar Rao edited comment on KAFKA-8295 at 7/27/21, 6:15 PM: [

[jira] [Created] (KAFKA-13141) Leader should not update follower fetch offset if diverging epoch is present

Jason Gustafson created KAFKA-13141: --- Summary: Leader should not update follower fetch offset if diverging epoch is present Key: KAFKA-13141 URL: https://issues.apache.org/jira/browse/KAFKA-13141 Pr

[jira] [Created] (KAFKA-13142) KRaft controller does not validate dynamic configs

Ryan Dielhenn created KAFKA-13142: - Summary: KRaft controller does not validate dynamic configs Key: KAFKA-13142 URL: https://issues.apache.org/jira/browse/KAFKA-13142 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-13143) Disable Metadata endpoint for KRaft controller

Jason Gustafson created KAFKA-13143: --- Summary: Disable Metadata endpoint for KRaft controller Key: KAFKA-13143 URL: https://issues.apache.org/jira/browse/KAFKA-13143 Project: Kafka Issue Ty

[GitHub] [kafka] kkonstantine commented on pull request #11132: KAFKA-13139: Empty response after requesting to restart a connector without the tasks results in NPE

kkonstantine commented on pull request #11132: URL: https://github.com/apache/kafka/pull/11132#issuecomment-887819548 Thank you both. Merging to trunk and 3.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] kkonstantine commented on pull request #11132: KAFKA-13139: Empty response after requesting to restart a connector without the tasks results in NPE

kkonstantine commented on pull request #11132: URL: https://github.com/apache/kafka/pull/11132#issuecomment-887820306 A single, non-relevant, test failed on the second build: `Build / JDK 8 and Scala 2.12 / kafka.server.DelegationTokenRequestsTest.testDelegationTokenRequests()` -- Th

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r677784769 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java ## @@ -16,10 +16,294 @@ */ package org.apa

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r677784899 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -345,8 +343,17 @@ private SinkNo

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r677785678 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -1065,14 +1086,22 @@ private voi

[jira] [Assigned] (KAFKA-13143) Disable Metadata endpoint for KRaft controller

[ https://issues.apache.org/jira/browse/KAFKA-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13143: --- Assignee: Niket Goel (was: Jose Armando Garcia Sancio) > Disable Metadata endpoint

[jira] [Updated] (KAFKA-13143) Disable Metadata endpoint for KRaft controller

[ https://issues.apache.org/jira/browse/KAFKA-13143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13143: Issue Type: Bug (was: Improvement) > Disable Metadata endpoint for KRaft controller > ---

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r677786276 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -345,8 +343,17 @@ private SinkNo

[GitHub] [kafka] kkonstantine merged pull request #11132: KAFKA-13139: Empty response after requesting to restart a connector without the tasks results in NPE

kkonstantine merged pull request #11132: URL: https://github.com/apache/kafka/pull/11132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Resolved] (KAFKA-13139) Empty response after requesting to restart a connector without the tasks results in NPE

[ https://issues.apache.org/jira/browse/KAFKA-13139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-13139. Resolution: Fixed > Empty response after requesting to restart a connector

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388304#comment-17388304 ] A. Sophie Blee-Goldman commented on KAFKA-8295: --- I was just re-reading the

[GitHub] [kafka] niket-goel opened a new pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel opened a new pull request #11135: URL: https://github.com/apache/kafka/pull/11135 This PR is WIP and the test added does not work yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] niket-goel commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677815515 ## File path: clients/src/main/resources/common/message/MetadataRequest.json ## @@ -16,9 +16,9 @@ { "apiKey": 3, "type": "request", - "listener

[GitHub] [kafka] hachikuji commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

hachikuji commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677818654 ## File path: clients/src/main/resources/common/message/MetadataRequest.json ## @@ -16,9 +16,9 @@ { "apiKey": 3, "type": "request", - "listeners

[GitHub] [kafka] hachikuji commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

hachikuji commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677819183 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -151,6 +150,11 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] niket-goel commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677820374 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -151,6 +150,11 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] hachikuji commented on a change in pull request #11134: KAFKA-12851: Fix Raft partition simulation

hachikuji commented on a change in pull request #11134: URL: https://github.com/apache/kafka/pull/11134#discussion_r677821521 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -171,6 +171,12 @@ private boolean updateHighWatermark() {

[GitHub] [kafka] niket-goel commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677821728 ## File path: clients/src/main/resources/common/message/MetadataRequest.json ## @@ -16,9 +16,9 @@ { "apiKey": 3, "type": "request", - "listener

[jira] [Assigned] (KAFKA-13141) Leader should not update follower fetch offset if diverging epoch is present

[ https://issues.apache.org/jira/browse/KAFKA-13141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-13141: --- Assignee: Rajini Sivaram (was: Jason Gustafson) > Leader should not update followe

[jira] [Commented] (KAFKA-12713) Report "REAL" follower/consumer fetch latency

[ https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388324#comment-17388324 ] Kai Huang commented on KAFKA-12713: --- Twitter would be interested to pursue this work t

[jira] [Commented] (KAFKA-13139) Empty response after requesting to restart a connector without the tasks results in NPE

[ https://issues.apache.org/jira/browse/KAFKA-13139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388332#comment-17388332 ] Kalpesh Patel commented on KAFKA-13139: --- Thanks a lot [~rhauch] and [~kkonstantine

[GitHub] [kafka] hachikuji commented on a change in pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

hachikuji commented on a change in pull request #11098: URL: https://github.com/apache/kafka/pull/11098#discussion_r677847584 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -161,22 +162,26 @@ class TransactionStateManager(br

[GitHub] [kafka] hachikuji commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

hachikuji commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r677853531 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1367,12 +1367,25 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a change in pull request #11126: KAFKA-13132: Upgrading to topic IDs in LISR requests has gaps introduced in 3.0

jolshan commented on a change in pull request #11126: URL: https://github.com/apache/kafka/pull/11126#discussion_r677854946 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1367,12 +1367,25 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] guozhangwang commented on a change in pull request #10683: KAFKA-12648: Pt. 2 - Introduce TopologyMetadata to wrap InternalTopologyBuilders of named topologies

guozhangwang commented on a change in pull request #10683: URL: https://github.com/apache/kafka/pull/10683#discussion_r677787551 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -859,27 +855,27 @@ private KafkaStreams(final InternalTopologyBu

[GitHub] [kafka] jsancio commented on a change in pull request #11134: KAFKA-12851: Fix Raft partition simulation

jsancio commented on a change in pull request #11134: URL: https://github.com/apache/kafka/pull/11134#discussion_r677868867 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -171,6 +171,12 @@ private boolean updateHighWatermark() {

[GitHub] [kafka] niket-goel commented on a change in pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel commented on a change in pull request #11135: URL: https://github.com/apache/kafka/pull/11135#discussion_r677871792 ## File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala ## @@ -145,6 +145,14 @@ class ControllerApisTest { authorizer }

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13142: -- Summary: KRaft brokers do not validate dynamic configs before forwarding them to controller (

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13142: -- Description: The KRaft brokers are not currently validating dynamic configs before forwarding

[jira] [Commented] (KAFKA-10548) Implement deletion logic for LeaderAndIsrRequests

[ https://issues.apache.org/jira/browse/KAFKA-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388367#comment-17388367 ] Lucas Wang commented on KAFKA-10548: Hi [~jolshan] thanks for the KIP-516 and for ke

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13142: -- Priority: Major (was: Blocker) > KRaft brokers do not validate dynamic configs before forward

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-13142: -- Priority: Blocker (was: Major) > KRaft brokers do not validate dynamic configs before forward

[GitHub] [kafka] niket-goel commented on pull request #11135: KAFKA-13143 Remove HandleMetadata from ControllerAPis as metadata is not completely implemented on KRaft controllers

niket-goel commented on pull request #11135: URL: https://github.com/apache/kafka/pull/11135#issuecomment-887915977 @jsancio Without the change (as per Jason's description in the JIRA https://issues.apache.org/jira/browse/KAFKA-13143), the API would return an empty list of topics makin

[GitHub] [kafka] hachikuji commented on pull request #11131: KAFKA-13137: KRaft Controller Metric MBean names incorrectly quoted

hachikuji commented on pull request #11131: URL: https://github.com/apache/kafka/pull/11131#issuecomment-887924795 @rondagostino I've seen this test failing consistently: `kafka.controller.ControllerEventManagerTest.testMetricsCleanedOnClose()`. I tried it locally and it passes when run by

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388378#comment-17388378 ] Matthias J. Sax commented on KAFKA-9897: Works for me. > Flaky Test StoreQueryIn

[jira] [Updated] (KAFKA-13142) KRaft brokers do not validate dynamic configs before forwarding them to controller

[ https://issues.apache.org/jira/browse/KAFKA-13142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13142: --- Fix Version/s: 3.0.0 > KRaft brokers do not validate dynamic configs before

[GitHub] [kafka] hachikuji commented on pull request #11116: KAFKA-13114: Revert state and reregister raft listener

hachikuji commented on pull request #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-887935935 I'm trying to think of some approach for validating this logic. It is difficult because it is handling unexpected exceptions. One thought I had is implementing a poison messag

[GitHub] [kafka] hachikuji merged pull request #11098: KAFKA-13099; Transactional expiration should account for max batch size

hachikuji merged pull request #11098: URL: https://github.com/apache/kafka/pull/11098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] dengziming commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

dengziming commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-887949936 @rajinisivaram Are you interested in taking this across finish line? I think this has something that is very close to a first version, we can try to land that and then improvis

[GitHub] [kafka] jolshan commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-887966371 @dengziming -- @rajinisivaram can help in about 2 weeks. I will try to help review so it will be ready when she gets to it. -- This is an automated message from the Apache Git S

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677932361 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -42,6 +34,14 @@ import org.apache.kafka.common.quota.ClientQuotaFilter;

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677932954 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -303,7 +303,33 @@ default DescribeTopicsResult describeTopics(Collectio

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677933885 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677933885 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r677941027 ## File path: core/src/test/scala/integration/kafka/server/MetadataRequestBetweenDifferentIbpTest.scala ## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apac

[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-887980048 @dajac , could you help take a look at this PR? Also, do we want to put this PR into v3.0? Thank you. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] showuon commented on pull request #11124: [WIP] KAFKA-12839: use sessionWindow to represent SlidingWindows

showuon commented on pull request #11124: URL: https://github.com/apache/kafka/pull/11124#issuecomment-887989639 @mjsax @ableegoldman , I found we already had a `SessionWindow` to represent the close time interval: `[start,end]`. So I directly use it for `SlidingWindows` aggregation window

[GitHub] [kafka] ableegoldman commented on pull request #11124: [WIP] KAFKA-12839: use sessionWindow to represent SlidingWindows

ableegoldman commented on pull request #11124: URL: https://github.com/apache/kafka/pull/11124#issuecomment-887994503 It seems super awkward and likely to lead to confusion/future mistakes to use something called a `"SessionWindow"` in the "SlidingWindowAggregate", although yeah, it's pret