[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

dajac commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883146836 > @dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `REBALANC

[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883149180 Yes, you're right. We have handled all kinds of expected errors in previous PRs. So, we should only update for `AlterConsumerGroupOffsetsHandler` here, unless we also want to pu

[jira] [Commented] (KAFKA-13103) Should group admin handlers consider REBALANCE_IN_PROGRESS and GROUP_AUTHORIZATION_FAILED as retryable errors?

[ https://issues.apache.org/jira/browse/KAFKA-13103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383852#comment-17383852 ] Luke Chen commented on KAFKA-13103: --- In the PR, I put the `REBALANCE_IN_PROGRESS` into

[GitHub] [kafka] jlprat commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

jlprat commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672944792 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void shouldReport

[GitHub] [kafka] ableegoldman commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

ableegoldman commented on a change in pull request #10921: URL: https://github.com/apache/kafka/pull/10921#discussion_r672764087 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final boolean

[GitHub] [kafka] rhauch commented on pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

rhauch commented on pull request #10978: URL: https://github.com/apache/kafka/pull/10978#issuecomment-882731540 Thanks for the review, folks. @omkreddy, I renamed the new utility method as you suggested, and updated the JavaDocs as well. Hopefully the purpose and behavior is more clear.

[GitHub] [kafka] showuon commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

showuon commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be more eager than before, to fetch the offset. But, looks like we need those "fetch" to fix

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-882493385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] wcarlson5 commented on pull request #11083: KAFKA-13010: retry for tasks

wcarlson5 commented on pull request #11083: URL: https://github.com/apache/kafka/pull/11083#issuecomment-882919484 @ableegoldman @jlprat @cadonna Can I get a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jolshan commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

jolshan commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672384414 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[GitHub] [kafka] ableegoldman commented on pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

ableegoldman commented on pull request #11085: URL: https://github.com/apache/kafka/pull/11085#issuecomment-883003472 call for review @wcarlson5 @lct45 @guozhangwang @vvcephei @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964 @cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you. ``` SESSION REPORT (ALL TESTS) ducktape version:

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

rajinisivaram commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672176498 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -73,29 +75,40 @@ public St

[GitHub] [kafka] junrao merged pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

junrao merged pull request #10579: URL: https://github.com/apache/kafka/pull/10579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ccding commented on pull request #11080: fix NPE when record==null in append

ccding commented on pull request #11080: URL: https://github.com/apache/kafka/pull/11080#issuecomment-882800476 This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] dajac commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

dajac commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672245627 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -479,4 +501,31 @@ object LogConfig { logProps.put(MessageDownConversionEnableProp, k

[GitHub] [kafka] cmccabe merged pull request #11067: MINOR: log broker configs in KRaft mode

cmccabe merged pull request #11067: URL: https://github.com/apache/kafka/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

dajac commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883106256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672253775 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File], * Start the background threa

[GitHub] [kafka] ijuma merged pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma merged pull request #11078: URL: https://github.com/apache/kafka/pull/11078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882984058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] ijuma commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

ijuma commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672525835 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from-u

[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

cmccabe merged pull request #11064: URL: https://github.com/apache/kafka/pull/11064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ijuma commented on a change in pull request #11080: fix NPE when record==null in append

ijuma commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672610426 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord readFrom(ByteBuffe

[GitHub] [kafka] dajac merged pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac merged pull request #11016: URL: https://github.com/apache/kafka/pull/11016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672231624 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public String a

[GitHub] [kafka] ijuma merged pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma merged pull request #11036: URL: https://github.com/apache/kafka/pull/11036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] mumrah commented on a change in pull request #11070: Validate the controllerListener config on startup

mumrah commented on a change in pull request #11070: URL: https://github.com/apache/kafka/pull/11070#discussion_r672407194 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -137,8 +137,14 @@ class ControllerServer( credentialProvider,

[GitHub] [kafka] satishd commented on pull request #11033: KAFKA-12988 Asynchronous API support for RemoteLogMetadataManager add/update methods.

satishd commented on pull request #11033: URL: https://github.com/apache/kafka/pull/11033#issuecomment-883064875 @junrao This PR is rebased with trunk, please review and let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from

[GitHub] [kafka] jlprat closed pull request #11025: Scala 3 Compilation with 2.12 support

jlprat closed pull request #11025: URL: https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ccding commented on a change in pull request #11080: fix NPE when record==null in append

ccding commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672758944 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord readFrom(ByteBuff

[GitHub] [kafka] ijuma commented on pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma commented on pull request #11078: URL: https://github.com/apache/kafka/pull/11078#issuecomment-882544244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] showuon edited a comment on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

showuon edited a comment on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be a little more eager than before, to fetch the offset. But, looks like we need those

[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [kafka] JoeCqupt closed pull request #11088: MINOR: remove unnecessary judgment in method: assignReplicasToBrokersRackAware

JoeCqupt closed pull request #11088: URL: https://github.com/apache/kafka/pull/11088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ijuma merged pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

ijuma merged pull request #10811: URL: https://github.com/apache/kafka/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dielhennr commented on a change in pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

dielhennr commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r672693205 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -42,23 +42,38 @@ import java.util.Map.Entry;

[GitHub] [kafka] mumrah commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

mumrah commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882589793 Thanks @ijuma, I don't have any more questions or follow-ups 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] jsancio commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

jsancio commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672716678 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -302,17 +302,13 @@ private void onUpdateLeaderHighWatermark( }

[GitHub] [kafka] jsancio commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

jsancio commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672645909 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable handleEventException(Stri

[GitHub] [kafka] dielhennr commented on a change in pull request #11082: KAFKA-13104: Controller should notify raft client when it resigns

dielhennr commented on a change in pull request #11082: URL: https://github.com/apache/kafka/pull/11082#discussion_r672657134 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -284,6 +284,7 @@ private Throwable handleEventException(St

[GitHub] [kafka] rackom commented on pull request #10824: KAFKA-12718: SessionWindows are closed too early

rackom commented on pull request #10824: URL: https://github.com/apache/kafka/pull/10824#issuecomment-882348752 Hello, is there any way how to fix it in version 2.5.0? Because this is causing us some issues with very short window + gap combinations (window: 10sec, grace: 5sec). It is not a

[jira] [Created] (KAFKA-13106) Offsets deletion error

Robert Janda created KAFKA-13106: Summary: Offsets deletion error Key: KAFKA-13106 URL: https://issues.apache.org/jira/browse/KAFKA-13106 Project: Kafka Issue Type: Bug Components:

[GitHub] [kafka] showuon edited a comment on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon edited a comment on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883108362 @dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `R

[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon commented on a change in pull request #11086: URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3184,8 +3197,111 @@ public void testDeleteConsumerGro

[GitHub] [kafka] ableegoldman commented on a change in pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

ableegoldman commented on a change in pull request #11085: URL: https://github.com/apache/kafka/pull/11085#discussion_r672760705 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -719,10 +719,10 @@ void runOnce() {

[GitHub] [kafka] niket-goel commented on pull request #11070: Validate the controllerListener config on startup

niket-goel commented on pull request #11070: URL: https://github.com/apache/kafka/pull/11070#issuecomment-882782314 This PR ends up failing a bunch of existing unit tests. Taking a look at the failures. Will update the PR. List of failed tests ``` ConnectionQuotasTest. tes

[GitHub] [kafka] ijuma commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882511896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] jlprat commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

jlprat commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672944792 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void shouldReport

[GitHub] [kafka] rondagostino commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

rondagostino commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882573376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [kafka] ableegoldman commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

ableegoldman commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672762836 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void should

[GitHub] [kafka] dielhennr closed pull request #11081: MINOR: Typo in RaftClient Javadoc

dielhennr closed pull request #11081: URL: https://github.com/apache/kafka/pull/11081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

ijuma commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369 Thanks for the explanation @rondagostino. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882996715 @ijuma , thanks for the update. It looks better now! Also, thank you and @rondagostino for your patiently review! For your question: > it looks to me that we don't have

[GitHub] [kafka] mjsax commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

mjsax commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672438866 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[GitHub] [kafka] cmccabe commented on a change in pull request #11084: KAFKA-13100: Create a snapshot during leadership promotion

cmccabe commented on a change in pull request #11084: URL: https://github.com/apache/kafka/pull/11084#discussion_r672715848 ## File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java ## @@ -755,11 +766,22 @@ public void handleLeaderChange(LeaderAndE

[GitHub] [kafka] jlprat commented on pull request #11025: Scala 3 Compilation with 2.12 support

jlprat commented on pull request #11025: URL: https://github.com/apache/kafka/pull/11025#issuecomment-882487321 I will close this PR as this is not really compiling in Scala3 as Gradle's scala plugin somehow still attempts to compile in Scala 2. -- This is an automated message from the A

[GitHub] [kafka] PhilHardwick commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

PhilHardwick commented on a change in pull request #10921: URL: https://github.com/apache/kafka/pull/10921#discussion_r672966032 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final boolean

[jira] [Resolved] (KAFKA-13106) Offsets deletion error

[ https://issues.apache.org/jira/browse/KAFKA-13106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Janda resolved KAFKA-13106. -- Resolution: Fixed version 2.3.1 does not suport it > Offsets deletion error > ---

[GitHub] [kafka] cadonna commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

cadonna commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672999766 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void shouldRepor

[jira] [Created] (KAFKA-13107) KafkaServer.startup leaves server socket open if zk error is throws (ex. NodeExists)

Fuud created KAFKA-13107: Summary: KafkaServer.startup leaves server socket open if zk error is throws (ex. NodeExists) Key: KAFKA-13107 URL: https://issues.apache.org/jira/browse/KAFKA-13107 Project: Kafka

[jira] [Updated] (KAFKA-13107) KafkaServer.startup leaves server socket open if zk error is throws (ex. NodeExists)

[ https://issues.apache.org/jira/browse/KAFKA-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fuud updated KAFKA-13107: - Description: kafka.network.Acceptor#serverChannel is not closed if KafkaServer.startup is failed with zk error.

[GitHub] [kafka] ableegoldman commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

ableegoldman commented on a change in pull request #10921: URL: https://github.com/apache/kafka/pull/10921#discussion_r672764087 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final boolean

[GitHub] [kafka] rhauch commented on pull request #10978: MINOR: Use time constant algorithms when comparing passwords or keys

rhauch commented on pull request #10978: URL: https://github.com/apache/kafka/pull/10978#issuecomment-882731540 Thanks for the review, folks. @omkreddy, I renamed the new utility method as you suggested, and updated the JavaDocs as well. Hopefully the purpose and behavior is more clear.

[GitHub] [kafka] dajac merged pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac merged pull request #11016: URL: https://github.com/apache/kafka/pull/11016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-882493385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] wcarlson5 commented on pull request #11083: KAFKA-13010: retry for tasks

wcarlson5 commented on pull request #11083: URL: https://github.com/apache/kafka/pull/11083#issuecomment-882919484 @ableegoldman @jlprat @cadonna Can I get a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jolshan commented on a change in pull request #11075: MINOR: Move off deprecated APIs in StreamsResetter

jolshan commented on a change in pull request #11075: URL: https://github.com/apache/kafka/pull/11075#discussion_r672384414 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -655,7 +655,7 @@ public void doDelete(final List topicsToDelete,

[GitHub] [kafka] ableegoldman commented on pull request #11085: MINOR: reduce debug log spam and busy loop during shutdown

ableegoldman commented on pull request #11085: URL: https://github.com/apache/kafka/pull/11085#issuecomment-883003472 call for review @wcarlson5 @lct45 @guozhangwang @vvcephei @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] showuon commented on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

showuon commented on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be more eager than before, to fetch the offset. But, looks like we need those "fetch" to fix

[GitHub] [kafka] cadonna commented on a change in pull request #11083: KAFKA-13010: Retry getting tasks incase of rebalance for TaskMetadata tests

cadonna commented on a change in pull request #11083: URL: https://github.com/apache/kafka/pull/11083#discussion_r672999766 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -158,9 +158,13 @@ public void shouldRepor

[GitHub] [kafka] rajinisivaram commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

rajinisivaram commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672241651 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964 @cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you. ``` SESSION REPORT (ALL TESTS) ducktape version:

[GitHub] [kafka] ijuma commented on pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

ijuma commented on pull request #11064: URL: https://github.com/apache/kafka/pull/11064#issuecomment-882580369 Thanks for the explanation @rondagostino. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] junrao merged pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

junrao merged pull request #10579: URL: https://github.com/apache/kafka/pull/10579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ccding commented on pull request #11080: fix NPE when record==null in append

ccding commented on pull request #11080: URL: https://github.com/apache/kafka/pull/11080#issuecomment-882800476 This PR is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] dajac commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

dajac commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672245627 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -479,4 +501,31 @@ object LogConfig { logProps.put(MessageDownConversionEnableProp, k

[GitHub] [kafka] ijuma merged pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma merged pull request #11036: URL: https://github.com/apache/kafka/pull/11036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] cmccabe merged pull request #11067: MINOR: log broker configs in KRaft mode

cmccabe merged pull request #11067: URL: https://github.com/apache/kafka/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

dajac commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883106256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] ijuma merged pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma merged pull request #11078: URL: https://github.com/apache/kafka/pull/11078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

ijuma commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672525835 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from-u

[GitHub] [kafka] cmccabe merged pull request #11064: MINOR: enable reassign_partitions_test.py for kraft

cmccabe merged pull request #11064: URL: https://github.com/apache/kafka/pull/11064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] ijuma commented on a change in pull request #11080: fix NPE when record==null in append

ijuma commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672610426 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord readFrom(ByteBuffe

[GitHub] [kafka] ijuma commented on a change in pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma commented on a change in pull request #11036: URL: https://github.com/apache/kafka/pull/11036#discussion_r672253775 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -403,27 +411,49 @@ class LogManager(logDirs: Seq[File], * Start the background threa

[GitHub] [kafka] mumrah commented on pull request #11036: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

mumrah commented on pull request #11036: URL: https://github.com/apache/kafka/pull/11036#issuecomment-882589793 Thanks @ijuma, I don't have any more questions or follow-ups 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r672231624 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -105,53 +118,96 @@ public String a

[GitHub] [kafka] mumrah commented on a change in pull request #11070: Validate the controllerListener config on startup

mumrah commented on a change in pull request #11070: URL: https://github.com/apache/kafka/pull/11070#discussion_r672407194 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -137,8 +137,14 @@ class ControllerServer( credentialProvider,

[GitHub] [kafka] satishd commented on pull request #11033: KAFKA-12988 Asynchronous API support for RemoteLogMetadataManager add/update methods.

satishd commented on pull request #11033: URL: https://github.com/apache/kafka/pull/11033#issuecomment-883064875 @junrao This PR is rebased with trunk, please review and let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] cmccabe commented on a change in pull request #11067: MINOR: log broker configs in KRaft mode

cmccabe commented on a change in pull request #11067: URL: https://github.com/apache/kafka/pull/11067#discussion_r672512638 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -389,6 +389,9 @@ class BrokerServer( // a potentially lengthy recovery-from

[GitHub] [kafka] jlprat closed pull request #11025: Scala 3 Compilation with 2.12 support

jlprat closed pull request #11025: URL: https://github.com/apache/kafka/pull/11025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] ccding commented on a change in pull request #11080: fix NPE when record==null in append

ccding commented on a change in pull request #11080: URL: https://github.com/apache/kafka/pull/11080#discussion_r672758944 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java ## @@ -293,7 +293,9 @@ public static DefaultRecord readFrom(ByteBuff

[GitHub] [kafka] showuon edited a comment on pull request #11057: KAFKA-13008: Try to refresh end offset when partitionLag returns empty

showuon edited a comment on pull request #11057: URL: https://github.com/apache/kafka/pull/11057#issuecomment-882498141 After test, **I confirmed that this fix can resolve the issue**. Just that it might be a little more eager than before, to fetch the offset. But, looks like we need those

[GitHub] [kafka] ijuma commented on pull request #11078: KAFKA-12944: Assume message format version is 3.0 when inter-broker protocol is 3.0 or higher (KIP-724)

ijuma commented on pull request #11078: URL: https://github.com/apache/kafka/pull/11078#issuecomment-882544244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] ijuma merged pull request #10811: KAFKA-12598: ConfigCommand should only support communication via ZooKeeper for a reduced set of cases

ijuma merged pull request #10811: URL: https://github.com/apache/kafka/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

showuon commented on pull request #11086: URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [kafka] JoeCqupt closed pull request #11088: MINOR: remove unnecessary judgment in method: assignReplicasToBrokersRackAware

JoeCqupt closed pull request #11088: URL: https://github.com/apache/kafka/pull/11088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] dielhennr commented on a change in pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

dielhennr commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r672693205 ## File path: metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java ## @@ -42,23 +42,38 @@ import java.util.Map.Entry;

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882984058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

  1   2   3   >