showuon commented on a change in pull request #11019:
URL: https://github.com/apache/kafka/pull/11019#discussion_r667673170
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java
##
@@ -100,51 +100,115 @@ public Stri
showuon commented on a change in pull request #11019:
URL: https://github.com/apache/kafka/pull/11019#discussion_r667675187
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -3345,12 +3345,9 @@ public void testDeleteConsumerGrou
showuon commented on pull request #11019:
URL: https://github.com/apache/kafka/pull/11019#issuecomment-878026811
@dajac @rajinisivaram @mimaison , please help take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Luke Chen created KAFKA-13062:
-
Summary: refactor DeleteConsumerGroupsHandler
Key: KAFKA-13062
URL: https://issues.apache.org/jira/browse/KAFKA-13062
Project: Kafka
Issue Type: Sub-task
tombentley commented on a change in pull request #11006:
URL: https://github.com/apache/kafka/pull/11006#discussion_r667692668
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -312,7 +312,15 @@ class LogManager(logDirs: Seq[File],
val logDirAbsolutePath
MPeli commented on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-878059760
It seems that a lot of people are struggling with this issue. See
https://stackoverflow.com/q/45599625/1200885
I was wondering whether @hachikuji, @dajac or @cmccabe could rec
theidexisted commented on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-878064974
> It seems that a lot of people are struggling with this issue. See
https://stackoverflow.com/q/45599625/1200885
>
> I was wondering whether @hachikuji, @dajac or @cmcc
theidexisted edited a comment on pull request #6403:
URL: https://github.com/apache/kafka/pull/6403#issuecomment-878064974
> It seems that a lot of people are struggling with this issue. See
https://stackoverflow.com/q/45599625/1200885
>
> I was wondering whether @hachikuji, @dajac o
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667238459
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667725993
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667726212
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -711,56 +830,73 @@ BrokersToIsrs brokersToIsrs() {
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667726466
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1204,6 +1317,298 @@ void generateLeaderAndIsrUpdat
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667727058
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -,19 +,19 @@ private QuorumController(LogContext log
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667726749
##
File path:
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json
##
@@ -29,6 +29,15 @@
"about": "null if the ISR didn't change
cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667727196
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumControllerMetrics.java
##
@@ -90,6 +97,13 @@ public Integer value() {
yanspirit opened a new pull request #11020:
URL: https://github.com/apache/kafka/pull/11020
this patch resolve the KAFKA-12937 issue: mm2 can not start from the ending
of a topic.
When starting with previously uncommitted partitions, the MirrorSourceTask
always set offset to 0.
solu
showuon opened a new pull request #11021:
URL: https://github.com/apache/kafka/pull/11021
refactor `DeleteConsumerGroupsHandler` and tests:
1. add all expected errors in the handleError
2. update tests
### Committer Checklist (excluded from commit message)
- [ ] Verify de
showuon commented on pull request #11021:
URL: https://github.com/apache/kafka/pull/11021#issuecomment-878082917
@dajac , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iakunin commented on pull request #10775:
URL: https://github.com/apache/kafka/pull/10775#issuecomment-878083043
@chia7712 @huxihx could you have a look at this PR, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Luke Chen created KAFKA-13063:
-
Summary: refactor DescribeConsumerGroupsHandler
Key: KAFKA-13063
URL: https://issues.apache.org/jira/browse/KAFKA-13063
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13063:
-
Assignee: Luke Chen
> refactor DescribeConsumerGroupsHandler
>
[
https://issues.apache.org/jira/browse/KAFKA-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13062:
-
Assignee: Luke Chen
> refactor DeleteConsumerGroupsHandler
> --
[
https://issues.apache.org/jira/browse/KAFKA-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13059:
-
Assignee: Luke Chen
> update for DeleteConsumerGroupOffsetsHandler
> --
[
https://issues.apache.org/jira/browse/KAFKA-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379066#comment-17379066
]
Omnia Ibrahim commented on KAFKA-10588:
---
Hi [~kkonstantine] there is a pr here for
OmniaGM commented on pull request #11007:
URL: https://github.com/apache/kafka/pull/11007#issuecomment-878101172
@kkonstantine can you approve this, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
[
https://issues.apache.org/jira/browse/KAFKA-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379067#comment-17379067
]
Omnia Ibrahim commented on KAFKA-10589:
---
[~kkonstantine] the pr is waiting for an
Luke Chen created KAFKA-13064:
-
Summary: refactor ListConsumerGroupOffsetsHandler
Key: KAFKA-13064
URL: https://issues.apache.org/jira/browse/KAFKA-13064
Project: Kafka
Issue Type: Sub-task
Chun-Hao Tang created KAFKA-13065:
-
Summary: Replace EasyMock with Mockito for
BasicAuthSecurityRestExtensionTest
Key: KAFKA-13065
URL: https://issues.apache.org/jira/browse/KAFKA-13065
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379164#comment-17379164
]
Josep Prat commented on KAFKA-12954:
Hi [~ijuma] Did another try, this time I manage
Chun-Hao Tang created KAFKA-13066:
-
Summary: Replace EasyMock with Mockito for
FileStreamSinkConnectorTest
Key: KAFKA-13066
URL: https://issues.apache.org/jira/browse/KAFKA-13066
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-12486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379188#comment-17379188
]
Sagar Rao commented on KAFKA-12486:
---
i was looking at this one today. Had one question
[
https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379260#comment-17379260
]
Bruno Cadonna commented on KAFKA-8529:
--
Failed again:
https://ci-builds.apache.org
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379262#comment-17379262
]
Bruno Cadonna commented on KAFKA-10251:
---
Failed again:
https://ci-builds.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379264#comment-17379264
]
Bruno Cadonna commented on KAFKA-12629:
---
Failed again:
https://ci-builds.apache.o
David Arthur created KAFKA-13067:
Summary: KafkaMetadataLog should not use segment size smaller than
KafkaRaftClient max batch size
Key: KAFKA-13067
URL: https://issues.apache.org/jira/browse/KAFKA-13067
[
https://issues.apache.org/jira/browse/KAFKA-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13067:
-
Affects Version/s: 3.0.0
> KafkaMetadataLog should not use segment size smaller than KafkaRaftCl
[
https://issues.apache.org/jira/browse/KAFKA-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-13067:
-
Component/s: kraft
> KafkaMetadataLog should not use segment size smaller than KafkaRaftClient m
[
https://issues.apache.org/jira/browse/KAFKA-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur reassigned KAFKA-13067:
Assignee: David Arthur
> KafkaMetadataLog should not use segment size smaller than KafkaR
ijuma commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r668098050
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to
tombentley commented on pull request #11006:
URL: https://github.com/apache/kafka/pull/11006#issuecomment-878160534
The test failures are unrelated.
@chia7712 would you be able to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
cadonna commented on pull request #10943:
URL: https://github.com/apache/kafka/pull/10943#issuecomment-878423037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
showuon commented on pull request #11026:
URL: https://github.com/apache/kafka/pull/11026#issuecomment-878254300
@dajac , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cadonna commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-878142176
If @ijuma is fine with the PR, I can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
hachikuji merged pull request #10794:
URL: https://github.com/apache/kafka/pull/10794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubsc
C0urante commented on pull request #10945:
URL: https://github.com/apache/kafka/pull/10945#issuecomment-878477034
@rhauch @tombentley any chance you could take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
wycc commented on a change in pull request #11017:
URL: https://github.com/apache/kafka/pull/11017#discussion_r667974480
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -939,7 +939,7 @@ private StreamThread createAndAddStreamThread(final
showuon opened a new pull request #11022:
URL: https://github.com/apache/kafka/pull/11022
refactor DescribeConsumerGroupsHandler and tests. Also, put
`COORDINATOR_NOT_AVAILABLE` as unmap retry.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impl
tang7526 opened a new pull request #11024:
URL: https://github.com/apache/kafka/pull/11024
https://issues.apache.org/jira/browse/KAFKA-13065
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
OmniaGM commented on pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#issuecomment-878261191
> @OmniaGM Thanks for the PR. I left a small comment. Could we also add
test(s) in `ConsoleConsumerTest` to cover the new argument?
I added few test cases to cover both ne
tang7526 opened a new pull request #11027:
URL: https://github.com/apache/kafka/pull/11027
https://issues.apache.org/jira/browse/KAFKA-13066
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build sta
cadonna merged pull request #10943:
URL: https://github.com/apache/kafka/pull/10943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
mumrah opened a new pull request #11029:
URL: https://github.com/apache/kafka/pull/11029
Found a few NPEs when running system tests. Added coverage for a few null
cases in BrokerMetadataPublisher as well as a unit test
--
This is an automated message from the Apache Git Service.
To respo
IvanVas opened a new pull request #11023:
URL: https://github.com/apache/kafka/pull/11023
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
jlprat opened a new pull request #11025:
URL: https://github.com/apache/kafka/pull/11025
This PR adds support to Scala 3.0 without the need to drop support for Scala
2.12
Did my best as well to add some new stages in Jenkis for Scala 3.0
### Committer Checklist (excluded from comm
showuon commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-878296600
@dajac I've created 4 PRs. The last one will be created tomorrow.
In addition to making the coordinator error handling consistent, I also make
sure the handle response lo
hachikuji commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r668056225
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed
xvrl commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r668178829
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,21 @@ object ConsoleConsumer extends Logging {
formatter.config
tombentley commented on pull request #11028:
URL: https://github.com/apache/kafka/pull/11028#issuecomment-878306759
@cmccabe perhaps you could review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jlprat commented on pull request #11025:
URL: https://github.com/apache/kafka/pull/11025#issuecomment-878228936
Ping @ijuma I think I managed to keep Scala 2.12 while adding 3.0 support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
OmniaGM commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r667526957
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging {
formatter.con
cadonna commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-878149711
> Are these changes only necessary for SessionWindows and TimeWindows
classes? What about the JoinWindows and SlidingWindows classes?
As far as I can see `SlidingWindows`
tombentley opened a new pull request #11028:
URL: https://github.com/apache/kafka/pull/11028
Prior to this change the logs for the example controller were in
raft-controller-logs which wasn't consistent (raft vs kraft) with
kraft-broker-logs or kraft-combined-logs used for the broker or co
cadonna commented on a change in pull request #10943:
URL: https://github.com/apache/kafka/pull/10943#discussion_r667782099
##
File path: tests/kafkatest/tests/streams/streams_upgrade_test.py
##
@@ -474,8 +474,9 @@ def do_rolling_bounce(self, processor, counter,
current_genera
dajac commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-878456895
@showuon Thanks. I will start reviewing them tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon opened a new pull request #11026:
URL: https://github.com/apache/kafka/pull/11026
Some issues found in the ListConsumerGroupOffsetsHandler:
1. if coordinator errors is put in the topic partition, we don't do retry
2. Didn't handle possible partition level exception
T
dielhennr opened a new pull request #11030:
URL: https://github.com/apache/kafka/pull/11030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: ji
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn updated KAFKA-12886:
--
Summary: Enable request forwarding by default in 3.1 (was: Enable request
forwarding by defau
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379403#comment-17379403
]
Ryan Dielhenn commented on KAFKA-12886:
---
[~kkonstantine] targeting 3.1 now
> Enab
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Dielhenn updated KAFKA-12886:
--
Fix Version/s: (was: 3.0.0)
3.1.0
> Enable request forwarding by defaul
cmccabe merged pull request #10935:
URL: https://github.com/apache/kafka/pull/10935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
[
https://issues.apache.org/jira/browse/KAFKA-13003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Eisele resolved KAFKA-13003.
Resolution: Fixed
Pull Request #10935 has been merged.
> KafkaBroker advertises socket port inste
mumrah opened a new pull request #11031:
URL: https://github.com/apache/kafka/pull/11031
In order to facilitate system and integration tests that use a smaller log
segment size, we are adding this internal config to lower the minimum. During
normal operation, this config will use the defau
guozhangwang commented on pull request #10986:
URL: https://github.com/apache/kafka/pull/10986#issuecomment-878589565
@hachikuji I think the key idea behind this fix is that, if a rebalance
failed with e.g. memberId lost, then conceptually we would just started a new
rebalance in which we
[
https://issues.apache.org/jira/browse/KAFKA-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Badai Aqrandista reopened KAFKA-7760:
-
Reopening issue and making this the main ticket for KIP-760
> Add broker configuration to se
[
https://issues.apache.org/jira/browse/KAFKA-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Badai Aqrandista resolved KAFKA-13040.
--
Resolution: Duplicate
> Increase minimum value of segment.ms and segment.bytes
> -
hachikuji commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r668258168
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed
hachikuji commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r668258168
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed
vvcephei commented on pull request #11003:
URL: https://github.com/apache/kafka/pull/11003#issuecomment-878599816
Thanks, @JimGalasyn , @showuon , and @abbccdda !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
vvcephei merged pull request #11003:
URL: https://github.com/apache/kafka/pull/11003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
[
https://issues.apache.org/jira/browse/KAFKA-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kowshik Prakasam updated KAFKA-12554:
-
Summary: Split Log layer into Log and LocalLog (was: Split Log layer into
UnifiedLog an
[
https://issues.apache.org/jira/browse/KAFKA-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kowshik Prakasam updated KAFKA-12554:
-
Description: Split Log layer into Log and LocalLog based on the proposal
described in th
Kowshik Prakasam created KAFKA-13068:
Summary: Rename Log to UnifiedLog
Key: KAFKA-13068
URL: https://issues.apache.org/jira/browse/KAFKA-13068
Project: Kafka
Issue Type: Sub-task
vvcephei commented on pull request #11003:
URL: https://github.com/apache/kafka/pull/11003#issuecomment-878602756
Merged and cherry-picked to 3.0 (cc @kkonstantine )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-12360.
--
Resolution: Fixed
> Improve documentation of max.task.idle.ms (kafka-streams)
> --
[
https://issues.apache.org/jira/browse/KAFKA-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kowshik Prakasam updated KAFKA-12977:
-
Parent: KAFKA-12551
Issue Type: Sub-task (was: Improvement)
> Eliminate tempora
[
https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10091.
--
Resolution: Fixed
> Improve task idling
> ---
>
> Key: KAFKA-1
cmccabe merged pull request #11030:
URL: https://github.com/apache/kafka/pull/11030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
hachikuji commented on pull request #10986:
URL: https://github.com/apache/kafka/pull/10986#issuecomment-878621043
To clarify, from the perspective of the eager protocol, how would this case
look? Would we get multiple calls to `onPartitionsRevoked` with the same set of
partitions or somet
d8tltanc commented on pull request #11002:
URL: https://github.com/apache/kafka/pull/11002#issuecomment-878621846
Failed tests:
Build / JDK 11 and Scala 2.13 /
kafka.api.TransactionsTest.testAbortTransactionTimeout()
Build / JDK 16 and Scala 2.13 /
kafka.api.TransactionsTest.testSen
d8tltanc commented on pull request #11002:
URL: https://github.com/apache/kafka/pull/11002#issuecomment-878622218
@ijuma @rajinisivaram Please let me know if we are good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
Ron Dagostino created KAFKA-13069:
-
Summary: Add magic number to
DefaultKafkaPrincipalBuilder.KafkaPrincipalSerde
Key: KAFKA-13069
URL: https://issues.apache.org/jira/browse/KAFKA-13069
Project: Kafka
dielhennr commented on a change in pull request #11011:
URL: https://github.com/apache/kafka/pull/11011#discussion_r668286722
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed
guozhangwang commented on a change in pull request #10985:
URL: https://github.com/apache/kafka/pull/10985#discussion_r668293781
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -186,16 +209,25 @@ private boolean
Kowshik Prakasam created KAFKA-13070:
Summary: LogManager shutdown races with periodic work scheduled by
the instance
Key: KAFKA-13070
URL: https://issues.apache.org/jira/browse/KAFKA-13070
Projec
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-878641126
@junrao Thanks for the review. I ran load tests on the changes from this PR,
there weren't any new regressions (i.e. latency regressions or errors) that I
noticed, except for an
mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r668300841
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -156,13 +161,27 @@ public void ensureValid() {
mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r668302886
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -246,6 +265,19 @@ public boolean isTransactional() {
mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r668303344
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -167,21 +167,9 @@ public void ensureValid() {
mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r668304063
##
File path: checkstyle/suppressions.xml
##
@@ -57,7 +57,7 @@
Review comment:
the same suppression is on L54
--
This is an a
mattwong949 commented on a change in pull request #10914:
URL: https://github.com/apache/kafka/pull/10914#discussion_r668302886
##
File path:
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##
@@ -246,6 +265,19 @@ public boolean isTransactional() {
1 - 100 of 164 matches
Mail list logo
