[jira] [Updated] (KAFKA-13055) Security without JAAS file

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Description: I'm setting up kafka security with multiple listeners. Listener for broker

[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667442158 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -246,10 +246,15 @@ State setState(final State n

[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667442355 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -939,6 +939,11 @@ private StreamThread createAndAddStreamThread(fina

[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667443023 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -96,13 +94,7 @@ import static org.apache.kafka.streams.integra

[GitHub] [kafka] wycccccc commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

wycc commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667443055 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -61,18 +59,18 @@ import org.apache.kafka.test.MockMetricsReport

[jira] [Created] (KAFKA-13058) `AlterConsumerGroupOffsetsHandler` does not handle partition errors correctly.

David Jacot created KAFKA-13058: --- Summary: `AlterConsumerGroupOffsetsHandler` does not handle partition errors correctly. Key: KAFKA-13058 URL: https://issues.apache.org/jira/browse/KAFKA-13058 Project:

[GitHub] [kafka] dajac commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

dajac commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r667453896 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java ## @@ -136,21 +142,28 @@ private void ha

[GitHub] [kafka] dajac commented on pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on pull request #11016: URL: https://github.com/apache/kafka/pull/11016#issuecomment-81635 I am reviewing the other handlers which have been introduced in KIP-699. I will follow-up with other PRs if necessary. -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] jacky1193610322 commented on pull request #9624: KAFKA-10655: wrap and catch exception for appendAsLeader failure

jacky1193610322 commented on pull request #9624: URL: https://github.com/apache/kafka/pull/9624#issuecomment-877790095 Should this be included in AK3.0？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877791048 @dajac , thanks for letting me know. I tested it today, and confirmed that it's a regression bug. I also confirmed that there's no regression bug in `DeleteConsumerGroupOffsetsH

[GitHub] [kafka] showuon commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r667474183 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -104,15 +104,18 @@ public Strin

[GitHub] [kafka] showuon commented on a change in pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon commented on a change in pull request #10973: URL: https://github.com/apache/kafka/pull/10973#discussion_r667474248 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupsHandler.java ## @@ -112,21 +112,34 @@ private void handl

[GitHub] [kafka] showuon edited a comment on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon edited a comment on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877791048 @dajac , thanks for letting me know. I tested it today, and confirmed that it's a regression bug. I also confirmed that there's no regression bug in `DeleteConsumerGroupO

[GitHub] [kafka] showuon commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

showuon commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r667475174 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AlterConsumerGroupOffsetsResult.java ## @@ -75,22 +69,19 @@ public void accept(final M

[jira] [Updated] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Summary: Security without JAAS configuration (was: Security without JAAS file) > Secur

[jira] [Updated] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Description: I'm setting up kafka security with multiple listeners. Listener for broker

[GitHub] [kafka] dajac commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

dajac commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877795034 @showuon I wonder if we could split up this PR by handler. We've already have few regressions related to KIP-699 changes so I'd like to be extra careful and review them all separa

[jira] [Updated] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Kashavkin updated KAFKA-13055: - Description: I'm setting up kafka security with multiple listeners. Listener for broker

[GitHub] [kafka] dajac commented on a change in pull request #11016: KAFKA-13058; AlterConsumerGroupOffsetsHandler does not handle partition errors correctly.

dajac commented on a change in pull request #11016: URL: https://github.com/apache/kafka/pull/11016#discussion_r667478130 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AlterConsumerGroupOffsetsResult.java ## @@ -48,23 +46,19 @@ public KafkaFuture part

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877797171 > I wonder if we could split up this PR by handler. Sounds good to me. I can split them tomorrow. There are 6 handlers added in KIP-699, I'll split into 5 PR, and plus #11

[GitHub] [kafka] showuon edited a comment on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon edited a comment on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877797171 > I wonder if we could split up this PR by handler. Sounds good to me. I can split them tomorrow(my time). There are 6 handlers added in KIP-699, I'll split into 5

[jira] [Commented] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378655#comment-17378655 ] Alexey Kashavkin commented on KAFKA-13055: -- {code:bash} listener.name.clients.s

[jira] [Comment Edited] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378655#comment-17378655 ] Alexey Kashavkin edited comment on KAFKA-13055 at 7/11/21, 1:20 PM: --

[GitHub] [kafka] dajac commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

dajac commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-877800572 Sounds good, thanks! I will review them directly. Let's get them in 3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] meher ben ahmed updated KAFKA-12851: Attachment: Capture.PNG > Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsRe

[jira] [Commented] (KAFKA-12851) Flaky Test RaftEventSimulationTest.canMakeProgressIfMajorityIsReachable

[ https://issues.apache.org/jira/browse/KAFKA-12851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378657#comment-17378657 ] meher ben ahmed commented on KAFKA-12851: - it s working fine  !Capture.PNG! > F

[jira] [Created] (KAFKA-13059) update for DeleteConsumerGroupOffsetsHandler

Luke Chen created KAFKA-13059: - Summary: update for DeleteConsumerGroupOffsetsHandler Key: KAFKA-13059 URL: https://issues.apache.org/jira/browse/KAFKA-13059 Project: Kafka Issue Type: Sub-task

[jira] [Comment Edited] (KAFKA-13055) Security without JAAS configuration

[ https://issues.apache.org/jira/browse/KAFKA-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378655#comment-17378655 ] Alexey Kashavkin edited comment on KAFKA-13055 at 7/11/21, 1:55 PM: --

[GitHub] [kafka] ueisele commented on a change in pull request #10935: KAFKA-13003: In kraft mode also advertise configured advertised port instead of socket port

ueisele commented on a change in pull request #10935: URL: https://github.com/apache/kafka/pull/10935#discussion_r667498348 ## File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala ## @@ -313,4 +318,94 @@ class RaftClusterTest { cluster.close()

[GitHub] [kafka] ijuma commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

ijuma commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667506307 ## File path: docs/upgrade.html ## @@ -21,6 +21,10 @@ Notable changes in 3.0.0 +Custom principal builder implementations specified through princi

[GitHub] [kafka] ueisele commented on pull request #10935: KAFKA-13003: In kraft mode also advertise configured advertised port instead of socket port

ueisele commented on pull request #10935: URL: https://github.com/apache/kafka/pull/10935#issuecomment-877829585 I checked the tests which are failing. For me it looks like they are not related to the change made in this pull request. What is failing is "RaftClusterTest.testCreateCluste

[GitHub] [kafka] ijuma commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

ijuma commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667506596 ## File path: clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalSerde.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to

[GitHub] [kafka] ijuma commented on a change in pull request #11011: KAFKA-13051: Require Principal Serde and add default

ijuma commented on a change in pull request #11011: URL: https://github.com/apache/kafka/pull/11011#discussion_r667506307 ## File path: docs/upgrade.html ## @@ -21,6 +21,10 @@ Notable changes in 3.0.0 +Custom principal builder implementations specified through princi

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667511546 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] tang7526 commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

tang7526 commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667511730 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -939,7 +939,7 @@ private StreamThread createAndAddStreamThread(final

[GitHub] [kafka] tang7526 commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

tang7526 commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r667512077 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -246,12 +246,12 @@ State setState(final State n

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667511546 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] tang7526 opened a new pull request #11018: MINOR: Remove unused method and extract method for runtime#WorkerTest.java

tang7526 opened a new pull request #11018: URL: https://github.com/apache/kafka/pull/11018 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Created] (KAFKA-13060) Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java

Chun-Hao Tang created KAFKA-13060: - Summary: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest.java Key: KAFKA-13060 URL: https://issues.apache.org/jira/browse/KAFKA-13060 Project:

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667511546 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] OmniaGM commented on a change in pull request #11008: Kafka-10588 Rename kafka-console-consumer CLI command line arguments for KIP-629

OmniaGM commented on a change in pull request #11008: URL: https://github.com/apache/kafka/pull/11008#discussion_r667526957 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -315,11 +321,14 @@ object ConsoleConsumer extends Logging { formatter.con

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r667427888 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,432 @@ +/*

[jira] [Created] (KAFKA-13061) spark kafka offset missed some partition offset describle

geekyouth created KAFKA-13061: - Summary: spark kafka offset missed some partition offset describle Key: KAFKA-13061 URL: https://issues.apache.org/jira/browse/KAFKA-13061 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-13061) spark kafka offset missed some partition offset describle

[ https://issues.apache.org/jira/browse/KAFKA-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] geekyouth updated KAFKA-13061: -- Description: Caused by: org.apache.spark.sql.streaming.StreamingQueryException: Set(rcf_adidas_wow_ro

[GitHub] [kafka] showuon opened a new pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

showuon opened a new pull request #11019: URL: https://github.com/apache/kafka/pull/11019 Some issues found in the `DeleteConsumerGroupOffsetsHandler`: 1. if `coordinator errors` is put in the topic partition, plus a Errors.NONE, we'll failed with `IllegalArgumentException: Partition foo

[GitHub] [kafka] showuon commented on a change in pull request #11019: KAFKA-13059: refactor DeleteConsumerGroupOffsetsHandler and tests

showuon commented on a change in pull request #11019: URL: https://github.com/apache/kafka/pull/11019#discussion_r667672477 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteConsumerGroupOffsetsHandler.java ## @@ -100,51 +100,115 @@ public Stri