[GitHub] [kafka] dajac merged pull request #10966: MINOR: fix comments on deleteTopics method

dajac merged pull request #10966: URL: https://github.com/apache/kafka/pull/10966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac merged pull request #10957: MINOR: Delete unused DeleteTopicsWithIdsResult.java

dajac merged pull request #10957: URL: https://github.com/apache/kafka/pull/10957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663713956 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] hachikuji opened a new pull request #10974: KAFKA-12979; Implement command to find hanging transactions

hachikuji opened a new pull request #10974: URL: https://github.com/apache/kafka/pull/10974 This patch implements the `find-hanging` command described in KIP-664: https://cwiki.apache.org/confluence/display/KAFKA/KIP-664%3A+Provide+tooling+to+detect+and+abort+hanging+transactions#KIP664:Pro

[GitHub] [kafka] dajac commented on pull request #10955: KafkaAdminClient getListOffsetsCalls benchmark

dajac commented on pull request #10955: URL: https://github.com/apache/kafka/pull/10955#issuecomment-873889722 @jeffkbkim We could add a `getListOffsetsCalls` method to `AdminClientTestUtils`, which is in the same package as the `KafkaAdminClient`, to access the package private method from

[GitHub] [kafka] dajac commented on a change in pull request #10955: KafkaAdminClient getListOffsetsCalls benchmark

dajac commented on a change in pull request #10955: URL: https://github.com/apache/kafka/pull/10955#discussion_r663716647 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3677,7 +3677,8 @@ public ListOffsetsResult listOffsets(Map

[GitHub] [kafka] showuon commented on a change in pull request #10969: KAFKA-10884: Limit the size of Fetch and FetchSnapshot response based on broker configuration

showuon commented on a change in pull request #10969: URL: https://github.com/apache/kafka/pull/10969#discussion_r663730489 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -138,14 +139,15 @@ private UnknownAddressSpec() { } } -pu

[GitHub] [kafka] dajac commented on a change in pull request #10965: KAFKA-13029; Set appropriate fields for FindCoordinatorRequest based on version

dajac commented on a change in pull request #10965: URL: https://github.com/apache/kafka/pull/10965#discussion_r663739212 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1532,9 +1525,10 @@ String coordinatorKey() {

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663752257 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663754330 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExc

[GitHub] [kafka] chia7712 commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

chia7712 commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663755587 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] chia7712 commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

chia7712 commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663756958 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663760942 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaCompletableFuture.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-873936999 @chia7712 thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-873937881 @dajac @chia7712 I think I've addressed all your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac commented on a change in pull request #10974: KAFKA-12979; Implement command to find hanging transactions

dajac commented on a change in pull request #10974: URL: https://github.com/apache/kafka/pull/10974#discussion_r663770706 ## File path: tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java ## @@ -437,6 +442,536 @@ public void testOldBrokerAbortTransactionWi

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

thomaskwscott commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663791043 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,22 @@ class LogSegment private[log] (val log: FileRecords, // volat

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663808257 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java ## @@ -0,0 +1,130 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663809083 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogSegmentLifecycleManager.java ## @@ -0,0 +1,60 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663809683 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,360 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663811753 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerHarness.java ## @@ -0,0 +1,123

[jira] [Updated] (KAFKA-9619) Receiving duplicates when application is configured for exactly once

[ https://issues.apache.org/jira/browse/KAFKA-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Takeshi Yamasaki updated KAFKA-9619: Description: こんにちは。すべてが高耐久性のために構成されていて、1回だけの構成を使用している場合でも、重複を受け取る場合があります（非常にまれですが、あります）。  

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663813208 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java ## @@ -0,0 +1,132 @@

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663818344 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java ## @@ -0,0 +1,140 @@ +/* + * Li

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663819484 ## File path: storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerHarness.java ## @@ -0,0 +1,123

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r663821465 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,360 @@ +/*

[GitHub] [kafka] satishd commented on pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on pull request #10579: URL: https://github.com/apache/kafka/pull/10579#issuecomment-874000725 Thanks @junrao for your comments. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] rajinisivaram commented on pull request #10965: KAFKA-13029; Set appropriate fields for FindCoordinatorRequest based on version

rajinisivaram commented on pull request #10965: URL: https://github.com/apache/kafka/pull/10965#issuecomment-874004039 @chia7712 @dajac Thanks for the reviews, addressed comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10962: KIP-709: Implement request/response for offsetFetch batching

rajinisivaram commented on a change in pull request #10962: URL: https://github.com/apache/kafka/pull/10962#discussion_r663488495 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1308,29 +1308,31 @@ private OffsetF

[GitHub] [kafka] showuon commented on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon commented on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-874065187 @mimaison , thanks for the comments. I've updated the PR. Please take a look again. Thanks. Failed tests are unrelated. ``` Build / JDK 8 and Scala 2.12 / kafka

[GitHub] [kafka] showuon edited a comment on pull request #10973: KAFKA-13033: COORDINATOR_NOT_AVAILABLE should be unmapped

showuon edited a comment on pull request #10973: URL: https://github.com/apache/kafka/pull/10973#issuecomment-874065187 @mimaison , thanks for the comments. I've updated the `KafkaAdminClientTest`. Please take a look again. Thanks. Failed tests are unrelated. ``` Build / JD

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663877163 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,21 @@ class LogSegment private[log] (val log: FileRecords, // volatile for

[GitHub] [kafka] dajac commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

dajac commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663902068 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -27,217 +28,111 @@ /** * A flexible future which suppor

[GitHub] [kafka] dajac commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

dajac commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r66390 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExceptio

[GitHub] [kafka] dajac commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

dajac commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663903698 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExceptio

[jira] [Created] (KAFKA-13034) Kafka-connect : impossible to set infinite retention at topic.creation.default.retention.ms

raphael auv created KAFKA-13034: --- Summary: Kafka-connect : impossible to set infinite retention at topic.creation.default.retention.ms Key: KAFKA-13034 URL: https://issues.apache.org/jira/browse/KAFKA-13034

[GitHub] [kafka] rajinisivaram commented on pull request #10965: KAFKA-13029; Set appropriate fields for FindCoordinatorRequest based on version

rajinisivaram commented on pull request #10965: URL: https://github.com/apache/kafka/pull/10965#issuecomment-874111712 @showuon @chia7712 @dajac Thanks for the reviews. Test failure (RaftClusterTest.testCreateClusterAndCreateAndManyTopics) not related. Merging to trunk. -- This is an au

[GitHub] [kafka] rajinisivaram merged pull request #10965: KAFKA-13029; Set appropriate fields for FindCoordinatorRequest based on version

rajinisivaram merged pull request #10965: URL: https://github.com/apache/kafka/pull/10965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-uns

[GitHub] [kafka] chia7712 commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

chia7712 commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663931300 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExcep

[GitHub] [kafka] chia7712 commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

chia7712 commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663936311 ## File path: clients/src/test/java/org/apache/kafka/common/KafkaFutureTest.java ## @@ -17,68 +17,265 @@ package org.apache.kafka.common; import org.ap

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663955317 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExc

[GitHub] [kafka] ijuma commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

ijuma commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663961964 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExceptio

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663962563 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -27,217 +28,111 @@ /** * A flexible future which s

[GitHub] [kafka] dajac commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

dajac commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r663961829 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -338,16 +338,15 @@ class LogSegment private[log] (val log: FileRecords, txnIndex.res

[GitHub] [kafka] tombentley commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663966834 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExc

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-874150442 @chia7712 thanks, I've implemented your most recent comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] chia7712 commented on a change in pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

chia7712 commented on a change in pull request #9878: URL: https://github.com/apache/kafka/pull/9878#discussion_r663968914 ## File path: clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java ## @@ -267,50 +180,82 @@ public T get() throws InterruptedExcep

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-874181375 If no further comments I'll merge this in the next hour or so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] dajac commented on pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

dajac commented on pull request #10960: URL: https://github.com/apache/kafka/pull/10960#issuecomment-874186134 @thomaskwscott Could you also update the description of the PR? It would be great to explain how it relates to KIP-734 as well. -- This is an automated message from the Apache

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r664014932 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,402 @@ +/*

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

thomaskwscott commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664016024 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -99,21 +99,21 @@ class LogSegment private[log] (val log: FileRecords, // volat

[GitHub] [kafka] ijuma commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

ijuma commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664036719 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -386,15 +385,13 @@ class LogSegment private[log] (val log: FileRecords, private def lo

[GitHub] [kafka] tombentley commented on pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley commented on pull request #9878: URL: https://github.com/apache/kafka/pull/9878#issuecomment-874226640 Thanks for the reviews @chia7712 @dajac @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

thomaskwscott commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664042509 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -386,15 +385,13 @@ class LogSegment private[log] (val log: FileRecords, privat

[GitHub] [kafka] thomaskwscott commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

thomaskwscott commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664042666 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -386,15 +385,13 @@ class LogSegment private[log] (val log: FileRecords, privat

[GitHub] [kafka] ijuma commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

ijuma commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664043382 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1345,8 +1345,9 @@ class Log(@volatile private var _dir: File, val latestTimestampSegme

[GitHub] [kafka] tombentley merged pull request #9878: KAFKA-6987: Add KafkaFuture.toCompletionStage()

tombentley merged pull request #9878: URL: https://github.com/apache/kafka/pull/9878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[GitHub] [kafka] ijuma commented on a change in pull request #10960: KAFKA-12981 Ensure LogSegment.maxTimestampSoFar and LogSegment.offsetOfMaxTimestampSoFar are read/updated in sync

ijuma commented on a change in pull request #10960: URL: https://github.com/apache/kafka/pull/10960#discussion_r664044152 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1345,8 +1345,9 @@ class Log(@volatile private var _dir: File, val latestTimestampSegme

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664075804 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsResult.java ## @@ -32,28 +34,87 @@ */ @InterfaceStability.Evolving pub

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664076833 ## File path: clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java ## @@ -65,6 +65,20 @@ public Builder(List topics, boolean allowA

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664077354 ## File path: clients/src/main/resources/common/message/MetadataResponse.json ## @@ -65,7 +66,7 @@ "about": "Each topic in the response.", "fields":

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r664078161 ## File path: core/src/main/scala/kafka/api/ApiVersion.scala ## @@ -116,7 +116,9 @@ object ApiVersion { // Introduce AllocateProducerIds (KIP-730)

[jira] [Created] (KAFKA-13035) Kafka Connect: Update documentation for POST /connectors/(string: name)/restart to include task Restart behavior

Kalpesh Patel created KAFKA-13035: - Summary: Kafka Connect: Update documentation for POST /connectors/(string: name)/restart to include task Restart behavior Key: KAFKA-13035 URL: https://issues.apache.org/jira/

[jira] [Updated] (KAFKA-13035) Kafka Connect: Update documentation for POST /connectors/(string: name)/restart to include task Restart behavior

[ https://issues.apache.org/jira/browse/KAFKA-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-13035: -- Description: KAFKA-4793 updated the behavior of POST /connectors/(string: name)/restart based

[jira] [Assigned] (KAFKA-13035) Kafka Connect: Update documentation for POST /connectors/(string: name)/restart to include task Restart behavior

[ https://issues.apache.org/jira/browse/KAFKA-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-13035: - Assignee: Kalpesh Patel > Kafka Connect: Update documentation for POST /connectors/(str

[GitHub] [kafka] kpatelatwork opened a new pull request #10975: KAFKA-13035 updated documentation for connector restart REST API to …

kpatelatwork opened a new pull request #10975: URL: https://github.com/apache/kafka/pull/10975 …include the tasks restart behavior Targets AK 3.0.0 where KAFKA-4793 will get released. @kkonstantine and @rhauch Could you please review and see if the changes look good.

[GitHub] [kafka] kpatelatwork commented on pull request #10975: KAFKA-13035 updated documentation for connector restart REST API to …

kpatelatwork commented on pull request #10975: URL: https://github.com/apache/kafka/pull/10975#issuecomment-874289811 This is how formatting looks locally  -- This is an

[jira] [Updated] (KAFKA-13035) Kafka Connect: Update documentation for POST /connectors/(string: name)/restart to include task Restart behavior

[ https://issues.apache.org/jira/browse/KAFKA-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-13035: -- Component/s: KafkaConnect > Kafka Connect: Update documentation for POST /connectors/(string:

[GitHub] [kafka] hachikuji commented on a change in pull request #10974: KAFKA-12979; Implement command to find hanging transactions

hachikuji commented on a change in pull request #10974: URL: https://github.com/apache/kafka/pull/10974#discussion_r664154672 ## File path: tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java ## @@ -437,6 +442,536 @@ public void testOldBrokerAbortTransacti

[GitHub] [kafka] hachikuji commented on a change in pull request #10974: KAFKA-12979; Implement command to find hanging transactions

hachikuji commented on a change in pull request #10974: URL: https://github.com/apache/kafka/pull/10974#discussion_r664156720 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -461,6 +469,417 @@ public void execute(Admin admin, Namespace ns

[GitHub] [kafka] hachikuji commented on a change in pull request #10974: KAFKA-12979; Implement command to find hanging transactions

hachikuji commented on a change in pull request #10974: URL: https://github.com/apache/kafka/pull/10974#discussion_r664159092 ## File path: tools/src/test/java/org/apache/kafka/tools/TransactionsCommandTest.java ## @@ -437,6 +442,536 @@ public void testOldBrokerAbortTransacti

[jira] [Commented] (KAFKA-12879) Compatibility break in Admin.listOffsets()

[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375067#comment-17375067 ] Kirk True commented on KAFKA-12879: --- I'm trying to understand the reason to _*not*_ th

[jira] [Commented] (KAFKA-12879) Compatibility break in Admin.listOffsets()

[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375069#comment-17375069 ] Kirk True commented on KAFKA-12879: --- Also, there's code elsewhere in Kafka that will p

[GitHub] [kafka] hachikuji merged pull request #10971: KAFKA-12992 Make kraft configuration properties public

hachikuji merged pull request #10971: URL: https://github.com/apache/kafka/pull/10971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[jira] [Resolved] (KAFKA-12992) Make kraft configuration properties public

[ https://issues.apache.org/jira/browse/KAFKA-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12992. - Resolution: Fixed > Make kraft configuration properties public > ---

[jira] [Updated] (KAFKA-12989) `MockClient` should respect the request matcher passed to `prepareUnsupportedVersionResponse`

[ https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-12989: -- Description: The {{MockClient}} offers the possibility to prepare an unsupported version response wit

[jira] [Updated] (KAFKA-12989) MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

[ https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-12989: -- Summary: MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse (w

[GitHub] [kafka] hachikuji commented on a change in pull request #10560: KAFKA-12660: Do not update offset commit sensor after append failure

hachikuji commented on a change in pull request #10560: URL: https://github.com/apache/kafka/pull/10560#discussion_r664167798 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala ## @@ -1349,6 +1357,10 @@ class GroupMetadataManagerTest

[jira] [Commented] (KAFKA-12989) MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

[ https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375090#comment-17375090 ] Kirk True commented on KAFKA-12989: --- I don't really understand the purpose of {{Reques

[jira] [Comment Edited] (KAFKA-12989) MockClient should respect the request matcher passed to prepareUnsupportedVersionResponse

[ https://issues.apache.org/jira/browse/KAFKA-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375090#comment-17375090 ] Kirk True edited comment on KAFKA-12989 at 7/6/21, 1:26 AM:

[GitHub] [kafka] dengziming commented on a change in pull request #10560: KAFKA-12660: Do not update offset commit sensor after append failure

dengziming commented on a change in pull request #10560: URL: https://github.com/apache/kafka/pull/10560#discussion_r664191030 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala ## @@ -1349,6 +1357,10 @@ class GroupMetadataManagerTest

[jira] [Commented] (KAFKA-7260) Failures while attempting to move partitions with kafka-reassign-partitions.sh

[ https://issues.apache.org/jira/browse/KAFKA-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375124#comment-17375124 ] Kai Tian commented on KAFKA-7260: - I had a similar problem to yours, but we had a disk fa