showuon commented on a change in pull request #10965:
URL: https://github.com/apache/kafka/pull/10965#discussion_r663463655
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1327,7 +1317,7 @@ boolean isEndTxn() {
Niclas Hedhman created KAFKA-13032:
--
Summary: Impossible stacktrace
Key: KAFKA-13032
URL: https://issues.apache.org/jira/browse/KAFKA-13032
Project: Kafka
Issue Type: Bug
Component
[
https://issues.apache.org/jira/browse/KAFKA-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niclas Hedhman updated KAFKA-13032:
---
Description:
I am presented with a stacktrace that has not a single touch point in my code,
[
https://issues.apache.org/jira/browse/KAFKA-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374235#comment-17374235
]
HaiyuanZhao commented on KAFKA-12982:
-
Hi, [~jagsancio], Is this task still needed
zhaohaidao commented on pull request #10932:
URL: https://github.com/apache/kafka/pull/10932#issuecomment-873551428
@abbccdda Hi, Could you review this pr if you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663417840
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -68,36 +74,117 @@ public Builder(String groupId,
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663417944
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##
@@ -68,36 +74,117 @@ public Builder(String groupId,
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663419495
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -154,14 +166,88 @@ public OffsetFetchResponse(in
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663421545
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -214,6 +321,10 @@ public Errors error() {
skaundinya15 commented on pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#issuecomment-873554145
@rajinisivaram Thank you for the reviews, I believe I have addressed all
your comments. In the latest commit, I have also fixed some of the failing
tests, as well as added
[
https://issues.apache.org/jira/browse/KAFKA-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374248#comment-17374248
]
HaiyuanZhao commented on KAFKA-12968:
-
Hi, [~jagsancio]
I would like to pick this u
Luke Chen created KAFKA-13033:
-
Summary: coordinator not available error should cause add into
unmap list to do a new lookup
Key: KAFKA-13033
URL: https://issues.apache.org/jira/browse/KAFKA-13033
Project
[
https://issues.apache.org/jira/browse/KAFKA-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13033:
--
Description:
In KIP-699, we add some handler to handle different types of operation. In the
`handleEr
[
https://issues.apache.org/jira/browse/KAFKA-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13033:
--
Description:
In KIP-699, we add some handler to handle different types of operation. In the
`handleEr
showuon opened a new pull request #10973:
URL: https://github.com/apache/kafka/pull/10973
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
showuon commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-87356
@skaundinya15 @mimaison @dajac , could you please check the PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-873562708
@showuon Thanks. Good catch! I will review it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663485187
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java
##
@@ -73,7 +73,10 @@ public Stri
rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663485547
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -154,14 +166,88 @@ public OffsetFetchResponse(i
rajinisivaram commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663485656
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -214,6 +321,10 @@ public Errors error() {
rajinisivaram commented on pull request #10965:
URL: https://github.com/apache/kafka/pull/10965#issuecomment-873568935
@showuon Thanks for the review, addressed comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
mimaison commented on pull request #10963:
URL: https://github.com/apache/kafka/pull/10963#issuecomment-873583155
Thanks @chia7712. This `if` statement is being removed in
https://github.com/apache/kafka/pull/10965 so I think it should address this
issue
--
This is an automated message
mimaison commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r663501513
##
File path: docs/upgrade.html
##
@@ -97,6 +97,9 @@ Notable changes in 3
DefaultReplicationPolicy, cannot prevent replication
cycles based on
mimaison commented on pull request #10973:
URL: https://github.com/apache/kafka/pull/10973#issuecomment-873593049
Yes we should handle errors consistantly but as part of KIP-699, I ensured
all existing `KafkaAdminClientTest` tests kept working to avoid changing
behaviour, see discussion in
chia7712 commented on pull request #10963:
URL: https://github.com/apache/kafka/pull/10963#issuecomment-873593708
> This if statement is being removed in #10965 so I think it should address
this issue
you are right. close this as duplicate :)
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-13030.
Resolution: Duplicate
close as duplicate
(https://github.com/apache/kafka/pull/10963#issu
chia7712 closed pull request #10963:
URL: https://github.com/apache/kafka/pull/10963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
chia7712 commented on a change in pull request #10965:
URL: https://github.com/apache/kafka/pull/10965#discussion_r663507496
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1145,11 +1142,7 @@ private void
lookupCo
ryannedolan commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r663509197
##
File path: docs/upgrade.html
##
@@ -97,6 +97,9 @@ Notable changes in 3
DefaultReplicationPolicy, cannot prevent replication
cycles based
ryannedolan commented on a change in pull request #10805:
URL: https://github.com/apache/kafka/pull/10805#discussion_r663509639
##
File path: docs/upgrade.html
##
@@ -97,6 +97,9 @@ Notable changes in 3
DefaultReplicationPolicy, cannot prevent replication
cycles based
mimaison merged pull request #10805:
URL: https://github.com/apache/kafka/pull/10805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
ijuma commented on pull request #10919:
URL: https://github.com/apache/kafka/pull/10919#issuecomment-873604742
Failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ijuma merged pull request #10919:
URL: https://github.com/apache/kafka/pull/10919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
ijuma commented on pull request #10919:
URL: https://github.com/apache/kafka/pull/10919#issuecomment-873605675
Btw, we should generally refrain from mentioning security vulnerabilities in
PR and commit messages: https://kafka.apache.org/project-security
--
This is an automated message fr
abbccdda merged pull request #10932:
URL: https://github.com/apache/kafka/pull/10932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
hachikuji commented on pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#issuecomment-873632735
@cmccabe The following test cases in `ClientQuotasRequestTest` that fail
consistently:
- `testDescribeClientQuotasMatchPartial`
- `testClientQuotasUnsupportedEntityTypes`
hachikuji edited a comment on pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#issuecomment-873632735
@cmccabe The following test cases in `ClientQuotasRequestTest` that fail
consistently:
- `testDescribeClientQuotasMatchPartial`
- `testClientQuotasUnsupportedEntit
hachikuji edited a comment on pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#issuecomment-873632735
@cmccabe The following test cases in `ClientQuotasRequestTest` fail
consistently:
- `testDescribeClientQuotasMatchPartial`
- `testClientQuotasUnsupportedEntityType
ijuma commented on pull request #10968:
URL: https://github.com/apache/kafka/pull/10968#issuecomment-873633465
Failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ijuma merged pull request #10968:
URL: https://github.com/apache/kafka/pull/10968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663537599
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java
##
@@ -73,7 +73,10 @@ public Strin
skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663537638
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
##
@@ -154,14 +166,88 @@ public OffsetFetchResponse(in
[
https://issues.apache.org/jira/browse/KAFKA-13012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13012:
-
Assignee: Luke Chen
> Rationalize error handling of AdminClient calls
> ---
cmccabe commented on pull request #10931:
URL: https://github.com/apache/kafka/pull/10931#issuecomment-873740913
Should be fixed. The difference was in handling unknown entity types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
44 matches
Mail list logo
