[GitHub] [kafka] cadonna commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

cadonna commented on pull request #10846: URL: https://github.com/apache/kafka/pull/10846#issuecomment-857476064 `Optional` sounds good but it would substantially increase the size of this fix which is actually not required. On the other hand, I am not sure if we do not have other re

[jira] [Created] (KAFKA-12922) MirrorCheckpointTask should close topic filter

Viktor Somogyi-Vass created KAFKA-12922: --- Summary: MirrorCheckpointTask should close topic filter Key: KAFKA-12922 URL: https://issues.apache.org/jira/browse/KAFKA-12922 Project: Kafka

[GitHub] [kafka] viktorsomogyi opened a new pull request #10849: KAFKA-12922: MirrorCheckpointTask should close topic filter

viktorsomogyi opened a new pull request #10849: URL: https://github.com/apache/kafka/pull/10849 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Created] (KAFKA-12923) Log.splitOverflowedSegment logic can skip producer state snapshot deletion

Kowshik Prakasam created KAFKA-12923: Summary: Log.splitOverflowedSegment logic can skip producer state snapshot deletion Key: KAFKA-12923 URL: https://issues.apache.org/jira/browse/KAFKA-12923 Pr

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648112486 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[jira] [Updated] (KAFKA-12923) Log.splitOverflowedSegment logic can skip producer state snapshot deletion

[ https://issues.apache.org/jira/browse/KAFKA-12923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-12923: - Priority: Minor (was: Major) > Log.splitOverflowedSegment logic can skip producer state

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648132657 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648133097 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File, .map(_.messageOffse

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648133473 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1578,144 +1409,85 @@ class Log(@volatile private var _dir: File, .map(_.messageOffse

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648133704 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1010 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648134244 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1788,14 +1559,8 @@ class Log(@volatile private var _dir: File, maybeHandleIOException(s"

[jira] [Created] (KAFKA-12924) Replace EasyMock and PowerMock with Mockito in streams module(metrics)

YI-CHEN WANG created KAFKA-12924: Summary: Replace EasyMock and PowerMock with Mockito in streams module(metrics) Key: KAFKA-12924 URL: https://issues.apache.org/jira/browse/KAFKA-12924 Project: Kafka

[GitHub] [kafka] kowshik commented on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-857548583 Thanks for the review @junrao! I've addressed the comments in 8ebb39f. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] wycccccc opened a new pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

wycc opened a new pull request #10850: URL: https://github.com/apache/kafka/pull/10850 Development of EasyMock and PowerMock has stagnated while Mockito continues to be actively developed. With the new Java cadence, it's a problem to depend on libraries that do bytecode generation and

[GitHub] [kafka] wycccccc commented on a change in pull request #10835: KAFKA-12905: Replace EasyMock and PowerMock with Mockito for NamedCacheMetricsTest

wycc commented on a change in pull request #10835: URL: https://github.com/apache/kafka/pull/10835#discussion_r648145898 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/NamedCacheMetricsTest.java ## @@ -49,37 +41,28 @@ private stat

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648134244 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1788,14 +1559,8 @@ class Log(@volatile private var _dir: File, maybeHandleIOException(s"

[GitHub] [kafka] lkokhreidze opened a new pull request #10851: KAFKA-6718 / Rack aware standby task assignor

lkokhreidze opened a new pull request #10851: URL: https://github.com/apache/kafka/pull/10851 This PR is part of [KIP-708](https://cwiki.apache.org/confluence/display/KAFKA/KIP-708%3A+Rack+awareness+for+Kafka+Streams) and adds rack aware standby task assignment logic. Rack aware sta

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-857564039 Call for review @cadonna @vvcephei @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] lkokhreidze commented on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

lkokhreidze commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-857567693 Hi @cadonna FYI, I've opened a PR around rack aware standby task assignment https://github.com/apache/kafka/pull/10851 -- This is an automated message from the Apach

[GitHub] [kafka] lkokhreidze edited a comment on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

lkokhreidze edited a comment on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-857567693 Hi @cadonna FYI, I've opened a PR around rack aware standby task assignment https://github.com/apache/kafka/pull/10851 -- This is an automated message from the A

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-857548583 Thanks for the review @junrao! I've addressed the comments in 8f14879. I've also triggered a system test run on the most recent commit, I'll review it once it completes.

[GitHub] [kafka] mdedetrich commented on a change in pull request #10839: KAFKA-12913: Make case class's final

mdedetrich commented on a change in pull request #10839: URL: https://github.com/apache/kafka/pull/10839#discussion_r648171013 ## File path: gradle/spotbugs-exclude.xml ## @@ -132,6 +132,13 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read

[GitHub] [kafka] wycccccc commented on a change in pull request #10835: KAFKA-12905: Replace EasyMock and PowerMock with Mockito for NamedCacheMetricsTest

wycc commented on a change in pull request #10835: URL: https://github.com/apache/kafka/pull/10835#discussion_r648148202 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/NamedCacheMetricsTest.java ## @@ -49,37 +41,28 @@ private stat

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-857548583 Thanks for the review @junrao! I've addressed the comments in 8f14879. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dengziming opened a new pull request #10852: MINOR: Replace easymock with mockito in log4j-appender

dengziming opened a new pull request #10852: URL: https://github.com/apache/kafka/pull/10852 *More detailed description of your change* As the title *Summary of testing strategy (including rationale)* QA -- This is an automated message from the Apache Git Service. To resp

[jira] [Updated] (KAFKA-12922) MirrorCheckpointTask should close topic filter

[ https://issues.apache.org/jira/browse/KAFKA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-12922: Description: MirrorCheckpointTask utilizes a TopicFilter, but never closes it and

[jira] [Updated] (KAFKA-12922) MirrorCheckpointTask should close topic filter

[ https://issues.apache.org/jira/browse/KAFKA-12922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-12922: Description: MirrorCheckpointTask uses a TopicFilter, but never closes it and leak

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r648251540 ## File path: README.md ## @@ -207,6 +207,20 @@ You can run checkstyle using: The checkstyle warnings will be found in `reports/checkstyle/reports/main.

[GitHub] [kafka] Moovlin opened a new pull request #10853: KAFKA-12811: kafka-topics.sh should let the user know they cannot adj…ust the replication factor for a topic using the --alter flag and not w

Moovlin opened a new pull request #10853: URL: https://github.com/apache/kafka/pull/10853 KAFKA-12811: kafka-topics.sh should let the user know they cannot adj…ust the replication factor for a topic using the --alter flag and not warn about missing the --partition flag This work is

[GitHub] [kafka] ijuma commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

ijuma commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648315914 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -21,39 +21,28 @@ import org.apache.kafka.commo

[GitHub] [kafka] ijuma commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

ijuma commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648316500 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -125,8 +114,8 @@ public void shouldAddAliveStre

[GitHub] [kafka] ijuma commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

ijuma commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648316500 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -125,8 +114,8 @@ public void shouldAddAliveStre

[GitHub] [kafka] C0urante opened a new pull request #10854: KAFKA-12717: Remove internal Connect converter properties

C0urante opened a new pull request #10854: URL: https://github.com/apache/kafka/pull/10854 [Jira](https://issues.apache.org/jira/browse/KAFKA-12717) / [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-738%3A+Removal+of+Connect%27s+internal+converter+properties) Changes:

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360131#comment-17360131 ] Alexis Josephides commented on KAFKA-12468: --- We are also seeing this issue des

[jira] [Comment Edited] (KAFKA-12468) Initial offsets are copied from source to target cluster

[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360131#comment-17360131 ] Alexis Josephides edited comment on KAFKA-12468 at 6/9/21, 2:43 PM: --

[GitHub] [kafka] lct45 commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

lct45 commented on a change in pull request #10813: URL: https://github.com/apache/kafka/pull/10813#discussion_r648383533 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -60,8 +60,8 @@ public void init(final InternalProcesso

[GitHub] [kafka] lct45 commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

lct45 commented on a change in pull request #10813: URL: https://github.com/apache/kafka/pull/10813#discussion_r648383874 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java ## @@ -78,6 +79,10 @@ throw new S

[GitHub] [kafka] wenbingshen commented on a change in pull request #10853: KAFKA-12811: kafka-topics.sh should let the user know they cannot adj…ust the replication factor for a topic using the --alte

wenbingshen commented on a change in pull request #10853: URL: https://github.com/apache/kafka/pull/10853#discussion_r648397088 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -574,6 +574,7 @@ object TopicCommand extends Logging { if (has(alterOpt)

[GitHub] [kafka] vvcephei commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

vvcephei commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648363737 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetricsTest.java ## @@ -18,87 +18,73 @@ import

[GitHub] [kafka] wenbingshen commented on a change in pull request #10853: KAFKA-12811: kafka-topics.sh should let the user know they cannot adj…ust the replication factor for a topic using the --alte

wenbingshen commented on a change in pull request #10853: URL: https://github.com/apache/kafka/pull/10853#discussion_r648413266 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -574,6 +574,7 @@ object TopicCommand extends Logging { if (has(alterOpt)

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r648427370 ## File path: build.gradle ## @@ -604,6 +625,9 @@ subprojects { description = 'Run checkstyle on all main Java sources' } + checkstyleMain

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r648435365 ## File path: README.md ## @@ -207,6 +207,20 @@ You can run checkstyle using: The checkstyle warnings will be found in `reports/checkstyle/reports/

[GitHub] [kafka] jlprat opened a new pull request #10855: MINOR: clean up unneeded `@SuppressWarnings`

jlprat opened a new pull request #10855: URL: https://github.com/apache/kafka/pull/10855 Remove unneeded `@SuppressWarnings("unchecked")` in source and test Remove unneeded `@SuppressWarnings("deprecated")` in source and test Several of those annotations were either never needed, o

[GitHub] [kafka] jlprat opened a new pull request #10856: MINOR: Small optimizations and removal of unused code in Streams

jlprat opened a new pull request #10856: URL: https://github.com/apache/kafka/pull/10856 Remove unused methods in internal classes Mark fields that can be final as final Remove unneeded generic type annotation Convert single use fields to local final variables Use method referenc

[GitHub] [kafka] jlprat commented on a change in pull request #10856: MINOR: Small optimizations and removal of unused code in Streams

jlprat commented on a change in pull request #10856: URL: https://github.com/apache/kafka/pull/10856#discussion_r648463106 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/BaseJoinProcessorNode.java ## @@ -63,10 +63,6 @@ return join

[GitHub] [kafka] jlprat commented on pull request #10855: MINOR: clean up unneeded `@SuppressWarnings` on Streams module

jlprat commented on pull request #10855: URL: https://github.com/apache/kafka/pull/10855#issuecomment-857841468 cc. @mjsax as you were doing a PR touching similar things recently, maybe you want to review this one as well? Also pinging @vvcephei as he was reviewing that PR I was referrin

[GitHub] [kafka] jlprat commented on pull request #10856: MINOR: Small optimizations and removal of unused code in Streams

jlprat commented on pull request #10856: URL: https://github.com/apache/kafka/pull/10856#issuecomment-857842621 Pinging @mjsax on this one as you did some changes on Streams recently. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] kpatelatwork commented on pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745) (WIP)

kpatelatwork commented on pull request #10822: URL: https://github.com/apache/kafka/pull/10822#issuecomment-857875970 Below are some logs when both connector and tasks are restarted. > [2021-06-09 12:02:26,045] DEBUG Writing RestartRequest{connectorName='simple-source', onlyFailed=fa

[GitHub] [kafka] tombentley commented on a change in pull request #10826: KAFKA-7632: Support Compression Level

tombentley commented on a change in pull request #10826: URL: https://github.com/apache/kafka/pull/10826#discussion_r648485713 ## File path: clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java ## @@ -183,8 +183,8 @@ public double compressionRatio() {

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648519181 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java ## @@ -40,61 +54,116 @@ public CoordinatorStrategy

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648520281 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -267,7 +278,11 @@ public void onFailure( pri

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648522353 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1305,66 +1305,102 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] jolshan commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-857891409 all 3 jdk versions are failing with something like this: ``` Execution failed for task ':core:integrationTest'. > Process 'Gradle Test Executor 127' finished with non-zero

[GitHub] [kafka] jolshan edited a comment on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan edited a comment on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-857891409 all 3 jdk versions are failing with something like this: ``` Execution failed for task ':core:integrationTest'. > Process 'Gradle Test Executor 127' finished with n

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648525658 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java ## @@ -24,7 +24,7 @@ public final String idValue;

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648526428 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -250,6 +254,13 @@ public void onFailure(

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648530700 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1305,66 +1305,102 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] wycccccc commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

wycc commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648531262 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -135,45 +124,38 @@ public void shouldGetFail

[GitHub] [kafka] wycccccc commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

wycc commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648532511 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetricsTest.java ## @@ -18,51 +18,38 @@ import org.apach

[GitHub] [kafka] wycccccc commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

wycc commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648533278 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -21,39 +21,28 @@ import org.apache.kafka.co

[GitHub] [kafka] wycccccc commented on a change in pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams mo…

wycc commented on a change in pull request #10850: URL: https://github.com/apache/kafka/pull/10850#discussion_r648535313 ## File path: streams/src/test/java/org/apache/kafka/streams/internals/metrics/ClientMetricsTest.java ## @@ -125,8 +114,8 @@ public void shouldAddAliveS

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648537766 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java ## @@ -17,20 +17,34 @@ package org.apache.kafka.c

[GitHub] [kafka] Moovlin commented on a change in pull request #10853: KAFKA-12811: kafka-topics.sh should let the user know they cannot adj…ust the replication factor for a topic using the --alter fl

Moovlin commented on a change in pull request #10853: URL: https://github.com/apache/kafka/pull/10853#discussion_r648550375 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -574,6 +574,7 @@ object TopicCommand extends Logging { if (has(alterOpt)) {

[jira] [Updated] (KAFKA-12924) Replace EasyMock and PowerMock with Mockito in streams module(metrics)

[ https://issues.apache.org/jira/browse/KAFKA-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12924: Component/s: unit tests streams > Replace EasyMock and PowerMock with Moc

[jira] [Updated] (KAFKA-7342) Migrate streams modules to JUnit 5

[ https://issues.apache.org/jira/browse/KAFKA-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-7342: --- Component/s: unit tests > Migrate streams modules to JUnit 5 > --

[GitHub] [kafka] mimaison commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

mimaison commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r648552780 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java ## @@ -204,7 +206,8 @@ private void completeLookup(Map

[jira] [Commented] (KAFKA-8335) Log cleaner skips Transactional mark and batch record, causing unlimited growth of __consumer_offsets

[ https://issues.apache.org/jira/browse/KAFKA-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360281#comment-17360281 ] Victor Garcia commented on KAFKA-8335: -- [~francisco.juan] we are having the exact sa

[jira] [Comment Edited] (KAFKA-8335) Log cleaner skips Transactional mark and batch record, causing unlimited growth of __consumer_offsets

[ https://issues.apache.org/jira/browse/KAFKA-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360281#comment-17360281 ] Victor Garcia edited comment on KAFKA-8335 at 6/9/21, 6:47 PM:

[jira] [Commented] (KAFKA-12920) Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost`

[ https://issues.apache.org/jira/browse/KAFKA-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360328#comment-17360328 ] A. Sophie Blee-Goldman commented on KAFKA-12920: While there does seem t

[GitHub] [kafka] junrao commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

junrao commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648679167 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1812,37 +1570,39 @@ class Log(@volatile private var _dir: File, endOffset: Long ): Uni

[GitHub] [kafka] junrao commented on a change in pull request #10848: MINOR Updated transaction index as optional in LogSegmentData.

junrao commented on a change in pull request #10848: URL: https://github.com/apache/kafka/pull/10848#discussion_r648690860 ## File path: storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java ## @@ -33,31 +34,32 @@ private final Path logS

[GitHub] [kafka] junrao merged pull request #10829: MINOR Removed unused ConfigProvider from raft resources module.

junrao merged pull request #10829: URL: https://github.com/apache/kafka/pull/10829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r648132657 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -246,17 +262,17 @@ object LogLoader extends Logging { return fn } catch

[GitHub] [kafka] hachikuji commented on pull request #10803: KAFKA-12874; Increase default consumer session timeout to 45s

hachikuji commented on pull request #10803: URL: https://github.com/apache/kafka/pull/10803#issuecomment-858133566 I'm going to go ahead and merge this. I have been having trouble getting a good build, but that does not seem unique to the PR. The test failures in the recent build appear to

[GitHub] [kafka] hachikuji merged pull request #10803: KAFKA-12874; Increase default consumer session timeout to 45s

hachikuji merged pull request #10803: URL: https://github.com/apache/kafka/pull/10803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Resolved] (KAFKA-12874) Increase default consumer session timeout to 45s (KIP-735)

[ https://issues.apache.org/jira/browse/KAFKA-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12874. - Fix Version/s: 3.0.0 Resolution: Fixed > Increase default consumer session timeou

[GitHub] [kafka] chia7712 commented on a change in pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

chia7712 commented on a change in pull request #10588: URL: https://github.com/apache/kafka/pull/10588#discussion_r648710542 ## File path: tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java ## @@ -0,0 +1,164 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] hachikuji commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

hachikuji commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r648724939 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -68,15 +68,22 @@ public static Path snapshotPath(Path logDir, OffsetAndE

[GitHub] [kafka] mjsax commented on a change in pull request #10856: MINOR: Small optimizations and removal of unused code in Streams

mjsax commented on a change in pull request #10856: URL: https://github.com/apache/kafka/pull/10856#discussion_r648739553 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -294,14 +293,6 @@ public final void

[GitHub] [kafka] mjsax commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

mjsax commented on pull request #10846: URL: https://github.com/apache/kafka/pull/10846#issuecomment-858160278 What do you propose @cadonna ? Also happy to do a follow up PR (but not sure if necessary)? It's all just internal code so we can change at will. Happy to merge as-is, or change t

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360462#comment-17360462 ] Matthias J. Sax commented on KAFKA-9009: Any progress? Failed gain:  https://gith

[jira] [Commented] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

[ https://issues.apache.org/jira/browse/KAFKA-12657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360461#comment-17360461 ] Matthias J. Sax commented on KAFKA-12657: - https://github.com/apache/kafka/pull/

[jira] [Updated] (KAFKA-12925) prefixScan missing from intermediate interfaces

[ https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Viamari updated KAFKA-12925: Summary: prefixScan missing from intermediate interfaces (was: StateStore::prefixScan mis

[jira] [Created] (KAFKA-12925) StateStore::prefixScan missing from intermediate interfaces

Michael Viamari created KAFKA-12925: --- Summary: StateStore::prefixScan missing from intermediate interfaces Key: KAFKA-12925 URL: https://issues.apache.org/jira/browse/KAFKA-12925 Project: Kafka

[GitHub] [kafka] dhruvilshah3 commented on pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

dhruvilshah3 commented on pull request #10388: URL: https://github.com/apache/kafka/pull/10388#issuecomment-858171003 Closing this PR as it's being taken forward in https://github.com/apache/kafka/pull/10763. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dhruvilshah3 closed pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

dhruvilshah3 closed pull request #10388: URL: https://github.com/apache/kafka/pull/10388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360466#comment-17360466 ] Luke Chen commented on KAFKA-9009: -- [~mjsax], yes, PR is ready and waiting for the test

[jira] [Commented] (KAFKA-12925) prefixScan missing from intermediate interfaces

[ https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360467#comment-17360467 ] Matthias J. Sax commented on KAFKA-12925: - [~sagarrao] [~cadonna] [~guozhang] –

[jira] [Updated] (KAFKA-4327) Move Reset Tool from core to streams

[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-4327: --- Labels: kip (was: needs-kip) > Move Reset Tool from core to streams > --

[jira] [Commented] (KAFKA-4327) Move Reset Tool from core to streams

[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360468#comment-17360468 ] Matthias J. Sax commented on KAFKA-4327: As 3.0 KIP deadline passed today, I thin

[jira] [Updated] (KAFKA-4327) Move Reset Tool from core to streams

[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-4327: --- Description: This is a follow up on https://issues.apache.org/jira/browse/KAFKA-4008 Current

[jira] [Commented] (KAFKA-10501) Log Cleaner never clean up some __consumer_offsets partitions

[ https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360469#comment-17360469 ] Victor Garcia commented on KAFKA-10501: --- [~mbaluta] do you think this issue is the

[GitHub] [kafka] cmccabe opened a new pull request #10857: MINOR: Create SnapshotWriter and SnapshotReader interfaces

cmccabe opened a new pull request #10857: URL: https://github.com/apache/kafka/pull/10857 Previously, we had an interface named org.apache.kafka.controller.SnapshotWriter and a concrete implementation class called org.apache.kafka.snapshot.SnapshotWriter. As part of unit tests,

[jira] [Created] (KAFKA-12926) ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

Ignacio Acuna created KAFKA-12926: - Summary: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh Key: KAFKA-12926 URL: https://issues.apache.org/jira/br

[GitHub] [kafka] satishd commented on a change in pull request #10848: MINOR Updated transaction index as optional in LogSegmentData.

satishd commented on a change in pull request #10848: URL: https://github.com/apache/kafka/pull/10848#discussion_r648768897 ## File path: storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java ## @@ -33,31 +34,32 @@ private final Path log

[jira] [Commented] (KAFKA-12925) prefixScan missing from intermediate interfaces

[ https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360472#comment-17360472 ] A. Sophie Blee-Goldman commented on KAFKA-12925: [~sagarrao] do you thin

[jira] [Updated] (KAFKA-12925) prefixScan missing from intermediate interfaces

[ https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12925: --- Fix Version/s: 2.8.1 3.0.0 > prefixScan missing from inte

[jira] [Comment Edited] (KAFKA-12925) prefixScan missing from intermediate interfaces

[ https://issues.apache.org/jira/browse/KAFKA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360472#comment-17360472 ] A. Sophie Blee-Goldman edited comment on KAFKA-12925 at 6/10/21, 12:51 AM: ---

[GitHub] [kafka] IgnacioAcunaF opened a new pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

IgnacioAcunaF opened a new pull request #10858: URL: https://github.com/apache/kafka/pull/10858 **Jira:**: https://issues.apache.org/jira/browse/KAFKA-12926 Instead of setting "null" to negative offsets partition (as in KAFKA-9507), this PR aims to skip those cases from the returned

[jira] [Commented] (KAFKA-12920) Consumer's cooperative sticky assignor need to clear generation / assignment data upon `onPartitionsLost`

[ https://issues.apache.org/jira/browse/KAFKA-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360480#comment-17360480 ] A. Sophie Blee-Goldman commented on KAFKA-12920: I believe we've found t

  1   2   >