showuon commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647166328
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java
##
@@ -17,39 +17,94 @@
package org.apache.kafka.streams.proces
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359151#comment-17359151
]
Abhijit Mane commented on KAFKA-12847:
--
Thanks [~chia7712] for the prompt responses
[
https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359160#comment-17359160
]
Josep Prat commented on KAFKA-12893:
Right link to the KIP for documentation purpose
[
https://issues.apache.org/jira/browse/KAFKA-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359160#comment-17359160
]
Josep Prat edited comment on KAFKA-12893 at 6/8/21, 8:51 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359162#comment-17359162
]
Bruno Cadonna commented on KAFKA-12905:
---
[~a493172422] Could you convert this tick
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359163#comment-17359163
]
Chia-Ping Tsai commented on KAFKA-12847:
> If you get a chance, maybe you could
cadonna commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647252571
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -314,7 +314,6 @@ class GroupMetadataManager(brokerId: Int,
cadonna commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r647259690
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/NamedCacheMetricsTest.java
##
@@ -49,37 +41,28 @@
private stati
[
https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12890:
Fix Version/s: 3.0.0
> Consumer group stuck in `CompletingRebalance`
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12896:
Fix Version/s: 3.0.0
> Group rebalance loop caused by repeated group leader JoinGroups
> -
[
https://issues.apache.org/jira/browse/KAFKA-12896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12896:
Priority: Blocker (was: Major)
> Group rebalance loop caused by repeated group leader JoinGroups
Matthew de Detrich created KAFKA-12913:
--
Summary: Make Scala Case class's final
Key: KAFKA-12913
URL: https://issues.apache.org/jira/browse/KAFKA-12913
Project: Kafka
Issue Type: Improve
cadonna commented on a change in pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#discussion_r647295043
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfoTest.java
##
@@ -407,32 +409,56 @@ public voi
lkokhreidze commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-856654402
Hi @cadonna,
Thanks for the feedback. I think that's a good call. I didn't know that
consequence of bumping the version. I will open PR around assignor changes
shortly, a
tombentley commented on pull request #9878:
URL: https://github.com/apache/kafka/pull/9878#issuecomment-856684447
Test failure is unrelated. @dajac @cmccabe @mimaison please could one of you
review?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
mdedetrich opened a new pull request #10839:
URL: https://github.com/apache/kafka/pull/10839
This PR makes all of the Scala's `case class`'s final to ensure correctness
of Kafka's Scala code that uses these case classes. In Scala its best practice
to make `case class`'s final since `case c
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r647360753
##
File path:
core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerWithZkSaslTest.scala
##
@@ -178,9 +177,3 @@ class TestableDigestLoginMod
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r647361367
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -1143,3 +1141,5 @@ class ZkAdminManager(val config: KafkaConfig,
retval
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r647362215
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -462,10 +462,10 @@ class ZkMetadataCache(brokerId: Int) extends
MetadataCache
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r647362843
##
File path:
core/src/test/scala/integration/kafka/server/MultipleListenersWithSameSecurityProtocolBaseTest.scala
##
@@ -180,7 +180,7 @@ abstract cla
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r647363288
##
File path:
core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerWithZkSaslTest.scala
##
@@ -69,7 +68,7 @@ class AclAuthorizerWithZkSaslT
jlprat opened a new pull request #10840:
URL: https://github.com/apache/kafka/pull/10840
Implementation of [KIP-744](https://cwiki.apache.org/confluence/x/XIrOCg).
Creates new Interfaces for TaskMetadata, ThreadMetadata, and
StreamsMetadata, providing internal implementations for e
[
https://issues.apache.org/jira/browse/KAFKA-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-12849:
---
Fix Version/s: 3.0.0
> Consider migrating TaskMetadata to interface with internal implementation
> -
ijuma commented on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856770388
I updated the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ijuma commented on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856771541
Unrelated failures:
> Build / JDK 11 and Scala 2.13 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
> Build / JDK 15 and Scala 2.13 /
org.apac
ijuma merged pull request #10828:
URL: https://github.com/apache/kafka/pull/10828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/KAFKA-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YI-CHEN WANG updated KAFKA-12905:
-
Parent: KAFKA-7438
Issue Type: Sub-task (was: Improvement)
> Replace EasyMock and Power
[
https://issues.apache.org/jira/browse/KAFKA-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YI-CHEN WANG updated KAFKA-12905:
-
Attachment: image-2021-06-08-21-42-15-727.png
> Replace EasyMock and PowerMock with Mockito for
ijuma commented on pull request #10828:
URL: https://github.com/apache/kafka/pull/10828#issuecomment-856781793
Merged to trunk and cherry-picked to 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359368#comment-17359368
]
YI-CHEN WANG commented on KAFKA-12905:
--
[~cadonna] OK, I have converted.My future m
[
https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12890:
Fix Version/s: 2.8.1
> Consumer group stuck in `CompletingRebalance`
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12890:
Fix Version/s: 2.7.2
2.6.3
> Consumer group stuck in `CompletingRebalance`
> --
dongjinleekr commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647468635
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -314,7 +314,6 @@ class GroupMetadataManager(brokerId: Int
lkokhreidze commented on a change in pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#discussion_r647470689
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java
##
@@ -161,8 +162,8 @@ public ByteBuffer subscriptionUserD
ijuma commented on pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#issuecomment-856794295
@cadonna The build changes look good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ijuma commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647474072
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -402,43 +402,43 @@ object KafkaConfig {
val RackProp = "broker.rack"
/** **
ijuma commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647474443
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -248,7 +248,7 @@ object ConsoleConsumer extends Logging {
val timeoutMsOpt =
lkokhreidze commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-856797369
Hi @cadonna I've addressed all of your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lkokhreidze commented on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-856813901
Hi @cadonna
Giving it a bit more thought around the order of PRs, logically it makes
more sense to have this PR first, as TaskAssignor gets data from the
subscription in
lkokhreidze edited a comment on pull request #10802:
URL: https://github.com/apache/kafka/pull/10802#issuecomment-856813901
Hi @cadonna
Giving it a bit more thought around the order of PRs, logically it makes
more sense to have this PR first, as TaskAssignor gets data from the
subscrip
chia7712 commented on a change in pull request #10835:
URL: https://github.com/apache/kafka/pull/10835#discussion_r647503080
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/NamedCacheMetricsTest.java
##
@@ -49,37 +41,28 @@
private stat
kpatelatwork opened a new pull request #10841:
URL: https://github.com/apache/kafka/pull/10841
The following Connect worker configuration properties were deprecated 3
years ago and 3.0.0 seems like a good major release to remove them as part of
this PR:
- rest.host.name (deprecated
vamossagar12 opened a new pull request #10842:
URL: https://github.com/apache/kafka/pull/10842
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
Will Bartlett created KAFKA-12914:
-
Summary: StreamSourceNode.toString() throws with
StreamsBuilder.stream(Pattern) ctor
Key: KAFKA-12914
URL: https://issues.apache.org/jira/browse/KAFKA-12914
Project
[
https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359432#comment-17359432
]
Sagar Rao commented on KAFKA-12848:
---
[~ableegoldman], i have added benchmarks for pers
[
https://issues.apache.org/jira/browse/KAFKA-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359432#comment-17359432
]
Sagar Rao edited comment on KAFKA-12848 at 6/8/21, 3:50 PM:
wenbingshen commented on a change in pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#discussion_r647551596
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -146,25 +146,6 @@
+ "data to be com
mushfiqur rahoman created KAFKA-12915:
-
Summary: Online TV Channel
Key: KAFKA-12915
URL: https://issues.apache.org/jira/browse/KAFKA-12915
Project: Kafka
Issue Type: Bug
Repor
rhauch commented on a change in pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#discussion_r647588529
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -304,8 +285,6 @@ protected static ConfigDef baseConfi
jsancio commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r647596275
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -247,6 +247,34 @@ final class KafkaMetadataLog private (
FileRawSnapshotWri
[
https://issues.apache.org/jira/browse/KAFKA-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359447#comment-17359447
]
Matthias J. Sax commented on KAFKA-12870:
-
Could this be related to https://issu
thomaskwscott commented on a change in pull request #10760:
URL: https://github.com/apache/kafka/pull/10760#discussion_r647639491
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4225,76 +4232,84 @@ public ListOffsetsResult
listO
Christopher L. Shannon created KAFKA-12916:
--
Summary: Add new AUTO_CREATE ACL for auto topic creation
Key: KAFKA-12916
URL: https://issues.apache.org/jira/browse/KAFKA-12916
Project: Kafka
vvcephei commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647659103
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/RecordMetadata.java
##
@@ -16,19 +16,51 @@
*/
package org.apache.kafka.str
YiDing-Duke opened a new pull request #10843:
URL: https://github.com/apache/kafka/pull/10843
Format configuration logging during exceptions or errors.
Also make sure it redacts sensitive information or unknown values.
### Committer Checklist (excluded from commit message)
- [ ]
vincent81jiang opened a new pull request #10844:
URL: https://github.com/apache/kafka/pull/10844
'fetchStartOffset' is easier to read than 'startOffset' in Log.scala since
'startOffset' is easy to be confused with logStartOffset.
### Committer Checklist (excluded from commit message)
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647662697
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/RecordMetadata.java
##
@@ -16,19 +16,51 @@
*/
package org.apache.kafka.stream
YiDing-Duke commented on pull request #10843:
URL: https://github.com/apache/kafka/pull/10843#issuecomment-856973287
@dajac @kowshik @showuon could you help review this PR? thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jlprat commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647670096
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##
@@ -53,9 +53,9 @@
TaskId taskId();
/**
-
jlprat commented on pull request #10840:
URL: https://github.com/apache/kafka/pull/10840#issuecomment-856977741
Failure was:
```
[2021-06-08T14:01:59.439Z] FAILURE: Build failed with an exception.
[2021-06-08T14:01:59.439Z]
[2021-06-08T14:01:59.439Z] * What went wrong:
[2021-
cshannon opened a new pull request #10845:
URL: https://github.com/apache/kafka/pull/10845
This will authorizing a user to auto create a topic with cluster defaults
but prevent manual creation with overriden settings. The change is backwards
compatible as being granted CREATE also implies
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647695386
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java
##
@@ -17,39 +17,94 @@
package org.apache.kafka.streams.processo
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647696003
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##
@@ -53,9 +53,9 @@
TaskId taskId();
/**
-
mjsax commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647702594
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/RecordContext.java
##
@@ -17,39 +17,94 @@
package org.apache.kafka.streams.processo
[
https://issues.apache.org/jira/browse/KAFKA-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-12912.
-
Resolution: Invalid
> fdgfdgfg
>
>
> Key: KAFKA-12912
>
jlprat commented on a change in pull request #10810:
URL: https://github.com/apache/kafka/pull/10810#discussion_r647715006
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##
@@ -53,9 +53,9 @@
TaskId taskId();
/**
-
[
https://issues.apache.org/jira/browse/KAFKA-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-12914:
---
Assignee: Matthias J. Sax
> StreamSourceNode.toString() throws with StreamsBuilder.
mjsax opened a new pull request #10846:
URL: https://github.com/apache/kafka/pull/10846
Call for review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queri
kpatelatwork commented on a change in pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#discussion_r647722430
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -146,25 +146,6 @@
+ "data to be co
kpatelatwork commented on a change in pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#discussion_r647724197
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java
##
@@ -304,8 +285,6 @@ protected static ConfigDef bas
kpatelatwork commented on pull request #10841:
URL: https://github.com/apache/kafka/pull/10841#issuecomment-857065222
@rhauch and @wenbingshen I updated the PR with all review comments. When
you get time could you please check, if it looks good now?
--
This is an automated message from
mushfiqur rahoman created KAFKA-12917:
-
Summary: Watch Animated 'America: The Motion Picture' Trailer Full
Hd Download-Now
Key: KAFKA-12917
URL: https://issues.apache.org/jira/browse/KAFKA-12917
P
mushfiqur rahoman created KAFKA-12918:
-
Summary: Watch-Free Animated 'America: The Motion Picture' Trailer
2021 Full Hd Download
Key: KAFKA-12918
URL: https://issues.apache.org/jira/browse/KAFKA-12918
mushfiqur rahoman created KAFKA-12919:
-
Summary: Watch-Free Animated 'America: The Motion Picture' Trailer
2021 Full Hd Download-Here
Key: KAFKA-12919
URL: https://issues.apache.org/jira/browse/KAFKA-12919
[
https://issues.apache.org/jira/browse/KAFKA-12917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-12917.
Resolution: Invalid
> Watch Animated 'America: The Motion Picture' Trailer Full Hd Downloa
[
https://issues.apache.org/jira/browse/KAFKA-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-12918.
---
> Watch-Free Animated 'America: The Motion Picture' Trailer 2021 Full Hd
> Download
>
[
https://issues.apache.org/jira/browse/KAFKA-12918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang closed KAFKA-12918.
-
> Watch-Free Animated 'America: The Motion Picture' Trailer 2021 Full Hd
> Download
>
hachikuji commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r647803084
##
File path:
metadata/src/main/java/org/apache/kafka/controller/SnapshotGenerator.java
##
@@ -74,56 +74,49 @@ String name() {
this.batch = nu
gharris1727 commented on pull request #8259:
URL: https://github.com/apache/kafka/pull/8259#issuecomment-857215526
@rhauch @gharris1727
I've applied the above feedback. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Guozhang Wang created KAFKA-12920:
-
Summary: Consumer's cooperative sticky assignor need to clear
generation / assignment data upon `onPartitionsLost`
Key: KAFKA-12920
URL: https://issues.apache.org/jira/browse/KA
[
https://issues.apache.org/jira/browse/KAFKA-12920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12920:
--
Issue Type: Bug (was: Improvement)
> Consumer's cooperative sticky assignor need to clear gen
gharris1727 edited a comment on pull request #8259:
URL: https://github.com/apache/kafka/pull/8259#issuecomment-857215526
@rhauch @kkonstantine
I've applied the above feedback. PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
dongjinleekr commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647902119
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -248,7 +248,7 @@ object ConsoleConsumer extends Logging {
val timeoutM
dongjinleekr commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647902481
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -402,43 +402,43 @@ object KafkaConfig {
val RackProp = "broker.rack"
/**
mjsax commented on pull request #10846:
URL: https://github.com/apache/kafka/pull/10846#issuecomment-857329691
> Just a thought that do you think it's better to return empty set when null?
For `SourceGraphNode` we either set `topicName` or `pattern` `null`, and we
also return `null`
showuon commented on pull request #10846:
URL: https://github.com/apache/kafka/pull/10846#issuecomment-857330899
> As an afterthought, it might even be better to change both return types to
`Optional` ?
Sounds good!
--
This is an automated message from the Apache Git Service.
To r
David Christle created KAFKA-12921:
--
Summary: Upgrade ZSTD JNI from 1.4.9-1 to 1.5.0-1
Key: KAFKA-12921
URL: https://issues.apache.org/jira/browse/KAFKA-12921
Project: Kafka
Issue Type: Impr
mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r647928413
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java
##
@@ -60,8 +60,8 @@ public void init(final InternalProcesso
mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r647929736
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java
##
@@ -78,6 +79,10 @@
throw new S
dchristle opened a new pull request #10847:
URL: https://github.com/apache/kafka/pull/10847
This PR aims to upgrade `zstd-jni` from `1.4.9-1` to `1.5.0-1`.
This change will incorporate a number of bug fixes and performance
improvements made in the `1.4.x` branch and `1.5.0` of `zstd`
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r647946747
##
File path: build.gradle
##
@@ -829,6 +829,7 @@ project(':core') {
testImplementation(libs.jfreechart) {
exclude group: 'junit', module: 'ju
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r647946840
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -350,7 +372,8 @@ class BrokerToControllerRequestThread(
ijuma commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647966061
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -248,7 +248,7 @@ object ConsoleConsumer extends Logging {
val timeoutMsOpt =
socutes commented on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-857382741
@mumrah Code format fix completed! Thank you very much for your Review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dchristle commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-857396796
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjinleekr commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647996559
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -248,7 +248,7 @@ object ConsoleConsumer extends Logging {
val timeoutM
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-857413304
Rebased onto the latest trunk, adapting @ijuma's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
satishd opened a new pull request #10848:
URL: https://github.com/apache/kafka/pull/10848
- Updated transaction index as optional in `LogSegmentData`.
- Added a unit test for the introduced change.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
satishd commented on pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#issuecomment-857423198
@junrao : Pl take a look at this minor PR making transaction index as
optional in `LogSegmentData` as we discussed earlier.
--
This is an automated message from the Apache Gi
socutes edited a comment on pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#issuecomment-857382741
@mumrah Code format fix completed! Thank you very much for your Review.
Before I submit the code, I execute the command "./gradlew checkstyleMain
checkstyleTest "to
1 - 100 of 101 matches
Mail list logo
