[GitHub] [kafka] predatorray commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2021-06-05 Thread GitBox
predatorray commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-855196926 @jjkoshy Could you help me review this pr and share some thoughts about the exception with us? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] showuon commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-05 Thread GitBox
showuon commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-855197435 2 PR builds have no build failure. This PR can fix the trunk build failure issue. Thanks. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] showuon commented on pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test

2021-06-05 Thread GitBox
showuon commented on pull request #10821: URL: https://github.com/apache/kafka/pull/10821#issuecomment-85519 @soarez , thanks for the quick fix. But unfortunately, the PR build still failed for "JDK 15 and Scala 2.13" build. I don't see the AclException in the log, but still failed the

[GitHub] [kafka] omkreddy commented on pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test

2021-06-05 Thread GitBox
omkreddy commented on pull request #10821: URL: https://github.com/apache/kafka/pull/10821#issuecomment-855205284 Changes LGTM. let us re-run the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] vitojeng opened a new pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-05 Thread GitBox
vitojeng opened a new pull request #10825: URL: https://github.com/apache/kafka/pull/10825 follow-up #8200 KAFKA-5876's PR break into multiple parts, this PR is part 5. In KIP-216, the following exceptions is currently not completed: StreamsRebalancingException, StreamsRebalan

[GitHub] [kafka] vitojeng commented on pull request #10825: KAFKA-5876: Add `streams()` method to StateStoreProvider

2021-06-05 Thread GitBox
vitojeng commented on pull request #10825: URL: https://github.com/apache/kafka/pull/10825#issuecomment-855223713 @ableegoldman Please take a look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] omkreddy merged pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test

2021-06-05 Thread GitBox
omkreddy merged pull request #10821: URL: https://github.com/apache/kafka/pull/10821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] omkreddy commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-05 Thread GitBox
omkreddy commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-855231676 @showuon I have merged the PR https://github.com/apache/kafka/pull/10821. Let us monitor any build failures. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-05 Thread GitBox
showuon commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-855233257 @omkreddy , sure. Hope it fixes the build. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] tang7526 commented on pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-06-05 Thread GitBox
tang7526 commented on pull request #10588: URL: https://github.com/apache/kafka/pull/10588#issuecomment-855235007 > @tang7526 thanks for your patch. Could you run `benchmark_test.py` to make sure this refactor does not make performance regression? @chia7712 Thank you for your opinio

[jira] [Commented] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-06-05 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357861#comment-17357861 ] Abhijit Mane commented on KAFKA-12847: -- Thanks [~chia7712]. I understand what you h

[jira] [Commented] (KAFKA-12370) Refactor KafkaStreams exposed metadata hierarchy

2021-06-05 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357869#comment-17357869 ] Josep Prat commented on KAFKA-12370: As I'm already half familiar with these changes

[jira] [Updated] (KAFKA-7632) Support Compression Level

2021-06-05 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-7632: --- Summary: Support Compression Level (was: Allow fine-grained configuration for compression) > Suppor

[GitHub] [kafka] dongjinleekr closed pull request #5927: KAFKA-7632: Allow fine-grained configuration for compression

2021-06-05 Thread GitBox
dongjinleekr closed pull request #5927: URL: https://github.com/apache/kafka/pull/5927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [kafka] dongjinleekr commented on pull request #5927: KAFKA-7632: Allow fine-grained configuration for compression

2021-06-05 Thread GitBox
dongjinleekr commented on pull request #5927: URL: https://github.com/apache/kafka/pull/5927#issuecomment-855263224 Closes this PR in preference of a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] dongjinleekr opened a new pull request #10826: KAFKA-7632: Support Compression Level

2021-06-05 Thread GitBox
dongjinleekr opened a new pull request #10826: URL: https://github.com/apache/kafka/pull/10826 Since I reworked [KIP-390](https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level) from scratch, here I open a new PR. ### Committer Checklist (excluded fro

[GitHub] [kafka] dongjinleekr edited a comment on pull request #5927: KAFKA-7632: Allow fine-grained configuration for compression

2021-06-05 Thread GitBox
dongjinleekr edited a comment on pull request #5927: URL: https://github.com/apache/kafka/pull/5927#issuecomment-855263224 Closes this PR in preference of a [new one](https://github.com/apache/kafka/pull/10826). -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] dongjinleekr commented on pull request #10826: KAFKA-7632: Support Compression Level

2021-06-05 Thread GitBox
dongjinleekr commented on pull request #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-855263796 @ijuma @guozhangwang Could you have a look when you are free? I refined the original work with a benchmark with a real-world dataset. As you can see in the updated KIP, thi

[jira] [Commented] (KAFKA-10269) AdminClient ListOffsetsResultInfo/timestamp is always -1

2021-06-05 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357938#comment-17357938 ] Dongjin Lee commented on KAFKA-10269: - [~huxi_2b] It seems like this is not a bug. R

[jira] [Created] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-06-05 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-12899: --- Summary: Support --bootstrap-server in ReplicaVerificationTool Key: KAFKA-12899 URL: https://issues.apache.org/jira/browse/KAFKA-12899 Project: Kafka Issue Typ

[GitHub] [kafka] dongjinleekr opened a new pull request #10827: KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-05 Thread GitBox
dongjinleekr opened a new pull request #10827: URL: https://github.com/apache/kafka/pull/10827 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[jira] [Commented] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

2021-06-05 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357947#comment-17357947 ] Dongjin Lee commented on KAFKA-12899: - Hi [~guozhang], Please don't leave this issu

[GitHub] [kafka] ijuma opened a new pull request #10828: MINOR: Only log overridden topic configs during topic creation

2021-06-05 Thread GitBox
ijuma opened a new pull request #10828: URL: https://github.com/apache/kafka/pull/10828 I think this behavior changed unintentionally as part of the kraft work. Also make sure to redact sensitive and unknown config values. Unit test included. ### Committer Checklist (exclude

[GitHub] [kafka] ijuma commented on pull request #10828: MINOR: Only log overridden topic configs during topic creation

2021-06-05 Thread GitBox
ijuma commented on pull request #10828: URL: https://github.com/apache/kafka/pull/10828#issuecomment-855297271 @rondagostino Can you double check if what I stated regarding the kraft work is true? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (KAFKA-12900) JBOD: Partitions count calculation does not take into account topic name

2021-06-05 Thread Georgy (Jira)
Georgy created KAFKA-12900: -- Summary: JBOD: Partitions count calculation does not take into account topic name Key: KAFKA-12900 URL: https://issues.apache.org/jira/browse/KAFKA-12900 Project: Kafka

[jira] [Updated] (KAFKA-12900) JBOD: Partitions count calculation does not take into account topic name

2021-06-05 Thread Georgy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgy updated KAFKA-12900: --- Attachment: KAFKA-12900.patch > JBOD: Partitions count calculation does not take into account topic name > -

[jira] [Updated] (KAFKA-12900) JBOD: Partitions count calculation does not take into account topic name

2021-06-05 Thread Georgy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgy updated KAFKA-12900: --- Description: In KAFKA-188 multiple data directories support was implemented. New partitions are spread to m

[jira] [Commented] (KAFKA-188) Support multiple data directories

2021-06-05 Thread Georgy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358002#comment-17358002 ] Georgy commented on KAFKA-188: -- [~jkreps] please look at KAFKA-12900 It seems that we do not

[jira] [Issue Comment Deleted] (KAFKA-5560) LogManager should be able to create new logs based on free disk space

2021-06-05 Thread Georgy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgy updated KAFKA-5560: -- Comment: was deleted (was: [~huxi_2b] [~junrao] Will this task be in progress someday or maybe there is some a

[GitHub] [kafka] wenbingshen commented on pull request #10815: KAFKA-12885: Add the --timeout property to kafka-leader-election.sh

2021-06-05 Thread GitBox
wenbingshen commented on pull request #10815: URL: https://github.com/apache/kafka/pull/10815#issuecomment-855314268 @socutes Thanks for your reply. We need a KIP for adding a new flag to a command line tool as it is considered as part of the public API. -- This is an automated message f

[GitHub] [kafka] wenbingshen commented on a change in pull request #10827: KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-05 Thread GitBox
wenbingshen commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r646052588 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -75,9 +75,14 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10827: KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-05 Thread GitBox
dongjinleekr commented on a change in pull request #10827: URL: https://github.com/apache/kafka/pull/10827#discussion_r646053346 ## File path: core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala ## @@ -75,9 +75,14 @@ object ReplicaVerificationTool extends Logging {

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-06-05 Thread GitBox
dongjinleekr commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r646056035 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource re

[GitHub] [kafka] socutes commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-06-05 Thread GitBox
socutes commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-855340683 @jsancio Can this PR be merged into the trunk? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a