dongjinleekr closed pull request #10642:
URL: https://github.com/apache/kafka/pull/10642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-851263147
Rebased onto the latest trunk, along with additional glitches I found during
other issues.
@chia7712 @kowshik @ijuma Could you have a look? :pray:
--
This is an au
chia7712 commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851271639
> The build definition doesn't require changes to mention this annotation?
The doc (https://jqwik.net/docs/current/user-guide.html#tagging-tests)
explains how to tag a te
chia7712 opened a new pull request #10796:
URL: https://github.com/apache/kafka/pull/10796
see CI
(https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-10585/5/pipeline/12/)
and the error is related to 6b005b2b4eece81a5500fb0080ef5354b4240681
### Commit
Kowshik Prakasam created KAFKA-12867:
Summary: Trogdor ConsumeBenchWorker quits prematurely with
maxMessages config
Key: KAFKA-12867
URL: https://issues.apache.org/jira/browse/KAFKA-12867
Project:
kowshik opened a new pull request #10797:
URL: https://github.com/apache/kafka/pull/10797
The trogdor `ConsumeBenchWorker` has a bug. If one of the consumption tasks
completes executing successfully due to `maxMessages` being consumed, then, the
consumption task notifies the `doneFuture` c
kowshik commented on pull request #10797:
URL: https://github.com/apache/kafka/pull/10797#issuecomment-851293196
cc @junrao @apovzner @rajinisivaram for review.
@apovzner It appears this behavior has been around since
`ConsumeBenchWorker` was first implemented:
https://github.com/ap
Yuneng Xie created KAFKA-12868:
--
Summary: log cleaner failed with
java.lang.ArrayIndexOutOfBoundsException: -2147483648
Key: KAFKA-12868
URL: https://issues.apache.org/jira/browse/KAFKA-12868
Project: Ka
[
https://issues.apache.org/jira/browse/KAFKA-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuneng Xie updated KAFKA-12868:
---
Description:
our broker spent too long loading the offset partition.
```
[2021-05-30 03:18:20,505]
[
https://issues.apache.org/jira/browse/KAFKA-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuneng Xie updated KAFKA-12868:
---
Description:
our broker spent too long loading the offset partition.
```
[2021-05-30 03:18:20,505]
[
https://issues.apache.org/jira/browse/KAFKA-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuneng Xie updated KAFKA-12868:
---
Description:
our broker spent too long loading the offset partition.
```
[2021-05-30 03:18:20,505]
[
https://issues.apache.org/jira/browse/KAFKA-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuneng Xie updated KAFKA-12868:
---
Description:
our broker spent too long loading the offset partition.
```
[2021-05-30 03:18:20,505]
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354293#comment-17354293
]
Chia-Ping Tsai commented on KAFKA-12847:
Could you try to use non-root to run ka
jlprat commented on pull request #10702:
URL: https://github.com/apache/kafka/pull/10702#issuecomment-851334730
For reference, there is an issue in PowerMock for this:
https://github.com/powermock/powermock/issues/1099
--
This is an automated message from the Apache Git Service.
To respo
cadonna commented on pull request #10796:
URL: https://github.com/apache/kafka/pull/10796#issuecomment-851444665
The test failures are unrelated and known to be flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
showuon commented on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-851446115
Tests added. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna merged pull request #10796:
URL: https://github.com/apache/kafka/pull/10796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642461619
##
File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
##
@@ -198,15 +199,15 @@ class DefaultAutoTopicCreationManager(
//
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642461619
##
File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
##
@@ -198,15 +199,15 @@ class DefaultAutoTopicCreationManager(
//
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642462291
##
File path: core/src/main/scala/kafka/server/ForwardingManager.scala
##
@@ -125,7 +125,7 @@ class ForwardingManagerImpl(
}
}
-channelM
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642461619
##
File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala
##
@@ -198,15 +199,15 @@ class DefaultAutoTopicCreationManager(
//
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642462291
##
File path: core/src/main/scala/kafka/server/ForwardingManager.scala
##
@@ -125,7 +125,7 @@ class ForwardingManagerImpl(
}
}
-channelM
lkokhreidze commented on a change in pull request #10785:
URL: https://github.com/apache/kafka/pull/10785#discussion_r642467096
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -33,8 +31,10 @@
import java.util.Map;
import java.util.Set;
cadonna commented on a change in pull request #10507:
URL: https://github.com/apache/kafka/pull/10507#discussion_r642403697
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/LogAndContinueExceptionHandler.java
##
@@ -32,7 +32,7 @@
private static final Lo
vamossagar12 opened a new pull request #10798:
URL: https://github.com/apache/kafka/pull/10798
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354490#comment-17354490
]
Sagar Rao commented on KAFKA-9168:
--
[~ableegoldman] i modified the put API for single co
ijuma commented on pull request #10796:
URL: https://github.com/apache/kafka/pull/10796#issuecomment-851537672
Thanks for the fix, my bad for missing it. I did merge trunk and build
locally before merging the PR, but didn't check Scala 2.12.
--
This is an automated message from the Apach
ijuma commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851538731
I was asking if our build has to change. Looks like it's string based, so it
doesn't?
https://github.com/apache/kafka/blob/trunk/build.gradle#L404
--
This is an automated
ijuma edited a comment on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851538731
I was asking if our build has to change. Looks like it's string based, so it
doesn't?
https://github.com/apache/kafka/blob/trunk/build.gradle#L404
Have we test
viktorsomogyi commented on pull request #10738:
URL: https://github.com/apache/kafka/pull/10738#issuecomment-851544134
Finished rebasing and coding (and therefore force pushing), I'll switch the
pr into "ready for review" state now.
--
This is an automated message from the Apache Git Ser
viktorsomogyi commented on pull request #10738:
URL: https://github.com/apache/kafka/pull/10738#issuecomment-851545252
@omkreddy @rajinisivaram would you please help in the review to get this
long outstanding KIP done?
--
This is an automated message from the Apache Git Service.
To respo
dengziming commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642556841
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -363,6 +386,22 @@ class BrokerToControllerRequestThread(
dajac opened a new pull request #10799:
URL: https://github.com/apache/kafka/pull/10799
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing s
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851594252
Hi @ableegoldman as you reviewed the last change in that area (fix license
files) do you think you can review this one? Thanks in advance!
--
This is an automated message from
jlprat commented on pull request #10783:
URL: https://github.com/apache/kafka/pull/10783#issuecomment-851594384
@ijuma You can review now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ijuma commented on pull request #9497:
URL: https://github.com/apache/kafka/pull/9497#issuecomment-851596119
@d8tltanc can we rebase this PR so that we can get it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
ijuma removed a comment on pull request #9497:
URL: https://github.com/apache/kafka/pull/9497#issuecomment-851596119
@d8tltanc can we rebase this PR so that we can get it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ijuma commented on pull request #9497:
URL: https://github.com/apache/kafka/pull/9497#issuecomment-851597938
@d8tltanc I notice that the Jira ticket was assigned to you, but this PR was
submitted by @warrenzhu25. Are you working together on this?
I am asking because we need to get th
soarez commented on pull request #10795:
URL: https://github.com/apache/kafka/pull/10795#issuecomment-851598218
@omkreddy can you have a look at this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Pavel Kuznetsov created KAFKA-12869:
---
Summary: Update vulnerable dependencies
Key: KAFKA-12869
URL: https://issues.apache.org/jira/browse/KAFKA-12869
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354586#comment-17354586
]
Bruno Cadonna commented on KAFKA-9168:
--
[~sagarrao] and [~ableegoldman] I took the l
omkreddy commented on pull request #10795:
URL: https://github.com/apache/kafka/pull/10795#issuecomment-851613121
cc @rondagostino
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/KAFKA-12869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354604#comment-17354604
]
Ismael Juma commented on KAFKA-12869:
-
Thanks for the report. Have you checked if th
ijuma opened a new pull request #10800:
URL: https://github.com/apache/kafka/pull/10800
Async profiler 2.0 outputs html5 flame graph files
and supports simultaneous collection of cpu,
allocation and lock profiles in jfr format.
Updated the readme to include an example of the
cadonna commented on pull request #10765:
URL: https://github.com/apache/kafka/pull/10765#issuecomment-851639965
@showuon and @guozhangwang Do you want to have a second look after my last
update of the unit tests? Otherwise I would move on and merge.
--
This is an automated message from
ijuma commented on pull request #10783:
URL: https://github.com/apache/kafka/pull/10783#issuecomment-851640073
JDK 8 and Scala 2.12 has two unrelated failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ijuma merged pull request #10783:
URL: https://github.com/apache/kafka/pull/10783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
cadonna commented on pull request #10765:
URL: https://github.com/apache/kafka/pull/10765#issuecomment-851641644
Test failures are unrelated and known to be flaky:
```
JDK 8 and Scala 2.12 /
kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics()
JDK 8 and Scala 2.12
jlprat commented on pull request #10783:
URL: https://github.com/apache/kafka/pull/10783#issuecomment-851642412
Thanks a lot for the review @ijuma !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cadonna commented on pull request #10785:
URL: https://github.com/apache/kafka/pull/10785#issuecomment-851652903
@lkokhreidze Thank you for the PR!
This is quite a large PR. Could you split it up into smaller PRs that are
easier to review?
One option could be to have a separate PR for
ableegoldman commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851732066
Hey @jlprat , can you elaborate on (a) the motivation behind adding this
`NOTICE-binary` file (are we missing licenses completely? or we had them but
not in the correct for
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642743186
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -363,6 +386,22 @@ class BrokerToControllerRequestThread(
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642748185
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -363,6 +386,22 @@ class BrokerToControllerRequestThread(
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354778#comment-17354778
]
Sagar Rao edited comment on KAFKA-9168 at 6/1/21, 3:42 AM:
---
Tha
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354778#comment-17354778
]
Sagar Rao commented on KAFKA-9168:
--
Thanks [~cadonna]! would like to see the results.
>
chia7712 merged pull request #10585:
URL: https://github.com/apache/kafka/pull/10585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
chia7712 commented on pull request #10791:
URL: https://github.com/apache/kafka/pull/10791#issuecomment-851797315
> I was asking if our build has to change. Looks like it's string based, so
it doesn't?
Sorry for my incorrect response :(
> Have we tested?
yes.
*B
[
https://issues.apache.org/jira/browse/KAFKA-12869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354800#comment-17354800
]
Dongjin Lee commented on KAFKA-12869:
-
[~ijuma] I checked the versions. All of them
chia7712 merged pull request #10791:
URL: https://github.com/apache/kafka/pull/10791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
dongjinleekr commented on pull request #10176:
URL: https://github.com/apache/kafka/pull/10176#issuecomment-851818497
For those who are interested in this issue, here is some context:
As you can see in the table below (from
[here](https://www.eclipse.org/jetty/)), the change between
jlprat commented on pull request #10693:
URL: https://github.com/apache/kafka/pull/10693#issuecomment-851831451
Thanks for looking at it @ableegoldman ,
I'll do my best explaining:
a) I added a NOTICE-binary file following the same pattern done for the
LICENSE patch. The purpose o
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642195443
##
File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java
##
@@ -36,10 +37,16 @@
private final String message;
public
showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r642803795
##
File path:
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
##
@@ -239,18 +244,34 @@ class BrokerToControllerChannelManagerImpl
showuon commented on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-851845194
Jenkins PR build results proved the flaky tests doesn't fail anymore:
`#4`: 1 failed test:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.connect.integration.Block
showuon edited a comment on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-851845194
Jenkins PR build results proved the `RaftClusterTest` tests doesn't fail
anymore:
`#4`: 1 failed test:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.conne
showuon commented on pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#issuecomment-851846366
@dengziming , thanks for the comments. I've updated. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r642095314
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java
##
@@ -0,0 +1,253 @@
+/*
+ * Licensed to the Ap
lkokhreidze commented on pull request #10785:
URL: https://github.com/apache/kafka/pull/10785#issuecomment-851871480
Hi @cadonna
Thanks for the reply and suggestion. Will it be okay to have smaller PRs
merged into trunk without having full functionality in place? Afair, when I
worked on
68 matches
Mail list logo
