[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] showuon opened a new pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

showuon opened a new pull request #10794: URL: https://github.com/apache/kafka/pull/10794 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] dengziming commented on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

dengziming commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-850993572 This is awesome, I also notice that there is no logic about `NOT_CONTROLLER` and active controller, I will take some time to test this PR. 👍 -- This is an automated message

[jira] [Created] (KAFKA-12866) Kafka requires ZK root access even when using a chroot

Igor Soarez created KAFKA-12866: --- Summary: Kafka requires ZK root access even when using a chroot Key: KAFKA-12866 URL: https://issues.apache.org/jira/browse/KAFKA-12866 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-12866) Kafka requires ZK root access even when using a chroot

[ https://issues.apache.org/jira/browse/KAFKA-12866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-12866: Description: When a Zookeeper chroot is configured, users do not expect Kafka to need Zookeeper a

[jira] [Assigned] (KAFKA-12866) Kafka requires ZK root access even when using a chroot

[ https://issues.apache.org/jira/browse/KAFKA-12866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reassigned KAFKA-12866: --- Assignee: Igor Soarez > Kafka requires ZK root access even when using a chroot > --

[GitHub] [kafka] soarez opened a new pull request #10795: KAFKA-12866: Avoid root access to Zookeeper

soarez opened a new pull request #10795: URL: https://github.com/apache/kafka/pull/10795 https://issues.apache.org/jira/browse/KAFKA-12866 The broker shouldn't assume create access to the chroot. There are deployement scenarios where the chroot is already created is the only zno

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095137 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,346 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095193 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,346 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095217 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,346 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095239 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,346 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095305 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java ## @@ -0,0 +1,136 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095350 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r642095431 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataTopicPartitioner.java ## @@ -0,0 +1,43 @@ +/* +

[GitHub] [kafka] satishd commented on pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

satishd commented on pull request #10579: URL: https://github.com/apache/kafka/pull/10579#issuecomment-851023730 Thanks @junrao for your comment. Addressed most of them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on pull request #10787: KAFKA-12864: Move queue and timeline into server-common

ijuma commented on pull request #10787: URL: https://github.com/apache/kafka/pull/10787#issuecomment-851027604 Thanks for the PR. Can we please include the motivation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] ijuma commented on pull request #10783: MINOR: Dependency updates around Scala libraries

ijuma commented on pull request #10783: URL: https://github.com/apache/kafka/pull/10783#issuecomment-851027684 The snappy update doesn't seem related to Scala. Maybe that should be a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] jlprat commented on pull request #10783: MINOR: Dependency updates around Scala libraries

jlprat commented on pull request #10783: URL: https://github.com/apache/kafka/pull/10783#issuecomment-851033612 You are right, I should have skipped it. Fix pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] jlprat edited a comment on pull request #10783: MINOR: Dependency updates around Scala libraries

jlprat edited a comment on pull request #10783: URL: https://github.com/apache/kafka/pull/10783#issuecomment-850547775 Sure thing, let me fetch them and link them here: * Spotless: Unfortunately there is no release notes to be found * Scala 2.12.14: https://github.com/scala/scala/relea

[GitHub] [kafka] bruto1 commented on a change in pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

bruto1 commented on a change in pull request #10590: URL: https://github.com/apache/kafka/pull/10590#discussion_r642107164 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -920,23 +923,28 @@ private void throwIfProducerClosed() {

[GitHub] [kafka] ijuma commented on pull request #9229: MINOR: Reduce allocations in requests via buffer caching

ijuma commented on pull request #9229: URL: https://github.com/apache/kafka/pull/9229#issuecomment-851047311 The results are similar for the ducktape benchmarks since the bottleneck is elsewhere. In the PR description, I include the results for a workload that shows significant improvement

[GitHub] [kafka] ijuma merged pull request #9229: MINOR: Reduce allocations in requests via buffer caching

ijuma merged pull request #9229: URL: https://github.com/apache/kafka/pull/9229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[jira] [Assigned] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz reassigned KAFKA-5676: - Assignee: (was: Marco Lotz) > MockStreamsMetrics should be in o.a.k.test > -

[jira] [Commented] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354118#comment-17354118 ] Marco Lotz commented on KAFKA-5676: --- [~mjsax] [~cadonna] I have spent a reasonable amou

[jira] [Comment Edited] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354118#comment-17354118 ] Marco Lotz edited comment on KAFKA-5676 at 5/30/21, 10:47 PM: -

[GitHub] [kafka] dengziming removed a comment on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

dengziming removed a comment on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-833187678 ping @mumrah to have a look 😉. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10785: KIP-708 / A Rack awareness for Kafka Streams

lkokhreidze commented on a change in pull request #10785: URL: https://github.com/apache/kafka/pull/10785#discussion_r642141626 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignorTest.java ## @@ -0,0 +1,

[GitHub] [kafka] lkokhreidze commented on pull request #10785: KIP-708 / A Rack awareness for Kafka Streams

lkokhreidze commented on pull request #10785: URL: https://github.com/apache/kafka/pull/10785#issuecomment-851076581 Call for review @vvcephei @cadonna @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] dengziming commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

dengziming commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-851110147 ping @mumrah @cmccabe , this PR is similar to KIP-497, I wish this can be finished before KAFKA 3.0.0. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-12465) Decide whether inconsistent cluster id error are fatal

[ https://issues.apache.org/jira/browse/KAFKA-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354175#comment-17354175 ] dengziming commented on KAFKA-12465: [~omnia_h_ibrahim] Thank you for the feedback,

[jira] [Commented] (KAFKA-9135) Kafka producer/consumer are creating too many open file

[ https://issues.apache.org/jira/browse/KAFKA-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17354180#comment-17354180 ] Duong Pham commented on KAFKA-9135: --- you can upgrade Java version, prefer 1.8.0.291 >

[GitHub] [kafka] showuon commented on a change in pull request #10794: [WIP]KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r642195443 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiError.java ## @@ -36,10 +37,16 @@ private final String message; public

[GitHub] [kafka] showuon commented on a change in pull request #10794: [WIP]KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r642195788 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -350,7 +372,8 @@ class BrokerToControllerRequestThread(

[GitHub] [kafka] showuon commented on a change in pull request #10794: [WIP]KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r642196090 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -239,18 +244,34 @@ class BrokerToControllerChannelManagerImpl

[GitHub] [kafka] showuon commented on pull request #10794: [WIP]KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-851153567 @hachikuji @mumrah @abbccdda @cmccabe , could you help review this PR? I'll add tests later. Thank you. -- This is an automated message from the Apache Git Service. To respond