[jira] [Created] (KAFKA-12865) Documentation error for Admin Client API in describe ACLs

2021-05-29 Thread Rohit Sachan (Jira)
Rohit Sachan created KAFKA-12865: Summary: Documentation error for Admin Client API in describe ACLs Key: KAFKA-12865 URL: https://issues.apache.org/jira/browse/KAFKA-12865 Project: Kafka Iss

[GitHub] [kafka] rohit-sachan opened a new pull request #10790: KAFKA-12865

2021-05-29 Thread GitBox
rohit-sachan opened a new pull request #10790: URL: https://github.com/apache/kafka/pull/10790 It's a small fix for documentation bug. I don't think any test case is required for that. closes KAFKA-12865 ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] chia7712 commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-29 Thread GitBox
chia7712 commented on a change in pull request #10585: URL: https://github.com/apache/kafka/pull/10585#discussion_r641907832 ## File path: build.gradle ## @@ -380,6 +380,15 @@ subprojects { } } + cleanTest { +subprojects.each { + delete "${it.buildDir}/test-

[GitHub] [kafka] chia7712 opened a new pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …

2021-05-29 Thread GitBox
chia7712 opened a new pull request #10791: URL: https://github.com/apache/kafka/pull/10791 The command `./gradlew raft:integrationTest` can't run any integration test since `org.junit.jupiter.api.Tag` does not work for jqwik engine (see https://github.com/jlink/jqwik/issues/36#issuecommen

[GitHub] [kafka] omkreddy merged pull request #10790: KAFKA-12865

2021-05-29 Thread GitBox
omkreddy merged pull request #10790: URL: https://github.com/apache/kafka/pull/10790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Resolved] (KAFKA-12865) Documentation error for Admin Client API in describe ACLs

2021-05-29 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12865. --- Fix Version/s: 3.0.0 Resolution: Fixed > Documentation error for Admin Client API in describe

[jira] [Assigned] (KAFKA-12865) Documentation error for Admin Client API in describe ACLs

2021-05-29 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar reassigned KAFKA-12865: - Assignee: Rohit Sachan > Documentation error for Admin Client API in describe ACLs > --

[GitHub] [kafka] ijuma commented on pull request #10791: MINOR: replace by org.junit.jupiter.api.Tag by net.jqwik.api.Tag for …

2021-05-29 Thread GitBox
ijuma commented on pull request #10791: URL: https://github.com/apache/kafka/pull/10791#issuecomment-850871754 Good catch. The build definition doesn't require changes to mention this annotation? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-29 Thread GitBox
ijuma commented on a change in pull request #10585: URL: https://github.com/apache/kafka/pull/10585#discussion_r641965516 ## File path: build.gradle ## @@ -449,6 +449,14 @@ subprojects { } } + // remove test output from Test, IntegrationTest and UnitTest Review comm

[jira] [Commented] (KAFKA-5560) LogManager should be able to create new logs based on free disk space

2021-05-29 Thread Georgy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353849#comment-17353849 ] Georgy commented on KAFKA-5560: --- [~huxi_2b] [~junrao] Will this task be in progress someday

[GitHub] [kafka] VJvaLbhYbfr opened a new pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr opened a new pull request #10792: URL: https://github.com/apache/kafka/pull/10792 Removed redundant method parameter. Replaced Collections.singleton with Utils.mkSet for consistency. ### Committer Checklist (excluded from commit message) - [ ] Verify design and i

[jira] [Commented] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353882#comment-17353882 ] Luke Chen commented on KAFKA-12677: --- [~cmccabe], I've found the root cause of this iss

[jira] [Commented] (KAFKA-12629) Failing Test: RaftClusterTest

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353903#comment-17353903 ] Luke Chen commented on KAFKA-12629: --- Good news! I found a root cause of the blocker bu

[jira] [Comment Edited] (KAFKA-12629) Failing Test: RaftClusterTest

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353903#comment-17353903 ] Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:23 PM:

[jira] [Comment Edited] (KAFKA-12629) Failing Test: RaftClusterTest

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353903#comment-17353903 ] Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:23 PM:

[jira] [Comment Edited] (KAFKA-12629) Failing Test: RaftClusterTest

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353903#comment-17353903 ] Luke Chen edited comment on KAFKA-12629 at 5/29/21, 11:24 PM:

[GitHub] [kafka] dengziming commented on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
dengziming commented on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850919041 In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow prepared for future test, but I think this PR is feasi

[jira] [Commented] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-05-29 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353909#comment-17353909 ] Ismael Juma commented on KAFKA-12677: - Go for it [~showuon] > The raftCluster alway

[GitHub] [kafka] dengziming opened a new pull request #10793: KAFKA-12338: Remove useless MetadataParser

2021-05-29 Thread GitBox
dengziming opened a new pull request #10793: URL: https://github.com/apache/kafka/pull/10793 *More detailed description of your change* `MetadataParser` is a duplication of `MetadataRecordSerde` and it's not used in any code, so we can remove it. *Summary of testing strategy (incl

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow prepared for future test, but I

[GitHub] [kafka] VJvaLbhYbfr commented on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr commented on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow prepared for future test, but I think t

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow prepared for future test, but I

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 Thank you for your review. > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 Thank you for your review. > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 Thank you for your review. > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow

[GitHub] [kafka] VJvaLbhYbfr edited a comment on pull request #10792: MINOR: Small refactor of tests

2021-05-29 Thread GitBox
VJvaLbhYbfr edited a comment on pull request #10792: URL: https://github.com/apache/kafka/pull/10792#issuecomment-850922135 Thank you for your review. > > > In fact, `Collections.singleton` is more efficient than other collection constructor and the `highWatermark` is somehow

[GitHub] [kafka] dengziming commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-05-29 Thread GitBox
dengziming commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r642003507 ## File path: raft/src/main/java/org/apache/kafka/raft/metadata/AbstractApiMessageSerde.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Softwa

[jira] [Assigned] (KAFKA-12677) The raftCluster always send to the wrong active controller and never update

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12677: - Assignee: Luke Chen (was: Colin McCabe) > The raftCluster always send to the wrong active cont

[GitHub] [kafka] socutes commented on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-29 Thread GitBox
socutes commented on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-850931986 > > Left 2 comments. Thanks. > > fixed! @showuon Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] socutes closed pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-29 Thread GitBox
socutes closed pull request #10749: URL: https://github.com/apache/kafka/pull/10749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] socutes removed a comment on pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-29 Thread GitBox
socutes removed a comment on pull request #10749: URL: https://github.com/apache/kafka/pull/10749#issuecomment-850052203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-29 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r642010687 ## File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java ## @@ -945,11 +946,10 @@ public void testObserverUnattachedToFollower() throws

[jira] [Commented] (KAFKA-10900) Add metrics enumerated in KIP-630

2021-05-29 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353920#comment-17353920 ] loboxu commented on KAFKA-10900: [~showuon] I have received the Jire. May I ask whether

[jira] [Commented] (KAFKA-10900) Add metrics enumerated in KIP-630

2021-05-29 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353931#comment-17353931 ] Luke Chen commented on KAFKA-10900: --- You can start your work anytime. When completed,