[GitHub] [kafka] showuon commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638511262 ## File path: raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java ## @@ -67,7 +68,7 @@ public FileBasedStateStore(final File stateFile) {

[GitHub] [kafka] showuon commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638513347 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -372,27 +371,23 @@ private void maybeFireLeaderChange() { @Overri

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-25 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638519831 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -210,11 +209,23 @@ class LogSegments(topicPartition: TopicPartition) { * @return t

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-25 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638520142 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1217,10 +1213,8 @@ class Log(@volatile private var _dir: File, fetchDataInfo = seg

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

2021-05-25 Thread GitBox
kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638520142 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1217,10 +1213,8 @@ class Log(@volatile private var _dir: File, fetchDataInfo = seg

[jira] [Commented] (KAFKA-12824) Remove Deprecated method KStream#branch

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350859#comment-17350859 ] Josep Prat commented on KAFKA-12824: I know that some of the ones I created might no

[jira] [Commented] (KAFKA-12822) Remove Deprecated APIs of Kafka Streams in 4.0

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350862#comment-17350862 ] Josep Prat commented on KAFKA-12822: As [~mjsax] pointed out, some of this sub-tasks

[GitHub] [kafka] kowshik opened a new pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

2021-05-25 Thread GitBox
kowshik opened a new pull request #10756: URL: https://github.com/apache/kafka/pull/10756 Have done a small improvement in this PR by flipping logical NOT for readability. Basically, the following code: ``` if (A) { if (B) { } else { } } else if (B) { } ```

[GitHub] [kafka] kowshik commented on pull request #10756: MINOR: Log constructor: Flip logical NOT for readability

2021-05-25 Thread GitBox
kowshik commented on pull request #10756: URL: https://github.com/apache/kafka/pull/10756#issuecomment-847620694 cc @junrao @ijuma @chia7712 for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638535599 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -116,7 +117,7 @@ public void initialize(OffsetAndEpoch logEndOffsetAndEpoch)

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638536001 ## File path: raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java ## @@ -91,14 +92,17 @@ private QuorumStateData readStateFromFile(File file

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638537574 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -372,27 +371,23 @@ private void maybeFireLeaderChange() { @Overri

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638535599 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -116,7 +117,7 @@ public void initialize(OffsetAndEpoch logEndOffsetAndEpoch)

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638542037 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -116,7 +117,7 @@ public void initialize(OffsetAndEpoch logEndOffsetAndEpoch)

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638542877 ## File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java ## @@ -945,9 +945,7 @@ public void testObserverUnattachedToFollower() throws

[GitHub] [kafka] showuon commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638544356 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -372,27 +371,23 @@ private void maybeFireLeaderChange() { @Overri

[GitHub] [kafka] DuongPTIT commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
DuongPTIT commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847644863 hi @showuon, can you please review this for me? Many thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] socutes commented on a change in pull request #10749: KAFKA-12773: Use UncheckedIOException when wrapping IOException

2021-05-25 Thread GitBox
socutes commented on a change in pull request #10749: URL: https://github.com/apache/kafka/pull/10749#discussion_r638556812 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -372,27 +371,23 @@ private void maybeFireLeaderChange() { @Overri

[GitHub] [kafka] showuon commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
showuon commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847654763 @DuongPTIT , thanks for the PR. One important question to you before reviewing the code: could you confirm this issue only happen in V2.5, and not V2.8? I'm not sure if we will

[jira] [Created] (KAFKA-12846) why need this logic in Consumer‘s Fetch logic it should remove?

2021-05-25 Thread yws (Jira)
yws created KAFKA-12846: --- Summary: why need this logic in Consumer‘s Fetch logic it should remove? Key: KAFKA-12846 URL: https://issues.apache.org/jira/browse/KAFKA-12846 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-12846) why need this logic in Consumer‘s Fetch logic it should remove?

2021-05-25 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350904#comment-17350904 ] Luke Chen commented on KAFKA-12846: --- [~ws], I believe the comments in else block answe

[GitHub] [kafka] kowshik closed pull request #9764: MINOR: Eliminate KafkaScheduler#scheduleOnce in favor of KafkaScheduler#schedule

2021-05-25 Thread GitBox
kowshik closed pull request #9764: URL: https://github.com/apache/kafka/pull/9764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Assigned] (KAFKA-10900) Add metrics enumerated in KIP-630

2021-05-25 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-10900: -- Assignee: loboxu > Add metrics enumerated in KIP-630 > - > >

[jira] [Assigned] (KAFKA-12461) Extend LogManager to cover the metadata topic

2021-05-25 Thread loboxu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-12461: -- Assignee: (was: loboxu) > Extend LogManager to cover the metadata topic > ---

[GitHub] [kafka] DuongPTIT commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
DuongPTIT commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847728426 > Please confirm if the issue only happen in V2.5 or newer release. If also happen in trunk, please make the merge target as `trunk` (and fix based on the `trunk` branch), and

[GitHub] [kafka] DuongPTIT removed a comment on pull request #10670: KAFKA-10273 Connect Converters should produce actionable error messages

2021-05-25 Thread GitBox
DuongPTIT removed a comment on pull request #10670: URL: https://github.com/apache/kafka/pull/10670#issuecomment-840464740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [kafka] DuongPTIT commented on pull request #10670: KAFKA-10273 Connect Converters should produce actionable error messages

2021-05-25 Thread GitBox
DuongPTIT commented on pull request #10670: URL: https://github.com/apache/kafka/pull/10670#issuecomment-847730974 hi @showuon, please take a review. Thank you so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-12824) Remove Deprecated method KStream#branch

2021-05-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350941#comment-17350941 ] Bruno Cadonna commented on KAFKA-12824: --- [~mjsax] Do we know for which date AK 4.0

[jira] [Commented] (KAFKA-12824) Remove Deprecated method KStream#branch

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350942#comment-17350942 ] Josep Prat commented on KAFKA-12824: On the parent issue there is this sentence: >

[GitHub] [kafka] DuongPTIT edited a comment on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
DuongPTIT edited a comment on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847728426 > Please confirm if the issue only happen in V2.5 or newer release. If also happen in trunk, please make the merge target as `trunk` (and fix based on the `trunk` branc

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r638651011 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -444,23 +392,32 @@ private boolean allS

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r638654728 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -469,73 +426,190 @@ private boolean all

[GitHub] [kafka] tombentley commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
tombentley commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847746044 Probably fixed by https://github.com/apache/kafka/pull/9735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r638655936 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -637,19 +709,27 @@ private void assignP

[GitHub] [kafka] dengziming commented on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-05-25 Thread GitBox
dengziming commented on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-847753120 @mjsax @guozhangwang , how do you think about this approach? In fact, I'm not very confident about this change since it isn't very elegant, but this can remove the TODO, feel

[GitHub] [kafka] DuongPTIT commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
DuongPTIT commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847756554 > Probably fixed by #9735 I've seen that this issue still happen in V2.5, V2.6, V2.7. What about these versions? Do they need to fix this similar to V2.8 and trunk?

[jira] [Commented] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

2021-05-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350960#comment-17350960 ] Bruno Cadonna commented on KAFKA-5676: -- [~marcolotz] Thank you for looking into this

[jira] [Comment Edited] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test

2021-05-25 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350960#comment-17350960 ] Bruno Cadonna edited comment on KAFKA-5676 at 5/25/21, 10:42 AM: --

[GitHub] [kafka] rajinisivaram commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

2021-05-25 Thread GitBox
rajinisivaram commented on pull request #10377: URL: https://github.com/apache/kafka/pull/10377#issuecomment-847762942 @feyman2016 We should add `ignorable=true` for the fields added for feature support in `clients/src/main/resources/common/message/ApiVersionsResponse.json`. This would av

[jira] [Created] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
Abhijit Mane created KAFKA-12847: Summary: Dockerfile needed for kafka system tests needs changes Key: KAFKA-12847 URL: https://issues.apache.org/jira/browse/KAFKA-12847 Project: Kafka Issue

[GitHub] [kafka] tombentley commented on pull request #10750: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2021-05-25 Thread GitBox
tombentley commented on pull request #10750: URL: https://github.com/apache/kafka/pull/10750#issuecomment-847768625 It's unlikely that 2.5 or 2.6 will see another release, but I've backported it to the 2.7 branch so it's in any 2.7.2 which gets released. -- This is an automated message f

[jira] [Updated] (KAFKA-10846) FileStreamSourceTask buffer can grow without bound

2021-05-25 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-10846: Fix Version/s: 2.7.2 > FileStreamSourceTask buffer can grow without bound > --

[jira] [Updated] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane updated KAFKA-12847: - Description: Hello, I tried apache/kafka system tests as per documentation: - ([https://github

[jira] [Updated] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane updated KAFKA-12847: - Description: Hello, I tried apache/kafka system tests as per documentation: - (_[https://githu

[jira] [Updated] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane updated KAFKA-12847: - Description: Hello, I tried apache/kafka system tests as per documentation: - ([https://github

[jira] [Updated] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane updated KAFKA-12847: - Description: Hello, I tried apache/kafka system tests as per documentation: - ([https://github

[jira] [Updated] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-05-25 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane updated KAFKA-12847: - Description: Hello, I tried apache/kafka system tests as per documentation: - ([https://github

[jira] [Assigned] (KAFKA-12782) Javadocs search sends you to a non-existent URL

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12782: -- Assignee: Josep Prat > Javadocs search sends you to a non-existent URL >

[jira] [Commented] (KAFKA-12743) [Kafka Streams] - cluster failover for stateful Kafka Streams applications

2021-05-25 Thread Sergey Zyrianov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351000#comment-17351000 ] Sergey Zyrianov commented on KAFKA-12743: - I don't think uReplicator alternative

[jira] [Commented] (KAFKA-12782) Javadocs search sends you to a non-existent URL

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351001#comment-17351001 ] Josep Prat commented on KAFKA-12782: I can confirm this is bug with Java11 for API d

[GitHub] [kafka] dajac opened a new pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-25 Thread GitBox
dajac opened a new pull request #10757: URL: https://github.com/apache/kafka/pull/10757 This patch logs more information when a producer snapshot is written to the disk. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-25 Thread GitBox
showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r638718719 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -637,19 +709,27 @@ private void assignP

[GitHub] [kafka] showuon commented on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-25 Thread GitBox
showuon commented on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-847807953 @vahidhashemian , thanks for the comments. I've updated. Please take a look again. Thank you. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] jlprat opened a new pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-25 Thread GitBox
jlprat opened a new pull request #10758: URL: https://github.com/apache/kafka/pull/10758 This is just a workaround to solve this problem while we are still using JDK11. Once moving to, presumably, JDK17 this change won't be needed anymore and could be deleted safely. See https://bu

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-25 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-847839591 cc @ableegoldman as you opened the Jira ticket, maybe you'd like to review this one? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] dajac commented on a change in pull request #10616: KAFKA-12709; Add Admin API for `ListTransactions`

2021-05-25 Thread GitBox
dajac commented on a change in pull request #10616: URL: https://github.com/apache/kafka/pull/10616#discussion_r638764893 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AllBrokersStrategy.java ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] dajac merged pull request #10717: KAFKA-12800: Configure generator to fail on trailing JSON tokens

2021-05-25 Thread GitBox
dajac merged pull request #10717: URL: https://github.com/apache/kafka/pull/10717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Assigned] (KAFKA-12800) Configure jackson to to reject trailing input in the generator

2021-05-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-12800: --- Assignee: (was: David Jacot) > Configure jackson to to reject trailing input in the gen

[jira] [Assigned] (KAFKA-12800) Configure jackson to to reject trailing input in the generator

2021-05-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-12800: --- Assignee: David Jacot > Configure jackson to to reject trailing input in the generator > --

[jira] [Resolved] (KAFKA-12800) Configure jackson to to reject trailing input in the generator

2021-05-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12800. - Fix Version/s: 3.0.0 Resolution: Fixed Author: Nathan Lincoln > Configure jackson to to

[GitHub] [kafka] ijuma opened a new pull request #10759: MINOR: Adjust parameter ordering of `waitForCondition` and `retryOnExceptionWithTimeout`

2021-05-25 Thread GitBox
ijuma opened a new pull request #10759: URL: https://github.com/apache/kafka/pull/10759 New parameters in overloaded methods should appear later apart from lambdas that should always be last. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implemen

[GitHub] [kafka] thomaskwscott opened a new pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-05-25 Thread GitBox
thomaskwscott opened a new pull request #10760: URL: https://github.com/apache/kafka/pull/10760 See https://cwiki.apache.org/confluence/display/KAFKA/KIP-734%3A+Improve+AdminClient.listOffsets+to+return+timestamp+and+offset+for+the+record+with+the+largest+timestamp *More detailed des

[GitHub] [kafka] ijuma opened a new pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-25 Thread GitBox
ijuma opened a new pull request #10761: URL: https://github.com/apache/kafka/pull/10761 Log if deletion fails and don't expose log topic id for mutability outside of `assignTopicId()`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] ijuma commented on pull request #10761: MINOR: Don't ignore deletion of partition metadata file and log topic id clean-ups

2021-05-25 Thread GitBox
ijuma commented on pull request #10761: URL: https://github.com/apache/kafka/pull/10761#issuecomment-847881296 cc @jolshan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dajac commented on pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-05-25 Thread GitBox
dajac commented on pull request #10760: URL: https://github.com/apache/kafka/pull/10760#issuecomment-847883470 I will review it in the next few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ijuma commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-25 Thread GitBox
ijuma commented on a change in pull request #10757: URL: https://github.com/apache/kafka/pull/10757#discussion_r638803061 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2011,7 +2011,11 @@ object Log extends Logging { logDirFailureChannel, config.mess

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

2021-05-25 Thread GitBox
dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-847885818 Rebased onto the latest trunk. cc/ @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2021-05-25 Thread GitBox
dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-847886290 Hi @guozhangwang @vvcephei, Could you have a look now? :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-25 Thread GitBox
dajac commented on a change in pull request #10757: URL: https://github.com/apache/kafka/pull/10757#discussion_r638806738 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2011,7 +2011,11 @@ object Log extends Logging { logDirFailureChannel, config.mess

[GitHub] [kafka] mdedetrich opened a new pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…

2021-05-25 Thread GitBox
mdedetrich opened a new pull request #10762: URL: https://github.com/apache/kafka/pull/10762 This PR does various QoL improvements for the MM tests, mainly some basic refactoring to remove some boilerplate as well as adding messages to all of the assert statements so that if they fail ther

[GitHub] [kafka] ryannedolan commented on pull request #10762: KAFKA-12819: Add assert messages to MirrorMaker tests plus other qual…

2021-05-25 Thread GitBox
ryannedolan commented on pull request #10762: URL: https://github.com/apache/kafka/pull/10762#issuecomment-847906780 thx lgtm! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-05-25 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351093#comment-17351093 ] Matthew de Detrich commented on KAFKA-12430: [~ryannedolan] I am going to lo

[jira] [Assigned] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-05-25 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-12430: -- Assignee: Matthew de Detrich > emit.heartbeats.enabled = false should disable

[GitHub] [kafka] ijuma commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-25 Thread GitBox
ijuma commented on a change in pull request #10757: URL: https://github.com/apache/kafka/pull/10757#discussion_r638837477 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2011,7 +2011,11 @@ object Log extends Logging { logDirFailureChannel, config.mess

[jira] [Commented] (KAFKA-12430) emit.heartbeats.enabled = false should disable heartbeats topic creation

2021-05-25 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351104#comment-17351104 ] Ryanne Dolan commented on KAFKA-12430: -- Hmm. I guess the downside to not creating t

[GitHub] [kafka] dajac commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

2021-05-25 Thread GitBox
dajac commented on a change in pull request #10757: URL: https://github.com/apache/kafka/pull/10757#discussion_r638898378 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2011,7 +2011,11 @@ object Log extends Logging { logDirFailureChannel, config.mess

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351155#comment-17351155 ] Josep Prat commented on KAFKA-9009: --- Seen in [https://ci-builds.apache.org/job/Kafka/j

[jira] [Commented] (KAFKA-12511) Flaky test DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351159#comment-17351159 ] Josep Prat commented on KAFKA-12511: Seen in: [https://ci-builds.apache.org/job/Kaf

[jira] [Commented] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351161#comment-17351161 ] Josep Prat commented on KAFKA-12319: Failed again in [https://ci-builds.apache.org/

[jira] [Comment Edited] (KAFKA-12511) Flaky test DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351159#comment-17351159 ] Josep Prat edited comment on KAFKA-12511 at 5/25/21, 4:00 PM:

[jira] [Commented] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-25 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351166#comment-17351166 ] Josep Prat commented on KAFKA-9295: --- Seen it in [https://ci-builds.apache.org/job/Kafk

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-25 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-847997038 Test failures were known flaky tests. Added a comment on the corresponding Jira's -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-25 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351227#comment-17351227 ] Pedro Gontijo commented on KAFKA-12845: --- [~mjsax] and [~JoelWee] it would be great

[jira] [Comment Edited] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-25 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351227#comment-17351227 ] Pedro Gontijo edited comment on KAFKA-12845 at 5/25/21, 5:26 PM: -

[jira] [Comment Edited] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-25 Thread Pedro Gontijo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351227#comment-17351227 ] Pedro Gontijo edited comment on KAFKA-12845 at 5/25/21, 5:26 PM: -

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-25 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351230#comment-17351230 ] Sagar Rao commented on KAFKA-9168: -- [~ableegoldman], so I went through the github PR lin

[jira] [Commented] (KAFKA-8295) Optimize count() using RocksDB merge operator

2021-05-25 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351232#comment-17351232 ] Sagar Rao commented on KAFKA-8295: -- hey [~ableegoldman], wanted to know if you got a cha

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351238#comment-17351238 ] A. Sophie Blee-Goldman commented on KAFKA-9168: --- Yep, I think that's exactl

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-25 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351243#comment-17351243 ] Sagar Rao commented on KAFKA-9168: -- Got it.. How do you want me to benchmark? Using the

[GitHub] [kafka] ableegoldman commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-25 Thread GitBox
ableegoldman commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-848103904 To be honest I don't have much context on the javadocs but I will take a look. Maybe @ijuma can help review -- This is an automated message from the Apache Git Service. T

[jira] [Reopened] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-9295: --- Guess there is still something else going on here yet. At this point I think we

[GitHub] [kafka] jlprat commented on pull request #10758: KAFKA-12782: Javadocs search sends you to a non-existent URL

2021-05-25 Thread GitBox
jlprat commented on pull request #10758: URL: https://github.com/apache/kafka/pull/10758#issuecomment-848155893 Sure @ableegoldman , no worries. I just mentioned you as you were the one who created the ticket. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-12845) Rollback change which requires join key to be non null on KStream->GlobalKTable

2021-05-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351308#comment-17351308 ] Matthias J. Sax commented on KAFKA-12845: - I think you confuse "input record key

[GitHub] [kafka] ccding opened a new pull request #10763: [WIP] KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-05-25 Thread GitBox
ccding opened a new pull request #10763: URL: https://github.com/apache/kafka/pull/10763 When we find a .swap file on startup, we typically want to rename and replace it as .log, .index, .timeindex, etc. as a way to complete any ongoing replace operations. These swap files are usually know

[jira] [Created] (KAFKA-12848) Add some basic benchmarks for Kafka Streams

2021-05-25 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12848: -- Summary: Add some basic benchmarks for Kafka Streams Key: KAFKA-12848 URL: https://issues.apache.org/jira/browse/KAFKA-12848 Project: Kafka

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

2021-05-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351377#comment-17351377 ] A. Sophie Blee-Goldman commented on KAFKA-9168: --- There's nothing available

[GitHub] [kafka] junrao commented on a change in pull request #10280: KAFKA-12554: Refactor Log layer

2021-05-25 Thread GitBox
junrao commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r638367249 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1500,50 +1325,67 @@ class Log(@volatile private var _dir: File, } } -deleteO

[GitHub] [kafka] DuongPTIT removed a comment on pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-25 Thread GitBox
DuongPTIT removed a comment on pull request #10677: URL: https://github.com/apache/kafka/pull/10677#issuecomment-845827053 @chia7712 PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] DuongPTIT commented on pull request #10677: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-25 Thread GitBox
DuongPTIT commented on pull request #10677: URL: https://github.com/apache/kafka/pull/10677#issuecomment-848382648 hi @showuon, can you please review this issue for me? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] mjsax commented on a change in pull request #10755: MINOR: deprecate TaskMetadata constructor and add KIP-740 notes to upgrade guide

2021-05-25 Thread GitBox
mjsax commented on a change in pull request #10755: URL: https://github.com/apache/kafka/pull/10755#discussion_r639338584 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java ## @@ -40,6 +40,18 @@ private final Optional timeCurrentIdl

  1   2   >