[GitHub] [kafka] cadonna commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

2021-05-18 Thread GitBox

[jira] [Updated] (KAFKA-12796) Removal of deprecated classes under `streams-scala`

2021-05-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12796: Labels: scala (was: ) > Removal of deprecated classes under `streams-scala` > ---

[GitHub] [kafka] hudeqi opened a new pull request #10716: optimize offset reset strategy and fix lose data when add partition

2021-05-18 Thread GitBox
hudeqi opened a new pull request #10716: URL: https://github.com/apache/kafka/pull/10716 1. besides `latest` and `earliest`, we also add `nearest`: reset to either latest or earliest depending on the current offset (i.e. this policy won't trigger under the scenario when we see a partition

[GitHub] [kafka] showuon commented on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

2021-05-18 Thread GitBox
showuon commented on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-842947967 Broken tests are fixed and new tests are added for multiple generation tests for unequal subscription cases. Thanks. -- This is an automated message from the Apache Git Servic

[jira] [Created] (KAFKA-12805) Aborted send could have a different exception than DisconnectException

2021-05-18 Thread Nicolas Guyomar (Jira)
Nicolas Guyomar created KAFKA-12805: --- Summary: Aborted send could have a different exception than DisconnectException Key: KAFKA-12805 URL: https://issues.apache.org/jira/browse/KAFKA-12805 Project:

[jira] [Resolved] (KAFKA-12751) ISRs remain in in-flight state if proposed state is same as actual state

2021-05-18 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-12751. Reviewer: David Arthur Resolution: Fixed > ISRs remain in in-flight state if propose

[jira] [Updated] (KAFKA-12805) Aborted send could have a different exception than DisconnectException

2021-05-18 Thread Nicolas Guyomar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Guyomar updated KAFKA-12805: Description: Right now we are treating timeout in the network client as a disconnection e

[GitHub] [kafka] jlprat commented on pull request #10711: MINOR: Update Scala to 2.13.6

2021-05-18 Thread GitBox
jlprat commented on pull request #10711: URL: https://github.com/apache/kafka/pull/10711#issuecomment-842993232 cc @ijuma Could you please review this PR, as you were one the last ones to do a similar change? Thanks in advance -- This is an automated message from the Apache Git Servic

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-18 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346805#comment-17346805 ] NEERAJ VAIDYA commented on KAFKA-12776: --- [~guozhang] I am keen to get such a featu

[jira] [Commented] (KAFKA-12801) High CPU load after restarting brokers subsequent to quorum loss

2021-05-18 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346835#comment-17346835 ] Gunnar Morling commented on KAFKA-12801: Would a JFR profiling work, too? I coul

[jira] [Created] (KAFKA-12806) KRaft: Confusing leadership status exposed for controller without quorum

2021-05-18 Thread Gunnar Morling (Jira)
Gunnar Morling created KAFKA-12806: -- Summary: KRaft: Confusing leadership status exposed for controller without quorum Key: KAFKA-12806 URL: https://issues.apache.org/jira/browse/KAFKA-12806 Project:

[jira] [Updated] (KAFKA-12806) KRaft: Confusing leadership status exposed for controller without quorum

2021-05-18 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gunnar Morling updated KAFKA-12806: --- Description: I'm testing Kafka in the new KRaft mode added in 2.8. I have a cluster of three

[jira] [Updated] (KAFKA-12806) KRaft: Confusing leadership status exposed in metrics for controller without quorum

2021-05-18 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gunnar Morling updated KAFKA-12806: --- Summary: KRaft: Confusing leadership status exposed in metrics for controller without quorum

[GitHub] [kafka] NLincoln opened a new pull request #10717: KAFKA-12800: Configure generator to fail on trailing JSON tokens

2021-05-18 Thread GitBox
NLincoln opened a new pull request #10717: URL: https://github.com/apache/kafka/pull/10717 See #10709 for an example of this happening. The tl;dr is that Jackson will ignore trailing tokens by default, but other Json parsers cannot be configured to ignore them. This makes sure we don

[jira] [Created] (KAFKA-12807) allow mTLS authorization based on different fields of X509 certificate

2021-05-18 Thread Naresh (Jira)
Naresh created KAFKA-12807: -- Summary: allow mTLS authorization based on different fields of X509 certificate Key: KAFKA-12807 URL: https://issues.apache.org/jira/browse/KAFKA-12807 Project: Kafka I

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-05-18 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-843148293 @hachikuji I fixed the tests and made you suggested changes, but what do you think about @guozhangwang's point [above](https://github.com/apache/kafka/pull/9441#discussion_r624

[jira] [Created] (KAFKA-12808) Remove Deprecated methods under StreamsMetricsImpl

2021-05-18 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12808: -- Summary: Remove Deprecated methods under StreamsMetricsImpl Key: KAFKA-12808 URL: https://issues.apache.org/jira/browse/KAFKA-12808 Project: Kafka Issue Type: Ta

[jira] [Assigned] (KAFKA-12808) Remove Deprecated methods under StreamsMetricsImpl

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12808: -- Assignee: Josep Prat > Remove Deprecated methods under StreamsMetricsImpl > -

[jira] [Commented] (KAFKA-12808) Remove Deprecated methods under StreamsMetricsImpl

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346891#comment-17346891 ] Josep Prat commented on KAFKA-12808: I'll take this one > Remove Deprecated methods

[jira] [Created] (KAFKA-12809) Remove De

2021-05-18 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12809: -- Summary: Remove De Key: KAFKA-12809 URL: https://issues.apache.org/jira/browse/KAFKA-12809 Project: Kafka Issue Type: Task Reporter: Josep Prat

[jira] [Updated] (KAFKA-12809) Remove Deprecated methods under Stores

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12809: --- Component/s: streams Fix Version/s: 3.0.0 Description: There are 2 methods in org.apache

[jira] [Updated] (KAFKA-12808) Remove Deprecated methods under StreamsMetrics

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12808: --- Summary: Remove Deprecated methods under StreamsMetrics (was: Remove Deprecated methods under Strea

[jira] [Updated] (KAFKA-12808) Remove Deprecated methods under StreamsMetrics

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12808: --- Description: There are 4 methods in StreamMetrics and StreamsMetricsImpl that are deprecated since

[jira] [Created] (KAFKA-12810) Remove deprecated TopologyDescription.Source#topics

2021-05-18 Thread Josep Prat (Jira)
Josep Prat created KAFKA-12810: -- Summary: Remove deprecated TopologyDescription.Source#topics Key: KAFKA-12810 URL: https://issues.apache.org/jira/browse/KAFKA-12810 Project: Kafka Issue Type: S

[jira] [Updated] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12419: --- Description: Here's a list of deprecated APIs that we have accumulated in the past, we can consider

[jira] [Commented] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

2021-05-18 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346902#comment-17346902 ] Josep Prat commented on KAFKA-12419: I created https://issues.apache.org/jira/browse

[GitHub] [kafka] showuon commented on pull request #10457: KAFKA-12596: remove --zookeeper option from topic command

2021-05-18 Thread GitBox
showuon commented on pull request #10457: URL: https://github.com/apache/kafka/pull/10457#issuecomment-843191316 failed tests are unrelated and flaky. Thanks. ``` Build / JDK 15 and Scala 2.13 / org.apache.kafka.connect.integration.BlockingConnectorTest.testBlockInSinkTaskStart

[GitHub] [kafka] mumrah merged pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

2021-05-18 Thread GitBox
mumrah merged pull request #10561: URL: https://github.com/apache/kafka/pull/10561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12801) High CPU load after restarting brokers subsequent to quorum loss

2021-05-18 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346920#comment-17346920 ] Lucas Bradstreet commented on KAFKA-12801: -- JFR is perfectly fine too. > High

[GitHub] [kafka] cadonna commented on a change in pull request #10651: MINOR: Kafka Streams code samples formating unification

2021-05-18 Thread GitBox
cadonna commented on a change in pull request #10651: URL: https://github.com/apache/kafka/pull/10651#discussion_r634203662 ## File path: docs/streams/developer-guide/app-reset-tool.html ## @@ -78,18 +78,17 @@ Step 1: Run the application reset tool Inv

[GitHub] [kafka] jlprat commented on pull request #10651: MINOR: Kafka Streams code samples formating unification

2021-05-18 Thread GitBox
jlprat commented on pull request #10651: URL: https://github.com/apache/kafka/pull/10651#issuecomment-843207783 Thanks @cadonna, all good points. I'll address the feedback later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-12811) kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not warn about missing the --partition flag

2021-05-18 Thread Richard Joerger (Jira)
Richard Joerger created KAFKA-12811: --- Summary: kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not warn about missing the --partition flag Key: KAFKA-128

[GitHub] [kafka] rondagostino commented on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-05-18 Thread GitBox
rondagostino commented on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-843228313 @cmccabe I merged in trunk and pushed a separate commit to fix the failing unit tests. The way we test to ensure an API is always forwarded for KRaft is to send the reques

[jira] [Commented] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

2021-05-18 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346969#comment-17346969 ] Matthew de Detrich commented on KAFKA-9726: --- Would it be possible to assign the

[GitHub] [kafka] Moovlin opened a new pull request #10718: [KAFKA-12811] kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not

2021-05-18 Thread GitBox
Moovlin opened a new pull request #10718: URL: https://github.com/apache/kafka/pull/10718 Added 1 new line to check that that "replication factor" & "alter" are not being used together. Uses the existing CommandLineUtils to do the check. Committer Checklist (excluded from commit mess

[jira] [Commented] (KAFKA-12811) kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not warn about missing the --partition flag

2021-05-18 Thread Richard Joerger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346980#comment-17346980 ] Richard Joerger commented on KAFKA-12811: - Hi team, I've gone ahead and submitte

[GitHub] [kafka] jlprat commented on a change in pull request #10651: MINOR: Kafka Streams code samples formating unification

2021-05-18 Thread GitBox
jlprat commented on a change in pull request #10651: URL: https://github.com/apache/kafka/pull/10651#discussion_r634513734 ## File path: docs/streams/developer-guide/app-reset-tool.html ## @@ -78,18 +78,17 @@ Step 1: Run the application reset tool Invo

[GitHub] [kafka] satishd commented on pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-05-18 Thread GitBox
satishd commented on pull request #10579: URL: https://github.com/apache/kafka/pull/10579#issuecomment-843289802 @junrao @kowshik This PR is ready for review. Pl let me know your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

2021-05-18 Thread Matthew de Detrich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-9726: - Assignee: Matthew de Detrich (was: Ivan Yurchenko) > LegacyReplicationPolicy fo

[jira] [Created] (KAFKA-12812) Consider refactoring state store registration path

2021-05-18 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12812: - Summary: Consider refactoring state store registration path Key: KAFKA-12812 URL: https://issues.apache.org/jira/browse/KAFKA-12812 Project: Kafka Issue Ty

[GitHub] [kafka] soarez commented on pull request #10650: KAFKA-12763 NoSuchElementException during checkpointLogStartOffsets

2021-05-18 Thread GitBox
soarez commented on pull request #10650: URL: https://github.com/apache/kafka/pull/10650#issuecomment-843352974 @ijuma can you have a look at this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-12812) Consider refactoring state store registration path

2021-05-18 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347051#comment-17347051 ] Guozhang Wang commented on KAFKA-12812: --- The reason I feel this is better is that,

[GitHub] [kafka] mumrah commented on a change in pull request #10504: KAFKA-12620 Allocate producer ids on the controller

2021-05-18 Thread GitBox
mumrah commented on a change in pull request #10504: URL: https://github.com/apache/kafka/pull/10504#discussion_r634580042 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -2376,6 +2375,82 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] soarez closed pull request #10195: MINOR: Remove use of deprecated Gradle syntax

2021-05-18 Thread GitBox
soarez closed pull request #10195: URL: https://github.com/apache/kafka/pull/10195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] soarez commented on pull request #10195: MINOR: Remove use of deprecated Gradle syntax

2021-05-18 Thread GitBox
soarez commented on pull request #10195: URL: https://github.com/apache/kafka/pull/10195#issuecomment-843357496 This was fixed by #10203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] ijuma commented on pull request #10650: KAFKA-12763 NoSuchElementException during checkpointLogStartOffsets

2021-05-18 Thread GitBox
ijuma commented on pull request #10650: URL: https://github.com/apache/kafka/pull/10650#issuecomment-843373430 @soarez the concern is that it may hide a problem. So, it's important to understand the sequence of events. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] soarez commented on pull request #10650: KAFKA-12763 NoSuchElementException during checkpointLogStartOffsets

2021-05-18 Thread GitBox
soarez commented on pull request #10650: URL: https://github.com/apache/kafka/pull/10650#issuecomment-843367411 Hi @dhruvilshah3 This happened when a broker that was offline for a long time came back up. I agree this shouldn't happen in the first place. I have logs, but it isn't clea

[GitHub] [kafka] guozhangwang commented on a change in pull request #10609: KAFKA-12648: Pt. 1 - Add NamedTopology to protocol and state directory structure

2021-05-18 Thread GitBox
guozhangwang commented on a change in pull request #10609: URL: https://github.com/apache/kafka/pull/10609#discussion_r634626047 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -411,19 +442,37 @@ private void cleanRemo

[GitHub] [kafka] mumrah merged pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

2021-05-18 Thread GitBox
mumrah merged pull request #10431: URL: https://github.com/apache/kafka/pull/10431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ableegoldman commented on pull request #10713: HOTFIX: undo renaming of public part of Subtopology API

2021-05-18 Thread GitBox
ableegoldman commented on pull request #10713: URL: https://github.com/apache/kafka/pull/10713#issuecomment-843513828 Some flaky test failures, Java11 build passed and this is a trivial renaming anyways. Merging -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] ableegoldman merged pull request #10713: HOTFIX: undo renaming of public part of Subtopology API

2021-05-18 Thread GitBox
ableegoldman merged pull request #10713: URL: https://github.com/apache/kafka/pull/10713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] mimaison commented on pull request #10660: MINOR: Updating files with release 2.7.1

2021-05-18 Thread GitBox
mimaison commented on pull request #10660: URL: https://github.com/apache/kafka/pull/10660#issuecomment-843514462 @mjsax / @chia7712 Can you take another look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] ableegoldman commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
ableegoldman commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843543131 @showuon I don't think we need to increase the heartbeat interval, let's just bump up the session timeout for now. We still want to be relatively quick in our broker reques

[jira] [Commented] (KAFKA-12812) Consider refactoring state store registration path

2021-05-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347153#comment-17347153 ] A. Sophie Blee-Goldman commented on KAFKA-12812: 100% agree. Imo the old

[GitHub] [kafka] ableegoldman commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

2021-05-18 Thread GitBox
ableegoldman commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r634736745 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -174,13 +176,15 @@ public void re

[GitHub] [kafka] mumrah opened a new pull request #10719: Fix compile errors for KAFKA-12543

2021-05-18 Thread GitBox
mumrah opened a new pull request #10719: URL: https://github.com/apache/kafka/pull/10719 Fixes for two compiler errors which were introduced in https://github.com/apache/kafka/pull/10431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] junrao commented on a change in pull request #10719: Fix compile errors for KAFKA-12543

2021-05-18 Thread GitBox
junrao commented on a change in pull request #10719: URL: https://github.com/apache/kafka/pull/10719#discussion_r634743071 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java ## @@ -63,7 +63,7 @@ public void close() { String.f

[GitHub] [kafka] jsancio commented on pull request #10719: Fix compile errors for KAFKA-12543

2021-05-18 Thread GitBox
jsancio commented on pull request #10719: URL: https://github.com/apache/kafka/pull/10719#issuecomment-843561287 LGTM. Compiles locally and `KafkaMetadataLogTest` passes locally. Thanks @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] jsancio commented on a change in pull request #10719: Fix compile errors for KAFKA-12543

2021-05-18 Thread GitBox
jsancio commented on a change in pull request #10719: URL: https://github.com/apache/kafka/pull/10719#discussion_r634746833 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java ## @@ -63,7 +63,7 @@ public void close() { String.

[GitHub] [kafka] mumrah merged pull request #10719: Fix compile errors for KAFKA-12543

2021-05-18 Thread GitBox
mumrah merged pull request #10719: URL: https://github.com/apache/kafka/pull/10719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2021-05-18 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming resolved KAFKA-10195. Resolution: Won't Fix > Move offset management codes from ConsumerCoordinator to a new class > ---

[GitHub] [kafka] ryannedolan commented on pull request #10681: KIP 731 WIP Connect per-task record rate limiting

2021-05-18 Thread GitBox
ryannedolan commented on pull request #10681: URL: https://github.com/apache/kafka/pull/10681#issuecomment-843668847 Failing tests seem unrelated (KRaft and Streams). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
showuon commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843681372 @ableegoldman , no problem! Updated! Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] mjsax opened a new pull request #10720: MINOR: preserve timestamp when getting value from upstream state store

2021-05-18 Thread GitBox
mjsax opened a new pull request #10720: URL: https://github.com/apache/kafka/pull/10720 When getting a value from an upstream state store, we should ensure that the record timestamp is accessible when applying a `Transformer`. -- This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-18 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346805#comment-17346805 ] NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/19/21, 1:45 AM: -

[GitHub] [kafka] mjsax commented on a change in pull request #10720: MINOR: preserve timestamp when getting value from upstream state store

2021-05-18 Thread GitBox
mjsax commented on a change in pull request #10720: URL: https://github.com/apache/kafka/pull/10720#discussion_r634858161 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java ## @@ -63,15 +63,14 @@ public void enableSendingOldVal

[GitHub] [kafka] mjsax commented on a change in pull request #10720: MINOR: preserve timestamp when getting value from upstream state store

2021-05-18 Thread GitBox
mjsax commented on a change in pull request #10720: URL: https://github.com/apache/kafka/pull/10720#discussion_r634859119 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java ## @@ -141,16 +144,32 @@ public void close() {

[jira] [Commented] (KAFKA-12811) kafka-topics.sh should let the user know they cannot adjust the replication factor for a topic using the --alter flag and not warn about missing the --partition flag

2021-05-18 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347257#comment-17347257 ] Luke Chen commented on KAFKA-12811: --- [~rjoerger], I've helped you move this ticket int

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347259#comment-17347259 ] A. Sophie Blee-Goldman commented on KAFKA-12776: [~neeraj.vaidya] althou

[GitHub] [kafka] ViE-17-tuoi opened a new pull request #10721: Feature/kafka 12380

2021-05-18 Thread GitBox
ViE-17-tuoi opened a new pull request #10721: URL: https://github.com/apache/kafka/pull/10721 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of tes

[GitHub] [kafka] showuon commented on pull request #10716: optimize offset reset strategy and fix lose data when add partition

2021-05-18 Thread GitBox
showuon commented on pull request #10716: URL: https://github.com/apache/kafka/pull/10716#issuecomment-843693354 Also, there are code conflict with `trunk` branch. Please merge `trunk` and push again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
showuon commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843693730 I'll monitor it and let you know when completed. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ViE-17-tuoi closed pull request #10721: Feature/kafka 12380

2021-05-18 Thread GitBox
ViE-17-tuoi closed pull request #10721: URL: https://github.com/apache/kafka/pull/10721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-18 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347269#comment-17347269 ] NEERAJ VAIDYA commented on KAFKA-12776: --- Thanks [~ableegoldman] I'd imagined KIP-

[GitHub] [kafka] showuon commented on a change in pull request #10714: MINOR: add ConfigUtils method for printing configurations

2021-05-18 Thread GitBox
showuon commented on a change in pull request #10714: URL: https://github.com/apache/kafka/pull/10714#discussion_r634877755 ## File path: clients/src/test/java/org/apache/kafka/common/utils/ConfigUtilsTest.java ## @@ -140,4 +144,28 @@ public void testMultipleDeprecations() {

[GitHub] [kafka] DuongPTIT closed pull request #10685: KAFKA-12380 Executor in Connect's Worker is not shut down when the worker is

2021-05-18 Thread GitBox
DuongPTIT closed pull request #10685: URL: https://github.com/apache/kafka/pull/10685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] showuon opened a new pull request #10722: MINOR: update java doc for deprecated methods

2021-05-18 Thread GitBox
showuon opened a new pull request #10722: URL: https://github.com/apache/kafka/pull/10722 Update deprecated methods: 1. `KStream#through(String, Produced)` 2. `KafkaConsumer#poll(long)` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementa

[GitHub] [kafka] showuon commented on pull request #10722: MINOR: update java doc for deprecated methods

2021-05-18 Thread GitBox
showuon commented on pull request #10722: URL: https://github.com/apache/kafka/pull/10722#issuecomment-843715792 @mjsax , could you please review this small PR to update java doc? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dajac commented on pull request #10326: Avoid newly replicating brokers in RackAwareReplicaSelector

2021-05-18 Thread GitBox
dajac commented on pull request #10326: URL: https://github.com/apache/kafka/pull/10326#issuecomment-843754057 @lizthegrey Please, excuse me for the delay on this one. I did not have the time to really look into it. At the moment, it is not clear to me that the PR actually solves the

[jira] [Commented] (KAFKA-10201) Update codebase to use more inclusive terms

2021-05-18 Thread Vitaly Gerasimov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17347311#comment-17347311 ] Vitaly Gerasimov commented on KAFKA-10201: -- What's about to change the kafka "b

[GitHub] [kafka] abbccdda closed pull request #9311: KAFKA-9910: Implement new transaction timed out error

2021-05-18 Thread GitBox
abbccdda closed pull request #9311: URL: https://github.com/apache/kafka/pull/9311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] showuon commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
showuon commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843766426 Failed test is unrelated and flaky. ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics() ``` -- This is an autom

[GitHub] [kafka] showuon edited a comment on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
showuon edited a comment on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843766426 @ableegoldman , Failed test is unrelated and flaky. Thanks. ``` Build / JDK 15 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopics(

[GitHub] [kafka] abbccdda commented on a change in pull request #10700: KAFKA-12789: Remove Stale comments for meta response handling logic

2021-05-18 Thread GitBox
abbccdda commented on a change in pull request #10700: URL: https://github.com/apache/kafka/pull/10700#discussion_r634931818 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -1089,8 +1089,8 @@ public void handleSuccessfulResponse(RequestHead

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10700: KAFKA-12789: Remove Stale comments for meta response handling logic

2021-05-18 Thread GitBox
zhaohaidao commented on a change in pull request #10700: URL: https://github.com/apache/kafka/pull/10700#discussion_r634933714 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -1089,8 +1089,8 @@ public void handleSuccessfulResponse(RequestHe

[GitHub] [kafka] ableegoldman merged pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
ableegoldman merged pull request #10715: URL: https://github.com/apache/kafka/pull/10715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10715: KAFKA-9295: increase heartbeat and session timeout

2021-05-18 Thread GitBox
ableegoldman commented on pull request #10715: URL: https://github.com/apache/kafka/pull/10715#issuecomment-843771446 Merged to trunk at exactly 11pm PST (May 18th 2021) -- be on the lookout for any failures on builds kicked off after this time -- This is an automated message from the Ap

[jira] [Resolved] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-05-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-9295. --- Resolution: Fixed > KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shoul