[jira] [Resolved] (KAFKA-12728) Version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow plugin (6.1.0 -->> 7.0.0)

2021-05-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dejan Stojadinović resolved KAFKA-12728. Resolution: Done Solving as *done* (related code is merged into trunk). > Version

[jira] [Commented] (KAFKA-12771) CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of 'Indentation' errors

2021-05-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345662#comment-17345662 ] Dejan Stojadinović commented on KAFKA-12771: Hello fellow-contributor [~dong

[jira] [Comment Edited] (KAFKA-12771) CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons a pack of 'Indentation' errors

2021-05-16 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345662#comment-17345662 ] Dejan Stojadinović edited comment on KAFKA-12771 at 5/16/21, 10:02 AM: ---

[GitHub] [kafka] dejan2609 commented on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-16 Thread GitBox
dejan2609 commented on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-841795654 (Will be) solved elsewhere and hence closing in favor of #10698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dejan2609 closed pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-16 Thread GitBox
dejan2609 closed pull request #10658: URL: https://github.com/apache/kafka/pull/10658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-16 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-841795946 One flaky test failed, so I will retest this: ``` Build / JDK 11 and Scala 2.13 / testCreateClusterAndCreateListDeleteTopic() – kafka.server.RaftClusterTest19s Er

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-16 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-841795974 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] bruto1 commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
bruto1 commented on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-841806011 > Hi @bruto1 can you take a look at PlaintextConsumerTest.testHeadersSerializerDeserializer()? It seems to be failing and might be related to your change. there're quite a

[GitHub] [kafka] bruto1 edited a comment on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
bruto1 edited a comment on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-841806011 > Hi @bruto1 can you take a look at PlaintextConsumerTest.testHeadersSerializerDeserializer()? It seems to be failing and might be related to your change. there're

[GitHub] [kafka] bruto1 edited a comment on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
bruto1 edited a comment on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-841806011 > Hi @bruto1 can you take a look at PlaintextConsumerTest.testHeadersSerializerDeserializer()? It seems to be failing and might be related to your change. there're

[jira] [Created] (KAFKA-12793) KIP-693 Client-side Circuit Breaker for Partition Write Errors

2021-05-16 Thread KahnCheny (Jira)
KahnCheny created KAFKA-12793: - Summary: KIP-693 Client-side Circuit Breaker for Partition Write Errors Key: KAFKA-12793 URL: https://issues.apache.org/jira/browse/KAFKA-12793 Project: Kafka Iss

[GitHub] [kafka] chia7712 commented on pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-16 Thread GitBox
chia7712 commented on pull request #10585: URL: https://github.com/apache/kafka/pull/10585#issuecomment-841812285 BTW, this patch fixes the commands in readme (https://github.com/apache/kafka/blob/trunk/README.md#force-re-running-tests-without-code-change) -- This is an automated message

[GitHub] [kafka] ijuma commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-16 Thread GitBox
ijuma commented on a change in pull request #10585: URL: https://github.com/apache/kafka/pull/10585#discussion_r633089109 ## File path: build.gradle ## @@ -380,6 +380,15 @@ subprojects { } } + cleanTest { +subprojects.each { + delete "${it.buildDir}/test-res

[jira] [Commented] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

2021-05-16 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345695#comment-17345695 ] Alexandre Dupriez commented on KAFKA-12671: --- Cross-referencing [KAFKA-10442] -

[GitHub] [kafka] chia7712 commented on a change in pull request #10585: MINOR: cleanTest ought to remove output of unitTest task and integrat…

2021-05-16 Thread GitBox
chia7712 commented on a change in pull request #10585: URL: https://github.com/apache/kafka/pull/10585#discussion_r633090928 ## File path: build.gradle ## @@ -380,6 +380,15 @@ subprojects { } } + cleanTest { +subprojects.each { + delete "${it.buildDir}/test-

[GitHub] [kafka] romani commented on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-16 Thread GitBox
romani commented on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-841823518 @dejan2609 , fix for checkstyle/checkstyle#9957 will be released in 2 weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] romani commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-16 Thread GitBox
romani commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-841823954 as soon it is merged, we can add kafka to regression suite to make sure we will not leak regression on kafka code any more. -- This is an automated message from the Apache Git

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-05-16 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-841825044 Roger that @romani ! I hope that @ijuma will review this PR when he finds some time. Note: previous round of tests returned one error (flaky test, it seems) so I tried

[GitHub] [kafka] dejan2609 commented on pull request #10658: POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

2021-05-16 Thread GitBox
dejan2609 commented on pull request #10658: URL: https://github.com/apache/kafka/pull/10658#issuecomment-841828282 Thanx for info @romani, much appreciated ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] lbradstreet commented on pull request #10704: KAFKA-12791: ConcurrentModificationException in AbstractConfig use by KafkaProducer

2021-05-16 Thread GitBox
lbradstreet commented on pull request #10704: URL: https://github.com/apache/kafka/pull/10704#issuecomment-841831977 @ijuma I'm admittedly very confused by this too. I followed the producer configs through everywhere it's passed and can't see anywhere that it seems likely to be called conc

[GitHub] [kafka] rondagostino commented on a change in pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-05-16 Thread GitBox
rondagostino commented on a change in pull request #10550: URL: https://github.com/apache/kafka/pull/10550#discussion_r633107724 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -99,6 +100,9 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] rondagostino commented on a change in pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-05-16 Thread GitBox
rondagostino commented on a change in pull request #10550: URL: https://github.com/apache/kafka/pull/10550#discussion_r633107934 ## File path: clients/src/main/resources/common/message/DeleteAclsRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 31, "type": "request", - "lis

[GitHub] [kafka] rondagostino commented on a change in pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-05-16 Thread GitBox
rondagostino commented on a change in pull request #10550: URL: https://github.com/apache/kafka/pull/10550#discussion_r633110706 ## File path: tests/kafkatest/tests/core/zookeeper_authorizer_test.py ## @@ -0,0 +1,98 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] jolshan commented on a change in pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
jolshan commented on a change in pull request #10590: URL: https://github.com/apache/kafka/pull/10590#discussion_r633111374 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -920,23 +923,28 @@ private void throwIfProducerClosed() {

[GitHub] [kafka] jolshan commented on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
jolshan commented on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-841842291 >there're quite a few tests failing in every PR in this repo, it seems :) Yes, there are flaky tests, but this one fails each time on your branch and not on trunk. I think I i

[GitHub] [kafka] jolshan edited a comment on pull request #10590: KAFKA-5761: support ByteBuffer as value in ProducerRecord and avoid redundant serialization when it's used

2021-05-16 Thread GitBox
jolshan edited a comment on pull request #10590: URL: https://github.com/apache/kafka/pull/10590#issuecomment-841842291 >there're quite a few tests failing in every PR in this repo, it seems :) Yes, there are flaky tests, but this one fails each time on your branch and not on trunk.

[GitHub] [kafka] ijuma commented on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

2021-05-16 Thread GitBox
ijuma commented on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-841855882 @rondagostino did you see https://github.com/apache/kafka/pull/10699? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] mjsax opened a new pull request #10708: MINOR: remove unnecessary `public` keyword from `Partitioner` interface

2021-05-16 Thread GitBox
mjsax opened a new pull request #10708: URL: https://github.com/apache/kafka/pull/10708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

2021-05-16 Thread GitBox
lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r633135023 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/IncompleteBatches.java ## @@ -51,6 +51,14 @@ public void remove(Produ

[GitHub] [kafka] mjsax merged pull request #10708: MINOR: remove unnecessary `public` keyword from `Partitioner` interface

2021-05-16 Thread GitBox
mjsax merged pull request #10708: URL: https://github.com/apache/kafka/pull/10708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ning2008wisc commented on pull request #10644: [KAFKA-12635] auto sync consumer offset 0 when translated offset larger than partition end offset

2021-05-16 Thread GitBox
ning2008wisc commented on pull request #10644: URL: https://github.com/apache/kafka/pull/10644#issuecomment-841893030 users have verified that the PR is working. Please take the initial review when available cc @ryannedolan @mimaison Thanks -- This is an automated message from the Apac

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345804#comment-17345804 ] NEERAJ VAIDYA commented on KAFKA-12776: --- [~ijuma] The attempts to get metadata bec

[jira] [Comment Edited] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345804#comment-17345804 ] NEERAJ VAIDYA edited comment on KAFKA-12776 at 5/17/21, 12:44 AM:

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345810#comment-17345810 ] Ismael Juma commented on KAFKA-12776: - If you invoke `send` in sequence, the call wo

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345814#comment-17345814 ] NEERAJ VAIDYA commented on KAFKA-12776: --- [~ijuma] Yes `send` is called from multip

[GitHub] [kafka] guozhangwang commented on a change in pull request #10675: KAFKA-12574: remove internal Producer config and auto downgrade logic

2021-05-16 Thread GitBox
guozhangwang commented on a change in pull request #10675: URL: https://github.com/apache/kafka/pull/10675#discussion_r633174817 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -237,13 +237,15 @@ private static boolea

[GitHub] [kafka] zhaohaidao opened a new pull request #9311: KAFKA-9910: Implement new transaction timed out error

2021-05-16 Thread GitBox
zhaohaidao opened a new pull request #9311: URL: https://github.com/apache/kafka/pull/9311 The producer recovers by internally sending InitProducerId with the current epoch when received TRANSACTION_TIMED_OUT error. ### Committer Checklist (excluded from commit message) - [ ] Veri

[GitHub] [kafka] abbccdda commented on a change in pull request #10156: KAFKA-10345: File watch store reloading

2021-05-16 Thread GitBox
abbccdda commented on a change in pull request #10156: URL: https://github.com/apache/kafka/pull/10156#discussion_r633178155 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Timer.java ## @@ -158,6 +158,10 @@ public long remainingMs() { return Math.max

[GitHub] [kafka] abbccdda commented on a change in pull request #10156: KAFKA-10345: File watch store reloading

2021-05-16 Thread GitBox
abbccdda commented on a change in pull request #10156: URL: https://github.com/apache/kafka/pull/10156#discussion_r633178435 ## File path: clients/src/test/java/org/apache/kafka/test/TestSslUtils.java ## @@ -579,6 +583,9 @@ public SslConfigsBuilder usePem(boolean usePem) {

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345822#comment-17345822 ] Guozhang Wang commented on KAFKA-12776: --- Hey [~neeraj.vaidya], thanks for your upd

[jira] [Created] (KAFKA-12794) Trailing JSON tokens in DescribeProducersRequest.json can cause parse errors in some JSON parsers

2021-05-16 Thread Nathan Lincoln (Jira)
Nathan Lincoln created KAFKA-12794: -- Summary: Trailing JSON tokens in DescribeProducersRequest.json can cause parse errors in some JSON parsers Key: KAFKA-12794 URL: https://issues.apache.org/jira/browse/KAFKA-12

[jira] [Created] (KAFKA-12795) Create kafka connector use chinese character failed

2021-05-16 Thread pengWei Dou (Jira)
pengWei Dou created KAFKA-12795: --- Summary: Create kafka connector use chinese character failed Key: KAFKA-12795 URL: https://issues.apache.org/jira/browse/KAFKA-12795 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345828#comment-17345828 ] NEERAJ VAIDYA commented on KAFKA-12776: --- Thanks [~guozhang] Will [KIP-739|https:

[GitHub] [kafka] NLincoln opened a new pull request #10709: KAFKA-12794: Fix trailing json tokens in DescribeProducersRequest.json

2021-05-16 Thread GitBox
NLincoln opened a new pull request #10709: URL: https://github.com/apache/kafka/pull/10709 The schema definition for the DescribeProducersRequest see [here](https://github.com/apache/kafka/blob/3b6599c600f6e7fbeb000a088591f1cf9aba107d/clients/src/main/resources/common/message/DescribeProduc

[GitHub] [kafka] ableegoldman commented on a change in pull request #10675: KAFKA-12574: remove internal Producer config and auto downgrade logic

2021-05-16 Thread GitBox
ableegoldman commented on a change in pull request #10675: URL: https://github.com/apache/kafka/pull/10675#discussion_r633185500 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java ## @@ -237,13 +237,15 @@ private static boolea

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345836#comment-17345836 ] Guozhang Wang commented on KAFKA-12776: --- I think KIP-739 is relatively orthogonal

[jira] [Commented] (KAFKA-12776) Producer sends messages out-of-order inspite of enabling idempotence

2021-05-16 Thread NEERAJ VAIDYA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345848#comment-17345848 ] NEERAJ VAIDYA commented on KAFKA-12776: --- Thanks [~guozhang] To conclude, am I cor

[GitHub] [kafka] guozhangwang commented on a change in pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

2021-05-16 Thread GitBox
guozhangwang commented on a change in pull request #10646: URL: https://github.com/apache/kafka/pull/10646#discussion_r633182424 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -128,8 +129,7 @@ public void setG

[GitHub] [kafka] vamossagar12 commented on pull request #10542: KAFKA-12313: Streamling windowed Deserialiser configs.

2021-05-16 Thread GitBox
vamossagar12 commented on pull request #10542: URL: https://github.com/apache/kafka/pull/10542#issuecomment-841965396 hey @ableegoldman , could you plz review the PR whenever you get the chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

2021-05-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345867#comment-17345867 ] Guozhang Wang commented on KAFKA-12781: --- I did not review the original PR so do no

[jira] [Commented] (KAFKA-10594) Enhance Raft exception handling

2021-05-16 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345868#comment-17345868 ] Guozhang Wang commented on KAFKA-10594: --- Thanks for filing this Boyang. I also agr

[jira] [Commented] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-16 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345886#comment-17345886 ] kaushik srinivas commented on KAFKA-12534: -- Hi, We have tried the exact steps.

[jira] [Comment Edited] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-16 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345886#comment-17345886 ] kaushik srinivas edited comment on KAFKA-12534 at 5/17/21, 5:52 AM: --

[jira] [Comment Edited] (KAFKA-12534) kafka-configs does not work with ssl enabled kafka broker.

2021-05-16 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345886#comment-17345886 ] kaushik srinivas edited comment on KAFKA-12534 at 5/17/21, 5:53 AM: --