feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619793709
##
File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java
##
@@ -96,7 +96,7 @@ public BatchBuilder(
}
/**
- *
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619793844
##
File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotWriterTest.java
##
@@ -38,7 +38,7 @@
@Test
public void testWritingSnapsh
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619793903
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1335,6 +1313,51 @@ public void
testFetchSnapshotReques
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619795184
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, bool
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-826304130
@jsancio Could you please help to review? Thanks!
Locally verified, all the failed tests should not be related. See failed
tests in
https://ci-builds.apache.org/job/Kafka/
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331498#comment-17331498
]
Haoran Xuan commented on KAFKA-10800:
-
[~jagsancio] The PR [GitHub Pull Request
#10
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r619798057
##
File path: build.gradle
##
@@ -1485,7 +1485,7 @@ project(':tools') {
testImplementation libs.junitJupiter
testImplementation project(':clien
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r619798137
##
File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java
##
@@ -190,6 +166,51 @@ public static void main(String[] args) throws E
Rajni Jain created KAFKA-12714:
--
Summary: Kafka 2.8 server not starting on Windows OS
Key: KAFKA-12714
URL: https://issues.apache.org/jira/browse/KAFKA-12714
Project: Kafka
Issue Type: Bug
chia7712 merged pull request #9627:
URL: https://github.com/apache/kafka/pull/9627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
chia7712 commented on pull request #9627:
URL: https://github.com/apache/kafka/pull/9627#issuecomment-826320025
@showuon thanks for this patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chia7712 merged pull request #10558:
URL: https://github.com/apache/kafka/pull/10558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
[
https://issues.apache.org/jira/browse/KAFKA-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12684.
Resolution: Fixed
> The valid partition list is incorrectly replaced by the successfully e
chia7712 merged pull request #10586:
URL: https://github.com/apache/kafka/pull/10586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
chia7712 commented on pull request #10586:
URL: https://github.com/apache/kafka/pull/10586#issuecomment-826324896
@wenbingshen thanks for this backport!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12702.
Fix Version/s: 2.8.1
3.0.0
Resolution: Fixed
> Unhandled excepti
xu lobo created KAFKA-12715:
---
Summary: ACL authentication, Host field support IP network segment
Key: KAFKA-12715
URL: https://issues.apache.org/jira/browse/KAFKA-12715
Project: Kafka
Issue Type: I
[
https://issues.apache.org/jira/browse/KAFKA-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331526#comment-17331526
]
xu lobo commented on KAFKA-12715:
-
I could add this feature and would like to hear from
socutes opened a new pull request #10594:
URL: https://github.com/apache/kafka/pull/10594
merge
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summa
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331590#comment-17331590
]
Ming Liu commented on KAFKA-12713:
--
The idea is like this, we can:
1. Add waitTimeMS i
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331590#comment-17331590
]
Ming Liu edited comment on KAFKA-12713 at 4/25/21, 5:33 PM:
wenbingshen opened a new pull request #10595:
URL: https://github.com/apache/kafka/pull/10595
As the title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-826381116
@ijuma So, now I have something to show: I managed perform some
reverse-engineering and received exactly the same content in
`/streams/build/dependent-libs-${version.scala}` f
[
https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331635#comment-17331635
]
Matthias J. Sax commented on KAFKA-12453:
-
Thanks for asking. In general 3rd par
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619875764
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+ The
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619876217
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+ The
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619876369
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+ The
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619877425
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -603,7 +606,7 @@ boolean runLoop() {
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619877817
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
##
@@ -111,6 +113,7 @@
private final Strin
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619878083
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
##
@@ -126,10 +129,10 @@ public void setup() {
[
https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-10800:
---
Description:
When the state machine attempts to create a snapshot wr
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619882084
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619882204
##
File path:
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java
##
@@ -1335,6 +1313,51 @@ public void
testFetchSnapshotRequestCl
ijuma commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r619888968
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (confi
ijuma commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r619889058
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (confi
ijuma commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-826400303
@dejan2609 can you please rebase on trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331590#comment-17331590
]
Ming Liu edited comment on KAFKA-12713 at 4/25/21, 11:16 PM:
-
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final K key
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final K key
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final K key
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final K key
mjsax commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-826417134
Seems there is some checkstyle error:
```
[2021-04-22T23:02:56.789Z] [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10548/streams/src/main/j
socutes closed pull request #10594:
URL: https://github.com/apache/kafka/pull/10594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
socutes opened a new pull request #10596:
URL: https://github.com/apache/kafka/pull/10596
At present, ACL authentication, the Host field only supports equal matching
of source IP, so we hope that the Host field can support matching of IP network
segment.
### Committer Checklist (exc
[
https://issues.apache.org/jira/browse/KAFKA-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Minoru Tomioka reassigned KAFKA-12535:
--
Assignee: (was: Minoru Tomioka)
> Consider Revising Document Anchors for Properti
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619988848
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, bool
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619988848
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, bool
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619989241
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, bool
bruto1 edited a comment on pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#issuecomment-826126350
I guess the failing tests are par for the course here
pls review! @chia7712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-826067611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queri
dengziming opened a new pull request #10592:
URL: https://github.com/apache/kafka/pull/10592
*More detailed description of your change*
1. `LogSegmentsTest` will create
bruto1 commented on pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#issuecomment-826126350
I guess the failing tests are par for the course here
pls review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
kowshik commented on a change in pull request #10592:
URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506
##
File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala
##
@@ -35,6 +39,17 @@ class LogSegmentsTest {
LogTestUtils.createSegment(offse
socutes closed pull request #10594:
URL: https://github.com/apache/kafka/pull/10594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
chia7712 merged pull request #10586:
URL: https://github.com/apache/kafka/pull/10586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -234,13 +247,15 @@ public V delete(final K key
chia7712 merged pull request #9627:
URL: https://github.com/apache/kafka/pull/9627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mjsax commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-826417134
Seems there is some checkstyle error:
```
[2021-04-22T23:02:56.789Z] [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10548/streams/src/main/j
chia7712 merged pull request #10558:
URL: https://github.com/apache/kafka/pull/10558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
tang7526 commented on a change in pull request #10588:
URL: https://github.com/apache/kafka/pull/10588#discussion_r619798057
##
File path: build.gradle
##
@@ -1485,7 +1485,7 @@ project(':tools') {
testImplementation libs.junitJupiter
testImplementation project(':clien
dengziming commented on pull request #10592:
URL: https://github.com/apache/kafka/pull/10592#issuecomment-826089682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For quer
chia7712 commented on pull request #10586:
URL: https://github.com/apache/kafka/pull/10586#issuecomment-826324896
@wenbingshen thanks for this backport!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
62 matches
Mail list logo
