[GitHub] [kafka] chia7712 commented on pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-21 Thread GitBox
chia7712 commented on pull request #10567: URL: https://github.com/apache/kafka/pull/10567#issuecomment-823837778 > Does it cause any failures? According to source code (https://github.com/FasterXML/jackson-databind/blob/2.10/src/main/java/com/fasterxml/jackson/databind/deser/std/Num

[jira] [Assigned] (KAFKA-12700) The admin.listeners config has wonky valid values in the docs

2021-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12700: - Assignee: Luke Chen > The admin.listeners config has wonky valid values in the docs > -

[GitHub] [kafka] chia7712 commented on pull request #10446: KAFKA-12661 ConfigEntry#equal does not compare other fields when value is NOT null

2021-04-21 Thread GitBox
chia7712 commented on pull request #10446: URL: https://github.com/apache/kafka/pull/10446#issuecomment-823838830 ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.KTableKTableForeignKeyInnerJoinMultiIntegrationTest.shouldInnerJoinMultiPartitionQueryable Build /

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Travis Bischel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326316#comment-17326316 ] Travis Bischel commented on KAFKA-12701: Metadata v11 is supported in 2.8.0. I'v

[GitHub] [kafka] showuon opened a new pull request #10574: KAFKA-12700: override toString method to show correct value in doc

2021-04-21 Thread GitBox
showuon opened a new pull request #10574: URL: https://github.com/apache/kafka/pull/10574 We use customized validator here, but forgot to override the `toString` method to show correct value in doc. ### Committer Checklist (excluded from commit message) - [ ] Verify design and imp

[GitHub] [kafka] showuon commented on pull request #10574: KAFKA-12700: override toString method to show correct value in doc

2021-04-21 Thread GitBox
showuon commented on pull request #10574: URL: https://github.com/apache/kafka/pull/10574#issuecomment-823848128 @rhauch @wicknicks , could you help review this PR to update the doc? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-12700) The admin.listeners config has wonky valid values in the docs

2021-04-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326325#comment-17326325 ] Luke Chen commented on KAFKA-12700: --- Nice catch!! > The admin.listeners config has wo

[GitHub] [kafka] dajac commented on pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-21 Thread GitBox
dajac commented on pull request #10567: URL: https://github.com/apache/kafka/pull/10567#issuecomment-823855071 > > Does it cause any failures? > > According to source code (https://github.com/FasterXML/jackson-databind/blob/2.10/src/main/java/com/fasterxml/jackson/databind/deser/std/

[jira] [Created] (KAFKA-12702) Unhandled exception caught in InterBrokerSendThread

2021-04-21 Thread Wenbing Shen (Jira)
Wenbing Shen created KAFKA-12702: Summary: Unhandled exception caught in InterBrokerSendThread Key: KAFKA-12702 URL: https://issues.apache.org/jira/browse/KAFKA-12702 Project: Kafka Issue Typ

[GitHub] [kafka] chia7712 commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
chia7712 commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617297824 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void replay(PartitionRec

[jira] [Updated] (KAFKA-12702) Unhandled exception caught in InterBrokerSendThread

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen updated KAFKA-12702: - Attachment: image-2021-04-21-17-12-28-471.png > Unhandled exception caught in InterBrokerSendThr

[jira] [Commented] (KAFKA-12702) Unhandled exception caught in InterBrokerSendThread

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326387#comment-17326387 ] Wenbing Shen commented on KAFKA-12702: -- We need to fix this problem, because accord

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326392#comment-17326392 ] dengziming commented on KAFKA-12701: In fact, we first planned to support topicId in

[GitHub] [kafka] wenbingshen opened a new pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
wenbingshen opened a new pull request #10575: URL: https://github.com/apache/kafka/pull/10575 According to the comments in the configuration file (config/kraft/server.properties), if listeners and advertised.listeners are not configured with an address, the program will automatically obtai

[GitHub] [kafka] chia7712 commented on pull request #10567: Ensure `ignorable` is a boolean value.

2021-04-21 Thread GitBox
chia7712 commented on pull request #10567: URL: https://github.com/apache/kafka/pull/10567#issuecomment-823919500 ``` Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions() org.apache.kafka.connect.mirror.integration.M

[jira] [Resolved] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen resolved KAFKA-12680. -- Resolution: Cannot Reproduce > Failed to restart the broker in kraft mode > --

[GitHub] [kafka] chia7712 commented on a change in pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
chia7712 commented on a change in pull request #10575: URL: https://github.com/apache/kafka/pull/10575#discussion_r617365981 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -272,7 +273,7 @@ class BrokerServer( val networkListeners = new ListenerCo

[GitHub] [kafka] wenbingshen commented on a change in pull request #10575: KAFKA-12702: Fix NPE in networkListeners from BrokerServer

2021-04-21 Thread GitBox
wenbingshen commented on a change in pull request #10575: URL: https://github.com/apache/kafka/pull/10575#discussion_r617379329 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -272,7 +273,7 @@ class BrokerServer( val networkListeners = new Listene

[GitHub] [kafka] dengziming opened a new pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-21 Thread GitBox
dengziming opened a new pull request #10576: URL: https://github.com/apache/kafka/pull/10576 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* #9622 add topicI

[jira] [Assigned] (KAFKA-12702) Unhandled exception caught in InterBrokerSendThread

2021-04-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12702: -- Assignee: Wenbing Shen > Unhandled exception caught in InterBrokerSendThread > --

[GitHub] [kafka] chia7712 opened a new pull request #10577: MINOR: check duplicate advertised listeners based on resolved host

2021-04-21 Thread GitBox
chia7712 opened a new pull request #10577: URL: https://github.com/apache/kafka/pull/10577 related to #4897 I noticed this issue when reviewing #10575. With this patch, the listener `:12345` gets fast failure if its resolved host and port is registered already. ### Committer C

[GitHub] [kafka] Iskuskov commented on a change in pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

2021-04-21 Thread GitBox
Iskuskov commented on a change in pull request #9541: URL: https://github.com/apache/kafka/pull/9541#discussion_r617423452 ## File path: connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java ## @@ -266,7 +267,7 @@ public static void validateValue(String na

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617482721 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0 +1,1

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617483955 ## File path: build.gradle ## @@ -1409,6 +1409,7 @@ project(':storage') { dependencies { implementation project(':storage:api') implementatio

[GitHub] [kafka] satishd opened a new pull request #10578: MINOR Moved ApiMessageAndVersion and AbstractApiMessageAndVersionSerde to clients module.

2021-04-21 Thread GitBox
satishd opened a new pull request #10578: URL: https://github.com/apache/kafka/pull/10578 MINOR Moved ApiMessageAndVersion and AbstractApiMessageAndVersionSerde to clients module. Existing unit tests would be sufficient as this change is more about moving classes into `client` modul

[GitHub] [kafka] satishd commented on pull request #10578: MINOR Moved ApiMessageAndVersion and AbstractApiMessageAndVersionSerde to clients module.

2021-04-21 Thread GitBox
satishd commented on pull request #10578: URL: https://github.com/apache/kafka/pull/10578#issuecomment-824024671 @junrao This PR is based on https://github.com/apache/kafka/pull/10271. So, this should be merged only after https://github.com/apache/kafka/pull/10271 is merged. Review ca

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617483955 ## File path: build.gradle ## @@ -1409,6 +1409,7 @@ project(':storage') { dependencies { implementation project(':storage:api') implementatio

[jira] [Commented] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326499#comment-17326499 ] Ismael Juma commented on KAFKA-12680: - Hi [~wenbing.shen]. Thanks for the ticket. Ca

[GitHub] [kafka] satishd opened a new pull request #10579: KAFKA-9555 Initial version of default RLMM implementation.

2021-04-21 Thread GitBox
satishd opened a new pull request #10579: URL: https://github.com/apache/kafka/pull/10579 KAFKA-9555 Initial version of default RLMM implementation. This is still in draft mode. This includes changes containing default RLMM configs, RLMM implementation, producer/consumer manager

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617505731 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void replay(PartitionReco

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617507396 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,62 @@ void validateManualPartitionAss

[jira] [Created] (KAFKA-12703) Unencrypted PEM files don't work

2021-04-21 Thread Brian Bascoy (Jira)
Brian Bascoy created KAFKA-12703: Summary: Unencrypted PEM files don't work Key: KAFKA-12703 URL: https://issues.apache.org/jira/browse/KAFKA-12703 Project: Kafka Issue Type: Bug Co

[GitHub] [kafka] tombentley commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-21 Thread GitBox
tombentley commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r616833243 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,34 @@ else if (serverConnector !=

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-21 Thread GitBox
kpatelatwork commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r617556919 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,34 @@ else if (serverConnector !

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-21 Thread GitBox
kpatelatwork commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r617556919 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -369,9 +370,34 @@ else if (serverConnector !

[jira] [Updated] (KAFKA-12703) Unencrypted PEM files can't be loaded

2021-04-21 Thread Brian Bascoy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Bascoy updated KAFKA-12703: - Summary: Unencrypted PEM files can't be loaded (was: Unencrypted PEM files don't work) > Unenc

[jira] [Commented] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326589#comment-17326589 ] Wenbing Shen commented on KAFKA-12680: -- Hi [~ijuma] Sorry, this problem is caused b

[jira] [Reopened] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen reopened KAFKA-12680: -- > Failed to restart the broker in kraft mode > -- > >

[jira] [Resolved] (KAFKA-12680) Failed to restart the broker in kraft mode

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen resolved KAFKA-12680. -- Resolution: Not A Problem > Failed to restart the broker in kraft mode > -

[jira] [Commented] (KAFKA-10773) When I execute the below command, Kafka cannot start in local.

2021-04-21 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326600#comment-17326600 ] Wenbing Shen commented on KAFKA-10773: -- Similar to KAFKA-12680. In fact, this is a

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-21 Thread Haoran Xuan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326611#comment-17326611 ] Haoran Xuan commented on KAFKA-10800: - Hi, [~jagsancio], I just started working on t

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-21 Thread GitBox
Nathan22177 commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824141690 @mjsax > MeteredSessionStore: > > * put() (should verify `sessionKey != null` and `sessionKey.key() != null`) > * remove() > * fetchSession() > * fetch(K)

[GitHub] [kafka] kpatelatwork commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-21 Thread GitBox
kpatelatwork commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-824141840 @tombentley I took another shot of implementing the PR using the above suggestions. Could you please check if it still needs improvement? I didn't do explici

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326628#comment-17326628 ] Justine Olshan commented on KAFKA-12701: Thanks [~twmb] and [~dengziming] for ta

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617482721 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0 +1,1

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617482721 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0 +1,1

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326633#comment-17326633 ] Ismael Juma commented on KAFKA-12701: - I suggest fixing it in 3.0.0 and 2.8.1. > NP

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Mikhail Panchenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326635#comment-17326635 ] Mikhail Panchenko commented on KAFKA-12696: --- Ok. Just to confirm, the confluen

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326641#comment-17326641 ] Ismael Juma commented on KAFKA-12696: - The "avoid getters and setters" note applies

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326652#comment-17326652 ] Justine Olshan commented on KAFKA-12701: [~dengziming] Just to clarify, we did n

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326628#comment-17326628 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:49 PM:

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326628#comment-17326628 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:49 PM:

[jira] [Comment Edited] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326652#comment-17326652 ] Justine Olshan edited comment on KAFKA-12701 at 4/21/21, 3:58 PM:

[jira] [Created] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
Kalpesh Patel created KAFKA-12704: - Summary: Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances Key: KAFKA-12704 URL: https://issues.apache.org/jira/browse/KAFKA-12704

[jira] [Assigned] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-12704: - Assignee: Kalpesh Patel > Concurrent calls to AbstractHerder::getConnector can potentia

[jira] [Updated] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-12704: -- Description: Concurrent requests to the {{PUT /connector-plugins/\{connectorType}/config/vali

[jira] [Updated] (KAFKA-12704) Concurrent calls to AbstractHerder::getConnector can potentially create two connector instances

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-12704: -- Description: As discovered in KAFKA-9560, concurrent requests to the {{PUT /connector-plugins

[jira] [Updated] (KAFKA-9560) Connector::validate is utilized concurrently by the framework, but not documented as thread-safe

2021-04-21 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel updated KAFKA-9560: - Description: Requests to the {{PUT /connector-plugins/\{connectorType}/config/validate}} endpoin

[GitHub] [kafka] junrao commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-21 Thread GitBox
junrao commented on pull request #10576: URL: https://github.com/apache/kafka/pull/10576#issuecomment-824228739 @dengziming : We probably can't remove a field from an existing protocol without changing the version. Otherwise, the client will be confused on the exact protocol for a particul

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617765100 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataContextSerdes.java ## @@ -0,0 +1,12

[GitHub] [kafka] kpatelatwork opened a new pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork opened a new pull request #10580: URL: https://github.com/apache/kafka/pull/10580 *Concurrent requests to validate endpoint for the same connector type calls AbstractHerder::getConnector to get the cached connector instances and if the connector hasn't been cached yet then th

[GitHub] [kafka] C0urante commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
C0urante commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824267968 We may want to upgrade `tempConnectors` from a regular `Map` to a `ConcurrentMap` as well, LGTM otherwise though. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617773890 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -321,22 +339,17 @@ public void replay(PartitionRecor

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617785244 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1053,62 @@ void validateManualPartitionAss

[GitHub] [kafka] ableegoldman merged pull request #10570: MINOR: Bump to latest version 2.6.2

2021-04-21 Thread GitBox
ableegoldman merged pull request #10570: URL: https://github.com/apache/kafka/pull/10570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] Naros commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
Naros commented on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824277958 @C0urante @rhauch , could either of you review this to see if its acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ableegoldman commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617805969 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -667,8 +668,15 @@ public boolean isProcessabl

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante commented on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something like th

[GitHub] [kafka] C0urante edited a comment on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante edited a comment on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something

[GitHub] [kafka] C0urante edited a comment on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

2021-04-21 Thread GitBox
C0urante edited a comment on pull request #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-824292010 Hmm... I'm wondering if this might break existing setups. Since the `SchemaBuilder` class does implement the `Schema` interface, it's currently possible to do something

[jira] [Commented] (KAFKA-12696) Add standard getters to LagInfo class to allow automatic serialization

2021-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326845#comment-17326845 ] Matthias J. Sax commented on KAFKA-12696: - {quote}Ok. Just to confirm, the confl

[GitHub] [kafka] kpatelatwork commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824299926 > We may want to upgrade `tempConnectors` from a regular `Map` to a `ConcurrentMap` as well, LGTM otherwise though. it's already a ConcurrentHashMap :). `priva

[GitHub] [kafka] C0urante commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
C0urante commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824300835 Sure, I mean this: ```java private ConcurrentMap tempConnectors = new ConcurrentHashMap<>(); ``` -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326860#comment-17326860 ] Matthias J. Sax commented on KAFKA-10493: - Thinking about this ticket once more,

[GitHub] [kafka] kpatelatwork commented on pull request #10580: KAFKA-12704 Fixed potential concurrency issue in connector creation

2021-04-21 Thread GitBox
kpatelatwork commented on pull request #10580: URL: https://github.com/apache/kafka/pull/10580#issuecomment-824306271 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] ableegoldman opened a new pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman opened a new pull request #10581: URL: https://github.com/apache/kafka/pull/10581 Seems this was missed to add during the original 2.6.0 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] ableegoldman opened a new pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman opened a new pull request #10582: URL: https://github.com/apache/kafka/pull/10582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [kafka] ableegoldman merged pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman merged pull request #10582: URL: https://github.com/apache/kafka/pull/10582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[jira] [Commented] (KAFKA-5761) Serializer API should support ByteBuffer

2021-04-21 Thread Kirill Rodionov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326876#comment-17326876 ] Kirill Rodionov commented on KAFKA-5761: If we're talking pooled/reused buffers (

[jira] [Comment Edited] (KAFKA-5761) Serializer API should support ByteBuffer

2021-04-21 Thread Kirill Rodionov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326876#comment-17326876 ] Kirill Rodionov edited comment on KAFKA-5761 at 4/21/21, 7:54 PM: -

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617836508 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617836508 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] ableegoldman commented on pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-21 Thread GitBox
ableegoldman commented on pull request #10582: URL: https://github.com/apache/kafka/pull/10582#issuecomment-824320067 Cherrypicked back to 2.8 and 2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] mjsax commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r617826977 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -642,9 +647,13 @@ public void beginTransaction() throws Pro

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617839610 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617842172 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] mjsax commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-21 Thread GitBox
mjsax commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824325232 > All of them already had the checks. Sweet. I did not double check the code before. Seems, `put(final Windowed sessionKey,...)` and `remove(final Windowed sessionKe

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617844560 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] ableegoldman commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617845243 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23",

[GitHub] [kafka] ableegoldman closed pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
ableegoldman closed pull request #10581: URL: https://github.com/apache/kafka/pull/10581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

2021-04-21 Thread GitBox
wcarlson5 commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r617857575 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -667,8 +668,15 @@ public boolean isProcessable(f

[jira] [Commented] (KAFKA-12701) NPE in MetadataRequest when using topic IDs

2021-04-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326909#comment-17326909 ] Justine Olshan commented on KAFKA-12701: [~dengziming] I can work on the 2.8 ver

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r617858509 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String diff(PartitionControlInfo

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-21 Thread GitBox
junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r617904827 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractApiMessageAndVersionSerde.java ## @@ -0,0 +1

[jira] [Created] (KAFKA-12705) Task idling is not sufficiently tested

2021-04-21 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12705: -- Summary: Task idling is not sufficiently tested Key: KAFKA-12705 URL: https://issues.apache.org/jira/browse/KAFKA-12705 Project: Kafka Issue Type: Improv

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617935620 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617936154 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[GitHub] [kafka] mjsax commented on a change in pull request #10581: HOTFIX: kafka streams lib missing in dependencies.gradle

2021-04-21 Thread GitBox
mjsax commented on a change in pull request #10581: URL: https://github.com/apache/kafka/pull/10581#discussion_r617936154 ## File path: gradle/dependencies.gradle ## @@ -166,6 +166,7 @@ libs += [ kafkaStreams_23: "org.apache.kafka:kafka-streams:$versions.kafka_23", kafkaS

[jira] [Created] (KAFKA-12706) Consider adding reason and source of error in APPLICATION_SHUTDOWN

2021-04-21 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12706: -- Summary: Consider adding reason and source of error in APPLICATION_SHUTDOWN Key: KAFKA-12706 URL: https://issues.apache.org/jira/browse/KAFKA-12706

[jira] [Assigned] (KAFKA-9772) Transactional offset commit fails with IllegalStateException

2021-04-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-9772: -- Assignee: Jason Gustafson > Transactional offset commit fails with IllegalStateExcepti

  1   2   >