[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613799479 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] chia7712 commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

chia7712 commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r613807365 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -242,87 +253,99 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] chia7712 commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

chia7712 commented on a change in pull request #9861: URL: https://github.com/apache/kafka/pull/9861#discussion_r613807678 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -104,7 +104,7 @@ private final RocksDBMetricsRec

[GitHub] [kafka] showuon opened a new pull request #10541: KAFKA-12284: increase request timeout to make tests reliable

showuon opened a new pull request #10541: URL: https://github.com/apache/kafka/pull/10541 The `MirrorConnectorsIntegrationTests` recently failed with ``` TimeoutException: The request timed out. ``` quite frequently. After investigation, the reason is the `createTopic` in the s

[GitHub] [kafka] showuon commented on pull request #10541: KAFKA-12284: increase request timeout to make tests reliable

showuon commented on pull request #10541: URL: https://github.com/apache/kafka/pull/10541#issuecomment-820175418 @mimaison @ning2008wisc , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613799479 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613804832 ## File path: core/src/main/scala/kafka/log/LogLoader.scala ## @@ -0,0 +1,526 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[jira] [Created] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

Travis Bischel created KAFKA-12671: -- Summary: Out of order processing with a transactional producer can lead to a stuck LastStableOffset Key: KAFKA-12671 URL: https://issues.apache.org/jira/browse/KAFKA-12671

[GitHub] [kafka] highluck commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

highluck commented on a change in pull request #9861: URL: https://github.com/apache/kafka/pull/9861#discussion_r613861045 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -104,7 +104,7 @@ private final RocksDBMetricsRec

[GitHub] [kafka] stanislavkozlovski commented on pull request #10539: Minor: Move trogdor out of tools and into its own project

stanislavkozlovski commented on pull request #10539: URL: https://github.com/apache/kafka/pull/10539#issuecomment-820230424 I echo Colin's comments. Otherwise looks great. I just ran through the TROGDOR readme (https://github.com/apache/kafka/blob/trunk/TROGDOR.md) and it works great! --

[GitHub] [kafka] stanislavkozlovski edited a comment on pull request #10539: Minor: Move trogdor out of tools and into its own project

stanislavkozlovski edited a comment on pull request #10539: URL: https://github.com/apache/kafka/pull/10539#issuecomment-820230424 I echo Colin's comments. Otherwise looks great. I just built the project (with 4b6c476) and ran through the TROGDOR readme (https://github.com/apache/kafka/blo

[jira] [Commented] (KAFKA-7748) Add wall clock TimeDefinition for suppression of intermediate events

[ https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322023#comment-17322023 ] Andrey Bratus commented on KAFKA-7748: -- Hi [~cosbor11], for a simple use case I wor

[GitHub] [kafka] highluck commented on pull request #9861: MINOR: Modify unnecessary access specifiers

highluck commented on pull request #9861: URL: https://github.com/apache/kafka/pull/9861#issuecomment-820267214 @chia7712 Thank you for the comment Code was modified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r613873623 ## File path: storage/src/main/resources/message/RemoteLogSegmentMetadata.json ## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r613882988 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r613882988 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r613882988 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] kowshik commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

kowshik commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r613882988 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r613795734 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason { @th

[GitHub] [kafka] mimaison commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

mimaison commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r613913901 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] tombentley commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

tombentley commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r613926107 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] mimaison commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

mimaison commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r613931955 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] mimaison commented on pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

mimaison commented on pull request #9549: URL: https://github.com/apache/kafka/pull/9549#issuecomment-820299395 Not sure why the build had failed, I've rekicked it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Assigned] (KAFKA-12662) add unit test for ProducerPerformance

[ https://issues.apache.org/jira/browse/KAFKA-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chun-Hao Tang reassigned KAFKA-12662: - Assignee: Chun-Hao Tang > add unit test for ProducerPerformance > -

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322092#comment-17322092 ] Alexis Polyzos commented on KAFKA-12635: [~yangguo1220] thanks for the reply! We

[GitHub] [kafka] showuon closed pull request #10541: KAFKA-12284: increase request timeout to make tests reliable

showuon closed pull request #10541: URL: https://github.com/apache/kafka/pull/10541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] showuon commented on pull request #10541: KAFKA-12284: increase request timeout to make tests reliable

showuon commented on pull request #10541: URL: https://github.com/apache/kafka/pull/10541#issuecomment-820346080 Need to rework. Close it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614002154 ## File path: storage/src/main/resources/message/RemoteLogSegmentMetadata.json ## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614004395 ## File path: storage/src/main/resources/message/RemoteLogSegmentMetadataUpdate.json ## @@ -0,0 +1,83 @@ +// Licensed to the Apache Software Foundation (

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614031843 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614064785 ## File path: storage/src/main/resources/message/RemoteLogSegmentMetadata.json ## @@ -0,0 +1,126 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614066999 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogSegmentMetadataSerde.java ## @@ -0,0 +1,87 @@ +/*

[GitHub] [kafka] ijuma commented on a change in pull request #10498: MINOR: remove `checksumOrNull` and `isValid` from Record

ijuma commented on a change in pull request #10498: URL: https://github.com/apache/kafka/pull/10498#discussion_r614068123 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -279,8 +279,10 @@ object DumpLogSegments { if (batch.magic >= Rec

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614071198 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogSegmentMetadataSerde.java ## @@ -0,0 +1,87 @@ +/*

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614083593 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serde/RemoteLogMetadataContextSerde.java ## @@ -0,0 +1,115 @@ +/*

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-820437818 Thanks @kowshik for the review. Addressed them with the latest [5250b79](https://github.com/apache/kafka/pull/10271/commits/5250b79cef6d21c73d2b2a12ef7cd95a00e9f034). -- This

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-820438379 @junrao This PR is rebased with the latest trunk and it is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614098535 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final ProcessorGraphN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614105673 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final ProcessorGraphN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614114447 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -60,20 +82,41 @@ } private class K

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614126665 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitter.java ## @@ -105,6 +105,11 @@ public void remo

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614129645 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java ## @@ -120,6 +120,13 @@ public synchronized bo

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614129645 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java ## @@ -120,6 +120,13 @@ public synchronized bo

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614129645 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java ## @@ -120,6 +120,13 @@ public synchronized bo

[GitHub] [kafka] dajac commented on pull request #10540: MINOR: update default for field in DeleteTopicsRequest

dajac commented on pull request #10540: URL: https://github.com/apache/kafka/pull/10540#issuecomment-820497042 Test failures are not related. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] dajac merged pull request #10540: MINOR: update default for field in DeleteTopicsRequest

dajac merged pull request #10540: URL: https://github.com/apache/kafka/pull/10540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] vamossagar12 opened a new pull request #10542: Kafka 12313: Streamling windowed Deserialiser configs.

vamossagar12 opened a new pull request #10542: URL: https://github.com/apache/kafka/pull/10542 This PR aims to streamline the configurations for WindowedDeserialisers. It deprecates default.windowed.key.serde.inner and default.windowed.value.serde.inner configs in StreamConfig and adds wi

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614161831 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java ## @@ -662,20 +666,94 @@ public void testSend

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614162085 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java ## @@ -662,20 +666,94 @@ public void testSend

[GitHub] [kafka] kpatelatwork commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on pull request #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-820517908 @C0urante overall looks good but as I am new to the code, I tried my best to review but I recommend getting a LGTM from one more reviewer also who knows this code better t

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Description: If there is pathological processing of incoming produce requests and EndTxn re

[GitHub] [kafka] kpatelatwork edited a comment on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork edited a comment on pull request #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-820517908 @C0urante overall looks good and very good job on the tests but as I am new to the code, I tried my best to review but I recommend getting a LGTM from one more revi

[GitHub] [kafka] wcarlson5 commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

wcarlson5 commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r614166802 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -248,7 +257,7 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] wcarlson5 commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

wcarlson5 commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r614166802 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -248,7 +257,7 @@ private void parseArguments(final String[] args) {

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322296#comment-17322296 ] Haoran Xuan commented on KAFKA-12574: - Hi, previously I was working on KAFKA-9689, i

[GitHub] [kafka] C0urante commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

C0urante commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614207888 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitter.java ## @@ -105,6 +105,11 @@ public void remove(C

[GitHub] [kafka] C0urante commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

C0urante commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614208181 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/OffsetStorageWriter.java ## @@ -120,6 +120,13 @@ public synchronized boolea

[GitHub] [kafka] C0urante commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

C0urante commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614208924 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java ## @@ -662,20 +666,94 @@ public void testSendReco

[GitHub] [kafka] JoelWee commented on pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

JoelWee commented on pull request #8923: URL: https://github.com/apache/kafka/pull/8923#issuecomment-820560188 Thanks @ableegoldman and @wcarlson5! Will try to get this done over the next week or so and ping you when ready :) -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mumrah commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

mumrah commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r614218074 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -197,15 +209,73 @@ private MockController(Collection initialTopics) { @Overri

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

kpatelatwork commented on a change in pull request #10528: URL: https://github.com/apache/kafka/pull/10528#discussion_r614230413 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceTaskOffsetCommitter.java ## @@ -105,6 +105,11 @@ public void remo

[GitHub] [kafka] cmccabe merged pull request #10538: MINOR: shutdown KafkaScheduler at appropriate time

cmccabe merged pull request #10538: URL: https://github.com/apache/kafka/pull/10538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (KAFKA-12672) Running test-kraft-server-start results in error

Bill Bejeck created KAFKA-12672: --- Summary: Running test-kraft-server-start results in error Key: KAFKA-12672 URL: https://issues.apache.org/jira/browse/KAFKA-12672 Project: Kafka Issue Type: Bu

[GitHub] [kafka] Iskuskov commented on pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

Iskuskov commented on pull request #9541: URL: https://github.com/apache/kafka/pull/9541#issuecomment-820596386 @chia7712, @ijuma, could you take a look at this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (KAFKA-12672) Running test-kraft-server-start results in error

[ https://issues.apache.org/jira/browse/KAFKA-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-12672: Description: Running the {{test-kraft-server-start}} script in the {{raft}} module results in thi

[GitHub] [kafka] cmccabe commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

cmccabe commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r614264455 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -242,87 +253,99 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] chia7712 commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

chia7712 commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r614266078 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -242,87 +253,99 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] wcarlson5 opened a new pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to

wcarlson5 opened a new pull request #10543: URL: https://github.com/apache/kafka/pull/10543 change each StreamsException so that it has the sub topology name in it ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test co

[GitHub] [kafka] wcarlson5 commented on pull request #10543: KAFKA-12648: tag uses of StreamsException to add Named to

wcarlson5 commented on pull request #10543: URL: https://github.com/apache/kafka/pull/10543#issuecomment-820610403 @ableegoldman I tagged all the cases of StreamsExceptions that I think can be attributed to a Sub topology. I may have missed some and some might not be attributable. Also the

[GitHub] [kafka] cmccabe merged pull request #10505: MINOR: fix some bugs in ControllerApis.scala

cmccabe merged pull request #10505: URL: https://github.com/apache/kafka/pull/10505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Updated] (KAFKA-12671) Out of order processing with a transactional producer can lead to a stuck LastStableOffset

[ https://issues.apache.org/jira/browse/KAFKA-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Bischel updated KAFKA-12671: --- Description: If there is pathological processing of incoming produce requests and EndTxn re

[GitHub] [kafka] wcarlson5 opened a new pull request #10544: KAFKA-12648: minimal changes for error handling namedTopologies

wcarlson5 opened a new pull request #10544: URL: https://github.com/apache/kafka/pull/10544 changed the obvious ones to attribute to a named topology. This might be all we need, we can always add more if they come up. ### Committer Checklist (excluded from commit message) - [ ] Ve

[GitHub] [kafka] wcarlson5 commented on pull request #10544: KAFKA-12648: minimal changes for error handling namedTopologies

wcarlson5 commented on pull request #10544: URL: https://github.com/apache/kafka/pull/10544#issuecomment-820620451 @ableegoldman This is what I think the error handling should look like. We can try to categorize more but I think we should make this best effort and we can add to it as we go

[jira] [Created] (KAFKA-12673) Kafka and zookeeper dependency

suhas created KAFKA-12673: - Summary: Kafka and zookeeper dependency Key: KAFKA-12673 URL: https://issues.apache.org/jira/browse/KAFKA-12673 Project: Kafka Issue Type: Task Reporter: suhas

[jira] [Updated] (KAFKA-12672) Running test-kraft-server-start results in error

[ https://issues.apache.org/jira/browse/KAFKA-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-12672: Description: Running the {{test-kraft-server-start}} script in the {{raft}} module results in thi

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614303123 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final K

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614304330 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final K

[GitHub] [kafka] cmccabe merged pull request #10539: Minor: Move trogdor out of tools and into its own project

cmccabe merged pull request #10539: URL: https://github.com/apache/kafka/pull/10539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614312224 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +263,66 @@ private void assertUniqueStoreN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614312924 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +263,66 @@ private void assertUniqueStoreN

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614313362 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final K

[GitHub] [kafka] bbejeck opened a new pull request #10545: KAFKA-12672: Added config for raft testing server

bbejeck opened a new pull request #10545: URL: https://github.com/apache/kafka/pull/10545 Adding a property to the `raft/config/kraft.properties` for running the raft test server in development. For testing I ran `./bin/test-kraft-server-start.sh --config config/kraft.properties` an

[GitHub] [kafka] ijuma commented on pull request #10545: KAFKA-12672: Added config for raft testing server

ijuma commented on pull request #10545: URL: https://github.com/apache/kafka/pull/10545#issuecomment-820659248 Thanks for the PR. Don't you need to update the multi-node-quorum section? https://github.com/apache/kafka/tree/trunk/raft#run-multi-node-quorum -- This is an automated message

[GitHub] [kafka] cmccabe commented on pull request #10505: MINOR: fix some bugs in ControllerApis.scala

cmccabe commented on pull request #10505: URL: https://github.com/apache/kafka/pull/10505#issuecomment-820659355 @chia7712: I re-ran the test failures locally and couldn't get them to occur. The failures I saw were mostly streams tests... those have have been a bit flaky lately... I

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322417#comment-17322417 ] Guozhang Wang commented on KAFKA-12574: --- Hi [~feyman] I'm aware of KAFKA-9689 as w

[GitHub] [kafka] bbejeck commented on pull request #10545: KAFKA-12672: Added config for raft testing server

bbejeck commented on pull request #10545: URL: https://github.com/apache/kafka/pull/10545#issuecomment-820665466 @ijuma updated README -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

wcarlson5 commented on a change in pull request #10544: URL: https://github.com/apache/kafka/pull/10544#discussion_r614398757 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1198,7 +1210,7 @@ int process(final int maxNum

[GitHub] [kafka] cmccabe commented on a change in pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

cmccabe commented on a change in pull request #10463: URL: https://github.com/apache/kafka/pull/10463#discussion_r614404680 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1148,113 @@ void validateManualPartitionAs

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

wcarlson5 commented on a change in pull request #10544: URL: https://github.com/apache/kafka/pull/10544#discussion_r614398250 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -471,6 +472,10 @@ private void replaceStreamThread(final Throwable

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10544: KAFKA-12648: minimum changes for error handling namedTopologies

wcarlson5 commented on a change in pull request #10544: URL: https://github.com/apache/kafka/pull/10544#discussion_r614398250 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -471,6 +472,10 @@ private void replaceStreamThread(final Throwable

[GitHub] [kafka] guozhangwang commented on pull request #10294: KAFKA-12450: Remove deprecated methods from ReadOnlyWindowStore

guozhangwang commented on pull request #10294: URL: https://github.com/apache/kafka/pull/10294#issuecomment-820756041 @jeqo could you rebase the PR while I review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322537#comment-17322537 ] Jitesh Motwani commented on KAFKA-12468: [~askldjd]  what do you mean by run 10

[jira] [Comment Edited] (KAFKA-12468) Initial offsets are copied from source to target cluster

[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322537#comment-17322537 ] Jitesh Motwani edited comment on KAFKA-12468 at 4/15/21, 11:52 PM: ---

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r614448708 ## File path: storage/src/main/resources/message/RemotePartitionDeleteMetadata.json ## @@ -0,0 +1,68 @@ +// Licensed to the Apache Software Foundation (ASF

[jira] [Created] (KAFKA-12674) Client failover takes 2-4 seconds on clean broker shutdown

Gwen Shapira created KAFKA-12674: Summary: Client failover takes 2-4 seconds on clean broker shutdown Key: KAFKA-12674 URL: https://issues.apache.org/jira/browse/KAFKA-12674 Project: Kafka Is

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r614534849 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final ProcessorGraphN

  1   2   >