[jira] [Commented] (KAFKA-7421) Deadlock in Kafka Connect

[ https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290761#comment-17290761 ] Konstantine Karantasis commented on KAFKA-7421: --- The suggested fix suggeste

[GitHub] [kafka] chia7712 commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

chia7712 commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r582599257 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[jira] [Updated] (KAFKA-12308) ConfigDef.parseType deadlock

[ https://issues.apache.org/jira/browse/KAFKA-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12308: --- Component/s: KafkaConnect > ConfigDef.parseType deadlock > -

[jira] [Comment Edited] (KAFKA-12308) ConfigDef.parseType deadlock

[ https://issues.apache.org/jira/browse/KAFKA-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290756#comment-17290756 ] Konstantine Karantasis edited comment on KAFKA-12308 at 2/25/21, 8:10 AM:

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9717: KAFKA-10766: Unit test cases for RocksDBRangeIterator

vamossagar12 commented on a change in pull request #9717: URL: https://github.com/apache/kafka/pull/9717#discussion_r582629479 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java ## @@ -0,0 +1,447 @@ +/* + * Licensed to th

[GitHub] [kafka] nicodds opened a new pull request #10207: Fixing documentation source for issue KAFKA-12360

nicodds opened a new pull request #10207: URL: https://github.com/apache/kafka/pull/10207 This PR fixes de documentation issue in https://issues.apache.org/jira/browse/KAFKA-12360 This is an automated message from the Ap

[jira] [Commented] (KAFKA-12360) Improve documentation of max.task.idle.ms (kafka-streams)

[ https://issues.apache.org/jira/browse/KAFKA-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290778#comment-17290778 ] ASF GitHub Bot commented on KAFKA-12360: nicodds commented on pull request #333:

[GitHub] [kafka] ijuma commented on a change in pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

ijuma commented on a change in pull request #10059: URL: https://github.com/apache/kafka/pull/10059#discussion_r582643189 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilderUtils.java ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] ijuma commented on a change in pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

ijuma commented on a change in pull request #10059: URL: https://github.com/apache/kafka/pull/10059#discussion_r582643189 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilderUtils.java ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (KAFKA-12308) ConfigDef.parseType deadlock

[ https://issues.apache.org/jira/browse/KAFKA-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290793#comment-17290793 ] Tom Bentley commented on KAFKA-12308: - [~kkonstantine] I'm not an expert in classloa

[GitHub] [kafka] ijuma commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

ijuma commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r582115743 ## File path: build.gradle ## @@ -219,37 +215,37 @@ subprojects { options.compilerArgs << "--release" << minJavaVersion } - uploadArchives { -

[GitHub] [kafka] ijuma commented on a change in pull request #10203: MINOR: Prepare for Gradle 7.0

ijuma commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r582672553 ## File path: build.gradle ## @@ -21,45 +21,41 @@ buildscript { repositories { mavenCentral() jcenter() -maven { - url "https://plugin

[GitHub] [kafka] cadonna commented on pull request #9717: KAFKA-10766: Unit test cases for RocksDBRangeIterator

cadonna commented on pull request #9717: URL: https://github.com/apache/kafka/pull/9717#issuecomment-785750359 Call for committer approval: @guozhangwang @ableegoldman @vvcephei @mjsax This is an automated message from the A

[GitHub] [kafka] dajac commented on a change in pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

dajac commented on a change in pull request #9958: URL: https://github.com/apache/kafka/pull/9958#discussion_r582631095 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -602,6 +765,30 @@ class GroupCoordinator(val brokerId: Int, groupE

[GitHub] [kafka] ijuma commented on pull request #10203: MINOR: Prepare for Gradle 7.0

ijuma commented on pull request #10203: URL: https://github.com/apache/kafka/pull/10203#issuecomment-785751671 @chia7712 @omkreddy Any of you have cycles to review this? We reached the end of the road when it comes to delaying the handling of these Gradle deprecations. :) ---

[GitHub] [kafka] cadonna commented on pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

cadonna commented on pull request #10052: URL: https://github.com/apache/kafka/pull/10052#issuecomment-785752484 Call for committer approval: @guozhangwang @ableegoldman @mjsax @vvcephei @abbccdda This is an automated messa

[GitHub] [kafka] tombentley commented on pull request #9847: KAFKA-10703: Better handling and doc for config defaults of topics

tombentley commented on pull request #9847: URL: https://github.com/apache/kafka/pull/9847#issuecomment-785763984 Thanks @rondagostino. @chia7712 @cmccabe would one of you be able to take a look? This is an automated

[GitHub] [kafka] mvpydq opened a new pull request #10208: add a conf for user to force select record version and then decides p…

mvpydq opened a new pull request #10208: URL: https://github.com/apache/kafka/pull/10208 …roduce api version *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] mvpydq closed pull request #10208: add a conf for user to force select record version and then decides p…

mvpydq closed pull request #10208: URL: https://github.com/apache/kafka/pull/10208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mvpydq opened a new pull request #10209: add a conf for user to force select record version and then decides p…

mvpydq opened a new pull request #10209: URL: https://github.com/apache/kafka/pull/10209 …roduce api version *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Commented] (KAFKA-7641) Add `consumer.group.max.size` to cap consumer metadata size on broker

[ https://issues.apache.org/jira/browse/KAFKA-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290983#comment-17290983 ] Justin Jack commented on KAFKA-7641: So sorry Stanislav for the confusion on my wordi

[GitHub] [kafka] vamossagar12 commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

vamossagar12 commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-786004816 @hachikuji , there were some merge conflicts which needed to be resolved. Can you plz review the PR whenever you get the chance ? ---

[GitHub] [kafka] rhauch commented on a change in pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

rhauch commented on a change in pull request #9950: URL: https://github.com/apache/kafka/pull/9950#discussion_r582985853 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java ## @@ -39,12 +40,8 @@ import org.slf4j.Logger; import org.slf

[jira] [Commented] (KAFKA-8206) A consumer can't discover new group coordinator when the cluster was partly restarted

[ https://issues.apache.org/jira/browse/KAFKA-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291049#comment-17291049 ] Rajamanickam Andrews Joseph commented on KAFKA-8206: [~ivanyu] [~guoz

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583065414 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] hachikuji commented on a change in pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

hachikuji commented on a change in pull request #9958: URL: https://github.com/apache/kafka/pull/9958#discussion_r583066513 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala ## @@ -430,7 +429,7 @@ private[group] class GroupMetadata(val groupId: Strin

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583077539 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084592 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -541,6 +559,57 @@ static void validateNewTopicNames

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084809 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084940 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] rondagostino opened a new pull request #10210: MINOR: fix syntax error in upgrade_test.py

rondagostino opened a new pull request #10210: URL: https://github.com/apache/kafka/pull/10210 Fixes a syntax error introduced in https://github.com/apache/kafka/pull/10105 that is causing 39 system tests to fail. ### Committer Checklist (excluded from commit message) - [ ] Verif

[jira] [Assigned] (KAFKA-8206) A consumer can't discover new group coordinator when the cluster was partly restarted

[ https://issues.apache.org/jira/browse/KAFKA-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Yurchenko reassigned KAFKA-8206: - Assignee: (was: Ivan Yurchenko) > A consumer can't discover new group coordinator wh

[GitHub] [kafka] guozhangwang commented on pull request #10205: KAFKA-12323 Follow-up: Refactor the unit test a bit

guozhangwang commented on pull request #10205: URL: https://github.com/apache/kafka/pull/10205#issuecomment-786132416 @mjsax updated. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

Tomasz Nguyen created KAFKA-12375: - Summary: ReplaceStreamThread creates a new consumer with the same name as the one it's replacing Key: KAFKA-12375 URL: https://issues.apache.org/jira/browse/KAFKA-12375

[GitHub] [kafka] hachikuji commented on a change in pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

hachikuji commented on a change in pull request #9958: URL: https://github.com/apache/kafka/pull/9958#discussion_r583102652 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala ## @@ -247,16 +250,20 @@ private[group] class GroupMetadata(val groupId: Str

[GitHub] [kafka] hachikuji commented on a change in pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

hachikuji commented on a change in pull request #9958: URL: https://github.com/apache/kafka/pull/9958#discussion_r583102652 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala ## @@ -247,16 +250,20 @@ private[group] class GroupMetadata(val groupId: Str

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291178#comment-17291178 ] A. Sophie Blee-Goldman commented on KAFKA-12375: Possible blocker for 2.

[jira] [Assigned] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12375: -- Assignee: Tomasz Nguyen > ReplaceStreamThread creates a new consumer

[GitHub] [kafka] rohitrmd commented on pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

rohitrmd commented on pull request #9744: URL: https://github.com/apache/kafka/pull/9744#issuecomment-786156966 @mjsax have i missed 228 deadline for this pr? This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] cmccabe merged pull request #10210: MINOR: fix syntax error in upgrade_test.py

cmccabe merged pull request #10210: URL: https://github.com/apache/kafka/pull/10210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583138415 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583148687 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -599,21 +606,30 @@ private[log] class Cleaner(val id: Int, } currentS

[GitHub] [kafka] guozhangwang commented on a change in pull request #10137: KAFKA-12268: Implement task idling semantics via currentLag API

guozhangwang commented on a change in pull request #10137: URL: https://github.com/apache/kafka/pull/10137#discussion_r583151649 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -211,7 +192,7 @@ public boolean readyToPr

[GitHub] [kafka] C0urante commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

C0urante commented on a change in pull request #10112: URL: https://github.com/apache/kafka/pull/10112#discussion_r583154155 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -475,11 +476,15 @@ public boolean commitOffsets

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583157017 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int, transactionMetadata

[jira] [Updated] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12375: - Priority: Blocker (was: Major) > ReplaceStreamThread creates a new consumer with the same name

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291209#comment-17291209 ] John Roesler commented on KAFKA-12375: -- Thanks, all. The 2.8 branch is not yet stab

[GitHub] [kafka] wcarlson5 opened a new pull request #10211: KAFKA-12347: updating TaskMetadata (WIP)

wcarlson5 opened a new pull request #10211: URL: https://github.com/apache/kafka/pull/10211 adding fields to taskMetadata ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] wcarlson5 closed pull request #10180: KAFKA- 12347: expose offsets to streams client (WIP)

wcarlson5 closed pull request #10180: URL: https://github.com/apache/kafka/pull/10180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] wcarlson5 commented on pull request #10180: KAFKA- 12347: expose offsets to streams client (WIP)

wcarlson5 commented on pull request #10180: URL: https://github.com/apache/kafka/pull/10180#issuecomment-786196837 Is moved to https://github.com/apache/kafka/pull/10211 This is an automated message from the Apache Git Servic

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583177672 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int, transactionMetadata.a

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583179618 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages ar

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583183607 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int, transactionMetadata.a

[GitHub] [kafka] hachikuji commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

hachikuji commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583179618 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages ar

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583183607 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -582,13 +586,16 @@ private[log] class Cleaner(val id: Int, transactionMetadata.a

[jira] [Commented] (KAFKA-12375) ReplaceStreamThread creates a new consumer with the same name as the one it's replacing

[ https://issues.apache.org/jira/browse/KAFKA-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291220#comment-17291220 ] Bruno Cadonna commented on KAFKA-12375: --- I do not think that the {{java.util.Concu

[GitHub] [kafka] C0urante commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

C0urante commented on a change in pull request #10112: URL: https://github.com/apache/kafka/pull/10112#discussion_r583154155 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -475,11 +476,15 @@ public boolean commitOffsets

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583203466 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583202007 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -209,6 +209,11 @@ case object LeaderOffsetIncremented extends LogStartOffsetIncrementReason {

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583208987 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583211123 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] hachikuji commented on a change in pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

hachikuji commented on a change in pull request #10112: URL: https://github.com/apache/kafka/pull/10112#discussion_r583219431 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -475,11 +476,15 @@ public boolean commitOffset

[jira] [Created] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

Jose Armando Garcia Sancio created KAFKA-12376: -- Summary: Use scheduleAtomicAppend for records that need to be atomic Key: KAFKA-12376 URL: https://issues.apache.org/jira/browse/KAFKA-12376

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583226737 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -675,6 +676,7 @@ object KafkaConfig { "KIP-500. If it is not set, the met

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583228799 ## File path: tests/kafkatest/sanity_checks/test_verifiable_producer.py ## @@ -96,4 +96,59 @@ def test_simple_run(self, producer_version, security_p

[jira] [Assigned] (KAFKA-12376) Use scheduleAtomicAppend for records that need to be atomic

[ https://issues.apache.org/jira/browse/KAFKA-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12376: Assignee: Jose Armando Garcia Sancio > Use scheduleAtomicAppend for records that need to

[GitHub] [kafka] cmccabe commented on pull request #10194: KAFKA-12365; Disable transactional APIs on KIP-500 broker

cmccabe commented on pull request #10194: URL: https://github.com/apache/kafka/pull/10194#issuecomment-786257147 The approach LGTM to me. Can you also disable the relevant system test(s) in this PR? Agree that we need to disable a few more things -- reassignment is one --

[jira] [Updated] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

[ https://issues.apache.org/jira/browse/KAFKA-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10101: Fix Version/s: 2.8.0 > recovery point is advanced without flushing the data after recovery > -

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583240035 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -250,14 +252,16 @@ def setup_sasl(self, node): 'is_ibm_

[GitHub] [kafka] rondagostino commented on a change in pull request #10199: KAFKA-12374: Add missing config sasl.mechanism.controller.protocol

rondagostino commented on a change in pull request #10199: URL: https://github.com/apache/kafka/pull/10199#discussion_r583240514 ## File path: tests/kafkatest/services/security/security_config.py ## @@ -343,6 +347,17 @@ def interbroker_sasl_mechanism(self): def enabled_sas

[GitHub] [kafka] cmccabe merged pull request #10200: KAFKA-12367; Ensure partition epoch is propagated to `Partition` state

cmccabe merged pull request #10200: URL: https://github.com/apache/kafka/pull/10200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on a change in pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

cmccabe commented on a change in pull request #9990: URL: https://github.com/apache/kafka/pull/9990#discussion_r583245201 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConf

[GitHub] [kafka] cmccabe commented on a change in pull request #9990: KAFKA-12235: Fix ZkAdminManager.describeConfigs on 2+ config keys

cmccabe commented on a change in pull request #9990: URL: https://github.com/apache/kafka/pull/9990#discussion_r583245201 ## File path: core/src/main/scala/kafka/server/ConfigHelper.scala ## @@ -47,11 +47,11 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConf

[GitHub] [kafka] cmccabe commented on a change in pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on a change in pull request #10184: URL: https://github.com/apache/kafka/pull/10184#discussion_r583084940 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -195,6 +201,147 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] hachikuji commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583247616 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_

[GitHub] [kafka] hachikuji commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583247616 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_

[GitHub] [kafka] cmccabe commented on pull request #10184: MINOR: enable topic deletion in the KIP-500 controller

cmccabe commented on pull request #10184: URL: https://github.com/apache/kafka/pull/10184#issuecomment-786277018 rebased on trunk This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583254723 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_CO

[GitHub] [kafka] hachikuji commented on pull request #10179: MINOR: tune KIP-631 configurations

hachikuji commented on pull request #10179: URL: https://github.com/apache/kafka/pull/10179#issuecomment-786277818 Overall, I'm ok with the lower timeouts for 2.8. I do think it's highly likely we'll end up increasing them after we get some operational experience with the new code. It's ju

[GitHub] [kafka] cmccabe commented on pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on pull request #10179: URL: https://github.com/apache/kafka/pull/10179#issuecomment-786277886 > We have a hard-coded fetch max wait time here: https://github.com/apache/kafka/blob/trunk/raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java#L143. I think it would

[GitHub] [kafka] cmccabe commented on a change in pull request #10179: MINOR: tune KIP-631 configurations

cmccabe commented on a change in pull request #10179: URL: https://github.com/apache/kafka/pull/10179#discussion_r583254723 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -79,12 +84,12 @@ public static final String QUORUM_REQUEST_TIMEOUT_MS_CO

[GitHub] [kafka] mjsax commented on pull request #10207: Fixing documentation source for issue KAFKA-12360

mjsax commented on pull request #10207: URL: https://github.com/apache/kafka/pull/10207#issuecomment-786280723 Thanks @nicodds! This PR should also update https://github.com/apache/kafka/blob/trunk/docs/streams/developer-guide/config-streams.html#L245-L246 -

[jira] [Commented] (KAFKA-8059) Flaky Test DynamicConnectionQuotaTest #testDynamicConnectionQuota

[ https://issues.apache.org/jira/browse/KAFKA-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291275#comment-17291275 ] Matthias J. Sax commented on KAFKA-8059: [https://github.com/apache/kafka/pull/10

[jira] [Commented] (KAFKA-8083) Flaky Test DelegationTokenRequestsTest#testDelegationTokenRequests

[ https://issues.apache.org/jira/browse/KAFKA-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291276#comment-17291276 ] Matthias J. Sax commented on KAFKA-8083: [https://github.com/apache/kafka/pull/10

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291278#comment-17291278 ] Matthias J. Sax commented on KAFKA-12283: - [https://github.com/apache/kafka/pull

[jira] [Updated] (KAFKA-10619) Producer will enable EOS by default

[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10619: - Description: This is an after-work for KIP-185.  In the producer config, # the default value o

[jira] [Commented] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291279#comment-17291279 ] Matthias J. Sax commented on KAFKA-8529: [https://github.com/apache/kafka/pull/10

[GitHub] [kafka] mjsax commented on a change in pull request #10205: KAFKA-12323 Follow-up: Refactor the unit test a bit

mjsax commented on a change in pull request #10205: URL: https://github.com/apache/kafka/pull/10205#discussion_r583261570 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java ## @@ -1936,8 +1934,8 @@ public void process(final O

[jira] [Commented] (KAFKA-10619) Producer will enable EOS by default

[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291284#comment-17291284 ] John Roesler commented on KAFKA-10619: -- Hey [~d8tltanc] , I noticed in your PR that

[GitHub] [kafka] vvcephei commented on pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

vvcephei commented on pull request #9744: URL: https://github.com/apache/kafka/pull/9744#issuecomment-786290505 Hi @rohitrmd , I was coincidentally just reviewing the list of KIPs that made the cutoff on Feb 3rd. Sadly, yes, this feature will not make 2.8, but we should push forward

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] jolshan commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r583216706 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -701,11 +719,17 @@ private[log] class Cleaner(val id: Int, // if any messages are

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583283950 ## File path: clients/src/main/resources/common/message/DescribeClientQuotasRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 48, "type": "request", -

[GitHub] [kafka] cmccabe commented on a change in pull request #10194: KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller

cmccabe commented on a change in pull request #10194: URL: https://github.com/apache/kafka/pull/10194#discussion_r583284033 ## File path: clients/src/main/resources/common/message/DeleteTopicsRequest.json ## @@ -16,7 +16,7 @@ { "apiKey": 20, "type": "request", - "listen

[jira] [Updated] (KAFKA-12365) Block APIs not supported by kip-500 broker/controller (for now)

[ https://issues.apache.org/jira/browse/KAFKA-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12365: Summary: Block APIs not supported by kip-500 broker/controller (for now) (was: Block tran

  1   2   >