[jira] [Closed] (KAFKA-5488) KStream.branch should not return a Array of streams we have to access by known index

2021-02-05 Thread Ivan Ponomarev (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Ponomarev closed KAFKA-5488. - PR is merged to trunk to be included in 2.8.0 release > KStream.branch should not return a Array of

[GitHub] [kafka] showuon commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570831039 ## File path: docs/security.html ## @@ -320,10 +320,10 @@ SSL key and certificates in PEM format listeners If SSL is not enabl

[GitHub] [kafka] showuon commented on pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on pull request #10002: URL: https://github.com/apache/kafka/pull/10002#issuecomment-773911615 @omkreddy , thanks for the comments. I've updated it. Please help review again. Thanks. This is an automated me

[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
cadonna commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909549 Call for committer review: @guozhangwang This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
cadonna commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909411 @vamossagar12, you need to rebase your PR. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] showuon commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570832287 ## File path: docs/security.html ## @@ -434,14 +434,14 @@ listener.name.sasl_ssl.scram-sha-256.sasl.jaas.config=org.apache.kafka.common.security

[GitHub] [kafka] showuon commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570832863 ## File path: docs/security.html ## @@ -491,13 +491,13 @@ OAUTHBEARER. For example, GSSAPI credentials may be co

[GitHub] [kafka] kkonstantine commented on a change in pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2021-02-05 Thread GitBox
kkonstantine commented on a change in pull request #9780: URL: https://github.com/apache/kafka/pull/9780#discussion_r570584036 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -209,7 +229,8 @@ public Distribu

[GitHub] [kafka] C0urante commented on pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox
C0urante commented on pull request #9726: URL: https://github.com/apache/kafka/pull/9726#issuecomment-773648389 Just ran into a situation last night where this would have been super helpful. Thanks for adding this @mimaison!

[GitHub] [kafka] jsancio commented on a change in pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
jsancio commented on a change in pull request #10045: URL: https://github.com/apache/kafka/pull/10045#discussion_r570507065 ## File path: core/src/main/scala/kafka/server/MetadataSupport.scala ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mjsax commented on a change in pull request #10046: MINOR: Extends RocksDB docs

2021-02-05 Thread GitBox
mjsax commented on a change in pull request #10046: URL: https://github.com/apache/kafka/pull/10046#discussion_r570683354 ## File path: docs/streams/developer-guide/memory-mgmt.html ## @@ -168,7 +168,15 @@ RocksDB Each instance of RocksDB allocates off-heap memor

[GitHub] [kafka] JimGalasyn commented on a change in pull request #10048: MINOR: add docs for KIP-680

2021-02-05 Thread GitBox
JimGalasyn commented on a change in pull request #10048: URL: https://github.com/apache/kafka/pull/10048#discussion_r570687710 ## File path: docs/streams/upgrade-guide.html ## @@ -121,6 +121,12 @@ Streams API the constructor, such as when using the console consumer. ht

[GitHub] [kafka] gardnervickers closed pull request #10055: [2.3] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
gardnervickers closed pull request #10055: URL: https://github.com/apache/kafka/pull/10055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax commented on pull request #10000: KAFKA-9274: handle TimeoutException on task reset

2021-02-05 Thread GitBox
mjsax commented on pull request #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-773774753 Updated this PR. This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] bob-barrett commented on pull request #10055: [2.3] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
bob-barrett commented on pull request #10055: URL: https://github.com/apache/kafka/pull/10055#issuecomment-773678966 @ableegoldman the 2.6 backport is https://github.com/apache/kafka/pull/10061. This is an automated message

[GitHub] [kafka] omkreddy commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
omkreddy commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570196800 ## File path: docs/security.html ## @@ -320,10 +320,10 @@ SSL key and certificates in PEM format listeners If SSL is not enab

[GitHub] [kafka] guozhangwang commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-02-05 Thread GitBox
guozhangwang commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-773096994 This change looks good to me. @hachikuji could you take another look before we merge? This is an automated m

[GitHub] [kafka] bob-barrett commented on pull request #10067: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on pull request #10067: URL: https://github.com/apache/kafka/pull/10067#issuecomment-773800834 This is a backport of 131d475 to 2.3. As with #10061, the conflicts were due to the missing connection timeout config, which was added in 2.7, and didn't meaningfully change

[GitHub] [kafka] kkonstantine merged pull request #10053: KAFKA-10834: Remove redundant type casts in Connect

2021-02-05 Thread GitBox
kkonstantine merged pull request #10053: URL: https://github.com/apache/kafka/pull/10053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2021-02-05 Thread GitBox
tombentley commented on pull request #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-773183761 Rebased to trigger CI again. @chia7712 please could to take another look when you have the chance? This

[GitHub] [kafka] wcarlson5 commented on pull request #10060: KAFKA-10716: persist UUID in state directory for stable processId across restarts - 2.7

2021-02-05 Thread GitBox
wcarlson5 commented on pull request #10060: URL: https://github.com/apache/kafka/pull/10060#issuecomment-773820050 +1 from me. Thanks for the pr This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] mimaison commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
mimaison commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773243982 Tests passed on JDK 8. The failure on JDK 11 (`kafka.api.TransactionsTest.testAbortTransactionTimeout()`) looks unrelated. ---

[GitHub] [kafka] ableegoldman commented on pull request #10055: [2.3] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
ableegoldman commented on pull request #10055: URL: https://github.com/apache/kafka/pull/10055#issuecomment-773675180 Hey @gardnervickers , do you have plans to open a PR against 2.6 as well? Just checking in since it seems this fix has been ported to everything except 2.6 so far and I wan

[GitHub] [kafka] tombentley commented on a change in pull request #10004: MINOR : add memberId to JoinGroup Success message

2021-02-05 Thread GitBox
tombentley commented on a change in pull request #10004: URL: https://github.com/apache/kafka/pull/10004#discussion_r570162199 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -591,7 +591,7 @@ public void handle(Joi

[GitHub] [kafka] kkonstantine commented on pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox
kkonstantine commented on pull request #9726: URL: https://github.com/apache/kafka/pull/9726#issuecomment-773706451 One failure on an unrelated flaky test Merging to coordinate merge with another PR. Thanks @mimaison ! Thi

[GitHub] [kafka] gardnervickers closed pull request #10057: [2.4] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
gardnervickers closed pull request #10057: URL: https://github.com/apache/kafka/pull/10057 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
dajac commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773366825 I have picked the commit into 2.7 but could not pick it into 2.6 cleanly. @bob-barrett Could you open a PR for 2.6?

[GitHub] [kafka] cmccabe commented on pull request #10030: MINOR: Add KafkaEventQueue

2021-02-05 Thread GitBox
cmccabe commented on pull request #10030: URL: https://github.com/apache/kafka/pull/10030#issuecomment-773648975 Test failure is `org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest` which is not related.

[GitHub] [kafka] bob-barrett commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r569992543 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -106,8 +106,9 @@ public static ChannelBuilder createChannelBuilder(

[GitHub] [kafka] bob-barrett commented on pull request #10064: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on pull request #10064: URL: https://github.com/apache/kafka/pull/10064#issuecomment-773736235 This is a backport of 131d4753cfed65ed6dee0a8c754765c97c3d513f to 2.5. As with https://github.com/apache/kafka/pull/10061, the conflicts were due to the missing connection t

[GitHub] [kafka] cadonna commented on a change in pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
cadonna commented on a change in pull request #10051: URL: https://github.com/apache/kafka/pull/10051#discussion_r570139416 ## File path: docs/streams/upgrade-guide.html ## @@ -154,6 +154,14 @@ Streams API turn on all higher levels, ie INFO and DEBUG. See https://cwiki

[GitHub] [kafka] dajac commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
dajac commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r569998233 ## File path: clients/src/main/java/org/apache/kafka/clients/HostResolver.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] cadonna commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-05 Thread GitBox
cadonna commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r570207387 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void shouldRemov

[GitHub] [kafka] mimaison commented on a change in pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox
mimaison commented on a change in pull request #9726: URL: https://github.com/apache/kafka/pull/9726#discussion_r570545828 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -188,6 +188,16 @@ public Connect

[GitHub] [kafka] gardnervickers commented on pull request #10055: [2.3] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
gardnervickers commented on pull request #10055: URL: https://github.com/apache/kafka/pull/10055#issuecomment-773675865 @ableegoldman I believe @bob-barrett was working on a PR against 2.6. This is an automated message from

[GitHub] [kafka] junrao commented on a change in pull request #10030: MINOR: Add KafkaEventQueue

2021-02-05 Thread GitBox
junrao commented on a change in pull request #10030: URL: https://github.com/apache/kafka/pull/10030#discussion_r570453181 ## File path: metadata/src/main/java/org/apache/kafka/queue/EventQueue.java ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] vvcephei commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-05 Thread GitBox
vvcephei commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-773549603 Thanks, all, that Scala fix looks perfect to me. This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] mjsax commented on a change in pull request #10048: MINOR: add docs for KIP-680

2021-02-05 Thread GitBox
mjsax commented on a change in pull request #10048: URL: https://github.com/apache/kafka/pull/10048#discussion_r570698397 ## File path: docs/streams/upgrade-guide.html ## @@ -121,6 +121,12 @@ Streams API the constructor, such as when using the console consumer. https:/

[GitHub] [kafka] bob-barrett commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-773171300 @dajac @mimaison @satishd Thanks for your reviews! In addition to PR feedback, I pushed a new change to `ClusterConnectionStatesTest`. I noticed while testing locally th

[GitHub] [kafka] kkonstantine merged pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API (KIP-661)

2021-02-05 Thread GitBox
kkonstantine merged pull request #9726: URL: https://github.com/apache/kafka/pull/9726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on a change in pull request #10000: KAFKA-9274: handle TimeoutException on task reset

2021-02-05 Thread GitBox
mjsax commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r570691793 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -227,6 +230,27 @@ public void initializeIfNeeded() {

[GitHub] [kafka] hachikuji commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-773479357 @vamossagar12 Thanks, I missed the update. I will review today. This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-02-05 Thread GitBox
mjsax commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r570716520 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean init

[GitHub] [kafka] cmccabe commented on a change in pull request #10030: MINOR: Add KafkaEventQueue

2021-02-05 Thread GitBox
cmccabe commented on a change in pull request #10030: URL: https://github.com/apache/kafka/pull/10030#discussion_r570442555 ## File path: metadata/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] cmccabe commented on pull request #10047: MINOR: Add ClusterTool as specified in KIP-631

2021-02-05 Thread GitBox
cmccabe commented on pull request #10047: URL: https://github.com/apache/kafka/pull/10047#issuecomment-773516371 Test failures are not related to the PR This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on a change in pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on a change in pull request #10002: URL: https://github.com/apache/kafka/pull/10002#discussion_r570831039 ## File path: docs/security.html ## @@ -320,10 +320,10 @@ SSL key and certificates in PEM format listeners If SSL is not enabl

[GitHub] [kafka] mimaison commented on pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox
mimaison commented on pull request #9726: URL: https://github.com/apache/kafka/pull/9726#issuecomment-773567218 Thanks @kkonstantine for the feedback. I've pushed an update This is an automated message from the Apache Git Ser

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-05 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r570326339 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -348,15 +348,15 @@ class KafkaServer( /* start processing requests

[GitHub] [kafka] gardnervickers closed pull request #10058: [2.5] Backport mocked HostResolver from KAFKA-12193 to avoid relying on kafka.apache.org for specific DNS behavior

2021-02-05 Thread GitBox
gardnervickers closed pull request #10058: URL: https://github.com/apache/kafka/pull/10058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-05 Thread GitBox
vamossagar12 commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r570171267 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void should

[GitHub] [kafka] ijuma commented on pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-05 Thread GitBox
ijuma commented on pull request #10008: URL: https://github.com/apache/kafka/pull/10008#issuecomment-773069082 We finally got a non-red build, some unrelated flaky tests in JDK 11 and 15. JDK 8 passed. This is an automated m

[GitHub] [kafka] cmccabe merged pull request #10030: MINOR: Add KafkaEventQueue

2021-02-05 Thread GitBox
cmccabe merged pull request #10030: URL: https://github.com/apache/kafka/pull/10030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #10054: KAFKA-12283 Flaky Test RebalanceSourceConnectorsIntegrationTest#testM…

2021-02-05 Thread GitBox
chia7712 commented on pull request #10054: URL: https://github.com/apache/kafka/pull/10054#issuecomment-773582456 @ramesh-muthusamy Could you take a look? thanks! This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] kkonstantine commented on a change in pull request #10053: KAFKA-10834: Remove redundant type casts in Connect

2021-02-05 Thread GitBox
kkonstantine commented on a change in pull request #10053: URL: https://github.com/apache/kafka/pull/10053#discussion_r570464187 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -236,7 +236,7 @@ public Distri

[GitHub] [kafka] kkonstantine commented on a change in pull request #9726: KAFKA-10833: Expose task configurations in Connect REST API

2021-02-05 Thread GitBox
kkonstantine commented on a change in pull request #9726: URL: https://github.com/apache/kafka/pull/9726#discussion_r570505650 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -188,6 +188,16 @@ public Con

[GitHub] [kafka] rohitrmd commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-02-05 Thread GitBox
rohitrmd commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r570605728 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean i

[GitHub] [kafka] hachikuji commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r569981529 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialB

[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
vamossagar12 commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773415951 done. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #10002: MINOR: remove the indent in security doc

2021-02-05 Thread GitBox
showuon commented on pull request #10002: URL: https://github.com/apache/kafka/pull/10002#issuecomment-773911615 @omkreddy , thanks for the comments. I've updated it. Please help review again. Thanks. This is an automated me

[GitHub] [kafka] RossierFl commented on pull request #9319: KAFKA-10413: Allow for even distribution of lost/new tasks when multiple Connect workers join at the same time

2021-02-05 Thread GitBox
RossierFl commented on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-773097655 Thanks a lot everyone for this fix ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rodesai commented on a change in pull request #10046: MINOR: Extends RocksDB docs

2021-02-05 Thread GitBox
rodesai commented on a change in pull request #10046: URL: https://github.com/apache/kafka/pull/10046#discussion_r570627385 ## File path: docs/streams/developer-guide/memory-mgmt.html ## @@ -168,7 +168,15 @@ RocksDB Each instance of RocksDB allocates off-heap mem

[GitHub] [kafka] mjsax merged pull request #10044: MINOR: Word count should account for extra whitespaces between words

2021-02-05 Thread GitBox
mjsax merged pull request #10044: URL: https://github.com/apache/kafka/pull/10044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] tombentley commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-05 Thread GitBox
tombentley commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r570158748 ## File path: clients/src/main/java/org/apache/kafka/common/utils/StringUtils.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] rhauch commented on a change in pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2021-02-05 Thread GitBox
rhauch commented on a change in pull request #9780: URL: https://github.com/apache/kafka/pull/9780#discussion_r570648556 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -185,16 +188,33 @@ private fina

[GitHub] [kafka] levzem commented on pull request #10053: KAFKA-10834: Remove redundant type casts in Connect

2021-02-05 Thread GitBox
levzem commented on pull request #10053: URL: https://github.com/apache/kafka/pull/10053#issuecomment-773495387 @kkonstantine would appreciate some 👀 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] jsancio commented on a change in pull request #10030: MINOR: Add KafkaEventQueue

2021-02-05 Thread GitBox
jsancio commented on a change in pull request #10030: URL: https://github.com/apache/kafka/pull/10030#discussion_r570367570 ## File path: metadata/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] hachikuji merged pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-05 Thread GitBox
hachikuji merged pull request #10005: URL: https://github.com/apache/kafka/pull/10005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] mjsax merged pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-05 Thread GitBox
mjsax merged pull request #9107: URL: https://github.com/apache/kafka/pull/9107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
cadonna commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773909411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mjsax merged pull request #10046: MINOR: Extends RocksDB docs

2021-02-05 Thread GitBox
mjsax merged pull request #10046: URL: https://github.com/apache/kafka/pull/10046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] kkonstantine merged pull request #9867: KAFKA-10835: Replace Runnable and Callable overrides with lambdas in Connect

2021-02-05 Thread GitBox
kkonstantine merged pull request #9867: URL: https://github.com/apache/kafka/pull/9867 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax merged pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

2021-02-05 Thread GitBox
mjsax merged pull request #9997: URL: https://github.com/apache/kafka/pull/9997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #10000: KAFKA-9274: handle TimeoutException on task reset

2021-02-05 Thread GitBox
ableegoldman commented on a change in pull request #1: URL: https://github.com/apache/kafka/pull/1#discussion_r570495244 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -227,6 +230,27 @@ public void initializeIfNee

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-05 Thread GitBox
mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-773692994 Merged to `trunk`. Congrats for getting this into the 2.8.0 release @inponomarev -- great work! This is an au

[GitHub] [kafka] bob-barrett commented on pull request #10061: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on pull request #10061: URL: https://github.com/apache/kafka/pull/10061#issuecomment-773678032 @dajac This is the backport of https://github.com/apache/kafka/commit/131d4753cfed65ed6dee0a8c754765c97c3d513f. The conflicts were because the connection timeout settings ad

[GitHub] [kafka] vamossagar12 commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-05 Thread GitBox
vamossagar12 commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-773181642 Thanks @guozhangwang ! @cadonna I have added the doc here in this PR: https://github.com/apache/kafka/pull/10051. I will create a separate. ticket for the missing test c

[GitHub] [kafka] dpoldrugo commented on pull request #10059: KAFKA-8562: SaslChannelBuilder - avoid (reverse) DNS lookup while building underlying SslTransportLayer

2021-02-05 Thread GitBox
dpoldrugo commented on pull request #10059: URL: https://github.com/apache/kafka/pull/10059#issuecomment-773663807 @ijuma, @omkreddy, @rajinisivaram could you take a look? This is an automated message from the Apache Git Serv

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: MINOR: Add ConfigRepository, use in Partition and KafkaApis

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r570404954 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1881,7 +1884,11 @@ class ReplicaManager(val config: KafkaConfig, logMana

[GitHub] [kafka] bob-barrett commented on pull request #10065: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
bob-barrett commented on pull request #10065: URL: https://github.com/apache/kafka/pull/10065#issuecomment-773800777 This is a backport of 131d475 to 2.4. As with #10061, the conflicts were due to the missing connection timeout config, which was added in 2.7, and didn't meaningfully change

[GitHub] [kafka] vamossagar12 commented on pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-02-05 Thread GitBox
vamossagar12 commented on pull request #9756: URL: https://github.com/apache/kafka/pull/9756#issuecomment-773204238 @hachikuji did you get a chance to review this? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mumrah commented on a change in pull request #10049: Refactor MetadataCache for Raft metadata

2021-02-05 Thread GitBox
mumrah commented on a change in pull request #10049: URL: https://github.com/apache/kafka/pull/10049#discussion_r570451366 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -483,61 +475,4 @@ class MetadataCacheTest { assertEquals(initialBrok

[GitHub] [kafka] tang7526 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-05 Thread GitBox
tang7526 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r570185975 ## File path: clients/src/main/java/org/apache/kafka/common/utils/StringUtils.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a change in pull request #10045: MINOR: Allow KafkaApis to be configured for Raft controller quorums

2021-02-05 Thread GitBox
hachikuji commented on a change in pull request #10045: URL: https://github.com/apache/kafka/pull/10045#discussion_r570727037 ## File path: core/src/main/scala/kafka/server/MetadataSupport.scala ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] mimaison merged pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-05 Thread GitBox
mimaison merged pull request #9902: URL: https://github.com/apache/kafka/pull/9902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vamossagar12 commented on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
vamossagar12 commented on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773943202 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax merged pull request #10048: MINOR: add docs for KIP-680

2021-02-05 Thread GitBox
mjsax merged pull request #10048: URL: https://github.com/apache/kafka/pull/10048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] tang7526 closed pull request #10012: MINOR: Refactor return statement and log info

2021-02-05 Thread GitBox
tang7526 closed pull request #10012: URL: https://github.com/apache/kafka/pull/10012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch commented on pull request #9780: KAFKA-10021: Changed Kafka backing stores to use shared admin client to get end offsets and create topics

2021-02-05 Thread GitBox
rhauch commented on pull request #9780: URL: https://github.com/apache/kafka/pull/9780#issuecomment-773485918 Rebased on `trunk` to correct conflicts. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-05 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r570153122 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ## @@ -103,6 +105,20 @@ public void putAll(fin

[GitHub] [kafka] abbccdda commented on a change in pull request #9579: KAFKA-9751: Forward CreateTopicsRequest for FindCoordinator/Metadata when topic creation is needed

2021-02-05 Thread GitBox
abbccdda commented on a change in pull request #9579: URL: https://github.com/apache/kafka/pull/9579#discussion_r570396673 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1113,82 +1097,36 @@ class KafkaApis(val requestChannel: RequestChannel, .setPa

[GitHub] [kafka] cmccabe merged pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-05 Thread GitBox
cmccabe merged pull request #10019: URL: https://github.com/apache/kafka/pull/10019 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vamossagar12 edited a comment on pull request #10051: Adding documentation for KIP-614

2021-02-05 Thread GitBox
vamossagar12 edited a comment on pull request #10051: URL: https://github.com/apache/kafka/pull/10051#issuecomment-773943202 @cadonna Done. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming opened a new pull request #10068: MINOR: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

2021-02-05 Thread GitBox
dengziming opened a new pull request #10068: URL: https://github.com/apache/kafka/pull/10068 *More detailed description of your change* The test case in `StopReplicaRespTest` and `StopReplicaReq` didn't cover all versions. *Summary of testing strategy (including rationale)* QA

[jira] [Created] (KAFKA-12296) MockProducer behaves contrary to documentation of Callback

2021-02-05 Thread Olaf (Jira)
Olaf created KAFKA-12296: Summary: MockProducer behaves contrary to documentation of Callback Key: KAFKA-12296 URL: https://issues.apache.org/jira/browse/KAFKA-12296 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-12296) MockProducer behaves contrary to documentation of Callback

2021-02-05 Thread Olaf (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf updated KAFKA-12296: - Description: In Unit tests, a MockProducer is used to imitate a real producer. Using the errorNext(RuntimeExcep

[jira] [Resolved] (KAFKA-12296) MockProducer behaves contrary to documentation of Callback

2021-02-05 Thread Olaf (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf resolved KAFKA-12296. -- Resolution: Duplicate sorry - wrong user > MockProducer behaves contrary to documentation of Callback > -

[jira] [Closed] (KAFKA-12296) MockProducer behaves contrary to documentation of Callback

2021-02-05 Thread Olaf (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olaf closed KAFKA-12296. sorry- wrong user > MockProducer behaves contrary to documentation of Callback >

[jira] [Created] (KAFKA-12297) Implementation of MockProducer contradicts documentation of Callback for async send

2021-02-05 Thread Olaf Gottschalk (Jira)
Olaf Gottschalk created KAFKA-12297: --- Summary: Implementation of MockProducer contradicts documentation of Callback for async send Key: KAFKA-12297 URL: https://issues.apache.org/jira/browse/KAFKA-12297

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-02-05 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-774017335 @abbccdda @guozhangwang , please help review this PR. Thanks. This is an automated message from the Apache Git Se

[jira] [Commented] (KAFKA-12213) Kafka Streams aggregation Initializer to accept record key

2021-02-05 Thread Piotr Fras (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279709#comment-17279709 ] Piotr Fras commented on KAFKA-12213: [~mjsax] [~guozhang] thank you for your comment

  1   2   3   >