[GitHub] [kafka] ijuma commented on pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-02-03 Thread GitBox
ijuma commented on pull request #9901: URL: https://github.com/apache/kafka/pull/9901#issuecomment-772328660 Seems like we only have a benchmark for adding items? What about reading items from the map? This is an automated m

[GitHub] [kafka] sknop edited a comment on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-03 Thread GitBox
sknop edited a comment on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-766939861 > @sknop hello , It seems like there are some style error . > You can use `./gradlew checkstyleMain checkstyleTest` to cehck . Thank you @g1geordie for your feedback.

[GitHub] [kafka] ijuma commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r569225393 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -51,6 +52,26 @@ class InterBrokerSendThreadTest { Some(queue.d

[GitHub] [kafka] ijuma commented on pull request #10031: KAFKA-12269: Replace partition metada with auto-generated protocal

2021-02-03 Thread GitBox
ijuma commented on pull request #10031: URL: https://github.com/apache/kafka/pull/10031#issuecomment-772347771 Thanks for the PR. Let's run the relevant jmh benchmark to ensure there is no perf regression. This is an automat

[GitHub] [kafka] ijuma commented on a change in pull request #10028: Replace BrokerStates.scala with BrokerState.java

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #10028: URL: https://github.com/apache/kafka/pull/10028#discussion_r569239693 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -60,7 +61,7 @@ class LogManager(logDirs: Seq[File], val retentionCheckM

[GitHub] [kafka] ijuma commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r569242848 ## File path: build.gradle ## @@ -1011,7 +1011,10 @@ project(':core') { } test { java { -srcDirs = ["src/generated/java", "src/test/j

[GitHub] [kafka] ijuma commented on a change in pull request #9986: JUnit extensions for integration tests

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #9986: URL: https://github.com/apache/kafka/pull/9986#discussion_r569243982 ## File path: core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala ## @@ -16,83 +16,94 @@ */ package kafka.server +import integration

[GitHub] [kafka] ijuma commented on pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
ijuma commented on pull request #10008: URL: https://github.com/apache/kafka/pull/10008#issuecomment-772354293 We discussed this offline and the current suggestion is to pass the function in the `start` method. This is an au

[GitHub] [kafka] ijuma commented on pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-03 Thread GitBox
ijuma commented on pull request #10003: URL: https://github.com/apache/kafka/pull/10003#issuecomment-772357616 A single unrelated flaky test failed for JDK 8: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10003/10/ ---

[GitHub] [kafka] ijuma merged pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-03 Thread GitBox
ijuma merged pull request #10003: URL: https://github.com/apache/kafka/pull/10003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] ijuma commented on pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-03 Thread GitBox
ijuma commented on pull request #10009: URL: https://github.com/apache/kafka/pull/10009#issuecomment-772360801 JDK 8 build exited (JDK 11 and 15 passed), so restarted the PR builder. This is an automated message from the Apac

[GitHub] [kafka] ijuma commented on pull request #10030: MINOR: Add KafkaEventQueue

2021-02-03 Thread GitBox
ijuma commented on pull request #10030: URL: https://github.com/apache/kafka/pull/10030#issuecomment-772361384 @junrao Do you have time to help review this? This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ijuma commented on pull request #10011: MINOR: remove org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread GitBox
ijuma commented on pull request #10011: URL: https://github.com/apache/kafka/pull/10011#issuecomment-772365157 Yeah, we should not remove public classes without a deprecation cycle. This is an automated message from the Apach

[GitHub] [kafka] ijuma commented on pull request #9998: KAFKA-12250; Add metadata record serde for KIP-631

2021-02-03 Thread GitBox
ijuma commented on pull request #9998: URL: https://github.com/apache/kafka/pull/9998#issuecomment-772365541 Is this ready for review @hachikuji? This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] chia7712 commented on pull request #10036: MINOR: change modifier of ConsumerRecords(FetchedRecords) from public…

2021-02-03 Thread GitBox
chia7712 commented on pull request #10036: URL: https://github.com/apache/kafka/pull/10036#issuecomment-772367680 > Has this been in any release? it is not in any release as it is committed 6 days ago (https://github.com/apache/kafka/commit/fdcf8fbf72bee9e672d0790cdbe5539846f7dc8e)

[GitHub] [kafka] chia7712 commented on pull request #10011: MINOR: remove org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread GitBox
chia7712 commented on pull request #10011: URL: https://github.com/apache/kafka/pull/10011#issuecomment-772368177 @mjsax @ijuma Thanks for your response. I will file a KIP to deprecate it. This is an automated message from th

[GitHub] [kafka] ijuma commented on pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-02-03 Thread GitBox
ijuma commented on pull request #9996: URL: https://github.com/apache/kafka/pull/9996#issuecomment-772372796 Restarted the build, it timed out for some reason. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] dajac commented on a change in pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

2021-02-03 Thread GitBox
dajac commented on a change in pull request #9958: URL: https://github.com/apache/kafka/pull/9958#discussion_r569206619 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -185,9 +185,9 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] chia7712 commented on pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-03 Thread GitBox
chia7712 commented on pull request #10024: URL: https://github.com/apache/kafka/pull/10024#issuecomment-772381441 > FatalExitException is mentioned in the PR description. What throws that? please take a look at following log (from gradle) ` [2021-02-03 02:03:58,599] ERRO

[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-03 Thread GitBox
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-772381544 I was talking about build 17 (triggered by Commit db573f5, see https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9107/) Where did build 18 came from, why it too

[GitHub] [kafka] inponomarev edited a comment on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-03 Thread GitBox
inponomarev edited a comment on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-772381544 I was talking about build 17 (triggered by Commit db573f5, see https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9107/) Where did build 18 come from, why

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-03 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r569277356 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -51,6 +52,26 @@ class InterBrokerSendThreadTest { Some(queu

[GitHub] [kafka] ijuma commented on a change in pull request #9998: KAFKA-12250; Add metadata record serde for KIP-631

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #9998: URL: https://github.com/apache/kafka/pull/9998#discussion_r569278561 ## File path: metadata/src/main/java/org/apache/kafka/metadata/MetadataRecordSerde.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] dajac commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-03 Thread GitBox
dajac commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-772395464 @bob-barrett Thanks for your answers. That makes sense and I do agree with the approach. This is an automated messa

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-03 Thread GitBox
rajinisivaram commented on a change in pull request #10022: URL: https://github.com/apache/kafka/pull/10022#discussion_r569292052 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1236,7 +1236,7 @@ public void assign(Collection par

[GitHub] [kafka] dajac commented on a change in pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-03 Thread GitBox
dajac commented on a change in pull request #9902: URL: https://github.com/apache/kafka/pull/9902#discussion_r569299977 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientUtils.java ## @@ -106,8 +106,9 @@ public static ChannelBuilder createChannelBuilder(Abstra

[GitHub] [kafka] ijuma commented on pull request #10036: MINOR: change modifier of ConsumerRecords(FetchedRecords) from public…

2021-02-03 Thread GitBox
ijuma commented on pull request #10036: URL: https://github.com/apache/kafka/pull/10036#issuecomment-772407610 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r569305537 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -51,6 +52,26 @@ class InterBrokerSendThreadTest { Some(queue.d

[GitHub] [kafka] purplefox commented on pull request #9963: MINOR: Extract ApiVersions logic from the `SocketServer` to the `KafkaApis`

2021-02-03 Thread GitBox
purplefox commented on pull request #9963: URL: https://github.com/apache/kafka/pull/9963#issuecomment-772415385 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (KAFKA-7077) KIP-318: Make Kafka Connect Source idempotent

2021-02-03 Thread Nabil GASRI (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277942#comment-17277942 ] Nabil GASRI commented on KAFKA-7077: Any updates guys? The PR [~Schmidt96u] submitted

[jira] [Created] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12281: -- Summary: Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException Key: KAFKA-12281 URL: https://issues.apache.org/jira/browse/KAFKA-12281 Project: Kafka

[GitHub] [kafka] chia7712 closed pull request #10011: MINOR: remove org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread GitBox
chia7712 closed pull request #10011: URL: https://github.com/apache/kafka/pull/10011 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #10011: MINOR: remove org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread GitBox
chia7712 commented on pull request #10011: URL: https://github.com/apache/kafka/pull/10011#issuecomment-772458010 superseded by https://issues.apache.org/jira/browse/KAFKA-12281 This is an automated message from the Apache Gi

[jira] [Updated] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12281: --- Labels: need-kip (was: ) > Deprecate org.apache.kafka.streams.errors.BrokerNotFoundExceptio

[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2021-02-03 Thread GitBox
tombentley commented on pull request #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-772458645 I've now run these tests 4 or 5 times in CI and not seen any failures in the previously flaky tests where previously I did, so I'm hopeful that these changes to indeed fix the

[jira] [Updated] (KAFKA-12281) Deprecate org.apache.kafka.streams.errors.BrokerNotFoundException

2021-02-03 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12281: --- Labels: needs-kip (was: need-kip) > Deprecate org.apache.kafka.streams.errors.BrokerNotFoun

[jira] [Updated] (KAFKA-10703) Document that default configs are not supported for TOPIC entities

2021-02-03 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-10703: Flags: Patch Labels: patch-available (was: ) > Document that default configs are not support

[GitHub] [kafka] tombentley commented on pull request #9847: KAFKA-10703: Better handling and doc for config defaults of topics

2021-02-03 Thread GitBox
tombentley commented on pull request #9847: URL: https://github.com/apache/kafka/pull/9847#issuecomment-772499370 @chia7712, @dajac, @ijuma please could someone review this? This is an automated message from the Apache Git Se

[GitHub] [kafka] tombentley commented on pull request #9822: KAFKA-10860: Fix NPE in JmxTool, add tests

2021-02-03 Thread GitBox
tombentley commented on pull request #9822: URL: https://github.com/apache/kafka/pull/9822#issuecomment-772500567 @chia7712 @dajac any chance of a review here, or can you suggest someone who can? This is an automated message

[GitHub] [kafka] chia7712 commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2021-02-03 Thread GitBox
chia7712 commented on pull request #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-772516599 > The cause of the flakiness appears to have been lack of test isolation between those tests and other tests which manipulate log levels (which are effectively global to the JVM)

[GitHub] [kafka] ijuma commented on pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-02-03 Thread GitBox
ijuma commented on pull request #9996: URL: https://github.com/apache/kafka/pull/9996#issuecomment-772517035 Two flaky tests: > JDK 8 / org.apache.kafka.common.metrics.MetricsTest.testPercentilesWithRandomNumbersAndLinearBucketing() > JDK 8 / org.apache.kafka.connect.integration.

[GitHub] [kafka] ijuma merged pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-02-03 Thread GitBox
ijuma merged pull request #9996: URL: https://github.com/apache/kafka/pull/9996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-03 Thread GitBox
ijuma commented on pull request #10009: URL: https://github.com/apache/kafka/pull/10009#issuecomment-772519286 Weird, red build again. Restarted it once again. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] rondagostino commented on a change in pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10008: URL: https://github.com/apache/kafka/pull/10008#discussion_r569428739 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -78,7 +76,7 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] ijuma commented on a change in pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
ijuma commented on a change in pull request #10008: URL: https://github.com/apache/kafka/pull/10008#discussion_r569430467 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -78,7 +76,7 @@ class GroupMetadataManager(brokerId: Int, priv

[GitHub] [kafka] rondagostino commented on a change in pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10008: URL: https://github.com/apache/kafka/pull/10008#discussion_r569433906 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala ## @@ -96,7 +94,8 @@ class TransactionStateManager(bro

[GitHub] [kafka] rondagostino commented on a change in pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10008: URL: https://github.com/apache/kafka/pull/10008#discussion_r569444234 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -78,7 +78,20 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] rondagostino commented on a change in pull request #10008: MINOR: Remove ZK dependency for coordinator topics' partition counts

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10008: URL: https://github.com/apache/kafka/pull/10008#discussion_r569444234 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -78,7 +78,20 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

2021-02-03 Thread GitBox
tombentley commented on pull request #9972: URL: https://github.com/apache/kafka/pull/9972#issuecomment-772542951 Thanks @chia7712 that's an excellent point! Maybe it's worth inlining `withLogReset` since it offers little value now?

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-03 Thread GitBox
urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r569494586 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -33,49 +34,65 @@ object GetOffsetShell { def main(args: Array[String]): Unit

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-03 Thread GitBox
urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r569496661 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -132,23 +150,104 @@ object GetOffsetShell { } } -partitionOffs

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-03 Thread GitBox
urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r569496512 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -89,33 +106,34 @@ object GetOffsetShell { } val listOffsetsTimestamp = o

[GitHub] [kafka] urbandan commented on a change in pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-03 Thread GitBox
urbandan commented on a change in pull request #9430: URL: https://github.com/apache/kafka/pull/9430#discussion_r569497510 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -132,23 +150,104 @@ object GetOffsetShell { } } -partitionOffs

[GitHub] [kafka] urbandan commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-03 Thread GitBox
urbandan commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-772586539 @dajac Thank you for your comments, finally managed to address them. Also rebased the branch. This is an automat

[GitHub] [kafka] dengziming opened a new pull request #10037: MINOR: remove unused import in TopicIdWithOldInterBrokerProtocolTest

2021-02-03 Thread GitBox
dengziming opened a new pull request #10037: URL: https://github.com/apache/kafka/pull/10037 *More detailed description of your change* I found a warning message in every QA Jenkins build: ``` [2021-02-03T01ː12ː51.812Z] [Warn] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR

[GitHub] [kafka] chia7712 commented on pull request #10033: MINOR: Fix always pass unit test in MetadataRequestTest

2021-02-03 Thread GitBox
chia7712 commented on pull request #10033: URL: https://github.com/apache/kafka/pull/10033#issuecomment-772600444 @dengziming Those failures should be unrelated to your PR but it would be better to see green QA before merging. Hence, could you merge trunk to trigger QA again? thanks. ---

[GitHub] [kafka] chia7712 commented on pull request #10036: MINOR: change modifier of ConsumerRecords(FetchedRecords) from public…

2021-02-03 Thread GitBox
chia7712 commented on pull request #10036: URL: https://github.com/apache/kafka/pull/10036#issuecomment-772605859 ``` Build / JDK 8 / kafka.api.ConsumerBounceTest.testClose() ``` see #9128 ``` Build / JDK 15 / org.apache.kafka.connect.integration.BlockingConnectorTest.tes

[GitHub] [kafka] chia7712 merged pull request #10036: MINOR: change modifier of ConsumerRecords(FetchedRecords) from public…

2021-02-03 Thread GitBox
chia7712 merged pull request #10036: URL: https://github.com/apache/kafka/pull/10036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 edited a comment on pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-03 Thread GitBox
chia7712 edited a comment on pull request #10024: URL: https://github.com/apache/kafka/pull/10024#issuecomment-772381441 > FatalExitException is mentioned in the PR description. What throws that? please take a look at following log (from gradle) ` [2021-02-03 02:03:58,59

[GitHub] [kafka] ijuma commented on pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-03 Thread GitBox
ijuma commented on pull request #10009: URL: https://github.com/apache/kafka/pull/10009#issuecomment-772625293 Two unrelated flaky failures: > Build / JDK 15 / org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining > Build / JDK

[GitHub] [kafka] ijuma merged pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-03 Thread GitBox
ijuma merged pull request #10009: URL: https://github.com/apache/kafka/pull/10009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Resolved] (KAFKA-4640) Improve Streams unit test coverage

2021-02-03 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-4640. --- Resolution: Fixed > Improve Streams unit test coverage > -- >

[jira] [Closed] (KAFKA-4640) Improve Streams unit test coverage

2021-02-03 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-4640. - > Improve Streams unit test coverage > -- > > Key: KA

[jira] [Reopened] (KAFKA-10764) Add support for returning topic IDs on create, supplying topic IDs for delete

2021-02-03 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reopened KAFKA-10764: We need to revisit the admin client apis for this. > Add support for returning topic IDs on c

[GitHub] [kafka] ijuma opened a new pull request #10038: MINOR: Disable Travis PR builds

2021-02-03 Thread GitBox
ijuma opened a new pull request #10038: URL: https://github.com/apache/kafka/pull/10038 Kafka is consuming over 50% of all our Travis executors according to Apache Infra, so let's disable it for now. ### Committer Checklist (excluded from commit message) - [ ] Verify design and im

[GitHub] [kafka] tang7526 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-03 Thread GitBox
tang7526 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r569549005 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredValidatorCallbackHandler.java #

[GitHub] [kafka] tang7526 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-03 Thread GitBox
tang7526 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r569549735 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredValidatorCallbackHandler.java #

[GitHub] [kafka] mumrah commented on a change in pull request #10026: MINOR: Add mock implementation of `BrokerToControllerChannelManager`

2021-02-03 Thread GitBox
mumrah commented on a change in pull request #10026: URL: https://github.com/apache/kafka/pull/10026#discussion_r569550254 ## File path: core/src/test/scala/unit/kafka/server/ForwardingManagerTest.scala ## @@ -19,135 +19,139 @@ package kafka.server import java.net.InetAddress

[GitHub] [kafka] chia7712 commented on pull request #10038: MINOR: Disable Travis PR builds

2021-02-03 Thread GitBox
chia7712 commented on pull request #10038: URL: https://github.com/apache/kafka/pull/10038#issuecomment-772654479 Personally, I'd like to keep compatibility tests :) This is an automated message from the Apache Git Service. T

[GitHub] [kafka] vvcephei commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

2021-02-03 Thread GitBox
vvcephei commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r569575143 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -714,19 +720,34 @@ public boolean process(final lon

[GitHub] [kafka] rondagostino opened a new pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-03 Thread GitBox
rondagostino opened a new pull request #10039: URL: https://github.com/apache/kafka/pull/10039 Currently log recovery begins as soon as we instantiate `LogManager`, but when using a Raft-based metadata quorum we won't have configs until after we catch up on the metadata log. We therefore

[GitHub] [kafka] ijuma commented on pull request #10038: MINOR: Disable Travis PR builds

2021-02-03 Thread GitBox
ijuma commented on pull request #10038: URL: https://github.com/apache/kafka/pull/10038#issuecomment-772659362 We need to figure out how to do it in a way that doesn't take so much of the Travis capacity. And only then add it back. -

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r569580157 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -402,7 +403,26 @@ class LogManager(logDirs: Seq[File], /** * Start the bac

[GitHub] [kafka] vvcephei commented on a change in pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-03 Thread GitBox
vvcephei commented on a change in pull request #10022: URL: https://github.com/apache/kafka/pull/10022#discussion_r569581763 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1236,7 +1236,7 @@ public void assign(Collection partitio

[GitHub] [kafka] ijuma merged pull request #10038: MINOR: Disable Travis PR builds

2021-02-03 Thread GitBox
ijuma merged pull request #10038: URL: https://github.com/apache/kafka/pull/10038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r569600606 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -256,9 +254,10 @@ class LogManager(logDirs: Seq[File], private[log] def loadLog

[GitHub] [kafka] rondagostino commented on a change in pull request #10039: MINOR: Defer log recovery until LogManager startup

2021-02-03 Thread GitBox
rondagostino commented on a change in pull request #10039: URL: https://github.com/apache/kafka/pull/10039#discussion_r569602196 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -402,7 +403,26 @@ class LogManager(logDirs: Seq[File], /** * Start the bac

[GitHub] [kafka] cmccabe commented on a change in pull request #10028: Replace BrokerStates.scala with BrokerState.java

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #10028: URL: https://github.com/apache/kafka/pull/10028#discussion_r569604728 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -60,7 +61,7 @@ class LogManager(logDirs: Seq[File], val retentionChec

[GitHub] [kafka] hachikuji commented on a change in pull request #10026: MINOR: Add mock implementation of `BrokerToControllerChannelManager`

2021-02-03 Thread GitBox
hachikuji commented on a change in pull request #10026: URL: https://github.com/apache/kafka/pull/10026#discussion_r569606950 ## File path: core/src/test/scala/unit/kafka/server/ForwardingManagerTest.scala ## @@ -19,135 +19,139 @@ package kafka.server import java.net.InetAddre

[jira] [Created] (KAFKA-12282) KIP-500: Reconcile configuration variables between trunk and the KIP-500 branch

2021-02-03 Thread Alok Nikhil (Jira)
Alok Nikhil created KAFKA-12282: --- Summary: KIP-500: Reconcile configuration variables between trunk and the KIP-500 branch Key: KAFKA-12282 URL: https://issues.apache.org/jira/browse/KAFKA-12282 Project

[GitHub] [kafka] hachikuji commented on a change in pull request #10018: Upstream MetadataImage and related classes

2021-02-03 Thread GitBox
hachikuji commented on a change in pull request #10018: URL: https://github.com/apache/kafka/pull/10018#discussion_r568973206 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -0,0 +1,140 @@ +/** + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] cmccabe commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #10019: URL: https://github.com/apache/kafka/pull/10019#discussion_r569617960 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -936,7 +939,10 @@ class DynamicListenerConfig(server: KafkaServer) extends

[GitHub] [kafka] cmccabe commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #10019: URL: https://github.com/apache/kafka/pull/10019#discussion_r569619467 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] cmccabe commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #10019: URL: https://github.com/apache/kafka/pull/10019#discussion_r569619467 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] hachikuji commented on a change in pull request #10026: MINOR: Add mock implementation of `BrokerToControllerChannelManager`

2021-02-03 Thread GitBox
hachikuji commented on a change in pull request #10026: URL: https://github.com/apache/kafka/pull/10026#discussion_r569620772 ## File path: core/src/test/scala/unit/kafka/server/ForwardingManagerTest.scala ## @@ -19,135 +19,139 @@ package kafka.server import java.net.InetAddre

[GitHub] [kafka] cmccabe commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #10019: URL: https://github.com/apache/kafka/pull/10019#discussion_r569617960 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -936,7 +939,10 @@ class DynamicListenerConfig(server: KafkaServer) extends

[GitHub] [kafka] rhauch commented on pull request #10027: KAFKA-12270: Handle race condition when Connect tasks attempt to create topic

2021-02-03 Thread GitBox
rhauch commented on pull request #10027: URL: https://github.com/apache/kafka/pull/10027#issuecomment-772700804 Closing in favor of #10032. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] rhauch closed pull request #10027: KAFKA-12270: Handle race condition when Connect tasks attempt to create topic

2021-02-03 Thread GitBox
rhauch closed pull request #10027: URL: https://github.com/apache/kafka/pull/10027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] rhauch commented on pull request #10032: KAFKA-12270: Handle race condition when Connect tasks attempt to create topics

2021-02-03 Thread GitBox
rhauch commented on pull request #10032: URL: https://github.com/apache/kafka/pull/10032#issuecomment-772702453 We're having infrastructure and build issues. I rebased this on the latest from `trunk`, which includes #10038 to disable Travis builds. No other changes were made since approval

[GitHub] [kafka] Cyril-Engels opened a new pull request #10040: KAFKA-12259: Use raw config to infer connector type when returning connect status response

2021-02-03 Thread GitBox
Cyril-Engels opened a new pull request #10040: URL: https://github.com/apache/kafka/pull/10040 Addressed [KAFKA-12259](https://issues.apache.org/jira/browse/KAFKA-12259). Problem: when calling the connect status endpoint, a 500 error is returned, e.g. ``` { "error_code": 5

[GitHub] [kafka] cmccabe commented on pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-03 Thread GitBox
cmccabe commented on pull request #10019: URL: https://github.com/apache/kafka/pull/10019#issuecomment-772706382 I agree with the comments from earlier that we don't want to expose the pre-KIP-500 `KafkaController` in the `KafkaServer` interface. I think casting to `KafkaServer` or `RaftB

[jira] [Created] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2021-02-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12283: --- Summary: Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining Key: KAFKA-12283 URL: https://issues.apache.org/jira/browse/KAFKA-12283

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2021-02-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278264#comment-17278264 ] Matthias J. Sax commented on KAFKA-9013: Failed again with {quote}{{java.lang.Ass

[GitHub] [kafka] cmccabe commented on a change in pull request #9998: KAFKA-12250; Add metadata record serde for KIP-631

2021-02-03 Thread GitBox
cmccabe commented on a change in pull request #9998: URL: https://github.com/apache/kafka/pull/9998#discussion_r569633608 ## File path: metadata/src/main/java/org/apache/kafka/metadata/MetadataRecordSerde.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] mjsax commented on a change in pull request #9997: KAFKA-9274: Add timeout handling for `StreamPartitioner`

2021-02-03 Thread GitBox
mjsax commented on a change in pull request #9997: URL: https://github.com/apache/kafka/pull/9997#discussion_r569634714 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -714,19 +720,34 @@ public boolean process(final long w

[GitHub] [kafka] vvcephei commented on a change in pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-03 Thread GitBox
vvcephei commented on a change in pull request #10022: URL: https://github.com/apache/kafka/pull/10022#discussion_r569635435 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1236,7 +1236,7 @@ public void assign(Collection partitio

[jira] [Created] (KAFKA-12284) Flaky Test MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWithAutoOffsetSync

2021-02-03 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12284: --- Summary: Flaky Test MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWithAutoOffsetSync Key: KAFKA-12284 URL: https://issues.apache.org/jira/browse/KAFKA-12284

[GitHub] [kafka] jolshan opened a new pull request #10041: MINOR: Prevent creating partition.metadata until ID can be written

2021-02-03 Thread GitBox
jolshan opened a new pull request #10041: URL: https://github.com/apache/kafka/pull/10041 Currently the partition.metadata file is created when the log is created. However, clusters with older inter-broker protocols will never use this file. This PR moves the creation of the file to when w

[GitHub] [kafka] mumrah commented on a change in pull request #10026: MINOR: Add mock implementation of `BrokerToControllerChannelManager`

2021-02-03 Thread GitBox
mumrah commented on a change in pull request #10026: URL: https://github.com/apache/kafka/pull/10026#discussion_r569642348 ## File path: core/src/test/scala/unit/kafka/server/ForwardingManagerTest.scala ## @@ -19,135 +19,139 @@ package kafka.server import java.net.InetAddress

[GitHub] [kafka] mjsax commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-03 Thread GitBox
mjsax commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-772719099 Ah I see -- well, we do have from flaky tests, so nothing to worry about I guess. The last run timed out, so I retriggered the build. However, I could build it locally with Java8/Sc

  1   2   3   >