[GitHub] [kafka] chia7712 merged pull request #9989: KAFKA-12246: Remove redundant suppression in KafkaAdminClient

2021-02-02 Thread GitBox
chia7712 merged pull request #9989: URL: https://github.com/apache/kafka/pull/9989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on a change in pull request #10017: KAFKA-12260: Avoid hitting NPE for partitionsFor

2021-02-02 Thread GitBox
chia7712 commented on a change in pull request #10017: URL: https://github.com/apache/kafka/pull/10017#discussion_r568403080 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1948,7 +1948,7 @@ public OffsetAndMetadata committed(Top

[GitHub] [kafka] chia7712 commented on a change in pull request #10017: KAFKA-12260: Avoid hitting NPE for partitionsFor

2021-02-02 Thread GitBox
chia7712 commented on a change in pull request #10017: URL: https://github.com/apache/kafka/pull/10017#discussion_r568411777 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1948,7 +1948,7 @@ public OffsetAndMetadata committed(Top

[jira] [Updated] (KAFKA-12257) Consumer mishandles topics deleted and recreated with the same name

2021-02-02 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee updated KAFKA-12257: -- Attachment: KAFKA-12257.patch > Consumer mishandles topics deleted and recreated with the same name >

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-02 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r568413963 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] chia7712 closed pull request #9502: MINOR: mark StandbyTaskEOSIntegrationTest as an IntegrationTest

2021-02-02 Thread GitBox
chia7712 closed pull request #9502: URL: https://github.com/apache/kafka/pull/9502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-02 Thread GitBox
mjsax commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r568413267 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] chia7712 commented on a change in pull request #10012: MINOR: Refactor return statement and log info

2021-02-02 Thread GitBox
chia7712 commented on a change in pull request #10012: URL: https://github.com/apache/kafka/pull/10012#discussion_r568422389 ## File path: clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/unsecured/OAuthBearerUnsecuredValidatorCallbackHandler.java #

[GitHub] [kafka] dajac commented on a change in pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
dajac commented on a change in pull request #10007: URL: https://github.com/apache/kafka/pull/10007#discussion_r568370315 ## File path: clients/src/test/java/org/apache/kafka/common/security/authenticator/SaslAuthenticatorTest.java ## @@ -1777,6 +1785,74 @@ public void testIn

[jira] [Commented] (KAFKA-9527) Application Reset Tool Returns NPE when --to-timestamp or --by-duration are run on --input-topics with empty partitions

2021-02-02 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276987#comment-17276987 ] Marco Lotz commented on KAFKA-9527: --- [~mjsax] what would be the expected behaviour in t

[jira] [Updated] (KAFKA-12261) Splitting partition causes message loss for consumers with auto.offset.reset=latest

2021-02-02 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-12261: - Description: As of now, auto.offset.reset of ConsumerConfig is "latest" by default.   This cou

[GitHub] [kafka] CaoManhDat commented on a change in pull request #10021: KAFKA-12205: Delete snapshot if leo less than the log start offset

2021-02-02 Thread GitBox
CaoManhDat commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r568473592 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -173,13 +164,16 @@ final class KafkaMetadataLog private ( override def t

[GitHub] [kafka] dajac commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-02 Thread GitBox
dajac commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-771527775 @bob-barrett Thanks for the PR. For my understanding, have we considered changing the way backoff is applied instead of re-resolving when an established connection is closed. For in

[GitHub] [kafka] CaoManhDat commented on a change in pull request #10021: KAFKA-12205: Delete snapshot if leo less than the log start offset

2021-02-02 Thread GitBox
CaoManhDat commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r568482293 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,23 +261,31 @@ final class KafkaMetadataLog private ( } } - ov

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
rajinisivaram commented on a change in pull request #10007: URL: https://github.com/apache/kafka/pull/10007#discussion_r568485297 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -129,6 +136,22 @@ private static ChannelBuilder crea

[GitHub] [kafka] rajinisivaram commented on a change in pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
rajinisivaram commented on a change in pull request #10007: URL: https://github.com/apache/kafka/pull/10007#discussion_r568488231 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -129,6 +136,22 @@ private static ChannelBuilder crea

[GitHub] [kafka] rajinisivaram commented on pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
rajinisivaram commented on pull request #10007: URL: https://github.com/apache/kafka/pull/10007#issuecomment-771534377 @dajac Thanks for the review. Addressed comments and left a couple of responses. This is an automated mes

[GitHub] [kafka] rajinisivaram commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-02-02 Thread GitBox
rajinisivaram commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-771541128 @dengziming Thanks for looking into this. Looks like a timing issue. @jolshan had run two system test runs on this PR last week and both had these consumer issues. At the ti

[GitHub] [kafka] dajac commented on a change in pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
dajac commented on a change in pull request #10007: URL: https://github.com/apache/kafka/pull/10007#discussion_r568499289 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -129,6 +136,22 @@ private static ChannelBuilder create(Secur

[GitHub] [kafka] dajac commented on a change in pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
dajac commented on a change in pull request #10007: URL: https://github.com/apache/kafka/pull/10007#discussion_r568499761 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -129,6 +136,22 @@ private static ChannelBuilder create(Secur

[GitHub] [kafka] cadonna commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-02 Thread GitBox
cadonna commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r568508079 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStoreTest.java ## @@ -434,6 +435,22 @@ public void shouldRemov

[GitHub] [kafka] cadonna commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-02 Thread GitBox
cadonna commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-771551918 @guozhangwang @vamossagar12 This failure is related to this PR: ``` org.apache.kafka.streams.state.internals.MeteredKeyValueStoreTest.shouldGetRecordsWithPrefixKey[0.10.0

[GitHub] [kafka] xiao-penglei commented on pull request #9992: KAFKA-10759 Add ARM build stage

2021-02-02 Thread GitBox
xiao-penglei commented on pull request #9992: URL: https://github.com/apache/kafka/pull/9992#issuecomment-771552356 > Looks like one of the tests got hung up and the build timed out: > > ``` > 16:04:09 SocketServerTest > testStagedListenerShutdownWhenConnectionQueueIsFull() START

[GitHub] [kafka] cadonna commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-02 Thread GitBox
cadonna commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-771553074 @vamossagar12 Probably, it would also be good to rebase this PR to current trunk to get a green build since we merged a couple of fixes to flaky tests recently.

[GitHub] [kafka] cadonna commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2021-02-02 Thread GitBox
cadonna commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-771558421 > @cadonna could you also help @vamossagar12 to come up with a PR on docs for this KIP? Yes, @vamossagar12, you should open a PR and add a short paragraph about KIP-614 in

[GitHub] [kafka] xiao-penglei commented on pull request #9992: KAFKA-10759 Add ARM build stage

2021-02-02 Thread GitBox
xiao-penglei commented on pull request #9992: URL: https://github.com/apache/kafka/pull/9992#issuecomment-771609535 > Looks like one of the tests got hung up and the build timed out: > > ``` > 16:04:09 SocketServerTest > testStagedListenerShutdownWhenConnectionQueueIsFull() START

[jira] [Created] (KAFKA-12268) System tests broken because consumer returns early without records

2021-02-02 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-12268: -- Summary: System tests broken because consumer returns early without records Key: KAFKA-12268 URL: https://issues.apache.org/jira/browse/KAFKA-12268 Project: Kafk

[jira] [Created] (KAFKA-12269) Replace MetadataResponse.PartitionMetadata with auto-generated protocol

2021-02-02 Thread dengziming (Jira)
dengziming created KAFKA-12269: -- Summary: Replace MetadataResponse.PartitionMetadata with auto-generated protocol Key: KAFKA-12269 URL: https://issues.apache.org/jira/browse/KAFKA-12269 Project: Kafka

[GitHub] [kafka] rajinisivaram commented on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-02-02 Thread GitBox
rajinisivaram commented on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-771612611 Looks like a bug was introduced by a different PR, opened https://issues.apache.org/jira/browse/KAFKA-12268 to fix this. ---

[jira] [Assigned] (KAFKA-9881) Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test

2021-02-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-9881: Assignee: Bruno Cadonna > Verify whether RocksDBMetrics Get Measurements from RocksDB in a

[jira] [Closed] (KAFKA-9881) Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test

2021-02-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-9881. > Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test > instead of an Intergrat

[jira] [Resolved] (KAFKA-9881) Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test

2021-02-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-9881. -- Resolution: Fixed > Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test

[jira] [Updated] (KAFKA-9881) Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test instead of an Intergration Test

2021-02-02 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-9881: - Fix Version/s: 2.6.0 > Verify whether RocksDBMetrics Get Measurements from RocksDB in a Unit Test

[GitHub] [kafka] C0urante commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-02 Thread GitBox
C0urante commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r568599861 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -171,13 +171,9 @@ protected void close() {

[GitHub] [kafka] C0urante commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-02 Thread GitBox
C0urante commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r568603419 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -202,6 +198,8 @@ public void removeMetrics() {

[GitHub] [kafka] C0urante commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-02 Thread GitBox
C0urante commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r568612017 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java ## @@ -288,14 +289,42 @@ public void

[GitHub] [kafka] rajinisivaram opened a new pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-02 Thread GitBox
rajinisivaram opened a new pull request #10022: URL: https://github.com/apache/kafka/pull/10022 Changes from https://issues.apache.org/jira/browse/KAFKA-10866 cause early return from KafkaConsumer.poll() even when records are not available. We should respect timeout specified in poll() and

[jira] [Resolved] (KAFKA-10366) TimeWindowedDeserializer doesn't allow users to set a custom window size

2021-02-02 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas resolved KAFKA-10366. - Fix Version/s: 2.8.0 Resolution: Fixed > TimeWindowedDeserializer doesn't allow users to

[jira] [Resolved] (KAFKA-9649) Remove/Warn on use of TimeWindowedSerde with no specified window size

2021-02-02 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas resolved KAFKA-9649. Fix Version/s: 2.8.0 Resolution: Fixed > Remove/Warn on use of TimeWindowedSerde with no spe

[GitHub] [kafka] ijuma commented on a change in pull request #9836: KAFKA-10866: Add metadata to ConsumerRecords

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #9836: URL: https://github.com/apache/kafka/pull/9836#discussion_r568623108 ## File path: build.gradle ## @@ -1070,6 +1070,7 @@ project(':clients') { testCompile libs.junitJupiterApi testCompile libs.junitVintageEngine

[GitHub] [kafka] ijuma commented on pull request #9836: KAFKA-10866: Add metadata to ConsumerRecords

2021-02-02 Thread GitBox
ijuma commented on pull request #9836: URL: https://github.com/apache/kafka/pull/9836#issuecomment-771655746 Have we verified that this doesn't cause perf regressions? It seems to have caused system test failures: https://issues.apache.org/jira/browse/KAFKA-12268 -

[GitHub] [kafka] C0urante commented on pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-02 Thread GitBox
C0urante commented on pull request #10016: URL: https://github.com/apache/kafka/pull/10016#issuecomment-771673592 Thanks for taking a look @gharris1727. I've tried to address your comments; let me know what you think. This i

[GitHub] [kafka] ijuma commented on a change in pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10009: URL: https://github.com/apache/kafka/pull/10009#discussion_r568649417 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -615,7 +615,7 @@ class TransactionCoordinator(brokerId:

[GitHub] [kafka] ijuma commented on a change in pull request #10009: MINOR: Introduce ProducerIdGenerator trait

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10009: URL: https://github.com/apache/kafka/pull/10009#discussion_r568650224 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -615,7 +615,7 @@ class TransactionCoordinator(brokerId:

[GitHub] [kafka] ijuma commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568653073 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -316,7 +324,7 @@ class ReplicaManager(val config: KafkaConfig, private def mayb

[GitHub] [kafka] C0urante commented on a change in pull request #10014: KAFKA-12252 and KAFKA-12262: Fix key rotation when leadership changes

2021-02-02 Thread GitBox
C0urante commented on a change in pull request #10014: URL: https://github.com/apache/kafka/pull/10014#discussion_r568653512 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -381,7 +381,7 @@ public void tick(

[GitHub] [kafka] C0urante commented on a change in pull request #10014: KAFKA-12252 and KAFKA-12262: Fix key rotation when leadership changes

2021-02-02 Thread GitBox
C0urante commented on a change in pull request #10014: URL: https://github.com/apache/kafka/pull/10014#discussion_r568654782 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -2161,6 +2163,83 @@ public Boo

[GitHub] [kafka] C0urante commented on pull request #10014: KAFKA-12252 and KAFKA-12262: Fix key rotation when leadership changes

2021-02-02 Thread GitBox
C0urante commented on pull request #10014: URL: https://github.com/apache/kafka/pull/10014#issuecomment-771682136 Thanks @gharris1727; I've tried to address your comments. Let me know what you think. This is an automated mes

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshot if leo less than the log start offset

2021-02-02 Thread GitBox
dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r568656400 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -173,13 +164,16 @@ final class KafkaMetadataLog private ( override def t

[GitHub] [kafka] dengziming commented on a change in pull request #10021: KAFKA-12205: Delete snapshot if leo less than the log start offset

2021-02-02 Thread GitBox
dengziming commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r568656553 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -267,23 +261,31 @@ final class KafkaMetadataLog private ( } } - ov

[GitHub] [kafka] CaoManhDat commented on a change in pull request #10021: KAFKA-12205: Delete snapshot if leo less than the log start offset

2021-02-02 Thread GitBox
CaoManhDat commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r568657609 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -173,13 +164,16 @@ final class KafkaMetadataLog private ( override def t

[GitHub] [kafka] rajinisivaram commented on pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
rajinisivaram commented on pull request #10007: URL: https://github.com/apache/kafka/pull/10007#issuecomment-771691510 @dajac Thanks for the review. Test failures not related, merging to trunk. This is an automated message fr

[GitHub] [kafka] rajinisivaram merged pull request #10007: KAFKA-10700 - Support mutual TLS authentication for SASL_SSL listeners (KIP-684)

2021-02-02 Thread GitBox
rajinisivaram merged pull request #10007: URL: https://github.com/apache/kafka/pull/10007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (KAFKA-10700) Support mutual TLS authentication for SASL_SSL listeners

2021-02-02 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-10700. Reviewer: David Jacot Resolution: Fixed > Support mutual TLS authentication for SASL

[GitHub] [kafka] ijuma commented on a change in pull request #10019: MINOR: Introduce KafkaBroker trait for use in dynamic reconfiguration

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10019: URL: https://github.com/apache/kafka/pull/10019#discussion_r568672128 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] inponomarev commented on a change in pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-02 Thread GitBox
inponomarev commented on a change in pull request #9107: URL: https://github.com/apache/kafka/pull/9107#discussion_r568681712 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Branched.scala ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Ap

[jira] [Assigned] (KAFKA-12263) Improve MockClient RequestMatcher interface

2021-02-02 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-12263: --- Assignee: Tom Bentley > Improve MockClient RequestMatcher interface > -

[GitHub] [kafka] rondagostino commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
rondagostino commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568716273 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -316,7 +324,7 @@ class ReplicaManager(val config: KafkaConfig, private d

[GitHub] [kafka] mumrah commented on a change in pull request #10018: Upstream MetadataImage and related classes

2021-02-02 Thread GitBox
mumrah commented on a change in pull request #10018: URL: https://github.com/apache/kafka/pull/10018#discussion_r568720185 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] mumrah commented on a change in pull request #10018: Upstream MetadataImage and related classes

2021-02-02 Thread GitBox
mumrah commented on a change in pull request #10018: URL: https://github.com/apache/kafka/pull/10018#discussion_r568723408 ## File path: core/src/main/scala/kafka/server/metadata/MetadataBrokers.scala ## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] rondagostino commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
rondagostino commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568730408 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -257,6 +264,37 @@ class ReplicaManager(val config: KafkaConfig, } }

[GitHub] [kafka] mumrah commented on a change in pull request #10018: Upstream MetadataImage and related classes

2021-02-02 Thread GitBox
mumrah commented on a change in pull request #10018: URL: https://github.com/apache/kafka/pull/10018#discussion_r568731023 ## File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala ## @@ -0,0 +1,282 @@ +/** + * Licensed to the Apache Software Foundation (

[jira] [Commented] (KAFKA-10091) Improve task idling

2021-02-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17277249#comment-17277249 ] John Roesler commented on KAFKA-10091: -- Reopened, since I still need to update the

[jira] [Reopened] (KAFKA-10091) Improve task idling

2021-02-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reopened KAFKA-10091: -- > Improve task idling > --- > > Key: KAFKA-10091 >

[jira] [Created] (KAFKA-12270) Kafka Connect may fail a task when racing to create topic

2021-02-02 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-12270: - Summary: Kafka Connect may fail a task when racing to create topic Key: KAFKA-12270 URL: https://issues.apache.org/jira/browse/KAFKA-12270 Project: Kafka I

[GitHub] [kafka] rondagostino commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
rondagostino commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568756317 ## File path: core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala ## @@ -111,7 +111,7 @@ class ReplicaAlterLogDirsThread(name: String,

[GitHub] [kafka] chia7712 commented on pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-02 Thread GitBox
chia7712 commented on pull request #10022: URL: https://github.com/apache/kafka/pull/10022#issuecomment-771781849 How about making ```Fetcher#fetchedRecords``` update metadata only if records is not empty? In other words, the [Fetcher.java#L643](https://github.com/apache/kafka/blob/trunk/c

[GitHub] [kafka] rajinisivaram commented on pull request #10022: KAFKA-12268; Return from KafkaConsumer.poll only when records available or timeout

2021-02-02 Thread GitBox
rajinisivaram commented on pull request #10022: URL: https://github.com/apache/kafka/pull/10022#issuecomment-771813678 @chia7712 Thanks for the review. There is a test that verifies that we get metadata even when there are no records (https://github.com/apache/kafka/blob/5c562efb2d76407011

[GitHub] [kafka] tombentley opened a new pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion

2021-02-02 Thread GitBox
tombentley opened a new pull request #10023: URL: https://github.com/apache/kafka/pull/10023 As described in [KAFKA-12263](https://issues.apache.org/jira/browse/KAFKA-12263), this PR refactors `MockClient.RequestMatcher` to become `MockClient.RequestAssertion` using assertions in the impl

[GitHub] [kafka] tombentley commented on pull request #10023: KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion

2021-02-02 Thread GitBox
tombentley commented on pull request #10023: URL: https://github.com/apache/kafka/pull/10023#issuecomment-771821577 @hachikuji since you raised the JIRA perhaps you could review this to check it's what you were after? This i

[jira] [Updated] (KAFKA-12263) Improve MockClient RequestMatcher interface

2021-02-02 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-12263: Flags: Patch Labels: patch-available (was: ) > Improve MockClient RequestMatcher interface >

[GitHub] [kafka] bob-barrett commented on pull request #9902: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-02 Thread GitBox
bob-barrett commented on pull request #9902: URL: https://github.com/apache/kafka/pull/9902#issuecomment-771823264 > For instance, we could try all the resolved IPs before applying the backoff. However, we would still have to wait until the connection timeouts for each IP. @dajac Th

[jira] [Created] (KAFKA-12271) Expose consistent Raft metadata to components

2021-02-02 Thread David Arthur (Jira)
David Arthur created KAFKA-12271: Summary: Expose consistent Raft metadata to components Key: KAFKA-12271 URL: https://issues.apache.org/jira/browse/KAFKA-12271 Project: Kafka Issue Type: Imp

[GitHub] [kafka] aloknnikhil commented on a change in pull request #9996: KAFKA-12249: KIP-500 - Add client-side Decommission Broker RPC

2021-02-02 Thread GitBox
aloknnikhil commented on a change in pull request #9996: URL: https://github.com/apache/kafka/pull/9996#discussion_r568814206 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -123,6 +124,9 @@ /** indicates whether the API is enabled f

[GitHub] [kafka] mjsax merged pull request #10020: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2021-02-02 Thread GitBox
mjsax merged pull request #10020: URL: https://github.com/apache/kafka/pull/10020 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] mjsax commented on pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2021-02-02 Thread GitBox
mjsax commented on pull request #9568: URL: https://github.com/apache/kafka/pull/9568#issuecomment-771851220 Back ported to `2.6` via #10020 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Updated] (KAFKA-10689) Assignor can't determine number of partitions on FJK with upstream windowed repartition

2021-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10689: Fix Version/s: 2.6.2 > Assignor can't determine number of partitions on FJK with upstream

[jira] [Created] (KAFKA-12272) Kafka Streams metric commit-latency-max and commit-latency-avg is always 0

2021-02-02 Thread Damien Gasparina (Jira)
Damien Gasparina created KAFKA-12272: Summary: Kafka Streams metric commit-latency-max and commit-latency-avg is always 0 Key: KAFKA-12272 URL: https://issues.apache.org/jira/browse/KAFKA-12272 Pr

[GitHub] [kafka] mjsax merged pull request #9974: KAFKA-10500: Add docs for failed stream thread metric

2021-02-02 Thread GitBox
mjsax merged pull request #9974: URL: https://github.com/apache/kafka/pull/9974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9974: KAFKA-10500: Add docs for failed stream thread metric

2021-02-02 Thread GitBox
mjsax commented on pull request #9974: URL: https://github.com/apache/kafka/pull/9974#issuecomment-771856604 Thanks for the PR @lct45! This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Assigned] (KAFKA-12272) Kafka Streams metric commit-latency-max and commit-latency-avg is always 0

2021-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12272: --- Assignee: Matthias J. Sax > Kafka Streams metric commit-latency-max and commit-late

[jira] [Updated] (KAFKA-12272) Kafka Streams metric commit-latency-max and commit-latency-avg is always 0

2021-02-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12272: Fix Version/s: 2.6.2 2.7.1 2.8.0 > Kafka Streams met

[GitHub] [kafka] gharris1727 commented on a change in pull request #10016: KAFKA-10340: Proactively close producer when cancelling source tasks

2021-02-02 Thread GitBox
gharris1727 commented on a change in pull request #10016: URL: https://github.com/apache/kafka/pull/10016#discussion_r568823888 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -171,13 +171,9 @@ protected void close() {

[GitHub] [kafka] gharris1727 commented on a change in pull request #10014: KAFKA-12252 and KAFKA-12262: Fix key rotation when leadership changes

2021-02-02 Thread GitBox
gharris1727 commented on a change in pull request #10014: URL: https://github.com/apache/kafka/pull/10014#discussion_r568830939 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -381,7 +381,7 @@ public void ti

[GitHub] [kafka] abbccdda commented on a change in pull request #10017: KAFKA-12260: Avoid hitting NPE for partitionsFor

2021-02-02 Thread GitBox
abbccdda commented on a change in pull request #10017: URL: https://github.com/apache/kafka/pull/10017#discussion_r568845018 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1948,7 +1948,7 @@ public OffsetAndMetadata committed(Top

[jira] [Created] (KAFKA-12273) InterBrokerSendThread#pollOnce throws FatalExitError even though it is shutdown correctly

2021-02-02 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12273: -- Summary: InterBrokerSendThread#pollOnce throws FatalExitError even though it is shutdown correctly Key: KAFKA-12273 URL: https://issues.apache.org/jira/browse/KAFKA-12273

[GitHub] [kafka] chia7712 opened a new pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-02 Thread GitBox
chia7712 opened a new pull request #10024: URL: https://github.com/apache/kafka/pull/10024 issue: https://issues.apache.org/jira/browse/KAFKA-12273 kafka tests sometimes shutdown gradle process with non-zero code. The (one of) root cause is that ```InterBrokerSendThread#pollOnce``` e

[GitHub] [kafka] ijuma commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568860838 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -316,7 +324,7 @@ class ReplicaManager(val config: KafkaConfig, private def mayb

[GitHub] [kafka] ijuma commented on a change in pull request #10003: MINOR: Add HostedPartition.Deferred state in ReplicaManager

2021-02-02 Thread GitBox
ijuma commented on a change in pull request #10003: URL: https://github.com/apache/kafka/pull/10003#discussion_r568862000 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -891,7 +944,7 @@ class ReplicaManager(val config: KafkaConfig, def processFai

[GitHub] [kafka] cmccabe merged pull request #9901: KAFKA-12209: Add the timeline data structures for the KIP-631 controller

2021-02-02 Thread GitBox
cmccabe merged pull request #9901: URL: https://github.com/apache/kafka/pull/9901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type-safe split() operator

2021-02-02 Thread GitBox
inponomarev commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-771925298 Hi @mjsax , I have rebased and manually merged conflicts, and also removed `FunctionConverters` JDK8 build still fails, but this time much later -- something related to

[jira] [Closed] (KAFKA-12190) Failure on Windows due to an UnsupportedOperationException when StateDirectory sets file permissions

2021-02-02 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman closed KAFKA-12190. -- > Failure on Windows due to an UnsupportedOperationException when > StateDirector

[jira] [Closed] (KAFKA-9176) Flaky test failure: OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore

2021-02-02 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman closed KAFKA-9176. - > Flaky test failure: > OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyS

[jira] [Closed] (KAFKA-10867) Implement improved semantics using the ConsumerRecords meta

2021-02-02 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman closed KAFKA-10867. -- > Implement improved semantics using the ConsumerRecords meta > --

[GitHub] [kafka] C0urante commented on pull request #10014: KAFKA-12252 and KAFKA-12262: Fix key rotation when leadership changes

2021-02-02 Thread GitBox
C0urante commented on pull request #10014: URL: https://github.com/apache/kafka/pull/10014#issuecomment-771935468 Ah whoops, the `PowerMock::verifyAll` broke the unit tests. Patched them up; should be good to go now. This is

[GitHub] [kafka] kkonstantine merged pull request #9319: KAFKA-10413: Allow for even distribution of lost/new tasks when multiple Connect workers join at the same time

2021-02-02 Thread GitBox
kkonstantine merged pull request #9319: URL: https://github.com/apache/kafka/pull/9319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-12274) Transactional operation fails when broker is replaced using the same broker ID.

2021-02-02 Thread Jira
Michał Łukowicz created KAFKA-12274: --- Summary: Transactional operation fails when broker is replaced using the same broker ID. Key: KAFKA-12274 URL: https://issues.apache.org/jira/browse/KAFKA-12274

[GitHub] [kafka] ableegoldman commented on pull request #9247: KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted

2021-02-02 Thread GitBox
ableegoldman commented on pull request #9247: URL: https://github.com/apache/kafka/pull/9247#issuecomment-771942436 Cherrypicked to 2.6 for 2.6.2 release This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (KAFKA-12274) Transactional operation fails when broker is replaced using the same broker ID.

2021-02-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Łukowicz updated KAFKA-12274: Description: Hello Team! One of our clusters is being used to: * process transactional w

[jira] [Updated] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2021-02-02 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10362: --- Fix Version/s: 2.6.2 > When resuming Streams active task with EOS, the check

  1   2   3   >