tang7526 opened a new pull request #10012:
URL: https://github.com/apache/kafka/pull/10012
- Invoke method only conditionally.
- No need to call "toString()" method as formatting and string conversion is
done by the Formatter.
before
```java
log.info("Successfully validate
showuon commented on a change in pull request #9777:
URL: https://github.com/apache/kafka/pull/9777#discussion_r567650065
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -885,6 +891,24 @@ object TestUtils extends Logging {
), "Timed out waiting for
showuon commented on pull request #9777:
URL: https://github.com/apache/kafka/pull/9777#issuecomment-770691251
@hachikuji , thanks for the comments. I've updated:
1. rename the method:
`waitUntilMetadataIsPropagatedWithExpectedSize` ->
`waitForAllPartitionMetadata`
`waitUntilMetada
showuon commented on a change in pull request #10010:
URL: https://github.com/apache/kafka/pull/10010#discussion_r567662275
##
File path:
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java
##
@@ -276,52 +277,46 @@ public RestrictedClassLoader() {
showuon commented on a change in pull request #10010:
URL: https://github.com/apache/kafka/pull/10010#discussion_r567662357
##
File path:
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java
##
@@ -276,52 +277,46 @@ public RestrictedClassLoader() {
showuon commented on a change in pull request #10010:
URL: https://github.com/apache/kafka/pull/10010#discussion_r567662443
##
File path:
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java
##
@@ -276,52 +277,46 @@ public RestrictedClassLoader() {
chia7712 commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r567655022
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/TopicListing.java
##
@@ -17,24 +17,36 @@
package org.apache.kafka.clients.admin;
+
chia7712 commented on pull request #10010:
URL: https://github.com/apache/kafka/pull/10010#issuecomment-770703994
@showuon Thanks for your reviews. I have addressed your comment by
https://github.com/apache/kafka/pull/10010/commits/dac031f228c8e8db02de2f17e14f43a96db11b8e
[
https://issues.apache.org/jira/browse/KAFKA-12257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee reassigned KAFKA-12257:
-
Assignee: lqjacklee
> Consumer mishandles topics deleted and recreated with the same name
> --
rajinisivaram commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770724994
@dengziming Have you tried any system tests with this PR? @jolshan ran a
system tests build on this branch twice and found quite a few tests had failed.
It is not clear whet
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r567718317
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1191,8 +1192,35 @@ class KafkaApis(val requestChannel: RequestChannel,
val met
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r567719703
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1191,8 +1192,35 @@ class KafkaApis(val requestChannel: RequestChannel,
val met
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770761700
@rajinisivaram I haven't run any system tests and I will try to run some
system tests later.
This is an autom
dengziming removed a comment on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770761700
@rajinisivaram I haven't run any system tests and I will try to run some
system tests later.
This is
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770763376
@rajinisivaram I haven't run any system tests and I will try to run some
system tests later. Should I run the 2 python script locally and analyze the
logs?
--
rajinisivaram commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770860477
@dengziming Yes, if you are able to run those two tests locally, that will
be good. The failures looked similar with consumer failing to consume, so I
guess may be only one
showuon commented on a change in pull request #9777:
URL: https://github.com/apache/kafka/pull/9777#discussion_r567837343
##
File path: core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
##
@@ -137,12 +137,12 @@ class AddPartitionsTest extends BaseRequestTest {
a
Chris Egerton created KAFKA-12262:
-
Summary: New session keys are never distributed when follower with
key becomes leader
Key: KAFKA-12262
URL: https://issues.apache.org/jira/browse/KAFKA-12262
Projec
rondagostino commented on pull request #10009:
URL: https://github.com/apache/kafka/pull/10009#issuecomment-770914261
Only test failure is a known flaky test:
https://issues.apache.org/jira/browse/KAFKA-7940
This is an autom
rondagostino opened a new pull request #10013:
URL: https://github.com/apache/kafka/pull/10013
`TransactionStateManager` currently uses ZooKeeper to obtain any non-default
value for the `__transaction_state` partition count. ZooKeeper will not be
available when the broker uses a Raft-base
rondagostino commented on pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#issuecomment-770924558
The combination of this PR and https://github.com/apache/kafka/pull/10009/
will remove hard ZooKeeper dependencies from the `TransactionCoordinator` and
`TransactionStateMa
feyman2016 commented on pull request #9739:
URL: https://github.com/apache/kafka/pull/9739#issuecomment-770938213
Fixed the KafkaMetadataLogTest, let's see if jenkins still complains~
This is an automated message from the Apa
C0urante opened a new pull request #10014:
URL: https://github.com/apache/kafka/pull/10014
Address [KAFKA-12252](https://issues.apache.org/jira/browse/KAFKA-12252) and
[KAFKA-12262](https://issues.apache.org/jira/browse/KAFKA-12262).
- To address `KAFKA-12262`, all workers now track
C0urante commented on pull request #10014:
URL: https://github.com/apache/kafka/pull/10014#issuecomment-770951057
@gharris1727 @ncliang would either of you like to take a look?
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12262:
--
Component/s: KafkaConnect
> New session keys are never distributed when follower with key beco
rondagostino commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r567943552
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -318,8 +318,9 @@ class KafkaServer(
/* start group coordinator */
ijuma commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r567952139
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.record.Re
mumrah commented on a change in pull request #9986:
URL: https://github.com/apache/kafka/pull/9986#discussion_r567956186
##
File path: core/src/test/java/kafka/test/ClusterInstance.java
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
mumrah commented on a change in pull request #9986:
URL: https://github.com/apache/kafka/pull/9986#discussion_r567956723
##
File path: build.gradle
##
@@ -1011,7 +1011,10 @@ project(':core') {
}
test {
java {
-srcDirs = ["src/generated/java", "src/test/
mumrah commented on a change in pull request #9986:
URL: https://github.com/apache/kafka/pull/9986#discussion_r567957941
##
File path: core/src/test/java/kafka/test/annotation/ClusterProperty.java
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
rondagostino commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r567962340
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.re
ijuma commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r567966872
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.record.Re
ijuma commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r567967281
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.record.Re
mumrah commented on a change in pull request #9986:
URL: https://github.com/apache/kafka/pull/9986#discussion_r567970806
##
File path: core/src/test/java/kafka/test/ClusterForEachTest.java
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
C0urante commented on pull request #9987:
URL: https://github.com/apache/kafka/pull/9987#issuecomment-770994329
Ping @kkonstantine this needs to be merged before any release with
https://github.com/apache/kafka/pull/9806 is put out.
C0urante edited a comment on pull request #9987:
URL: https://github.com/apache/kafka/pull/9987#issuecomment-770994329
Ping @kkonstantine this needs to be merged before any release with the
changes from https://github.com/apache/kafka/pull/9806 is put out.
mumrah commented on pull request #9992:
URL: https://github.com/apache/kafka/pull/9992#issuecomment-770999448
Looks like one of the tests got hung up and the build timed out:
```
16:04:09 SocketServerTest >
testStagedListenerShutdownWhenConnectionQueueIsFull() STARTED
16:04:09
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276498#comment-17276498
]
Chris Egerton commented on KAFKA-10340:
---
The logging changes are certainly an impr
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-10340:
--
Fix Version/s: (was: 2.6.1)
(was: 2.7.0)
> Source connectors should
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reopened KAFKA-10340:
---
Assignee: Chris Egerton (was: Luke Chen)
> Source connectors should report error when try
cmccabe commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r568009986
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -318,8 +318,9 @@ class KafkaServer(
/* start group coordinator */
[
https://issues.apache.org/jira/browse/KAFKA-12262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12262:
--
Description:
The expiration time for session keys [starts at
{{Long.MAX_VALUE}}|https://githu
cmccabe commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r568009986
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -318,8 +318,9 @@ class KafkaServer(
/* start group coordinator */
cmccabe commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r568011675
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.record.
hachikuji commented on a change in pull request #10006:
URL: https://github.com/apache/kafka/pull/10006#discussion_r568013407
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -1745,51 +1742,78 @@ public void testSeekWithInF
Jason Gustafson created KAFKA-12263:
---
Summary: Improve MockClient RequestMatcher interface
Key: KAFKA-12263
URL: https://issues.apache.org/jira/browse/KAFKA-12263
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12263:
Description:
MockClient has a RequestMatcher interface which is used to verify that a
req
cmccabe commented on pull request #10009:
URL: https://github.com/apache/kafka/pull/10009#issuecomment-771029381
This one looks good to me...
This is an automated message from the Apache Git Service.
To respond to the message
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568027824
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568028002
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568028493
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568029191
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568030332
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java
##
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundatio
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568030679
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java
##
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundatio
hachikuji merged pull request #9739:
URL: https://github.com/apache/kafka/pull/9739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10636.
-
Resolution: Fixed
> Bypass log validation for writes to raft log
> -
aloknnikhil commented on a change in pull request #9994:
URL: https://github.com/apache/kafka/pull/9994#discussion_r568033553
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##
@@ -98,7 +98,9 @@
UPDATE_FEATURES(ApiMessageType.UPDATE_FEATUR
jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r568033865
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -358,6 +452,15 @@ public int sessionId() {
.
aloknnikhil commented on a change in pull request #9994:
URL: https://github.com/apache/kafka/pull/9994#discussion_r568033646
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -232,6 +232,9 @@ class KafkaApis(val requestChannel: RequestChannel,
case
jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r568034891
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -358,6 +452,15 @@ public int sessionId() {
.
hachikuji merged pull request #9777:
URL: https://github.com/apache/kafka/pull/9777
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rondagostino commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r568046183
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -30,6 +30,13 @@ import org.apache.kafka.common.re
rondagostino closed pull request #10013:
URL: https://github.com/apache/kafka/pull/10013
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rondagostino commented on pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#issuecomment-771063821
Closing this PR -- I consolidated these changes into
https://github.com/apache/kafka/pull/10008 so we can review them together.
---
Jeff Kim created KAFKA-12264:
Summary: JMH BaseRecordBatchBenchmark ZSTD error
Key: KAFKA-12264
URL: https://issues.apache.org/jira/browse/KAFKA-12264
Project: Kafka
Issue Type: Bug
R
junrao commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568039786
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshotRegistry.java
##
@@ -0,0 +1,247 @@
+/*
+ * Licensed to the Apache Software Foundation
aloknnikhil commented on pull request #9994:
URL: https://github.com/apache/kafka/pull/9994#issuecomment-771079401
> Left a couple comments. You will need to update RequestConvertToJson as
well. Probably we should have some tests in RequestResponseTest as well.
Done.
-
aloknnikhil commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568065511
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##
@@ -98,7 +98,8 @@
UPDATE_FEATURES(ApiMessageType.UPDATE_FEATUR
vvcephei commented on a change in pull request #9997:
URL: https://github.com/apache/kafka/pull/9997#discussion_r568067987
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -111,13 +112,16 @@ public void initialize(
aloknnikhil commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568069107
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1449,6 +1449,39 @@ default DescribeFeaturesResult describeFeatures(
aloknnikhil commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568070217
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4503,6 +4506,47 @@ void handleFailure(Throwable throwab
aloknnikhil commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568072205
##
File path:
clients/src/main/resources/common/message/DecommissionBrokerResponse.json
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundat
aloknnikhil commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568074009
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3296,6 +3298,13 @@ class KafkaApis(val requestChannel: RequestChannel,
handle
jolshan commented on a change in pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#discussion_r568078414
##
File path: clients/src/main/java/org/apache/kafka/clients/MetadataCache.java
##
@@ -130,13 +149,30 @@ MetadataCache mergeWith(String newClusterId,
vvcephei commented on a change in pull request #9997:
URL: https://github.com/apache/kafka/pull/9997#discussion_r568069417
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java
##
@@ -111,13 +112,16 @@ public void initialize(
hachikuji merged pull request #10006:
URL: https://github.com/apache/kafka/pull/10006
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/KAFKA-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12245.
-
Resolution: Fixed
> fix flay
> org.apache.kafka.clients.consumer.internals.FetcherTest.
hachikuji opened a new pull request #10015:
URL: https://github.com/apache/kafka/pull/10015
This patch factors out a trait to allow for other ways to provide the
controller `Node` object to `BrokerToControllerChannelManager`. In KIP-500, the
controller will be provided from the Raft client
hachikuji commented on pull request #9994:
URL: https://github.com/apache/kafka/pull/9994#issuecomment-771137129
@aloknnikhil Looks like we will need to fix some failures in `ApiKeysTest`
before we can merge this. I suspect that the test does not like the throttle
time fields. One way we c
mumrah commented on a change in pull request #10009:
URL: https://github.com/apache/kafka/pull/10009#discussion_r568133942
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -615,7 +615,7 @@ class TransactionCoordinator(brokerId:
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568134210
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
mumrah commented on a change in pull request #10009:
URL: https://github.com/apache/kafka/pull/10009#discussion_r568134453
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##
@@ -615,7 +615,7 @@ class TransactionCoordinator(brokerId:
C0urante opened a new pull request #10016:
URL: https://github.com/apache/kafka/pull/10016
[Jira](https://issues.apache.org/jira/browse/KAFKA-10340)
When a source task produces records for a topic that doesn't exist on the
Kafka cluster and automatic topic creation is disabled on the
C0urante commented on pull request #10016:
URL: https://github.com/apache/kafka/pull/10016#issuecomment-771154039
@gharris1727 @ncliang @sajanaW would any of you have time to take a look?
This is an automated message from the
mumrah commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r568142924
##
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala
##
@@ -96,7 +108,20 @@ class TransactionStateManager(brokerI
abbccdda opened a new pull request #10017:
URL: https://github.com/apache/kafka/pull/10017
As mentioned in the ticket, returning `null` for `consumer#partitionsFor` is
not a good client side agreement. Addressing this problem by returning the
empty list instead.
### Committer Checkl
mumrah commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r568144003
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -78,7 +78,20 @@ class GroupMetadataManager(brokerId: Int,
pr
mumrah commented on pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#issuecomment-771166135
What is the motivation for making transactionTopicPartitionCount and
groupMetadataTopicPartitionCount lazy? Is it because in the KIP-500 world, we
may not yet have this metadata
mumrah commented on a change in pull request #10008:
URL: https://github.com/apache/kafka/pull/10008#discussion_r568149064
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -78,7 +78,20 @@ class GroupMetadataManager(brokerId: Int,
pr
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568157113
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,449 @@
+/*
+ * Licensed to the Apache Software Fou
ableegoldman commented on a change in pull request #9997:
URL: https://github.com/apache/kafka/pull/9997#discussion_r568158224
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -714,19 +720,34 @@ public boolean process(final
junrao commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568172947
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Foun
mumrah opened a new pull request #10018:
URL: https://github.com/apache/kafka/pull/10018
Mostly a wholesale copy of the files from confluentinc/kip-500, with a few
fixes for the test classes
This is an automated message from
gharris1727 commented on a change in pull request #10014:
URL: https://github.com/apache/kafka/pull/10014#discussion_r568174791
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
##
@@ -381,7 +381,7 @@ public void ti
hachikuji merged pull request #10015:
URL: https://github.com/apache/kafka/pull/10015
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
hachikuji edited a comment on pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#issuecomment-770067513
Note also the test failure
`RequestConvertToJsonTest.testAllResponseTypesHandled`.
This is an automated
gharris1727 commented on a change in pull request #10016:
URL: https://github.com/apache/kafka/pull/10016#discussion_r568190708
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -202,6 +198,8 @@ public void removeMetrics()
hachikuji commented on a change in pull request #9996:
URL: https://github.com/apache/kafka/pull/9996#discussion_r568200014
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
##
@@ -98,7 +98,8 @@
UPDATE_FEATURES(ApiMessageType.UPDATE_FEATURES
cmccabe commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r568201202
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,453 @@
+/*
+ * Licensed to the Apache Software Fou
rondagostino opened a new pull request #10019:
URL: https://github.com/apache/kafka/pull/10019
Dynamic broker reconfiguration needs to occur for both ZooKeeper-based
brokers and brokers that use a Raft-based metadata quorum.
`DynamicBrokerConfig` currently operates on `KafkaServer`, but i
1 - 100 of 164 matches
Mail list logo
