[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264685#comment-17264685
]
Andy Wilkinson commented on KAFKA-12190:
Yes, I'd be happy to provide a patch. W
Luke Chen created KAFKA-12194:
-
Summary: fix flaky AdjustStreamThreadCountTest tests
Key: KAFKA-12194
URL: https://issues.apache.org/jira/browse/KAFKA-12194
Project: Kafka
Issue Type: Test
Chia-Ping Tsai created KAFKA-12195:
--
Summary: Fix synchronization issue happening in KafkaStreams
(related to flaky AdjustStreamThreadCountTest)
Key: KAFKA-12195
URL: https://issues.apache.org/jira/browse/KAFKA-1
[
https://issues.apache.org/jira/browse/KAFKA-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-12195:
---
Issue Type: Bug (was: Improvement)
> Fix synchronization issue happening in KafkaStreams (r
chia7712 opened a new pull request #9887:
URL: https://github.com/apache/kafka/pull/9887
issue: https://issues.apache.org/jira/browse/KAFKA-12195
```
threads = Collections.synchronizedList(new LinkedList<>());
```
The synchronization list requires us to manually synchroni
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557230927
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -119,7 +119,6 @@ public void shouldAddStre
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557231712
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -989,16 +986,20 @@ private StreamThread createAndAddStreamThread(final
showuon opened a new pull request #9888:
URL: https://github.com/apache/kafka/pull/9888
The tests are flaky because we used the `waitForApplicationState` to wait
for a state. `waitForApplicationState` is using poll to the current stream
state, which might miss some state changes.
Ex: s
chia7712 commented on pull request #9847:
URL: https://github.com/apache/kafka/pull/9847#issuecomment-760059848
> The alternative would be to allow creation of such instances and fail on
the relevant calls to the Admin client, which is more complicated for no
obvious benefit imho.
I
showuon commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760060655
@wcarlson5 @ableegoldman @cadonna , could you help review this PR? Thanks.
This is an automated message from the A
chia7712 commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760070441
oh, we are working at same issue again (#9887) :(
This is an automated message from the Apache Git Service.
To re
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557253503
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -119,7 +119,6 @@ public void shouldAddStre
Chia-Ping Tsai created KAFKA-12196:
--
Summary: Migrate connect:api module to JUnit 5
Key: KAFKA-12196
URL: https://issues.apache.org/jira/browse/KAFKA-12196
Project: Kafka
Issue Type: Sub-tas
showuon commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557256217
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -119,7 +119,6 @@ public void shouldAddStrea
Chia-Ping Tsai created KAFKA-12197:
--
Summary: Migrate connect:transforms module to JUnit 5
Key: KAFKA-12197
URL: https://issues.apache.org/jira/browse/KAFKA-12197
Project: Kafka
Issue Type:
Chia-Ping Tsai created KAFKA-12198:
--
Summary: Migrate connect:json module to JUnit 5
Key: KAFKA-12198
URL: https://issues.apache.org/jira/browse/KAFKA-12198
Project: Kafka
Issue Type: Sub-ta
Chia-Ping Tsai created KAFKA-12200:
--
Summary: Migrate connect:file module to JUnit 5
Key: KAFKA-12200
URL: https://issues.apache.org/jira/browse/KAFKA-12200
Project: Kafka
Issue Type: Sub-ta
Chia-Ping Tsai created KAFKA-12199:
--
Summary: Migrate connect:runtime module to JUnit 5
Key: KAFKA-12199
URL: https://issues.apache.org/jira/browse/KAFKA-12199
Project: Kafka
Issue Type: Sub
Chia-Ping Tsai created KAFKA-12201:
--
Summary: Migrate connect:basic-auth-extensio module to JUnit 5
Key: KAFKA-12201
URL: https://issues.apache.org/jira/browse/KAFKA-12201
Project: Kafka
Iss
Chia-Ping Tsai created KAFKA-12202:
--
Summary: Migrate connect:mirror module to JUnit 5
Key: KAFKA-12202
URL: https://issues.apache.org/jira/browse/KAFKA-12202
Project: Kafka
Issue Type: Sub-
Chia-Ping Tsai created KAFKA-12203:
--
Summary: Migrate connect:mirror-client module to JUnit 5
Key: KAFKA-12203
URL: https://issues.apache.org/jira/browse/KAFKA-12203
Project: Kafka
Issue Typ
[
https://issues.apache.org/jira/browse/KAFKA-12203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12203:
--
Assignee: Chia-Ping Tsai
> Migrate connect:mirror-client module to JUnit 5
>
chia7712 opened a new pull request #9889:
URL: https://github.com/apache/kafka/pull/9889
issue: https://issues.apache.org/jira/browse/KAFKA-12203
Only changes the imports and the dependencies.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and imp
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557265629
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -148,7 +146,6 @@ public void shouldAddAndR
[
https://issues.apache.org/jira/browse/KAFKA-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
GeordieMai reassigned KAFKA-12196:
--
Assignee: GeordieMai
> Migrate connect:api module to JUnit 5
> --
chia7712 merged pull request #9886:
URL: https://github.com/apache/kafka/pull/9886
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264728#comment-17264728
]
GeordieMai commented on KAFKA-12196:
[~chia7712] I assign this to myself . if you a
[
https://issues.apache.org/jira/browse/KAFKA-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264730#comment-17264730
]
Chia-Ping Tsai commented on KAFKA-12196:
feel free to take over it :)
> Migrate
[
https://issues.apache.org/jira/browse/KAFKA-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264731#comment-17264731
]
dengziming commented on KAFKA-12198:
Hello [~chia7712] , I will do this one.;)
> Mi
[
https://issues.apache.org/jira/browse/KAFKA-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12198:
--
Assignee: dengziming
> Migrate connect:json module to JUnit 5
> -
[
https://issues.apache.org/jira/browse/KAFKA-12200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264737#comment-17264737
]
ChunHao commented on KAFKA-12200:
-
[~chia7712] Can you please assign this to me？
> Migr
[
https://issues.apache.org/jira/browse/KAFKA-12185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-12185:
-
Assignee: Bruno Cadonna
> Flaky Test StoreQueryIntegrationTest#shouldQueryAllStaleParti
[
https://issues.apache.org/jira/browse/KAFKA-12185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reopened KAFKA-12185:
---
> Flaky Test StoreQueryIntegrationTest#shouldQueryAllStalePartitionStores
>
[
https://issues.apache.org/jira/browse/KAFKA-12185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna reassigned KAFKA-12185:
-
Assignee: (was: Bruno Cadonna)
> Flaky Test StoreQueryIntegrationTest#shouldQueryAl
dengziming opened a new pull request #9890:
URL: https://github.com/apache/kafka/pull/9890
*More detailed description of your change*
Use junit5 methods to replace junit4 ones
*Summary of testing strategy (including rationale)*
### Committer Checklist (excluded from commit m
mimaison commented on pull request #9885:
URL: https://github.com/apache/kafka/pull/9885#issuecomment-760106919
@showuon That's definitively a mistake, thanks for the PR
This is an automated message from the Apache Git Servic
[
https://issues.apache.org/jira/browse/KAFKA-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-12197:
--
Assignee: dengziming
> Migrate connect:transforms module to JUnit 5
> ---
17hao opened a new pull request #9891:
URL: https://github.com/apache/kafka/pull/9891
Remind user index file is empty when dumping LogSegment xxx.index file
instead of throwing an `NoSuchElementException`.
BEFORE
![image](https://user-images.githubusercontent.com/18420212/1045806
cadonna commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557319308
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -61,15 +61,16 @@
@Rule
public Tes
[
https://issues.apache.org/jira/browse/KAFKA-12200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12200:
--
Assignee: ChunHao
> Migrate connect:file module to JUnit 5
>
[
https://issues.apache.org/jira/browse/KAFKA-12200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264815#comment-17264815
]
Chia-Ping Tsai commented on KAFKA-12200:
done
> Migrate connect:file module to
mimaison commented on pull request #9885:
URL: https://github.com/apache/kafka/pull/9885#issuecomment-760159015
Tests passed locally, merging to trunk
This is an automated message from the Apache Git Service.
To respond to th
mimaison merged pull request #9885:
URL: https://github.com/apache/kafka/pull/9885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison merged pull request #9844:
URL: https://github.com/apache/kafka/pull/9844
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison commented on pull request #9726:
URL: https://github.com/apache/kafka/pull/9726#issuecomment-760164790
Ping @rhauch @kkonstantine
The vote for this KIP passed, can you do a review? Thanks
This is an autom
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557265629
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -148,7 +146,6 @@ public void shouldAddAndR
ijuma merged pull request #9882:
URL: https://github.com/apache/kafka/pull/9882
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma reassigned KAFKA-12201:
---
Assignee: Ismael Juma
> Migrate connect:basic-auth-extensio module to JUnit 5
> ---
ijuma opened a new pull request #9892:
URL: https://github.com/apache/kafka/pull/9892
Also:
* Remove unused powermock dependency
* Remove "examples" from the JUnit 4 list since one module was already
converted and the other has no tests
### Committer Checklist (excluded from
ijuma commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r557397651
##
File path:
core/src/test/scala/unit/kafka/server/epoch/LeaderEpochFileCacheTest.scala
##
@@ -267,7 +267,7 @@ class LeaderEpochFileCacheTest {
cache.a
dengziming opened a new pull request #9893:
URL: https://github.com/apache/kafka/pull/9893
*More detailed description of your change*
"mirorr-client" => "mirror-client"
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded from commit me
dengziming commented on pull request #9893:
URL: https://github.com/apache/kafka/pull/9893#issuecomment-760204975
@ijuma Hi, PTAL, maybe you forget to check.
This is an automated message from the Apache Git Service.
To respon
ijuma commented on pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#issuecomment-760205274
Quick update: I reviewed over 200 files, so I think I'll be able to complete
this later today.
This is an automated
ijuma merged pull request #9893:
URL: https://github.com/apache/kafka/pull/9893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r557408197
##
File path: build.gradle
##
@@ -787,9 +787,7 @@ project(':core') {
testCompile libs.apachedsLdifPartition
testCompile libs.apachedsMavibotPartitio
chia7712 commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r557411439
##
File path: build.gradle
##
@@ -787,9 +787,7 @@ project(':core') {
testCompile libs.apachedsLdifPartition
testCompile libs.apachedsMavibotParti
ijuma commented on pull request #9858:
URL: https://github.com/apache/kafka/pull/9858#issuecomment-760223320
For the Stream modules, we should get one of the committers that is more
involved in that part. @mjsax and @vvcephei are two possible candidates.
--
[
https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264912#comment-17264912
]
Corentin Chary commented on KAFKA-5761:
---
was there any progress on this?
> Seriali
[
https://issues.apache.org/jira/browse/KAFKA-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264913#comment-17264913
]
Chia-Ping Tsai commented on KAFKA-5761:
---
[~iksaif] I don't have free cycles for thi
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557431921
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -230,4 +235,33 @@ public void
shouldAddAn
[
https://issues.apache.org/jira/browse/KAFKA-12190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264922#comment-17264922
]
Leah Thomas commented on KAFKA-12190:
-
Hey [~awilkinson], the 2.8 release plan is he
mumrah commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r557444603
##
File path: core/src/main/scala/kafka/server/ApisUtils.scala
##
@@ -0,0 +1,204 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557446077
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -88,69 +89,96 @@ public void setup() {
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557446304
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -61,15 +61,16 @@
@Rule
public Tes
ijuma commented on pull request #9849:
URL: https://github.com/apache/kafka/pull/9849#issuecomment-760242070
I updated the PR, but I need to verify that Jenkins handles merged reruns
correctly. If not, I will revert that part of the change.
showuon commented on a change in pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#discussion_r557447421
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -88,69 +89,96 @@ public void setup() {
mimaison merged pull request #9224:
URL: https://github.com/apache/kafka/pull/9224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
showuon commented on pull request #9888:
URL: https://github.com/apache/kafka/pull/9888#issuecomment-760243162
@cadonna , thanks for the comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9888/commits/c7218be8966e282322bdc1c512349ebce618bcbc.
Thank you.
-
ijuma commented on pull request #9527:
URL: https://github.com/apache/kafka/pull/9527#issuecomment-760247708
Thanks @chia7712.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264933#comment-17264933
]
Ismael Juma commented on KAFKA-10877:
-
[~smccauliff] Any update on the PR?
> Instan
ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r557460726
##
File path: core/src/main/scala/kafka/server/RequestHandlerUtils.scala
##
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r557461217
##
File path: core/src/main/scala/kafka/server/RequestHandlerUtils.scala
##
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on a change in pull request #9715:
URL: https://github.com/apache/kafka/pull/9715#discussion_r557461217
##
File path: core/src/main/scala/kafka/server/RequestHandlerUtils.scala
##
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264948#comment-17264948
]
ASF GitHub Bot commented on KAFKA-6223:
---
mimaison opened a new pull request #322:
U
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557478586
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -230,4 +235,33 @@ public void
shouldAddAn
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557478586
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -230,4 +235,33 @@ public void
shouldAddAn
chia7712 commented on a change in pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#discussion_r557479126
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -951,12 +948,15 @@ private StreamThread createAndAddStreamThread(final
chia7712 commented on pull request #9887:
URL: https://github.com/apache/kafka/pull/9887#issuecomment-760269796
@cadonna Could you take a look at those concurrent issues (see description)
? I'm digging in it to observe whether there are more issues. Thanks!
---
[
https://issues.apache.org/jira/browse/KAFKA-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10851:
-
Component/s: core
> Add Cluster Describe API
>
>
> Key:
[
https://issues.apache.org/jira/browse/KAFKA-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264967#comment-17264967
]
Mickael Maison commented on KAFKA-6223:
---
Thanks for the update [~sebb].
Once https
[
https://issues.apache.org/jira/browse/KAFKA-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12202:
--
Assignee: Chia-Ping Tsai
> Migrate connect:mirror module to JUnit 5
> ---
chia7712 commented on a change in pull request #9890:
URL: https://github.com/apache/kafka/pull/9890#discussion_r557500879
##
File path:
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java
##
@@ -56,12 +55,12 @@
import java.util.TimeZone;
import
David Jacot created KAFKA-12204:
---
Summary: Implement DescribeCluster API on the broker
Key: KAFKA-12204
URL: https://issues.apache.org/jira/browse/KAFKA-12204
Project: Kafka
Issue Type: Sub-tas
dengziming commented on a change in pull request #9890:
URL: https://github.com/apache/kafka/pull/9890#discussion_r557506915
##
File path:
connect/json/src/test/java/org/apache/kafka/connect/json/JsonConverterTest.java
##
@@ -131,8 +130,8 @@ public void doubleToConnect() {
[
https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12199:
--
Assignee: Chia-Ping Tsai
> Migrate connect:runtime module to JUnit 5
> --
chia7712 opened a new pull request #9894:
URL: https://github.com/apache/kafka/pull/9894
issue: https://issues.apache.org/jira/browse/KAFKA-12202
This PR consists of following changes.
1. replace junit 4 APIs by junit 5
2. remove the dependencies of junit 4 from ```EmbeddedK
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-760310777
Thanks @mimaison so much for your multiple rounds of valuable feedback and
comments which greatly improving the code quality of this PR
[
https://issues.apache.org/jira/browse/KAFKA-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265006#comment-17265006
]
Sean McCauliff commented on KAFKA-10877:
I found many places where the Logging t
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557537324
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -113,6 +145,22 @@ class KafkaMetadataLog(
log.truncateTo(offset)
}
+ ov
Jose Armando Garcia Sancio created KAFKA-12205:
--
Summary: Delete snapshots if it's end offset is less than the log
start offset
Key: KAFKA-12205
URL: https://issues.apache.org/jira/browse/KAFKA-12205
[
https://issues.apache.org/jira/browse/KAFKA-10877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17265009#comment-17265009
]
Ismael Juma commented on KAFKA-10877:
-
Sounds good.
> Instantiating loggers for eve
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557556584
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557557769
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557557769
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
cadonna opened a new pull request #9895:
URL: https://github.com/apache/kafka/pull/9895
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
cadonna commented on pull request #9895:
URL: https://github.com/apache/kafka/pull/9895#issuecomment-760336972
Call for review: @guozhangwang @ableegoldman @lct45
This is an automated message from the Apache Git Service.
To
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557563029
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557565077
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -147,18 +199,106 @@ class KafkaMetadataLog(
}
override def createSnapshot(
hachikuji commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557559024
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGER_
aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557571170
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -129,16 +133,41 @@ public String toString() {
QUORUM_LINGE
1 - 100 of 190 matches
Mail list logo
