[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543134773 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543168812 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543168812 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543174139 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543174139 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[GitHub] [kafka] mdespriee commented on pull request #9738: [KAFKA-8744] update scala API to give names to processors

mdespriee commented on pull request #9738: URL: https://github.com/apache/kafka/pull/9738#issuecomment-745166221 Failing tests looks like flaky tests. Seems unrelated to this change. This is an automated message from the Apac

[GitHub] [kafka] tombentley commented on a change in pull request #9552: KAFKA-10656: Log the feature flags received by the client

tombentley commented on a change in pull request #9552: URL: https://github.com/apache/kafka/pull/9552#discussion_r543183384 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -917,7 +917,10 @@ private void handleApiVersionsResponse(List resp

[GitHub] [kafka] chia7712 opened a new pull request #9755: MINOR: refactor SelectingIterator by scala iterator

chia7712 opened a new pull request #9755: URL: https://github.com/apache/kafka/pull/9755 ```SelectingIterator``` can be replaced by scala iterator with filter. Also, this PR adds a unit test for it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and imp

[GitHub] [kafka] vamossagar12 opened a new pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

vamossagar12 opened a new pull request #9756: URL: https://github.com/apache/kafka/pull/9756 This PR aims to add leader fsync occur with size based heuristic. Meaning, if we accumulate a configurable N bytes, then we should not wait for linger expiration and should just fsync immediately.

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9622: KAFKA-10547; add topicId in MetadataResp

rajinisivaram commented on a change in pull request #9622: URL: https://github.com/apache/kafka/pull/9622#discussion_r543224093 ## File path: clients/src/main/java/org/apache/kafka/common/Cluster.java ## @@ -46,6 +46,8 @@ private final Map> partitionsByNode; private f

[GitHub] [kafka] cadonna commented on a change in pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

cadonna commented on a change in pull request #9708: URL: https://github.com/apache/kafka/pull/9708#discussion_r543222611 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/StreamJoined.java ## @@ -36,6 +39,8 @@ protected final WindowBytesStoreSupplier o

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-745239513 @guozhangwang that's a much better solution, thanks! I've implemented that and rebased for a conflict. This i

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

rajinisivaram commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543243916 ## File path: clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java ## @@ -171,6 +196,14 @@ public long brokerEpoch() {

[GitHub] [kafka] dengziming commented on a change in pull request #9622: KAFKA-10547; add topicId in MetadataResp

dengziming commented on a change in pull request #9622: URL: https://github.com/apache/kafka/pull/9622#discussion_r543288152 ## File path: core/src/test/scala/unit/kafka/controller/ControllerChannelManagerTest.scala ## @@ -873,6 +883,11 @@ class ControllerChannelManagerTest {

[GitHub] [kafka] dengziming commented on a change in pull request #9622: KAFKA-10547; add topicId in MetadataResp

dengziming commented on a change in pull request #9622: URL: https://github.com/apache/kafka/pull/9622#discussion_r543289892 ## File path: clients/src/main/java/org/apache/kafka/common/Cluster.java ## @@ -46,6 +46,8 @@ private final Map> partitionsByNode; private fina

[jira] [Commented] (KAFKA-10843) Kafka Streams metadataForKey method returns null but allMetadata has the details

[ https://issues.apache.org/jira/browse/KAFKA-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249674#comment-17249674 ] Bruno Cadonna commented on KAFKA-10843: --- [~maria_87] What do you mean exactly with

[GitHub] [kafka] dengziming commented on a change in pull request #9622: KAFKA-10547; add topicId in MetadataResp

dengziming commented on a change in pull request #9622: URL: https://github.com/apache/kafka/pull/9622#discussion_r543331298 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -314,9 +315,16 @@ class MetadataCache(brokerId: Int) extends Logging {

[GitHub] [kafka] dajac merged pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac merged pull request #9526: URL: https://github.com/apache/kafka/pull/9526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10525) Emit JSONs with new auto-generated schema

[ https://issues.apache.org/jira/browse/KAFKA-10525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10525. - Fix Version/s: 2.8.0 Resolution: Fixed > Emit JSONs with new auto-generated schema >

[GitHub] [kafka] chia7712 commented on pull request #9516: MINOR: make Send and Receive work with TransportLayer rather than Gat…

chia7712 commented on pull request #9516: URL: https://github.com/apache/kafka/pull/9516#issuecomment-745294097 > I made a tiny adjustment to the javadoc of TransferableChannel. Thanks for kindly updating! This is an a

[GitHub] [kafka] chia7712 commented on pull request #9552: KAFKA-10656: Log the feature flags received by the client

chia7712 commented on pull request #9552: URL: https://github.com/apache/kafka/pull/9552#issuecomment-745297828 @cmccabe I will merge it tomorrow and it would be helpful if you could give a review :) This is an automated mes

[GitHub] [kafka] dajac merged pull request #9752: KAFKA-10854: Fix flaky testConnectionRatePerIp test

dajac merged pull request #9752: URL: https://github.com/apache/kafka/pull/9752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on a change in pull request #9755: MINOR: refactor SelectingIterator by scala iterator

ijuma commented on a change in pull request #9755: URL: https://github.com/apache/kafka/pull/9755#discussion_r543356198 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -972,40 +972,13 @@ class KafkaApis(val requestChannel: RequestChannel, } } - c

[GitHub] [kafka] ijuma commented on pull request #9753: KAFKA-10855; Fix non-local return in `KafkaApis.handle`

ijuma commented on pull request #9753: URL: https://github.com/apache/kafka/pull/9753#issuecomment-745301797 Yeah, I agree that using `return` in Scala is dangerous and should be avoided in most cases. This is an automated m

[GitHub] [kafka] ijuma commented on pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

ijuma commented on pull request #9707: URL: https://github.com/apache/kafka/pull/9707#issuecomment-745304984 Have we considered whether we could do something similar to `close` instead of throwing an exception? Not saying that's a good idea, just want to make sure we thought through the op

[GitHub] [kafka] showuon commented on pull request #9661: KAFKA-10776: update the doc to add version attribute in RequstsPerSec metrics

showuon commented on pull request #9661: URL: https://github.com/apache/kafka/pull/9661#issuecomment-745305055 @ijuma , please help review this simple PR to update the doc. Thanks. This is an automated message from the Apache

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-745305432 @abbccdda @guozhangwang , please help review this PR. Thanks. This is an automated message from the Apache Git Se

[GitHub] [kafka] ijuma commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

ijuma commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r543396355 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } + /

[GitHub] [kafka] ijuma commented on a change in pull request #9755: MINOR: refactor SelectingIterator by scala iterator

ijuma commented on a change in pull request #9755: URL: https://github.com/apache/kafka/pull/9755#discussion_r543399930 ## File path: core/src/main/scala/kafka/server/KafkaApisUtils.scala ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] ijuma merged pull request #9661: KAFKA-10776: update the doc to add version attribute in RequstsPerSec metrics

ijuma merged pull request #9661: URL: https://github.com/apache/kafka/pull/9661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9750: MINOR: Change toArray usage for Increase efficiency

ijuma commented on pull request #9750: URL: https://github.com/apache/kafka/pull/9750#issuecomment-745336737 I think this is based on https://shipilev.net/blog/2016/arrays-wisdom-ancients/ This is an automated message from t

[GitHub] [kafka] chia7712 commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

chia7712 commented on a change in pull request #9728: URL: https://github.com/apache/kafka/pull/9728#discussion_r543406537 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File], cleaner.startup() } +

[GitHub] [kafka] ijuma commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

ijuma commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543407334 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -343,9 +174,15 @@ public Struct parseResponse(short version, ByteBuffe

[GitHub] [kafka] chia7712 commented on a change in pull request #9755: MINOR: refactor SelectingIterator by scala iterator

chia7712 commented on a change in pull request #9755: URL: https://github.com/apache/kafka/pull/9755#discussion_r543412101 ## File path: core/src/main/scala/kafka/server/KafkaApisUtils.scala ## @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Created] (KAFKA-10857) Mirror Maker 2 - replication not working when deploying multiple instances

Athanasios Fanos created KAFKA-10857: Summary: Mirror Maker 2 - replication not working when deploying multiple instances Key: KAFKA-10857 URL: https://issues.apache.org/jira/browse/KAFKA-10857 Pr

[GitHub] [kafka] chia7712 commented on pull request #9750: MINOR: Change toArray usage for Increase efficiency

chia7712 commented on pull request #9750: URL: https://github.com/apache/kafka/pull/9750#issuecomment-745351598 > I think this is based on https://shipilev.net/blog/2016/arrays-wisdom-ancients/ @ijuma Thanks for this sharing. That is good to know :) @APaMio There are some simi

[GitHub] [kafka] APaMio commented on pull request #9750: MINOR: Change toArray usage for Increase efficiency

APaMio commented on pull request #9750: URL: https://github.com/apache/kafka/pull/9750#issuecomment-745355481 @chia7712 Of course. I'll fix it This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] lct45 commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

lct45 commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r543432273 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -201,9 +236,10 @@ private void proc

[GitHub] [kafka] ijuma commented on pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

ijuma commented on pull request #9748: URL: https://github.com/apache/kafka/pull/9748#issuecomment-745363005 > As the "id" is removed from the construction, is it possible to add new ApiKeys instances with incorrect order in the future? the static field ID_TO_TYPE assume all ApiKeys instan

[GitHub] [kafka] vvcephei commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

vvcephei commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r543441602 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -201,9 +236,10 @@ private void p

[GitHub] [kafka] vvcephei commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

vvcephei commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r543442819 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImplTest.java ## @@ -1202,6 +1204,46 @@ public void testCog

[GitHub] [kafka] chia7712 commented on pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

chia7712 commented on pull request #9748: URL: https://github.com/apache/kafka/pull/9748#issuecomment-745372032 > Can you please elaborate? I don't see the assumption you mention. The main assumption is that api keys are dense. I changed the code not to rely on the latter although it doesn

[GitHub] [kafka] lct45 commented on pull request #9708: [KAFKA-9126]: KIP-689: Add options to enable/disable logging for `StreamJoined`

lct45 commented on pull request #9708: URL: https://github.com/apache/kafka/pull/9708#issuecomment-745375628 Thanks for the review and test update @cadonna , and yes the scala should still be good to go This is an automated

[jira] [Commented] (KAFKA-6793) Unnecessary warning log message

[ https://issues.apache.org/jira/browse/KAFKA-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249761#comment-17249761 ] Jason Koppel commented on KAFKA-6793: - Any updates on providing a fix for this? > Un

[GitHub] [kafka] ijuma commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

ijuma commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543472687 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -289,49 +129,40 @@ public Struct parseResponse(short version, ByteBuff

[GitHub] [kafka] chia7712 commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType

chia7712 commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543483040 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -289,49 +129,40 @@ public Struct parseResponse(short version, ByteB

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543485900 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543487703 ## File path: core/src/main/scala/kafka/server/PartitionMetadataFile.scala ## @@ -0,0 +1,141 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543488660 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1021,6 +1036,13 @@ class Log(@volatile private var _dir: File, // re-initialize lead

[GitHub] [kafka] bertber closed pull request #9742: KAFKA-10768 Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

bertber closed pull request #9742: URL: https://github.com/apache/kafka/pull/9742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] hachikuji commented on pull request #9753: KAFKA-10855; Fix non-local return in `KafkaApis.handle`

hachikuji commented on pull request #9753: URL: https://github.com/apache/kafka/pull/9753#issuecomment-745416188 I agree returns are dangerous in scala. I'm also not fond of the nesting that often results from avoiding them.

[jira] [Resolved] (KAFKA-10854) Fix flaky kafka.network.SocketServerTest.testConnectionRatePerIp test

[ https://issues.apache.org/jira/browse/KAFKA-10854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10854. - Fix Version/s: 2.8.0 Resolution: Fixed > Fix flaky kafka.network.SocketServerTest.testCon

[GitHub] [kafka] splett2 commented on pull request #9752: KAFKA-10854: Fix flaky testConnectionRatePerIp test

splett2 commented on pull request #9752: URL: https://github.com/apache/kafka/pull/9752#issuecomment-745434002 thanks for the fix! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543529599 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -32,17 +33,18 @@ import scala.jdk.CollectionConverters._ /** * Class for

[jira] [Resolved] (KAFKA-10852) AlterIsr should not be throttled

[ https://issues.apache.org/jira/browse/KAFKA-10852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10852. - Fix Version/s: 2.7.1 2.8.0 Resolution: Fixed > AlterIsr should not be

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543533537 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -149,29 +152,32 @@ case class BrokerToControllerQueueItem(reques

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543557442 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -221,7 +216,7 @@ class BrokerToControllerRequestThread(networkCl

[jira] [Updated] (KAFKA-9393) DeleteRecords may cause extreme lock contention for large partition directories

[ https://issues.apache.org/jira/browse/KAFKA-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-9393: --- Fix Version/s: (was: 2.7.0) 2.8.0 > DeleteRecords may cause extreme lock contention fo

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543561935 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -53,6 +54,41 @@ object KafkaNetworkChannel { } +private[raft] class Raft

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543567541 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala ## @@ -127,11 +127,14 @@ class TxnMarkerQueue(@vola

[GitHub] [kafka] ijuma merged pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

ijuma merged pull request #4090: URL: https://github.com/apache/kafka/pull/4090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543568828 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -221,7 +216,7 @@ class BrokerToControllerRequestThread(networ

[GitHub] [kafka] ijuma commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

ijuma commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-745466391 LGTM, thanks. Merged to trunk. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on pull request #9702: CVE-2020-25649: bumping jackson to patched version 2.10.5.1

ijuma commented on pull request #9702: URL: https://github.com/apache/kafka/pull/9702#issuecomment-745466670 The build doesn't seem to complete for some reason. It happened twice in a row. It may be worth rebasing against trunk.

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r543588101 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -221,7 +216,7 @@ class BrokerToControllerRequestThread(networ

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543663481 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1434,6 +1447,31 @@ class ReplicaManager(val config: KafkaConfig, */

[GitHub] [kafka] vvcephei commented on pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

vvcephei commented on pull request #9727: URL: https://github.com/apache/kafka/pull/9727#issuecomment-745557286 The test failures were unrelated: Build / JDK 8 / kafka.network.SocketServerTest.testIdleConnection | 15 sec | 1 -- | -- | -- Build / JDK 11 / org.apache.kafka.s

[GitHub] [kafka] vvcephei merged pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

vvcephei merged pull request #9727: URL: https://github.com/apache/kafka/pull/9727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543679600 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1021,6 +1036,13 @@ class Log(@volatile private var _dir: File, // re-initialize lead

[GitHub] [kafka] hachikuji merged pull request #9753: KAFKA-10855; Fix non-local return in `KafkaApis.handle`

hachikuji merged pull request #9753: URL: https://github.com/apache/kafka/pull/9753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10855) Non-local return in envelope validation in causes unexpected response send

[ https://issues.apache.org/jira/browse/KAFKA-10855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10855. - Resolution: Fixed > Non-local return in envelope validation in causes unexpected respons

[jira] [Commented] (KAFKA-10844) groupBy without shuffling

[ https://issues.apache.org/jira/browse/KAFKA-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249937#comment-17249937 ] Mathieu DESPRIEE commented on KAFKA-10844: -- damn, looks like KAFKA-4835, it's 3

[GitHub] [kafka] jolshan commented on a change in pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan commented on a change in pull request #9626: URL: https://github.com/apache/kafka/pull/9626#discussion_r543691182 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig, val

[jira] [Assigned] (KAFKA-8744) Add Support to Scala API for KIP-307 and KIP-479

[ https://issues.apache.org/jira/browse/KAFKA-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-8744: -- Assignee: (was: Matthias J. Sax) > Add Support to Scala API for KIP-307 and KIP-47

[jira] [Assigned] (KAFKA-8744) Add Support to Scala API for KIP-307 and KIP-479

[ https://issues.apache.org/jira/browse/KAFKA-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-8744: -- Assignee: Mathieu DESPRIEE > Add Support to Scala API for KIP-307 and KIP-479 > --

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543696178 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

[jira] [Commented] (KAFKA-8744) Add Support to Scala API for KIP-307 and KIP-479

[ https://issues.apache.org/jira/browse/KAFKA-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249946#comment-17249946 ] Matthias J. Sax commented on KAFKA-8744: Thanks for the PR [~mathieude] – you cou

[jira] [Commented] (KAFKA-10843) Kafka Streams metadataForKey method returns null but allMetadata has the details

[ https://issues.apache.org/jira/browse/KAFKA-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249967#comment-17249967 ] Matthias J. Sax commented on KAFKA-10843: - I don't think that a stretch cluster

[jira] [Commented] (KAFKA-10844) groupBy without shuffling

[ https://issues.apache.org/jira/browse/KAFKA-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249971#comment-17249971 ] Matthias J. Sax commented on KAFKA-10844: - For (1) (or KAFKA-4835) it's actually

[jira] [Comment Edited] (KAFKA-10844) groupBy without shuffling

[ https://issues.apache.org/jira/browse/KAFKA-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249971#comment-17249971 ] Matthias J. Sax edited comment on KAFKA-10844 at 12/15/20, 9:59 PM: --

[jira] [Commented] (KAFKA-9087) ReplicaAlterLogDirs stuck and restart fails with java.lang.IllegalStateException: Offset mismatch for the future replica

[ https://issues.apache.org/jira/browse/KAFKA-9087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249973#comment-17249973 ] Jun Rao commented on KAFKA-9087: Not sure if this is exactly the reason, but we did fix a

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249991#comment-17249991 ] Matthias J. Sax commented on KAFKA-10062: - Thank [~rohitdeshaws] – if you create

[jira] [Updated] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10062: Labels: kip newbie (was: needs-kip newbie) > Add a method to retrieve the current timesta

[jira] [Updated] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10062: Description: Please add to the ProcessorContext a method to retrieve current timestamp co

[jira] [Resolved] (KAFKA-10839) Improve consumer group coordinator unavailable message

[ https://issues.apache.org/jira/browse/KAFKA-10839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10839. - Fix Version/s: 2.8.0 Resolution: Fixed > Improve consumer group coordinator unava

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543744087 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -304,6 +308,131 @@ class AclAuthorizer extends Authorizer with Loggin

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543744182 ## File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala ## @@ -175,4 +185,39 @@ class AuthorizerWrapper(private[kafka] val base

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543745352 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AuthorizerInterfaceDefaultTest.scala ## @@ -0,0 +1,164 @@ +/** + * Licensed to the Apache

[GitHub] [kafka] ijuma commented on pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType

ijuma commented on pull request #9748: URL: https://github.com/apache/kafka/pull/9748#issuecomment-745618466 Tests passed for JDK 11 and 15. JDK 8 had one flaky failure: > kafka.api.ConsumerBounceTest.testClose failed @chia7712 Do you have cycles to review this? -

[GitHub] [kafka] hachikuji opened a new pull request #9757: MINOR: Fix bad logging wildcard in `AbstractCoordinator`

hachikuji opened a new pull request #9757: URL: https://github.com/apache/kafka/pull/9757 Missed this in #9729. Caught by @ijuma . ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [

[GitHub] [kafka] hachikuji merged pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

hachikuji merged pull request #9729: URL: https://github.com/apache/kafka/pull/9729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji merged pull request #9757: MINOR: Fix bad logging substitution in `AbstractCoordinator`

hachikuji merged pull request #9757: URL: https://github.com/apache/kafka/pull/9757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250024#comment-17250024 ] Rohit Deshpande commented on KAFKA-10062: - got it thanks. > Add a method to ret

[GitHub] [kafka] ijuma merged pull request #9702: CVE-2020-25649: bumping jackson to patched version 2.10.5.1

ijuma merged pull request #9702: URL: https://github.com/apache/kafka/pull/9702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9702: CVE-2020-25649: bumping jackson to patched version 2.10.5.1

ijuma commented on pull request #9702: URL: https://github.com/apache/kafka/pull/9702#issuecomment-745686953 I merged to trunk and 2.7 branches. There were conflicts for older branches. This is an automated message from the A

[GitHub] [kafka] chia7712 merged pull request #9516: MINOR: make Send and Receive work with TransferableChannel rather than Gat…

chia7712 merged pull request #9516: URL: https://github.com/apache/kafka/pull/9516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType

chia7712 commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543799602 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -157,124 +38,76 @@ * Identifiers for all the Kafka APIs */ pub

[GitHub] [kafka] chia7712 commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType

chia7712 commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543804474 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -361,69 +172,35 @@ private static boolean shouldRetainsBufferRefer

[GitHub] [kafka] chia7712 commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType

chia7712 commented on a change in pull request #9748: URL: https://github.com/apache/kafka/pull/9748#discussion_r543804854 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java ## @@ -361,69 +172,35 @@ private static boolean shouldRetainsBufferRefer

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r543696178 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -130,6 +130,10 @@ class AclAuthorizer extends Authorizer with Logging

  1   2   >