[GitHub] [kafka] showuon commented on pull request #9690: KAFKA-10017: fix flaky EOS-beta upgrade test

showuon commented on pull request #9690: URL: https://github.com/apache/kafka/pull/9690#issuecomment-743046108 @mjsax , I investigated your failed tests for some days, and finally found out why sometimes the test failed here: ``` Did not receive all 148 records from topic multiPartiti

[GitHub] [kafka] showuon opened a new pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

showuon opened a new pull request #9733: URL: https://github.com/apache/kafka/pull/9733 The PR follows #9688, to make the EosBetaUpgradeIntegrationTest more stable. Fixed some issues: 1. Error message is like: ``` org.apache.kafka.streams.errors.InvalidStateStoreException: Cannot g

[GitHub] [kafka] showuon commented on pull request #9733: KAFKA-10017: fix 2 issues in EosBetaUpgradeIntegrationTest

showuon commented on pull request #9733: URL: https://github.com/apache/kafka/pull/9733#issuecomment-743082789 @mjsax @ableegoldman @guozhangwang , could you help review this PR? Thanks. This is an automated message from the

[GitHub] [kafka] vamossagar12 commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

vamossagar12 commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-743088282 hey @cadonna did you get a chance to look at the latest set of changes? This is an automated message from the

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r540798413 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -121,9 +122,16 @@ object RequestChannel extends Logging { } } -de

[GitHub] [kafka] cadonna commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

cadonna commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-743101385 @vamossagar12 I am really sorry, but I haven't found the time yet to review the changes. I hope I will find the time next week. --

[GitHub] [kafka] barbarosalp commented on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

barbarosalp commented on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-743103712 When this could be merged? We are facing this issue right now and would need to use it in prod soon. Do you have any suggestions on how could we proceed?

[GitHub] [kafka] barbarosalp edited a comment on pull request #8656: KAFKA-9981; dedicated mm2 cluster lose the update operation.

barbarosalp edited a comment on pull request #8656: URL: https://github.com/apache/kafka/pull/8656#issuecomment-743103712 @ryannedolan When this could be merged? We are facing this issue right now and would need to use it in prod soon. Do you have any suggestions on how could we proceed?

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540854106 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540854106 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540857996 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540857996 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] cadonna commented on a change in pull request #9695: KAFKA-10500: Remove thread

cadonna commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r540860759 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -631,6 +634,23 @@ public void shouldNotAddThreadWhenError() {

[jira] [Created] (KAFKA-10843) Kafka Streams metadataForKey method returns null but allMetadata has the details

Maria Thomas created KAFKA-10843: Summary: Kafka Streams metadataForKey method returns null but allMetadata has the details Key: KAFKA-10843 URL: https://issues.apache.org/jira/browse/KAFKA-10843 Proj

[GitHub] [kafka] cadonna commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

cadonna commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r540865043 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -436,6 +436,26 @@ private void defaultStreamsUncaughtExceptionHandler(f

[jira] [Created] (KAFKA-10844) groupBy without shuffling

Mathieu DESPRIEE created KAFKA-10844: Summary: groupBy without shuffling Key: KAFKA-10844 URL: https://issues.apache.org/jira/browse/KAFKA-10844 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-10843) Kafka Streams metadataForKey method returns null but allMetadata has the details

[ https://issues.apache.org/jira/browse/KAFKA-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247886#comment-17247886 ] Bruno Cadonna commented on KAFKA-10843: --- [~maria_87] Thank you for the report! {{

[GitHub] [kafka] mumrah commented on a change in pull request #9713: KAFKA-10825 ZK ISR manager

mumrah commented on a change in pull request #9713: URL: https://github.com/apache/kafka/pull/9713#discussion_r540945473 ## File path: core/src/main/scala/kafka/server/ZkIsrManager.scala ## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-10845) Introduce a `VisibleForTesting` annotation

[ https://issues.apache.org/jira/browse/KAFKA-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10845: --- Description: There are so much code with a "Visible for testing" or "public for testing" , it's bett

[jira] [Created] (KAFKA-10845) Introduce a `VisibleForTesting` annotation

dengziming created KAFKA-10845: -- Summary: Introduce a `VisibleForTesting` annotation Key: KAFKA-10845 URL: https://issues.apache.org/jira/browse/KAFKA-10845 Project: Kafka Issue Type: Improvemen

[GitHub] [kafka] dengziming opened a new pull request #9734: KAFKA-10845; Add VisibleForTesting annotation

dengziming opened a new pull request #9734: URL: https://github.com/apache/kafka/pull/9734 *More detailed description of your change* There are a lot of comments like "visible for testing" "public for testing", for example: https://github.com/apache/kafka/blob/ce275e29beb4861142

[jira] [Created] (KAFKA-10846) FileStreamSourceTask buffer can grow without bound

Tom Bentley created KAFKA-10846: --- Summary: FileStreamSourceTask buffer can grow without bound Key: KAFKA-10846 URL: https://issues.apache.org/jira/browse/KAFKA-10846 Project: Kafka Issue Type:

[GitHub] [kafka] tombentley opened a new pull request #9735: KAFKA-10846: Grow buffer in FileSourceStreamTask only when needed

tombentley opened a new pull request #9735: URL: https://github.com/apache/kafka/pull/9735 See [KAFKA-10846](https://issues.apache.org/jira/browse/KAFKA-10846) This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] tombentley commented on pull request #9735: KAFKA-10846: Grow buffer in FileSourceStreamTask only when needed

tombentley commented on pull request #9735: URL: https://github.com/apache/kafka/pull/9735#issuecomment-743254772 @C0urante @kkonstantine maybe one of you could take a look. This is an automated message from the Apache Git S

[GitHub] [kafka] lct45 commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

lct45 commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r541026655 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -201,9 +219,10 @@ private void proc

[GitHub] [kafka] vvcephei commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

vvcephei commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541028355 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -27,6 +27,7 @@ * Enumeration that des

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r541047802 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -631,6 +634,23 @@ public void shouldNotAddThreadWhenError() {

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r541056641 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r541063459 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9727: [KAFKA-10417] Update Cogrouped processor to work with suppress() and joins

wcarlson5 commented on a change in pull request #9727: URL: https://github.com/apache/kafka/pull/9727#discussion_r541065323 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -201,9 +219,10 @@ private void

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541070527 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -27,6 +27,7 @@ * Enumeration that de

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541071515 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -155,16 +171,46 @@ pub

[GitHub] [kafka] cadonna commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

cadonna commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541099547 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -27,6 +27,7 @@ * Enumeration that desc

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541114609 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -27,6 +27,7 @@ * Enumeration that de

[GitHub] [kafka] cadonna commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

cadonna commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r541119671 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -27,6 +27,7 @@ * Enumeration that desc

[GitHub] [kafka] ijuma commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

ijuma commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541147023 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffset

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541158744 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOf

[GitHub] [kafka] ijuma commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

ijuma commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541172565 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffset

[GitHub] [kafka] ijuma commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

ijuma commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541147023 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffset

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541199422 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOf

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541199422 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOf

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541202572 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +73,44 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541206048 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +73,44 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] kowshik commented on pull request #9731: MINOR: Make Log.recordVersion private and other small cleanups

kowshik commented on pull request #9731: URL: https://github.com/apache/kafka/pull/9731#issuecomment-743388498 @chia7712 if the change looks good to you, please could you merge it? thanks :) This is an automated message fro

[GitHub] [kafka] kowshik edited a comment on pull request #9731: MINOR: Make Log.recordVersion private and other small cleanups

kowshik edited a comment on pull request #9731: URL: https://github.com/apache/kafka/pull/9731#issuecomment-743388498 @chia7712 if the change looks good to you, please could you help merge it? :) This is an automated messag

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541206648 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +73,44 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] hachikuji commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

hachikuji commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r541213215 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -257,7 +257,7 @@ protected synchronized bo

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541156636 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,30 @@ abstract class InterBrokerSendThread(name: String, awa

[GitHub] [kafka] hachikuji commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

hachikuji commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r541218024 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1355,7 +1362,7 @@ public void run() {

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541219472 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,30 @@ abstract class InterBrokerSendThread(name: String,

[GitHub] [kafka] scott-hendricks opened a new pull request #9736: Add configurable workloads and E2E latency tracking to Trogdor.

scott-hendricks opened a new pull request #9736: URL: https://github.com/apache/kafka/pull/9736 This PR pulls together a couple of the outstanding one-pagers we have for Q4: https://confluentinc.atlassian.net/wiki/spaces/QERM/pages/1605992772 https://confluentinc.atlassian.net/wiki

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541219622 ## File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala ## @@ -68,179 +51,93 @@ object KafkaNetworkChannel { } } - private[raft]

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541221553 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,34 @@ abstract class InterBrokerSendThread(name: String,

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541221984 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,30 @@ abstract class InterBrokerSendThread(name: String,

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541225075 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -32,17 +33,18 @@ import scala.jdk.CollectionConverters._ /** * Class

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541225579 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -164,13 +164,11 @@ class BrokerToControllerRequestThread(

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r541240558 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -377,11 +387,24 @@ private void generateVariableLengt

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541216977 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala ## @@ -135,7 +117,16 @@ class BrokerToControllerChannelManagerImpl(met

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541274490 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -164,13 +164,11 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] mumrah commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

mumrah commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541274830 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,34 @@ abstract class InterBrokerSendThread(name: String, awa

[jira] [Commented] (KAFKA-10843) Kafka Streams metadataForKey method returns null but allMetadata has the details

[ https://issues.apache.org/jira/browse/KAFKA-10843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248176#comment-17248176 ] Matthias J. Sax commented on KAFKA-10843: - IIRC, we had some issue that might ha

[GitHub] [kafka] junrao commented on a change in pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

junrao commented on a change in pull request #9718: URL: https://github.com/apache/kafka/pull/9718#discussion_r541280750 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2670,6 +2645,34 @@ object Log { private def isLogFile(file: File): Boolean = file.getPat

[jira] [Updated] (KAFKA-10844) groupBy without shuffling

[ https://issues.apache.org/jira/browse/KAFKA-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10844: Labels: needs-kip (was: ) > groupBy without shuffling > - > >

[jira] [Commented] (KAFKA-10844) groupBy without shuffling

[ https://issues.apache.org/jira/browse/KAFKA-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248177#comment-17248177 ] Matthias J. Sax commented on KAFKA-10844: - I think we should add something like

[GitHub] [kafka] kowshik commented on a change in pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

kowshik commented on a change in pull request #9718: URL: https://github.com/apache/kafka/pull/9718#discussion_r541288822 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2670,6 +2645,34 @@ object Log { private def isLogFile(file: File): Boolean = file.getPa

[GitHub] [kafka] kowshik commented on pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

kowshik commented on pull request #9718: URL: https://github.com/apache/kafka/pull/9718#issuecomment-743426585 Thanks for the review @junrao ! I've addressed the comment in ec00e9f. The JDK 15 test failure in `org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shou

[GitHub] [kafka] kowshik edited a comment on pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

kowshik edited a comment on pull request #9718: URL: https://github.com/apache/kafka/pull/9718#issuecomment-743426585 Thanks for the review @junrao ! I've addressed the comment in ec00e9f. The JDK 15 test failure in `org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541291359 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BlockingMessageQueue.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] vvcephei merged pull request #9697: KAFKA-10810: Replace stream threads

vvcephei merged pull request #9697: URL: https://github.com/apache/kafka/pull/9697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10847) Avoid spurious left/outer join results in stream-stream join

Matthias J. Sax created KAFKA-10847: --- Summary: Avoid spurious left/outer join results in stream-stream join Key: KAFKA-10847 URL: https://issues.apache.org/jira/browse/KAFKA-10847 Project: Kafka

[jira] [Created] (KAFKA-10848) Allow fine grained control over cross-partition processing order

Matthias J. Sax created KAFKA-10848: --- Summary: Allow fine grained control over cross-partition processing order Key: KAFKA-10848 URL: https://issues.apache.org/jira/browse/KAFKA-10848 Project: Kafka

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541368311 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -164,13 +164,11 @@ class BrokerToControllerRequestThread(

[GitHub] [kafka] hachikuji commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

hachikuji commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541370421 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -51,22 +53,30 @@ abstract class InterBrokerSendThread(name: String,

[GitHub] [kafka] ijuma commented on a change in pull request #9732: KAFKA-10842; Use `InterBrokerSendThread` for raft's outbound network channel

ijuma commented on a change in pull request #9732: URL: https://github.com/apache/kafka/pull/9732#discussion_r541378653 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AddOffsetsToTxnRequest.java ## @@ -53,7 +53,7 @@ public AddOffsetsToTxnRequest(AddOffset

[GitHub] [kafka] cmccabe commented on a change in pull request #9736: Add configurable workloads and E2E latency tracking to Trogdor.

cmccabe commented on a change in pull request #9736: URL: https://github.com/apache/kafka/pull/9736#discussion_r541379098 ## File path: tools/src/main/java/org/apache/kafka/trogdor/workload/GaussianTimestampRandomPayloadGenerator.java ## @@ -0,0 +1,135 @@ +/* + * Licensed to t

[GitHub] [kafka] cmccabe commented on pull request #9736: Add configurable workloads and E2E latency tracking to Trogdor.

cmccabe commented on pull request #9736: URL: https://github.com/apache/kafka/pull/9736#issuecomment-743467898 Thanks for this, @scott-hendricks ... it looks really cool. Can you say a bit more about the decision to put the timestamp into the message, rather than using the timestamp

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

lbradstreet commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r541400985 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -890,13 +890,20 @@ private synchronized

[GitHub] [kafka] guozhangwang commented on a change in pull request #9616: KAFKA-10091: KIP-695: Deterministic semantics for task idling

guozhangwang commented on a change in pull request #9616: URL: https://github.com/apache/kafka/pull/9616#discussion_r541408960 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -331,9 +331,29 @@ public static StreamThread

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

lbradstreet commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r541424869 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1355,7 +1362,7 @@ public void run() {

[GitHub] [kafka] lbradstreet commented on a change in pull request #9729: KAFKA-10839: improve consumer group coordinator unavailable message

lbradstreet commented on a change in pull request #9729: URL: https://github.com/apache/kafka/pull/9729#discussion_r541425344 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1311,7 +1311,7 @@ public void handle(Of

[GitHub] [kafka] junrao merged pull request #9718: KAFKA-10832: Fix Log to use the correct ProducerStateManager instance when updating producers

junrao merged pull request #9718: URL: https://github.com/apache/kafka/pull/9718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10832) Recovery logic is using incorrect ProducerStateManager instance when updating producers

[ https://issues.apache.org/jira/browse/KAFKA-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10832. - Fix Version/s: 2.8.0 Resolution: Fixed Merged the PR to trunk. > Recovery logic is using incorre

[GitHub] [kafka] vvcephei commented on a change in pull request #9616: KAFKA-10091: KIP-695: Deterministic semantics for task idling

vvcephei commented on a change in pull request #9616: URL: https://github.com/apache/kafka/pull/9616#discussion_r541489164 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -331,9 +331,29 @@ public static StreamThread crea

[GitHub] [kafka] chia7712 commented on pull request #9707: KAFKA-10790 Detect/Prevent Deadlock on Producer Network Thread

chia7712 commented on pull request #9707: URL: https://github.com/apache/kafka/pull/9707#issuecomment-743714552 @hachikuji FYI This is an automated message from the Apache Git Service. To respond to the message, please log on