dajac commented on pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#issuecomment-742375037
Failed test is not related:
* JDK 11 - kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs
This i
dajac merged pull request #9628:
URL: https://github.com/apache/kafka/pull/9628
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dajac commented on pull request #9628:
URL: https://github.com/apache/kafka/pull/9628#issuecomment-742378220
@splett2 Thanks for your contribution!
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-10747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-10747.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Implement ClientQuota APIs for altering and desc
tombentley commented on pull request #9676:
URL: https://github.com/apache/kafka/pull/9676#issuecomment-742396820
@hachikuji @guozhangwang I decided to switch to a flag rather than
implementing the uninitialised `offlineLogDirs` with an `AtomicReference` which
would be contented by every t
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540016662
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540016804
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java
##
@@ -143,30 +127,24 @@ public AbstractResponse getEr
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540017068
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -160,7 +161,9 @@ abstract class AbstractFetcherThread(name: String,
if
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540030883
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -160,7 +161,9 @@ abstract class AbstractFetcherThread(name: String,
if
dajac commented on pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#issuecomment-742414752
@chia7712 @hachikuji Thanks for your feedback. I have addressed your
comments. Could you take another look please?
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247142#comment-17247142
]
Bruno Cadonna commented on KAFKA-10772:
---
[~lkokhreidze] [~thebearmayor]
To sum up
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-10772.
---
Resolution: Duplicate
> java.lang.IllegalStateException: There are insufficient bytes availa
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247142#comment-17247142
]
Bruno Cadonna edited comment on KAFKA-10772 at 12/10/20, 10:13 AM:
---
g1geordie commented on a change in pull request #9707:
URL: https://github.com/apache/kafka/pull/9707#discussion_r540045129
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java
##
@@ -131,6 +131,14 @@
Collections.singletonLi
[
https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247164#comment-17247164
]
Levani Kokhreidze commented on KAFKA-10772:
---
Thanks a lot [~cadonna] for the t
Mickael Maison created KAFKA-10833:
--
Summary: KIP-661: Expose task configurations in Connect REST API
Key: KAFKA-10833
URL: https://issues.apache.org/jira/browse/KAFKA-10833
Project: Kafka
I
dajac merged pull request #9685:
URL: https://github.com/apache/kafka/pull/9685
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-10748.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Add IP connection rate throttling metric
> -
[
https://issues.apache.org/jira/browse/KAFKA-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-10833:
---
Description:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-661%3A+Expose+task+config
mimaison opened a new pull request #9726:
URL: https://github.com/apache/kafka/pull/9726
This PR adds a new REST endpoint to Connect: `GET
/{connector}/tasks-config`, that returns the configuration of all tasks for the
connector.
This changes is for
[KIP-661](https://cwiki.apache.o
ijuma commented on a change in pull request #9680:
URL: https://github.com/apache/kafka/pull/9680#discussion_r540179126
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File],
try {
for ((dir, dirJ
[
https://issues.apache.org/jira/browse/KAFKA-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247246#comment-17247246
]
WANG CHIEN FENG commented on KAFKA-10768:
-
[~chia7712] Hello! Can I try to deal
ijuma commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r540182407
##
File path: gradle/spotbugs-exclude.xml
##
@@ -237,19 +237,8 @@ For a detailed description of spotbugs bug categories, see
https://spotbugs.read
ijuma commented on pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#issuecomment-742532333
@chia7712 Pushed a couple of follow ups. I think this is ready to merge.
This is an automated message from the Apach
ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540191647
##
File path:
clients/src/main/java/org/apache/kafka/common/network/TransferableChannel.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foun
ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540195130
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecords c
ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540197290
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecords c
cadonna commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r540148911
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long
cadonna commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r540225034
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long
mimaison commented on a change in pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#discussion_r540226389
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationSSLTest.java
##
@@ -0,0 +1,69 @@
+/*
+ *
chia7712 commented on a change in pull request #9680:
URL: https://github.com/apache/kafka/pull/9680#discussion_r540237095
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File],
try {
for ((dir, d
chia7712 commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540239577
##
File path:
clients/src/main/java/org/apache/kafka/common/network/TransferableChannel.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software F
chia7712 commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540239443
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecord
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-742587762
@mimaison thanks so much for your careful review. I checked
https://github.com/apache/kafka/pull/9698 again and make sure we do not miss
anything at this moment.
-
ijuma commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540262407
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecords c
sirocchj commented on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-742607711
> PS: I did see we needed to jump a few patch releases for 2.6 (and 2.5).
Hadn't noticed 2.4 was on 2.10.5 already though
And indeed, unless I'm missing something, 2.4 seem
cadonna commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r540249465
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,25 @@ private void handleStreamsUncaughtException(final
Th
dajac commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540218952
##
File path: clients/src/main/resources/common/message/LeaderAndIsrRequest.json
##
@@ -21,8 +21,12 @@
//
// Version 2 adds broker epoch and reorganizes
niteshmor commented on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-742615616
> > PS: I did see we needed to jump a few patch releases for 2.6 (and 2.5).
Hadn't noticed 2.4 was on 2.10.5 already though
>
> And indeed, unless I'm missing something, 2
niteshmor edited a comment on pull request #9702:
URL: https://github.com/apache/kafka/pull/9702#issuecomment-741973244
Thanks @sirocchj, you beat me to it for this upgrade request.
For older branches, these are the current versions of jackson databind in
use:
```
2.1:
lct45 opened a new pull request #9727:
URL: https://github.com/apache/kafka/pull/9727
Changes the cogrouped processor from `PassThrough` to `KTablePassThrough` to
allow for sending old values. `KTablePassThrough` extends
`KTableProcessorSupplier` instead of `ProcessorSupplier` to implement
jolshan commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540309740
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrResponse.java
##
@@ -45,8 +47,16 @@ public LeaderAndIsrResponse(Struct str
jolshan commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540311108
##
File path: clients/src/main/resources/common/message/LeaderAndIsrRequest.json
##
@@ -21,8 +21,12 @@
//
// Version 2 adds broker epoch and reorganiz
hachikuji commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540311440
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,
dajac commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540322639
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1378,12 +1378,26 @@ class KafkaController(val config: KafkaConfig,
val of
lct45 commented on pull request #9727:
URL: https://github.com/apache/kafka/pull/9727#issuecomment-742650459
@wcarlson5 @vvcephei for initial review
This is an automated message from the Apache Git Service.
To respond to the
bbejeck commented on pull request #9723:
URL: https://github.com/apache/kafka/pull/9723#issuecomment-742657765
Thanks @abbccdda !
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda merged pull request #9723:
URL: https://github.com/apache/kafka/pull/9723
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen resolved KAFKA-10813.
-
Resolution: Fixed
> StreamsProducer should catch InvalidProducerEpoch and throw TaskMigrated in
abbccdda commented on pull request #9700:
URL: https://github.com/apache/kafka/pull/9700#issuecomment-742662578
Cherry-picked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, please
wcarlson5 commented on a change in pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#discussion_r540308752
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -444,6 +444,25 @@ private void handleStreamsUncaughtException(final
guozhangwang commented on pull request #9722:
URL: https://github.com/apache/kafka/pull/9722#issuecomment-742666980
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
guozhangwang commented on pull request #9721:
URL: https://github.com/apache/kafka/pull/9721#issuecomment-742667214
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jolshan commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540354106
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerChannelManagerTest.scala
##
@@ -87,7 +90,10 @@ class ControllerChannelManagerTest {
jolshan commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r540354679
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerChannelManagerTest.scala
##
@@ -157,7 +163,8 @@ class ControllerChannelManagerTest {
hachikuji merged pull request #9639:
URL: https://github.com/apache/kafka/pull/9639
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 opened a new pull request #9728:
URL: https://github.com/apache/kafka/pull/9728
revert the change introduced by #9680 and add a unit test to verify
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
chia7712 commented on a change in pull request #9680:
URL: https://github.com/apache/kafka/pull/9680#discussion_r540356881
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File],
try {
for ((dir, d
[
https://issues.apache.org/jira/browse/KAFKA-10677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10677.
-
Resolution: Fixed
> Complete fetches in purgatory immediately after raft leader resigns
[
https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen resolved KAFKA-9552.
Resolution: Not A Problem
> Stream should handle OutOfSequence exception thrown from Producer
> ---
lbradstreet commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r540360441
##
File path: jmh-benchmarks/README.md
##
@@ -1,10 +1,69 @@
-### JMH-Benchmark module
+### JMH-Benchmarks module
This module contains benchmarks writ
lbradstreet commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r540361683
##
File path: jmh-benchmarks/README.md
##
@@ -1,10 +1,69 @@
-### JMH-Benchmark module
+### JMH-Benchmarks module
This module contains benchmarks writ
ijuma commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r540372753
##
File path: jmh-benchmarks/README.md
##
@@ -1,10 +1,69 @@
-### JMH-Benchmark module
+### JMH-Benchmarks module
This module contains benchmarks written us
ijuma commented on a change in pull request #9129:
URL: https://github.com/apache/kafka/pull/9129#discussion_r540373445
##
File path: jmh-benchmarks/README.md
##
@@ -1,10 +1,69 @@
-### JMH-Benchmark module
+### JMH-Benchmarks module
This module contains benchmarks written us
vvcephei commented on a change in pull request #9708:
URL: https://github.com/apache/kafka/pull/9708#discussion_r540375321
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/StreamJoined.java
##
@@ -267,7 +296,49 @@ private StreamJoined(final Serde keySerde,
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540382825
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,
mimaison commented on pull request #9726:
URL: https://github.com/apache/kafka/pull/9726#issuecomment-742697895
@rhauch @kkonstantine can you take a look? Thanks
This is an automated message from the Apache Git Service.
To re
wcarlson5 commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r540351596
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -924,25 +924,64 @@ private StreamThread createStreamThread(final long
wcarlson5 commented on pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#issuecomment-742706985
@cadonna
> In the KIP, it says that a rebalance is triggered even under static
membership. I could not find any code that ensures that. Shall we do that in a
separate PR
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247401#comment-17247401
]
Mickael Maison commented on KAFKA-10802:
I'm backporting this fix to 2.6 and I'l
wcarlson5 edited a comment on pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#issuecomment-742706985
@cadonna
> In the KIP, it says that a rebalance is triggered even under static
membership. I could not find any code that ensures that. Shall we do that in a
sepa
dajac commented on a change in pull request #9689:
URL: https://github.com/apache/kafka/pull/9689#discussion_r540406112
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -268,11 +271,12 @@ abstract class AbstractFetcherThread(name: String,
d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r540418386
##
File path: core/src/main/scala/kafka/security/authorizer/AuthorizerWrapper.scala
##
@@ -71,15 +73,19 @@ object AuthorizerWrapper {
}
def convert
[
https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-9552:
> Stream should handle OutOfSequence exception thrown from Producer
> -
[
https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-9552.
Fix Version/s: 2.6.0
Resolution: Fixed
> Stream should handle OutOfSequence exceptio
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247431#comment-17247431
]
Bill Bejeck commented on KAFKA-10802:
-
Thanks for the heads up [~mimaison] I need to
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247431#comment-17247431
]
Bill Bejeck edited comment on KAFKA-10802 at 12/10/20, 7:07 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-10802:
--
Assignee: Guozhang Wang
> Spurious log message when starting consumers
>
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-10802.
Fix Version/s: 2.8.0
2.6.1
Resolution: Fixed
> Spurious log mess
lct45 commented on a change in pull request #9708:
URL: https://github.com/apache/kafka/pull/9708#discussion_r540431368
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java
##
@@ -152,6 +155,52 @@ private void
shouldLogAnd
lct45 commented on pull request #9708:
URL: https://github.com/apache/kafka/pull/9708#issuecomment-742742254
@vvcephei Thanks for the review! Overall the test coverage looks pretty
good, IIUC the log config is never touched when logging is disabled so I don't
think there's a NPE that we're
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247449#comment-17247449
]
Gary Russell commented on KAFKA-10802:
--
Thanks, guys, really appreciate it; I think
chia7712 commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540448555
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecord
chia7712 commented on a change in pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#discussion_r540448555
##
File path:
clients/src/test/java/org/apache/kafka/common/record/LazyDownConversionRecordsTest.java
##
@@ -160,20 +161,21 @@ private static MemoryRecord
[
https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10345:
Description: With forwarding enabled, per-broker alter-config doesn't go to
the target broker anym
[
https://issues.apache.org/jira/browse/KAFKA-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10345:
Summary: Add auto reloading for trust/key store paths (was: Add file-watch
based update for trust
ijuma commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540461670
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+ /
chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540463850
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+
chia7712 commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-742769046
> This seems less safe than what we had before. Same for the transferFrom
implementation. I think we want implementations to decide the right behavior
for themselves.
Fair
ijuma commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540467496
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+ /
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247490#comment-17247490
]
Ismael Juma commented on KAFKA-10802:
-
Thanks [~mimaison]!
> Spurious log message w
kowshik commented on a change in pull request #9680:
URL: https://github.com/apache/kafka/pull/9680#discussion_r540476157
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File],
try {
for ((dir, di
kowshik commented on a change in pull request #9680:
URL: https://github.com/apache/kafka/pull/9680#discussion_r540476157
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -479,14 +479,14 @@ class LogManager(logDirs: Seq[File],
try {
for ((dir, di
kowshik commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540478009
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -680,4 +680,15 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDel
kowshik commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540478009
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -680,4 +680,15 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDel
chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540483941
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -680,4 +680,15 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDe
[
https://issues.apache.org/jira/browse/KAFKA-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-10802:
Fix Version/s: 2.7.0
> Spurious log message when starting consumers
>
chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540484990
##
File path: core/src/test/scala/unit/kafka/log/LogManagerTest.scala
##
@@ -680,4 +680,15 @@ class LogManagerTest {
time.sleep(logConfig.fileDeleteDe
chia7712 commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540486925
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
cleaner.startup()
}
+
bbejeck commented on pull request #9667:
URL: https://github.com/apache/kafka/pull/9667#issuecomment-742799929
cherry-picked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, please l
1 - 100 of 161 matches
Mail list logo
