[GitHub] [kafka] cadonna commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
cadonna commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533148335 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public RocksDBMetr

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-01 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r533153634 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel, m

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-01 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r533153634 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel, m

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-01 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r533154067 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel, m

[jira] [Commented] (KAFKA-3042) updateIsr should stop after failed several times due to zkVersion issue

2020-12-01 Thread zhangzhisheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241383#comment-17241383 ] zhangzhisheng commented on KAFKA-3042: -- using kafka_2.12-2.4.1,zookeeper-3.5.7 3 ZK

[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

2020-12-01 Thread GitBox
chia7712 commented on pull request #9423: URL: https://github.com/apache/kafka/pull/9423#issuecomment-736388571 ```kafka.api.TransactionsTest.testBumpTransactionalEpoch``` is traced by #9291 ```org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAl

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MM2 internal topics naming convention

2020-12-01 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Labels: (was: need-kip) > Add additional configuration to control MM2 internal topics naming

[GitHub] [kafka] cadonna opened a new pull request #9665: MINOR: fix reading SSH output in Streams system tests

2020-12-01 Thread GitBox
cadonna opened a new pull request #9665: URL: https://github.com/apache/kafka/pull/9665 SSH outputs in system tests originating from paramiko are bytes. However, the logger in the system tests does not accept bytes and instead throws an exception. That means, the bytes returned as SSH outp

[GitHub] [kafka] cadonna commented on pull request #9665: MINOR: fix reading SSH output in Streams system tests

2020-12-01 Thread GitBox
cadonna commented on pull request #9665: URL: https://github.com/apache/kafka/pull/9665#issuecomment-736527786 Call for review: @vvcephei @mjsax @abbccdda @ableegoldman @guozhangwang This is an automated message from the Apa

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r533392517 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -229,6 +230,15 @@ public V delete(final K

[jira] [Created] (KAFKA-10788) Streamlining Tests in CachingInMemoryKeyValueStoreTest

2020-12-01 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-10788: - Summary: Streamlining Tests in CachingInMemoryKeyValueStoreTest Key: KAFKA-10788 URL: https://issues.apache.org/jira/browse/KAFKA-10788 Project: Kafka Issue Type:

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r533393552 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemoryKeyValueStoreTest.java ## @@ -359,6 +361,31 @@ public void

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r533394274 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java ## @@ -196,6 +200,26 @@ public v

[jira] [Created] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2020-12-01 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-10789: - Summary: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest Key: KAFKA-10789 URL: https://issues.apache.org/jira/browse/KAFKA-10789 Project: Kafka Issue Typ

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r533394779 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r533394779 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] vamossagar12 commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-12-01 Thread GitBox
vamossagar12 commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-736542110 Thanks @cadonna , I have resolved all comments. Plz review again if things look ok now.. This is an automate

[jira] [Updated] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10789: -- Component/s: streams > Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest > ---

[jira] [Updated] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10789: -- Priority: Minor (was: Major) > Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest > --

[jira] [Updated] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10789: -- Labels: newbie (was: ) > Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest >

[jira] [Updated] (KAFKA-10788) Streamlining Tests in CachingInMemoryKeyValueStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10788: -- Component/s: unit tests streams > Streamlining Tests in CachingInMemoryKeyVal

[jira] [Updated] (KAFKA-10788) Streamlining Tests in CachingInMemoryKeyValueStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10788: -- Labels: newbie (was: ) > Streamlining Tests in CachingInMemoryKeyValueStoreTest > ---

[jira] [Updated] (KAFKA-10789) Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10789: -- Component/s: unit tests > Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest >

[GitHub] [kafka] ijuma commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-01 Thread GitBox
ijuma commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r533402852 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel, met

[GitHub] [kafka] cadonna commented on pull request #9665: MINOR: fix reading SSH output in Streams system tests

2020-12-01 Thread GitBox
cadonna commented on pull request #9665: URL: https://github.com/apache/kafka/pull/9665#issuecomment-736548818 System test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4295/ This is an automated mes

[GitHub] [kafka] cadonna edited a comment on pull request #9665: MINOR: fix reading SSH output in Streams system tests

2020-12-01 Thread GitBox
cadonna edited a comment on pull request #9665: URL: https://github.com/apache/kafka/pull/9665#issuecomment-736548818 System test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4296/ This is an automa

[jira] [Updated] (KAFKA-10292) fix flaky streams/streams_broker_bounce_test.py

2020-12-01 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10292: -- Description: {quote} Module: kafkatest.tests.streams.streams_broker_bounce_test Class: Stream

[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

2020-12-01 Thread GitBox
chia7712 commented on pull request #9423: URL: https://github.com/apache/kafka/pull/9423#issuecomment-736593865 @junrao I will merge it to trunk tomorrow if there is no objection. This is an automated message from the Apache

[jira] [Created] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-01 Thread Gary Russell (Jira)
Gary Russell created KAFKA-10790: Summary: Detect/Prevent Deadlock on Producer Network Thread Key: KAFKA-10790 URL: https://issues.apache.org/jira/browse/KAFKA-10790 Project: Kafka Issue Type

[GitHub] [kafka] viktorsomogyi commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

2020-12-01 Thread GitBox
viktorsomogyi commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-736624841 I ran another test with 2,000,000,000 keys being inserted into a Bloom Filter with 1% false positive rate (and it ran for 7 hours and 21 minutes). The test set was created b

[GitHub] [kafka] vvcephei commented on a change in pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-12-01 Thread GitBox
vvcephei commented on a change in pull request #8965: URL: https://github.com/apache/kafka/pull/8965#discussion_r533507421 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -3393,6 +3393,10 @@ KTable-KTable Foreign-Key but this

[jira] [Commented] (KAFKA-10697) Remove ProduceResponse.responses

2020-12-01 Thread UnityLung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241672#comment-17241672 ] UnityLung commented on KAFKA-10697: --- [~chia7712] Can I work on this? > Remove Produce

[jira] [Created] (KAFKA-10791) Kafka Metadata older epoch problem

2020-12-01 Thread KRISHNA SARVEPALLI (Jira)
KRISHNA SARVEPALLI created KAFKA-10791: -- Summary: Kafka Metadata older epoch problem Key: KAFKA-10791 URL: https://issues.apache.org/jira/browse/KAFKA-10791 Project: Kafka Issue Type: Bu

[GitHub] [kafka] hachikuji commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r533539812 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1862,23 +1864,51 @@ class ReplicaManager(val config: KafkaConfig, } }

[jira] [Commented] (KAFKA-10697) Remove ProduceResponse.responses

2020-12-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241678#comment-17241678 ] Chia-Ping Tsai commented on KAFKA-10697: [~UnityLung] sure. Go for it. > Remove

[jira] [Assigned] (KAFKA-10697) Remove ProduceResponse.responses

2020-12-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10697: -- Assignee: UnityLung (was: Chia-Ping Tsai) > Remove ProduceResponse.responses > -

[GitHub] [kafka] chia7712 commented on pull request #9663: MINOR: Small cleanups in `AlterIsr` handling logic

2020-12-01 Thread GitBox
chia7712 commented on pull request #9663: URL: https://github.com/apache/kafka/pull/9663#issuecomment-736671682 +1 to last commit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533570535 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public RocksDBMetric

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533585639 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java ## @@ -629,16 +657,18 @@ private void se

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533586582 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java ## @@ -619,8 +647,7 @@ public void shoul

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-736700777 BUILD SUCCESSFUL in 18s 122 actionable tasks: 3 executed, 119 up-to-date docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file /opt/kafka-dev/tests/dock

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-736701573 6206tests1failures61ignored6m45.08sduration | 6206tests | 1failures | 61ignored | 6m45.08sduration | 99%successful -- | -- | -- | -- | -- | -- 6206tests | 1failures | 61

[GitHub] [kafka] d8tltanc edited a comment on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc edited a comment on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-736701573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r533593868 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -72,11 +73,20 @@ public int epoch() { return voterReplicaStates.key

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r533593868 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -72,11 +73,20 @@ public int epoch() { return voterReplicaStates.key

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-01 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r533600431 ## File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java ## @@ -32,6 +32,7 @@ */ public static final String USER

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533574172 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -846,43 +856,24 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] hachikuji commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r533593868 ## File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java ## @@ -72,11 +73,20 @@ public int epoch() { return voterReplicaStates.key

[GitHub] [kafka] hachikuji opened a new pull request #9666: MINOR: Remove broken `.travis.yml` with system test hooks

2020-12-01 Thread GitBox
hachikuji opened a new pull request #9666: URL: https://github.com/apache/kafka/pull/9666 This patch removes `.travis.yml` which has never worked as far as I know, but is lately cluttering up PR requests. ### Committer Checklist (excluded from commit message) - [ ] Verify design a

[GitHub] [kafka] hachikuji commented on pull request #9666: MINOR: Remove broken `.travis.yml` with system test hooks

2020-12-01 Thread GitBox
hachikuji commented on pull request #9666: URL: https://github.com/apache/kafka/pull/9666#issuecomment-736731588 cc @chia7712 I guess you were trying to get this working instead? I can close this if you like. This is an auto

[GitHub] [kafka] hachikuji edited a comment on pull request #9666: MINOR: Remove broken `.travis.yml` with system test hooks

2020-12-01 Thread GitBox
hachikuji edited a comment on pull request #9666: URL: https://github.com/apache/kafka/pull/9666#issuecomment-736731588 cc @chia7712 I guess you were trying to get this working instead? I can close this if you prefer. This i

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533626328 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -398,6 +407,7 @@ public void setUncaughtExceptionHandler(final StreamsUn

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533627143 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -846,43 +856,24 @@ private KafkaStreams(final InternalTopologyBuilder in

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r533627543 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager: Broke

[GitHub] [kafka] guozhangwang merged pull request #9665: MINOR: fix reading SSH output in Streams system tests

2020-12-01 Thread GitBox
guozhangwang merged pull request #9665: URL: https://github.com/apache/kafka/pull/9665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533628342 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -846,18 +856,37 @@ private KafkaStreams(final InternalTopologyBuilder in

[GitHub] [kafka] mjsax commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
mjsax commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533639922 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public RocksDBMetric

[GitHub] [kafka] cadonna commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
cadonna commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533641540 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public RocksDBMetr

[GitHub] [kafka] guozhangwang opened a new pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-01 Thread GitBox
guozhangwang opened a new pull request #9667: URL: https://github.com/apache/kafka/pull/9667 For MemberIdRequiredException, we would not print the exception at INFO with a full exception message since it may introduce more confusion that clearance. ### Committer Checklist (excluded f

[GitHub] [kafka] guozhangwang commented on pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-01 Thread GitBox
guozhangwang commented on pull request #9667: URL: https://github.com/apache/kafka/pull/9667#issuecomment-736747672 @hachikuji @abbccdda This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] ableegoldman commented on a change in pull request #9654: MINOR: Increase unit test coverage of ProcessorTopology#updateSourceTopics()

2020-12-01 Thread GitBox
ableegoldman commented on a change in pull request #9654: URL: https://github.com/apache/kafka/pull/9654#discussion_r533644775 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java ## @@ -151,41 +156,105 @@ public void shou

[jira] [Commented] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-12-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241788#comment-17241788 ] Matthias J. Sax commented on KAFKA-10629: - Sure. Can you send a follow up email

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-12-01 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r533648988 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1250,13 +1251,23 @@ class KafkaApis(val requestChannel: RequestChannel, m

[GitHub] [kafka] ableegoldman commented on pull request #9654: MINOR: Increase unit test coverage of ProcessorTopology#updateSourceTopics()

2020-12-01 Thread GitBox
ableegoldman commented on pull request #9654: URL: https://github.com/apache/kafka/pull/9654#issuecomment-736752649 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ableegoldman merged pull request #9654: MINOR: Increase unit test coverage of ProcessorTopology#updateSourceTopics()

2020-12-01 Thread GitBox
ableegoldman merged pull request #9654: URL: https://github.com/apache/kafka/pull/9654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac commented on pull request #9666: MINOR: Remove broken `.travis.yml` with system test hooks

2020-12-01 Thread GitBox
dajac commented on pull request #9666: URL: https://github.com/apache/kafka/pull/9666#issuecomment-736754455 I am +1 on removing it. We can always bring it back to trunk if we can make it work later. This is an automated mes

[GitHub] [kafka] hachikuji merged pull request #9663: MINOR: Small cleanups in `AlterIsr` handling logic

2020-12-01 Thread GitBox
hachikuji merged pull request #9663: URL: https://github.com/apache/kafka/pull/9663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-01 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241814#comment-17241814 ] A. Sophie Blee-Goldman commented on KAFKA-10772: Hey [~lkokhreidze], tha

[GitHub] [kafka] ableegoldman merged pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-12-01 Thread GitBox
ableegoldman merged pull request #9609: URL: https://github.com/apache/kafka/pull/9609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-12-01 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-736766888 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533656732 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] mjsax opened a new pull request #9668: MINOR: add test for repartition/source-topic/changelog optimization

2020-12-01 Thread GitBox
mjsax opened a new pull request #9668: URL: https://github.com/apache/kafka/pull/9668 If topology optimization is enabled, KafkaStreams does not create store changelog topics but re-uses source input topics if possible. However, this optimization should not be applied to internal repar

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533675429 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533676976 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Created] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-01 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-10792: - Summary: Source tasks can block herder thread by hanging during stop Key: KAFKA-10792 URL: https://issues.apache.org/jira/browse/KAFKA-10792 Project: Kafka

[GitHub] [kafka] C0urante opened a new pull request #9669: KAFKA-10792: Prevent source task shutdown from blocking herder thread

2020-12-01 Thread GitBox
C0urante opened a new pull request #9669: URL: https://github.com/apache/kafka/pull/9669 [Jira](https://issues.apache.org/jira/browse/KAFKA-10792) The functional changes are simple: change the `WorkerSourceTask` class to only call `SourceTask::stop` from one location, during task shu

[GitHub] [kafka] C0urante commented on pull request #9669: KAFKA-10792: Prevent source task shutdown from blocking herder thread

2020-12-01 Thread GitBox
C0urante commented on pull request #9669: URL: https://github.com/apache/kafka/pull/9669#issuecomment-736784767 @tombentley @gharris1727 @ncliang care to take a look? This is an automated message from the Apache Git Service.

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533687031 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] hachikuji commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r533648722 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -426,21 +451,34 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-01 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533707640 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Updated] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-01 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10772: -- Attachment: KAFKA-10772.log > java.lang.IllegalStateException: There are insufficient

[jira] [Comment Edited] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-01 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241863#comment-17241863 ] Levani Kokhreidze edited comment on KAFKA-10772 at 12/1/20, 8:50 PM: -

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-01 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241863#comment-17241863 ] Levani Kokhreidze commented on KAFKA-10772: --- Hi [~ableegoldman], yes we are us

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-01 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241865#comment-17241865 ] Levani Kokhreidze commented on KAFKA-10772: --- Maybe this helps – we noticed tha

[GitHub] [kafka] hachikuji commented on a change in pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9601: URL: https://github.com/apache/kafka/pull/9601#discussion_r533719708 ## File path: core/src/test/scala/unit/kafka/server/ReplicaFetcherThreadTest.scala ## @@ -437,8 +437,8 @@ class ReplicaFetcherThreadTest { thread.doW

[GitHub] [kafka] JimGalasyn opened a new pull request #9670: DOCS-6076: Clarify config names for EOS versions 1 and 2

2020-12-01 Thread GitBox
JimGalasyn opened a new pull request #9670: URL: https://github.com/apache/kafka/pull/9670 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
rajinisivaram commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533510477 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -304,6 +308,122 @@ class AclAuthorizer extends Authorizer with L

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533737220 ## File path: core/src/test/scala/unit/kafka/security/authorizer/MockAuthorizer.scala ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] hachikuji commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r533732789 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-01 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r533765909 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -69,33 +70,39 @@ @BenchmarkMode(Mode.AverageTime)

[GitHub] [kafka] hachikuji commented on a change in pull request #9300: KAFKA-10491: Check authorizations first in KafkaApis

2020-12-01 Thread GitBox
hachikuji commented on a change in pull request #9300: URL: https://github.com/apache/kafka/pull/9300#discussion_r533763099 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1770,45 +1770,47 @@ class KafkaApis(val requestChannel: RequestChannel, sendR

[GitHub] [kafka] ncliang commented on a change in pull request #9669: KAFKA-10792: Prevent source task shutdown from blocking herder thread

2020-12-01 Thread GitBox
ncliang commented on a change in pull request #9669: URL: https://github.com/apache/kafka/pull/9669#discussion_r533788764 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -206,16 +203,13 @@ public void cancel() { pub

[GitHub] [kafka] hachikuji merged pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

2020-12-01 Thread GitBox
hachikuji merged pull request #9601: URL: https://github.com/apache/kafka/pull/9601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10729) KIP-482: Bump remaining RPC's to use tagged fields

2020-12-01 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10729. - Fix Version/s: 2.8.0 Resolution: Fixed > KIP-482: Bump remaining RPC's to use tag

  1   2   >