[GitHub] [kafka] cadonna commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-11-30 Thread GitBox
cadonna commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r532438482 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -229,6 +230,15 @@ public V delete(final K key)

[GitHub] [kafka] cadonna commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-11-30 Thread GitBox
cadonna commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r532440942 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/CachingInMemoryKeyValueStoreTest.java ## @@ -359,6 +361,31 @@ public void shou

[jira] [Updated] (KAFKA-10766) Add Unit Test cases for RocksDbRangeIterator

2020-11-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10766: -- Labels: newbie (was: ) > Add Unit Test cases for RocksDbRangeIterator > -

[jira] [Updated] (KAFKA-10766) Add Unit Test cases for RocksDbRangeIterator

2020-11-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10766: -- Component/s: unit tests streams > Add Unit Test cases for RocksDbRangeIterato

[GitHub] [kafka] dajac commented on a change in pull request #9630: KAFKA-10739; Replace EpochEndOffset with automated protocol

2020-11-30 Thread GitBox
dajac commented on a change in pull request #9630: URL: https://github.com/apache/kafka/pull/9630#discussion_r53221 ## File path: core/src/test/scala/unit/kafka/server/epoch/util/ReplicaFetcherMockBlockingSend.scala ## @@ -78,7 +80,19 @@ class ReplicaFetcherMockBlockingSen

[GitHub] [kafka] cadonna commented on a change in pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-11-30 Thread GitBox
cadonna commented on a change in pull request #9508: URL: https://github.com/apache/kafka/pull/9508#discussion_r532451217 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-10767) Add Unit Test cases for missing methods in ThreadCacheTest

2020-11-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10767: -- Component/s: unit tests streams > Add Unit Test cases for missing methods in

[jira] [Updated] (KAFKA-10767) Add Unit Test cases for missing methods in ThreadCacheTest

2020-11-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10767: -- Labels: newbie (was: ) > Add Unit Test cases for missing methods in ThreadCacheTest > ---

[GitHub] [kafka] cadonna commented on pull request #9508: KAFKA-10648: Add Prefix Scan support to State Stores

2020-11-30 Thread GitBox
cadonna commented on pull request #9508: URL: https://github.com/apache/kafka/pull/9508#issuecomment-735665881 @vamossagar12 I replied to your comments. Let me know when the PR is ready for review. This is an automated messa

[GitHub] [kafka] chia7712 merged pull request #9611: KAFKA-10736 Convert transaction coordinator metadata schemas to use g…

2020-11-30 Thread GitBox
chia7712 merged pull request #9611: URL: https://github.com/apache/kafka/pull/9611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10736) Convert transaction coordinator metadata schemas to use generated protocol

2020-11-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10736. Fix Version/s: 2.8.0 Resolution: Fixed > Convert transaction coordinator metadata s

[GitHub] [kafka] dengziming opened a new pull request #9662: Kafka-10130; Rewrite FeatureZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
dengziming opened a new pull request #9662: URL: https://github.com/apache/kafka/pull/9662 *More detailed description of your change* 1. remove FeatureZNode and replace it with FeatureZNode.json 2. Change code where FeatureZNode is used 3. copy some code of `org.apache.kafka.raf

[jira] [Commented] (KAFKA-9376) Plugin class loader not found using MM2

2020-11-30 Thread shezm (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240706#comment-17240706 ] shezm commented on KAFKA-9376: -- Hi,I had the same problem too(release 2.4.0 with scala 2.12)

[GitHub] [kafka] ankit-kumar-25 commented on pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

2020-11-30 Thread GitBox
ankit-kumar-25 commented on pull request #9326: URL: https://github.com/apache/kafka/pull/9326#issuecomment-735753885 Hey @mimaison, Thank you for your input. I have added a couple of test cases to validate this condition. For some reason the `Build Failed`. Can you please review th

[GitHub] [kafka] dengziming commented on pull request #9662: KAFKA-10130; Rewrite FeatureZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
dengziming commented on pull request #9662: URL: https://github.com/apache/kafka/pull/9662#issuecomment-735765304 @abbccdda @kowshik hi, PTAL. also ping @cmccabe @hachikuji to have a look. This is an automated message from

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-11-30 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240842#comment-17240842 ] David Jacot commented on KAFKA-8266: It seems that we haven't seen this one for a whi

[jira] [Resolved] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-11-30 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-8266. Resolution: Fixed > Improve > `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGr

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-30 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240908#comment-17240908 ] Ming Liu commented on KAFKA-7918: - We also had the code to optimize the changelog support

[jira] [Created] (KAFKA-10777) Add additional configuration to control MM2 internal topics naming convention

2020-11-30 Thread Omnia Ibrahim (Jira)
Omnia Ibrahim created KAFKA-10777: - Summary: Add additional configuration to control MM2 internal topics naming convention Key: KAFKA-10777 URL: https://issues.apache.org/jira/browse/KAFKA-10777 Proje

[jira] [Updated] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-11-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10017: - Fix Version/s: (was: 2.6.0) 2.8.0 > Flaky Test EosBetaUpgradeIntegrationT

[jira] [Updated] (KAFKA-10292) fix flaky streams/streams_broker_bounce_test.py

2020-11-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10292: - Fix Version/s: 2.8.0 > fix flaky streams/streams_broker_bounce_test.py > ---

[jira] [Updated] (KAFKA-10292) fix flaky streams/streams_broker_bounce_test.py

2020-11-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10292: - Priority: Blocker (was: Major) > fix flaky streams/streams_broker_bounce_test.py >

[jira] [Closed] (KAFKA-10754) Fix flaky shouldShutdownSingleThreadApplication test

2020-11-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler closed KAFKA-10754. > Fix flaky shouldShutdownSingleThreadApplication test > -

[jira] [Closed] (KAFKA-10758) Kafka Streams consuming from a pattern goes to PENDING_SHUTDOWN when adding a new topic

2020-11-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler closed KAFKA-10758. > Kafka Streams consuming from a pattern goes to PENDING_SHUTDOWN when adding a > new topic > ---

[GitHub] [kafka] hachikuji commented on pull request #9632: KAFKA-10702; Skip bookkeeping of empty transactions

2020-11-30 Thread GitBox
hachikuji commented on pull request #9632: URL: https://github.com/apache/kafka/pull/9632#issuecomment-735990319 For a little more background about the `LogTest.testAppendToTransactionIndexFailure` failure, it is due to an inconsistency in how we update state in `ProducerStateManager`. The

[jira] [Created] (KAFKA-10778) Stronger log fencing after write failure

2020-11-30 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10778: --- Summary: Stronger log fencing after write failure Key: KAFKA-10778 URL: https://issues.apache.org/jira/browse/KAFKA-10778 Project: Kafka Issue Type: Bu

[GitHub] [kafka] hachikuji commented on pull request #9632: KAFKA-10702; Skip bookkeeping of empty transactions

2020-11-30 Thread GitBox
hachikuji commented on pull request #9632: URL: https://github.com/apache/kafka/pull/9632#issuecomment-736004238 Note I filed https://issues.apache.org/jira/browse/KAFKA-10778 to introduce synchronous log fencing after IO errors. ---

[jira] [Updated] (KAFKA-10778) Stronger log fencing after write failure

2020-11-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10778: Description: If a log append operation fails with an IO error, the broker attempts to fail

[GitHub] [kafka] viktorsomogyi commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

2020-11-30 Thread GitBox
viktorsomogyi commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-736027069 @lbradstreet it is really hard to give an exact answer to this as collision rate is hard to calculate mathematically as it is very dependant on the size and values of the te

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

2020-11-30 Thread GitBox
viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-736027069 @lbradstreet it is really hard to give an exact answer to this as collision rate is hard to calculate mathematically as it is very dependant on the size and values of

[GitHub] [kafka] bbejeck merged pull request #9657: MINOR: Remove erroneous extra in design doc

2020-11-30 Thread GitBox
bbejeck merged pull request #9657: URL: https://github.com/apache/kafka/pull/9657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9655: MINOR: fix listeners doc to close properly

2020-11-30 Thread GitBox
bbejeck commented on pull request #9655: URL: https://github.com/apache/kafka/pull/9655#issuecomment-736030783 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] d1egoaz closed pull request #9088: sync docs for list of emitted metrics by MirrorMetrics

2020-11-30 Thread GitBox
d1egoaz closed pull request #9088: URL: https://github.com/apache/kafka/pull/9088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9657: MINOR: Remove erroneous extra in design doc

2020-11-30 Thread GitBox
bbejeck commented on pull request #9657: URL: https://github.com/apache/kafka/pull/9657#issuecomment-736032726 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

2020-11-30 Thread GitBox
viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-736027069 @lbradstreet it is really hard to give an exact answer to this as collision rate is hard to calculate mathematically as it is very dependant on the size and values of

[GitHub] [kafka] bdbyrne commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-11-30 Thread GitBox
bdbyrne commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r532909153 ## File path: clients/src/main/java/org/apache/kafka/common/quota/ClientQuotaEntity.java ## @@ -32,6 +32,7 @@ */ public static final String USER

[GitHub] [kafka] twobeeb commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-30 Thread GitBox
twobeeb commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-736079387 @ryannedolan I have a preference for your first suggestion (the one for which there is currently a code proposition) because it doesn't alter the behavior of MM2 in any way fo

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-11-30 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241113#comment-17241113 ] James Galasyn commented on KAFKA-2967: -- Since I inherited the Streams docs, I've com

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-11-30 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241113#comment-17241113 ] James Galasyn edited comment on KAFKA-2967 at 11/30/20, 10:31 PM: -

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-11-30 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241113#comment-17241113 ] James Galasyn edited comment on KAFKA-2967 at 11/30/20, 10:31 PM: -

[GitHub] [kafka] hachikuji merged pull request #9632: KAFKA-10702; Skip bookkeeping of empty transactions

2020-11-30 Thread GitBox
hachikuji merged pull request #9632: URL: https://github.com/apache/kafka/pull/9632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10702) Slow replication of empty transactions

2020-11-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10702: Issue Type: Improvement (was: Bug) > Slow replication of empty transactions > ---

[jira] [Resolved] (KAFKA-10702) Slow replication of empty transactions

2020-11-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10702. - Fix Version/s: 2.8.0 Resolution: Fixed > Slow replication of empty transactions >

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-11-30 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241113#comment-17241113 ] James Galasyn edited comment on KAFKA-2967 at 11/30/20, 10:49 PM: -

[jira] [Updated] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-11-30 Thread Joel Hamill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Hamill updated KAFKA-2967: --- Labels: documentation (was: ) > Move Kafka documentation to ReStructuredText > -

[GitHub] [kafka] hachikuji opened a new pull request #9663: MINOR: Small cleanups in `AlterIsr` handling logic

2020-11-30 Thread GitBox
hachikuji opened a new pull request #9663: URL: https://github.com/apache/kafka/pull/9663 A few small cleanups in `Partition` handling of `AlterIsr`: - Factor state update and log message into `sendAlterIsrRequest` - Ensure illegal state error gets raised if a retry fails to be enq

[GitHub] [kafka] junrao commented on a change in pull request #9631: KAFKA-9672: Leader with ISR as a superset of replicas

2020-11-30 Thread GitBox
junrao commented on a change in pull request #9631: URL: https://github.com/apache/kafka/pull/9631#discussion_r532963241 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -947,9 +947,10 @@ class Partition(val topicPartition: TopicPartition,

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241139#comment-17241139 ] Matthias J. Sax commented on KAFKA-7918: The existing caching layer also collapse

[jira] [Comment Edited] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241139#comment-17241139 ] Matthias J. Sax edited comment on KAFKA-7918 at 11/30/20, 11:51 PM: ---

[jira] [Commented] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241146#comment-17241146 ] Matthias J. Sax commented on KAFKA-10629: - [~rohitdeshaws] – you got 3 binding v

[jira] [Updated] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10629: Description: As of [https://github.com/apache/kafka/pull/9477,] many TopologyTestDriver u

[jira] [Updated] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10629: Issue Type: Improvement (was: Task) > TopologyTestDriver should not require a Properties

[jira] [Updated] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10629: Labels: kip newbie (was: needs-kip newbie) > TopologyTestDriver should not require a Prop

[GitHub] [kafka] mjsax commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-11-30 Thread GitBox
mjsax commented on a change in pull request #9660: URL: https://github.com/apache/kafka/pull/9660#discussion_r532983342 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -254,6 +265,19 @@ public TopologyTestDriver(final Topol

[GitHub] [kafka] mjsax merged pull request #9607: [KAFKA-10722] doc: Described the types of the stores used

2020-11-30 Thread GitBox
mjsax merged pull request #9607: URL: https://github.com/apache/kafka/pull/9607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9607: [KAFKA-10722] doc: Described the types of the stores used

2020-11-30 Thread GitBox
mjsax commented on pull request #9607: URL: https://github.com/apache/kafka/pull/9607#issuecomment-736136722 Thanks for the PR @fml2! Sorry for the delay in reviewing. Sometimes it takes some time (good that you kept nagging :) ) ---

[GitHub] [kafka] mjsax commented on a change in pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

2020-11-30 Thread GitBox
mjsax commented on a change in pull request #9606: URL: https://github.com/apache/kafka/pull/9606#discussion_r532996684 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java ## @@ -381,7 +381,8 @@ * {@link StreamsConfig#COMMIT_INTERVAL_

[GitHub] [kafka] mjsax commented on a change in pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

2020-11-30 Thread GitBox
mjsax commented on a change in pull request #9606: URL: https://github.com/apache/kafka/pull/9606#discussion_r532996901 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java ## @@ -438,7 +439,8 @@ * query the value of the key on a paral

[jira] [Created] (KAFKA-10779) Reassignment tool sets throttles incorrectly when overriding a reassignment

2020-11-30 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10779: --- Summary: Reassignment tool sets throttles incorrectly when overriding a reassignment Key: KAFKA-10779 URL: https://issues.apache.org/jira/browse/KAFKA-10779 Pro

[jira] [Created] (KAFKA-10780) Rewrite ControllerZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10780: -- Summary: Rewrite ControllerZNode struct with auto-generated protocol Key: KAFKA-10780 URL: https://issues.apache.org/jira/browse/KAFKA-10780 Project: Kafka Iss

[jira] [Created] (KAFKA-10781) Rewrite BrokerIdZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10781: -- Summary: Rewrite BrokerIdZNode struct with auto-generated protocol Key: KAFKA-10781 URL: https://issues.apache.org/jira/browse/KAFKA-10781 Project: Kafka Issue

[jira] [Created] (KAFKA-10782) Rewrite TopicZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10782: -- Summary: Rewrite TopicZNode struct with auto-generated protocol Key: KAFKA-10782 URL: https://issues.apache.org/jira/browse/KAFKA-10782 Project: Kafka Issue Type

[jira] [Created] (KAFKA-10783) Rewrite TopicPartitionStateZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10783: -- Summary: Rewrite TopicPartitionStateZNode struct with auto-generated protocol Key: KAFKA-10783 URL: https://issues.apache.org/jira/browse/KAFKA-10783 Project: Kafka

[jira] [Created] (KAFKA-10784) Rewrite ConfigEntityZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10784: -- Summary: Rewrite ConfigEntityZNode struct with auto-generated protocol Key: KAFKA-10784 URL: https://issues.apache.org/jira/browse/KAFKA-10784 Project: Kafka Is

[jira] [Created] (KAFKA-10785) Rewrite ConfigEntityChangeNotificationSequenceZNode struct with auto-generated protocol

2020-11-30 Thread dengziming (Jira)
dengziming created KAFKA-10785: -- Summary: Rewrite ConfigEntityChangeNotificationSequenceZNode struct with auto-generated protocol Key: KAFKA-10785 URL: https://issues.apache.org/jira/browse/KAFKA-10785 P

[GitHub] [kafka] junrao commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
junrao commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533002272 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -314,27 +315,23 @@ public KafkaProducer(Properties properties

[GitHub] [kafka] mjsax commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-30 Thread GitBox
mjsax commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533020449 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public RocksDBMetric

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-30 Thread GitBox
hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r533024276 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -35,7 +35,8 @@ import scala.jdk.CollectionConverters._

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-30 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r533026232 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -398,6 +407,7 @@ public void setUncaughtExceptionHandler(final StreamsUn

[GitHub] [kafka] hachikuji commented on a change in pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

2020-11-30 Thread GitBox
hachikuji commented on a change in pull request #9601: URL: https://github.com/apache/kafka/pull/9601#discussion_r533033927 ## File path: clients/src/main/java/org/apache/kafka/common/requests/WriteTxnMarkersRequest.java ## @@ -105,8 +105,8 @@ public int hashCode() {

[GitHub] [kafka] dengziming opened a new pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
dengziming opened a new pull request #9664: URL: https://github.com/apache/kafka/pull/9664 *More detailed description of your change* The #9662 rewrite FeatureZNode struct with auto-generated protocol, but it's a non-trivial change, so we can just review this simple pr first. *Sum

[GitHub] [kafka] hachikuji commented on a change in pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

2020-11-30 Thread GitBox
hachikuji commented on a change in pull request #9601: URL: https://github.com/apache/kafka/pull/9601#discussion_r533034552 ## File path: core/src/test/scala/unit/kafka/server/EdgeCaseRequestTest.scala ## @@ -84,19 +85,24 @@ class EdgeCaseRequestTest extends KafkaServerTestHarn

[jira] [Created] (KAFKA-10786) ReplicaAlterLogDirsThread gets stuck during the reassignment of Kafka partition

2020-11-30 Thread nick song (Jira)
nick song created KAFKA-10786: - Summary: ReplicaAlterLogDirsThread gets stuck during the reassignment of Kafka partition Key: KAFKA-10786 URL: https://issues.apache.org/jira/browse/KAFKA-10786 Project: K

[jira] [Updated] (KAFKA-10786) ReplicaAlterLogDirsThread gets stuck during the reassignment of Kafka partition

2020-11-30 Thread nick song (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nick song updated KAFKA-10786: -- Priority: Blocker (was: Major) > ReplicaAlterLogDirsThread gets stuck during the reassignment of Kaf

[GitHub] [kafka] dengziming commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
dengziming commented on pull request #9664: URL: https://github.com/apache/kafka/pull/9664#issuecomment-736217128 Hi, @abbccdda PTAL. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] chia7712 merged pull request #9659: KAFKA-10770: Remove duplicate defination of Metrics#getTags

2020-11-30 Thread GitBox
chia7712 merged pull request #9659: URL: https://github.com/apache/kafka/pull/9659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

2020-11-30 Thread GitBox
chia7712 commented on pull request #9423: URL: https://github.com/apache/kafka/pull/9423#issuecomment-736222765 > Are test failures related to this PR? They are unrelated error. Will rebase PR to trigger QA again. This

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533079695 ## File path: clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java ## @@ -79,25 +80,52 @@ public void testChannelBuilderConfigs(

[GitHub] [kafka] ijuma commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
ijuma commented on pull request #9664: URL: https://github.com/apache/kafka/pull/9664#issuecomment-736240488 Thanks for the PR. I don't think we should do this since KIP-500 will replace all this code. This is an automated m

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-30 Thread GitBox
abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r533091229 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager: Broker

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-30 Thread GitBox
abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r533091766 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -125,15 +126,25 @@ class BrokerToControllerChannelManagerI

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533092957 ## File path: clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java ## @@ -79,25 +80,52 @@ public void testChannelBuilderConfigs(

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533092986 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -314,27 +315,23 @@ public KafkaProducer(Properties properti

[jira] [Created] (KAFKA-10787) Introduce an import order in Java sources

2020-11-30 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-10787: --- Summary: Introduce an import order in Java sources Key: KAFKA-10787 URL: https://issues.apache.org/jira/browse/KAFKA-10787 Project: Kafka Issue Type: Improveme

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533093616 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r533093802 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -1271,27 +1270,48 @@ public void testProducerJmxPrefix(

[jira] [Commented] (KAFKA-10787) Introduce an import order in Java sources

2020-11-30 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241272#comment-17241272 ] Dongjin Lee commented on KAFKA-10787: - PR: https://github.com/apache/kafka/pull/8404

[jira] [Updated] (KAFKA-10787) Introduce an import order in Java sources

2020-11-30 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-10787: Affects Version/s: 2.8.0 > Introduce an import order in Java sources > ---

[GitHub] [kafka] rohitrmd commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-11-30 Thread GitBox
rohitrmd commented on a change in pull request #9660: URL: https://github.com/apache/kafka/pull/9660#discussion_r533099003 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -254,6 +265,19 @@ public TopologyTestDriver(final To

[GitHub] [kafka] dengziming commented on pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

2020-11-30 Thread GitBox
dengziming commented on pull request #9664: URL: https://github.com/apache/kafka/pull/9664#issuecomment-736255004 @ijuma Thank you, I ignored this fact. Some of the ZkNode will be removed because we no longer need them after KIP-500, for example `IsrChangeNotificationZNode` and `Control

[jira] [Commented] (KAFKA-10629) TopologyTestDriver should not require a Properties arg

2020-11-30 Thread Rohit Deshpande (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241301#comment-17241301 ] Rohit Deshpande commented on KAFKA-10629: - thanks [~mjsax]  > TopologyTestDrive

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

2020-11-30 Thread GitBox
viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-736027069 @lbradstreet it is really hard to give an exact answer to this as collision rate is hard to calculate mathematically as it is very dependant on the size and values of

[GitHub] [kafka] dongjinleekr commented on pull request #8404: KAFKA-10787: Introduce an import order in Java sources

2020-11-30 Thread GitBox
dongjinleekr commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-736272990 Here is the update. - Adapted the three-group import ordering as discussed in [the mailing thread](https://lists.apache.org/thread.html/rf6f49c845a3d48efe8a91916c8fbad

[GitHub] [kafka] chia7712 commented on a change in pull request #9663: MINOR: Small cleanups in `AlterIsr` handling logic

2020-11-30 Thread GitBox
chia7712 commented on a change in pull request #9663: URL: https://github.com/apache/kafka/pull/9663#discussion_r533126745 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1372,23 +1390,27 @@ class Partition(val topicPartition: TopicPartition, * Since