ning2008wisc commented on a change in pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#discussion_r527508609
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##
@@ -0,0 +1,407 @@
+
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-731014605
Thanks @mimaison for your suggestive and insightful feedback.
Regarding to your 2 major concerns, I agree and I believe there exists a
feasible solution. I will updat
ning2008wisc edited a comment on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-731014605
Thanks @mimaison for your suggestive and insightful feedback.
Regarding to your 2 major concerns, I agree and I believe there exists a
feasible solution, espec
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r527530444
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -894,11 +885,77 @@ private KafkaStreams(final InternalTopologyBuilder
[
https://issues.apache.org/jira/browse/KAFKA-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236031#comment-17236031
]
Benedikt Linse commented on KAFKA-10746:
Hi Luke, thanks for creating a Patch so
cadonna commented on a change in pull request #9508:
URL: https://github.com/apache/kafka/pull/9508#discussion_r527583614
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java
##
@@ -103,6 +105,19 @@ public void putAll(final Li
dengziming commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r527643380
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1445,15 +1483,38 @@ class ReplicaManager(val config: KafkaConfig,
r
BDeus commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731189266
Just a quick question.
Can we confirmed that when a KafkaConnect Cluster process mutiple
connectors, the task of each connector as equally balanced on the workers ?
Here an exa
showuon commented on a change in pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#discussion_r527719599
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -110,83 +110,45 @@ publi
showuon commented on a change in pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#discussion_r527720582
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##
@@ -903,16 +903,19 @@ public static void
start
[
https://issues.apache.org/jira/browse/KAFKA-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236181#comment-17236181
]
Martin Dengler commented on KAFKA-10746:
Hi Luke and Benedikt, thanks for the qu
lct45 commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r527724338
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
##
@@ -377,7 +378,7 @@ private void shouldAddMetricsOnAl
seankumar-tl commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731200868
@BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and can
confirm this is now the behavior. Our cluster is processing more than a million
messages a second
BDeus commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731203761
> @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a second and i
BDeus edited a comment on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731203761
> @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a secon
[
https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236189#comment-17236189
]
lqjacklee commented on KAFKA-10753:
---
{code:java}
public void reset(long timeoutMs) {
BDeus edited a comment on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731203761
> @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a secon
BDeus edited a comment on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731203761
> @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a secon
dongjinleekr commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-731208645
Hi @vvcephei,
I re-based the branch onto the latest trunk, reorganized the changes into
two commits, and fixed
`EOSUncleanShutdownIntegrationTest#shouldWorkWithUnclean
ramesh-muthusamy commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731210369
> > @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a
ramesh-muthusamy commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731210676
> @BDeus, I'm running @ramesh-muthusamy fix in production as a hotfix and
can confirm this is now the behavior. Our cluster is processing more than a
million messages a s
showuon commented on a change in pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#discussion_r527741948
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##
@@ -110,83 +110,45 @@ publi
BDeus commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731217584
> @BDeus it is currently not possible to differentiate the load parameters
of a connector, it is assumed that all connectors are equally while ingestion.
We do have similar scenario
[
https://issues.apache.org/jira/browse/KAFKA-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236217#comment-17236217
]
Prithvi commented on KAFKA-6181:
[~spright] Hey, please assign it to me.
> Examining log
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731225730
Sincere apologies for the delay in response. My jira account is
ipri...@gmail.com
Username: iprithv
Full name: Prithvi
Also I have commented in Jira.
---
iprithv edited a comment on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731225730
@chia7712 Sincere apologies for the delay in response. My jira account is
ipri...@gmail.com
Username: iprithv
Full name: Prithvi
Also I have commented in Jira.
--
ramesh-muthusamy commented on pull request #9319:
URL: https://github.com/apache/kafka/pull/9319#issuecomment-731236707
We will get the same results because the task distribution considers all
the tasks independent of a connector.
On Fri, Nov 20, 2020 at 8:26 PM Basile Deustua
dajac opened a new pull request #9630:
URL: https://github.com/apache/kafka/pull/9630
TBD
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrad
jolshan commented on a change in pull request #9626:
URL: https://github.com/apache/kafka/pull/9626#discussion_r527812774
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1445,15 +1483,38 @@ class ReplicaManager(val config: KafkaConfig,
repl
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r527836277
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -894,11 +904,72 @@ private KafkaStreams(final InternalTopologyBuilder
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r527857267
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -894,11 +904,72 @@ private KafkaStreams(final InternalTopologyBuilder
ryannedolan commented on pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#issuecomment-731307334
> Looking into my configuration, I now understand that I was lucky because I
have one link going up back up replica_OLS->replica_CENTRAL which is now the
single emitter of bea
abc863377 commented on pull request #9603:
URL: https://github.com/apache/kafka/pull/9603#issuecomment-731336490
@kkonstantine
Thanks a lot.
This is an automated message from the Apache Git Service.
To respond to the mes
ableegoldman commented on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731359086
Hey @showuon thanks for the quick fix! I notice that
`StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler`
still failed on the JDK15 PR build,
[
https://issues.apache.org/jira/browse/KAFKA-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236416#comment-17236416
]
Jose Armando Garcia Sancio commented on KAFKA-9672:
---
I was not able to
[
https://issues.apache.org/jira/browse/KAFKA-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236420#comment-17236420
]
Jose Armando Garcia Sancio commented on KAFKA-9672:
---
Based on my observ
[
https://issues.apache.org/jira/browse/KAFKA-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236420#comment-17236420
]
Jose Armando Garcia Sancio edited comment on KAFKA-9672 at 11/20/20, 8:14 PM:
-
jsancio opened a new pull request #9631:
URL: https://github.com/apache/kafka/pull/9631
It is possible for the the controller to send LeaderAndIsr requests with
an ISR that contains ids not in the replica set. This is used during
reassignment so that the partition leader doesn't add re
hachikuji opened a new pull request #9632:
URL: https://github.com/apache/kafka/pull/9632
Compacted topics can accumulate a large number of empty transaction markers
as the data from the transactions gets cleaned. For each transaction, there is
some bookkeeping that leaders and followers m
hachikuji commented on pull request #9632:
URL: https://github.com/apache/kafka/pull/9632#issuecomment-731411122
Addressing this problem more generally so that we can also handle small
transactions is difficult because of the need to maintain the index. I believe
there is still room for im
hachikuji opened a new pull request #9633:
URL: https://github.com/apache/kafka/pull/9633
This patch fixes a liveness bug which prevents follower truncation from
completing after a leader election. If there are consecutive leader elections
without writing any data entries, then the leader
lbradstreet commented on a change in pull request #9632:
URL: https://github.com/apache/kafka/pull/9632#discussion_r528006935
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -301,26 +304,28 @@ private[log] class ProducerAppendInfo(val topicPartition
hachikuji commented on a change in pull request #9632:
URL: https://github.com/apache/kafka/pull/9632#discussion_r528007637
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -301,26 +304,28 @@ private[log] class ProducerAppendInfo(val topicPartition:
Matthias J. Sax created KAFKA-10755:
---
Summary: Should consider commit latency when computing next commit
timestamp
Key: KAFKA-10755
URL: https://issues.apache.org/jira/browse/KAFKA-10755
Project: Ka
mjsax opened a new pull request #9634:
URL: https://github.com/apache/kafka/pull/9634
Call for review @wcarlson5 @guozhangwang
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/KAFKA-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-10755:
---
Assignee: Matthias J. Sax
> Should consider commit latency when computing next comm
guozhangwang commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731450981
LGTM! Please feel free to merge if local unit test passes.
This is an automated message from the Apache Git S
[
https://issues.apache.org/jira/browse/KAFKA-10755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10755:
Priority: Critical (was: Major)
> Should consider commit latency when computing next comm
d8tltanc commented on pull request #9497:
URL: https://github.com/apache/kafka/pull/9497#issuecomment-731462819
Hi, @warrenzhu25. We'll wait at least until 3.0 for merging as we are making
the ACL changes. Please see KIP-679 for more details and join our discussion.
Thanks.
-
[
https://issues.apache.org/jira/browse/KAFKA-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-10745.
-
Resolution: Invalid
[~nayusik] – we use the Jira board for bug reports, not to answer qu
[
https://issues.apache.org/jira/browse/KAFKA-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-10752.
-
Resolution: Invalid
[~dnamicro] – we use the Jira board for bug reports, not to answer q
[
https://issues.apache.org/jira/browse/KAFKA-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-10754:
Component/s: unit tests
streams
> Fix flaky shouldShutdownSingleThreadApp
junrao commented on a change in pull request #8826:
URL: https://github.com/apache/kafka/pull/8826#discussion_r527972552
##
File path:
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
##
@@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition, Ma
[
https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236547#comment-17236547
]
A. Sophie Blee-Goldman commented on KAFKA-10643:
Hey [~eran-levy]
Thank
hachikuji commented on pull request #9632:
URL: https://github.com/apache/kafka/pull/9632#issuecomment-731477573
Note that this change is causing
`LogTest.testAppendToTransactionIndexFailure` to fail. I think this has
surfaced an inconsistency in how we update the transaction state. I'm
c
hachikuji commented on pull request #9633:
URL: https://github.com/apache/kafka/pull/9633#issuecomment-731493312
@junrao Thanks for reviewing. I pushed a minor tweak. I think we need to
truncate the epoch cache even if the truncation offset is larger than the end
offset. This is what would
mjsax merged pull request #9634:
URL: https://github.com/apache/kafka/pull/9634
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731499093
Merged to `trunk` and cherry-picked to `2.6`. Will cherry pick to `2.7`
after release is done.
This is an automated
dengziming created KAFKA-10756:
--
Summary: Add missing unit test for `UnattachedState`
Key: KAFKA-10756
URL: https://issues.apache.org/jira/browse/KAFKA-10756
Project: Kafka
Issue Type: Sub-task
dengziming opened a new pull request #9635:
URL: https://github.com/apache/kafka/pull/9635
Accidentally find that there is no unit test for UnattachedState, We should
add missing unit tests, code is similar to ResignedStateTest and VotedStateTest.
-
dengziming commented on pull request #9635:
URL: https://github.com/apache/kafka/pull/9635#issuecomment-731501943
@hachikuji @guozhangwang ,Hi, PTAL.
This is an automated message from the Apache Git Service.
To respond to the
dengziming created KAFKA-10757:
--
Summary: KAFKA-10755 brings a compile error
Key: KAFKA-10757
URL: https://issues.apache.org/jira/browse/KAFKA-10757
Project: Kafka
Issue Type: Bug
R
dengziming opened a new pull request #9636:
URL: https://github.com/apache/kafka/pull/9636
The KAFKA-10755 calls new TaskManager with 9 params
```
final TaskManager taskManager = new TaskManager(
null,
null,
null,
null,
dengziming commented on pull request #9636:
URL: https://github.com/apache/kafka/pull/9636#issuecomment-731506777
@guozhangwang @mjsax Hi, PTAL.
This is an automated message from the Apache Git Service.
To respond to the mess
ijuma commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-731513666
Looks this broke the build. Did we check that the PR passed?
This is an automated message from the Apache Git Servic
ijuma merged pull request #9636:
URL: https://github.com/apache/kafka/pull/9636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9636:
URL: https://github.com/apache/kafka/pull/9636#issuecomment-731513931
I verified that the test passed locally and the Jenkins build passed the
compilation part.
This is an automated mes
showuon commented on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731520316
@ableegoldman , thanks for pointing it out. After investigation, I found the
test
`StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler`
failed is b
showuon edited a comment on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731520316
@ableegoldman , thanks for pointing it out. After investigation, I found the
test
`StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler`
fail
showuon edited a comment on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731520316
@ableegoldman , thanks for pointing it out. After investigation, I found the
test
`StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler`
fail
showuon edited a comment on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-731520316
@ableegoldman , thanks for pointing it out. After investigation, I found the
test
`StreamsUncaughtExceptionHandlerIntegrationTest.shouldShutdownThreadUsingOldHandler`
fail
chia7712 merged pull request #9204:
URL: https://github.com/apache/kafka/pull/9204
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-6181:
-
Assignee: Prithvi
> Examining log messages with {{--deep-iteration}} should show superse
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731525092
@iprithv Thanks for you patch. I have assigned
https://issues.apache.org/jira/browse/KAFKA-6181 to you :)
This
[
https://issues.apache.org/jira/browse/KAFKA-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-6181.
---
Fix Version/s: 2.8.0
Resolution: Fixed
> Examining log messages with {{--deep-iteratio
75 matches
Mail list logo
