[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-14 Thread fml2 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231972#comment-17231972 ] fml2 commented on KAFKA-10722: -- Hello, thank you for the quick response! This perfectly mak

[jira] [Commented] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-14 Thread fml2 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231981#comment-17231981 ] fml2 commented on KAFKA-10722: -- Matthias, does your response mean that we *always* get a ti

[jira] [Comment Edited] (KAFKA-10722) Timestamped store is used even if not desired

2020-11-14 Thread fml2 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231972#comment-17231972 ] fml2 edited comment on KAFKA-10722 at 11/14/20, 10:29 AM: -- Hell

[GitHub] [kafka] fml2 commented on pull request #8869: KAFKA-9781: Allow to specify a time zone when converting a timestamp to string

2020-11-14 Thread GitBox
fml2 commented on pull request #8869: URL: https://github.com/apache/kafka/pull/8869#issuecomment-727184886 Could someone informed tell me what is the reason of the build failure? Thanks! This is an automated message from th

[GitHub] [kafka] mimaison commented on pull request #9583: [KAFKA-10705]: Make state stores not readable by others

2020-11-14 Thread GitBox
mimaison commented on pull request #9583: URL: https://github.com/apache/kafka/pull/9583#issuecomment-727189048 @ableegoldman I see you merged this in 2.6. How critical is this fix? Do I need to spin a new RC? This is an aut

[jira] [Created] (KAFKA-10724) Command to run single quorum is missing "--config" parameters.

2020-11-14 Thread huldar chen (Jira)
huldar chen created KAFKA-10724: --- Summary: Command to run single quorum is missing "--config" parameters. Key: KAFKA-10724 URL: https://issues.apache.org/jira/browse/KAFKA-10724 Project: Kafka

[jira] [Updated] (KAFKA-10724) Command to run single quorum in raft is missing "--config" parameters.

2020-11-14 Thread huldar chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huldar chen updated KAFKA-10724: Summary: Command to run single quorum in raft is missing "--config" parameters. (was: Command to

[GitHub] [kafka] huldarchen opened a new pull request #9595: KAFKA-10724:Command to run single quorum in raft is missing "--config…

2020-11-14 Thread GitBox
huldarchen opened a new pull request #9595: URL: https://github.com/apache/kafka/pull/9595 When I run "bin/test-raft-server-start.sh config/raft.properties", I get an error: [2020-11-14 23:00:38,742] ERROR Exiting Kafka due to fatal exception (kafka.tools.TestRaftServer$) org.apache.

[GitHub] [kafka] abbccdda commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

2020-11-14 Thread GitBox
abbccdda commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r523440605 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -713,6 +715,8 @@ public void sendOffsetsToTransaction(Map o

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager shutdown error handler doesn't shutdown all internal thread pools

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Summary: LogManager leaks internal thread pool activity during shutdown (was: LogManage

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[jira] [Issue Comment Deleted] (KAFKA-10710) MirrorMaker 2 creates all combinations of herders

2020-11-14 Thread Julien C (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien C updated KAFKA-10710: - Comment: was deleted (was: Commit is not working as expected) > MirrorMaker 2 creates all combinations

[GitHub] [kafka] hachikuji commented on pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-14 Thread GitBox
hachikuji commented on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-727266100 @chia7712 Thanks for reviews, merging to trunk. I will follow up with the suggestion about `AbstractResponse.parseResponse` as well as a couple other improvements. ---

[jira] [Resolved] (KAFKA-10684) Avoid additional copies in envelope path when transmitting over network

2020-11-14 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10684. - Resolution: Fixed > Avoid additional copies in envelope path when transmitting over netw

[GitHub] [kafka] hachikuji merged pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-14 Thread GitBox
hachikuji merged pull request #9563: URL: https://github.com/apache/kafka/pull/9563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10424) MirrorMaker 2.0 does not replicates topic's "clean.policy"

2020-11-14 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ning Zhang resolved KAFKA-10424. Resolution: Not A Bug > MirrorMaker 2.0 does not replicates topic's "clean.policy" > -

[jira] [Created] (KAFKA-10725) Merge StoreQueryIntegrationTest and QueryableStateIntegrationTest

2020-11-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10725: - Summary: Merge StoreQueryIntegrationTest and QueryableStateIntegrationTest Key: KAFKA-10725 URL: https://issues.apache.org/jira/browse/KAFKA-10725 Project: Kafka

[GitHub] [kafka] kowshik opened a new pull request #9596: KAFKA-10723: Fix LogManager shutdown error handling

2020-11-14 Thread GitBox
kowshik opened a new pull request #9596: URL: https://github.com/apache/kafka/pull/9596 The asynchronous shutdown in `LogManager` has the shortcoming that if during shutdown any of the internal futures fail, then we do not always ensure that all futures are completed before `LogManager.shu

[jira] [Updated] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

2020-11-14 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10723: - Description: *TL;DR:* The asynchronous shutdown in {{LogManager}} has the shortcoming t

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521549126 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521566585 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521566585 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-14 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r523682718 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] abbccdda merged pull request #9594: Improve JavaDoc in KeyValueBytesStoreSupplier

2020-11-14 Thread GitBox
abbccdda merged pull request #9594: URL: https://github.com/apache/kafka/pull/9594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] kowshik commented on pull request #9596: KAFKA-10723: Fix LogManager shutdown error handling

2020-11-14 Thread GitBox
kowshik commented on pull request #9596: URL: https://github.com/apache/kafka/pull/9596#issuecomment-727523253 cc @dhruvilshah3 @junrao @hachikuji for review/discussion This is an automated message from the Apache Git Service

[jira] [Commented] (KAFKA-10701) First line of detailed stats from consumer-perf-test.sh incorrect

2020-11-14 Thread Quan Nguyen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232201#comment-17232201 ] Quan Nguyen commented on KAFKA-10701: - Hi, I can work on this bug if it hasn't been