[jira] [Assigned] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

2020-11-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10685: - Assignee: Luke Chen > --to-datetime passed to kafka-consumer-groups interpreting microseconds w

[GitHub] [kafka] chia7712 commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-05 Thread GitBox
chia7712 commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r517868504 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] chia7712 commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-05 Thread GitBox
chia7712 commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r517868504 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[jira] [Commented] (KAFKA-10685) --to-datetime passed to kafka-consumer-groups interpreting microseconds wrong

2020-11-05 Thread Michael Bingham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226576#comment-17226576 ] Michael Bingham commented on KAFKA-10685: - This issue seems to occur with Java 1

[jira] [Updated] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eran Levy updated KAFKA-10643: -- Attachment: broker-4-11.csv client-4-11.csv > Static membership - repetitive Preparing

[jira] [Commented] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy commented on KAFKA-10643: --- [^client-4-11.csv][~ableegoldman] thanks, sorry f

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy edited comment on KAFKA-10643 at 11/5/20, 9:42 AM: -

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy edited comment on KAFKA-10643 at 11/5/20, 10:39 AM:

[GitHub] [kafka] mimaison opened a new pull request #9565: MINOR: Move upgraded docs from site to Kafka docs

2020-11-05 Thread GitBox
mimaison opened a new pull request #9565: URL: https://github.com/apache/kafka/pull/9565 A number of doc updates have been applied to the website. For the 2.6.1 release, resync Kafka's docs folder with the website. ### Committer Checklist (excluded from commit message) - [ ] V

[GitHub] [kafka] mimaison commented on pull request #9565: MINOR: Move upgraded docs from site to Kafka docs

2020-11-05 Thread GitBox
mimaison commented on pull request #9565: URL: https://github.com/apache/kafka/pull/9565#issuecomment-722338239 Copied docs from the 26 folder in kafka-site. I checked and as far as I can tell, this already included all recent changes made to `/docs` in the 2.6 branch

[jira] [Closed] (KAFKA-10406) Table data doesn't wrap around in fixed-width columns and gets hidden

2020-11-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison closed KAFKA-10406. -- > Table data doesn't wrap around in fixed-width columns and gets hidden >

[GitHub] [kafka] mimaison commented on pull request #9565: MINOR: Move upgraded docs from site to Kafka docs

2020-11-05 Thread GitBox
mimaison commented on pull request #9565: URL: https://github.com/apache/kafka/pull/9565#issuecomment-722341097 @bbejeck Can you take a look? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r517474129 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -346,18 +351,21 @@ public void setStateListener(final KafkaStreams.Sta

[jira] [Created] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
Levani Kokhreidze created KAFKA-10686: - Summary: Pluggable standby tasks assignor for Kafka Streams Key: KAFKA-10686 URL: https://issues.apache.org/jira/browse/KAFKA-10686 Project: Kafka

[jira] [Commented] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226719#comment-17226719 ] Levani Kokhreidze commented on KAFKA-10686: --- If this ticket makes sense, I'd b

[jira] [Updated] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10686: -- Description: In production, Kafka Streams instances often run across different cluster

[GitHub] [kafka] cadonna commented on a change in pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-05 Thread GitBox
cadonna commented on a change in pull request #9543: URL: https://github.com/apache/kafka/pull/9543#discussion_r518057272 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -719,8 +718,7 @@ private KafkaStreams(final InternalTopologyBuilder in

[jira] [Commented] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226725#comment-17226725 ] Bruno Cadonna commented on KAFKA-10686: --- Hi [~lkokhreidze], I guess this ticket ma

[GitHub] [kafka] dengziming commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-11-05 Thread GitBox
dengziming commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r518097473 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -293,14 +297,17 @@ object TopicZNode { removingReplicasAssignmentJson += (partitio

[jira] [Updated] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10686: -- Description: In production, Kafka Streams instances often run across different cluster

[jira] [Commented] (KAFKA-10683) Consumer.position() Ignores Transaction Marker with read_uncommitted

2020-11-05 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226774#comment-17226774 ] Gary Russell commented on KAFKA-10683: -- In addition, position() does not take the m

[jira] [Comment Edited] (KAFKA-10683) Consumer.position() Ignores Transaction Marker with read_uncommitted

2020-11-05 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226774#comment-17226774 ] Gary Russell edited comment on KAFKA-10683 at 11/5/20, 3:35 PM: --

[jira] [Updated] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10686: -- Labels: needs-kip (was: ) > Pluggable standby tasks assignor for Kafka Streams >

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy edited comment on KAFKA-10643 at 11/5/20, 4:21 PM: -

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy edited comment on KAFKA-10643 at 11/5/20, 4:22 PM: -

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

2020-11-05 Thread Eran Levy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226608#comment-17226608 ] Eran Levy edited comment on KAFKA-10643 at 11/5/20, 4:26 PM: -

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518187139 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -380,8 +380,9 @@ private void generateVariableLengthTargetTo

[jira] [Updated] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10686: -- Description: In production, Kafka Streams instances often run across different cluster

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-11-05 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r518198753 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -426,21 +451,34 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-11-05 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r518200860 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -454,15 +492,23 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Comment Edited] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226832#comment-17226832 ] Levani Kokhreidze edited comment on KAFKA-10686 at 11/5/20, 4:55 PM: -

[jira] [Commented] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226832#comment-17226832 ] Levani Kokhreidze commented on KAFKA-10686: --- Hi [~cadonna]! Yes, that's exact

[jira] [Updated] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze updated KAFKA-10686: -- Issue Type: New Feature (was: Improvement) > Pluggable standby tasks assignor for Kaf

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

2020-11-05 Thread GitBox
abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r518208011 ## File path: core/src/main/scala/kafka/server/BrokerToControllerChannelManagerImpl.scala ## @@ -208,7 +209,9 @@ class BrokerToControllerRequestThread(net

[GitHub] [kafka] jolshan commented on a change in pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-11-05 Thread GitBox
jolshan commented on a change in pull request #9473: URL: https://github.com/apache/kafka/pull/9473#discussion_r518220189 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -293,14 +297,17 @@ object TopicZNode { removingReplicasAssignmentJson += (partition.p

[GitHub] [kafka] hachikuji commented on pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
hachikuji commented on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-722537557 @chia7712 I think it could. I was actually thinking about #9401 when I was working on it. As far as I can tell, the client currently copies the whole produce buffer when the req

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518187681 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java ## @@ -346,6 +346,10 @@ public ProduceResponse getErrorResponse(int

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518263368 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -346,18 +351,21 @@ public void setStateListener(final KafkaStreams.S

[GitHub] [kafka] abbccdda commented on a change in pull request #9560: KAFKA-10345: Add ZK-notification based update for trust/key store paths

2020-11-05 Thread GitBox
abbccdda commented on a change in pull request #9560: URL: https://github.com/apache/kafka/pull/9560#discussion_r518264048 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaC

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518263937 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,63 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518264927 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -997,6 +1061,72 @@ private boolean close(final long timeoutMs) {

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518265803 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518267956 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[jira] [Assigned] (KAFKA-10686) Pluggable standby tasks assignor for Kafka Streams

2020-11-05 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze reassigned KAFKA-10686: - Assignee: Levani Kokhreidze > Pluggable standby tasks assignor for Kafka Stream

[GitHub] [kafka] apovzner commented on a change in pull request #9555: KAFKA-10673: Cache inter broker listener name used in connection quotas

2020-11-05 Thread GitBox
apovzner commented on a change in pull request #9555: URL: https://github.com/apache/kafka/pull/9555#discussion_r518269240 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1189,6 +1189,7 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518269493 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,63 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518271215 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518271918 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518274359 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518283539 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,63 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] bbejeck commented on pull request #9565: MINOR: Move upgraded docs from site to Kafka docs

2020-11-05 Thread GitBox
bbejeck commented on pull request #9565: URL: https://github.com/apache/kafka/pull/9565#issuecomment-722569996 @mimaison ack, I'll take a look This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] cadonna commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
cadonna commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518283539 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -366,6 +374,63 @@ public void setUncaughtExceptionHandler(final Thread

[GitHub] [kafka] splett2 commented on a change in pull request #9555: KAFKA-10673: Cache inter broker listener name used in connection quotas

2020-11-05 Thread GitBox
splett2 commented on a change in pull request #9555: URL: https://github.com/apache/kafka/pull/9555#discussion_r518283600 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1189,6 +1189,7 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics

[GitHub] [kafka] splett2 commented on a change in pull request #9555: KAFKA-10673: Cache inter broker listener name used in connection quotas

2020-11-05 Thread GitBox
splett2 commented on a change in pull request #9555: URL: https://github.com/apache/kafka/pull/9555#discussion_r518283600 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1189,6 +1189,7 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics

[jira] [Commented] (KAFKA-1800) KafkaException was not recorded at the per-topic metrics

2020-11-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226934#comment-17226934 ] Guozhang Wang commented on KAFKA-1800: -- This has been fixed since 1.0.0; closing now

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-11-05 Thread GitBox
rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r518326079 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -221,7 +223,15 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518326776 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] rajinisivaram commented on pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

2020-11-05 Thread GitBox
rajinisivaram commented on pull request #9382: URL: https://github.com/apache/kafka/pull/9382#issuecomment-722609155 @hachikuji Thanks for the reviews, addressed the comments. This is an automated message from the Apache Git

[GitHub] [kafka] apovzner commented on a change in pull request #9555: KAFKA-10673: Cache inter broker listener name used in connection quotas

2020-11-05 Thread GitBox
apovzner commented on a change in pull request #9555: URL: https://github.com/apache/kafka/pull/9555#discussion_r518327928 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1189,6 +1189,7 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518335631 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518359188 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] jolshan opened a new pull request #9566: KAFKA-10618: Update to Uuid class

2020-11-05 Thread GitBox
jolshan opened a new pull request #9566: URL: https://github.com/apache/kafka/pull/9566 As decided in KIP-516, the UUID class has been named Uuid. This PR changes all instances of org.apache.kafka.common.UUID to org.apache.kafka.common.Uuid. It also modifies the Uuid class so that it

[GitHub] [kafka] jolshan commented on pull request #9566: KAFKA-10618: Update to Uuid class

2020-11-05 Thread GitBox
jolshan commented on pull request #9566: URL: https://github.com/apache/kafka/pull/9566#issuecomment-722639934 @cmccabe @ijuma Let me know if this looks ok. This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] vvcephei commented on pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-05 Thread GitBox
vvcephei commented on pull request #9543: URL: https://github.com/apache/kafka/pull/9543#issuecomment-722642034 The test failures look unrelated: ``` Build / JDK 8 / org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutoOffsetSync | 34 sec |

[GitHub] [kafka] vvcephei merged pull request #9543: KAFKA-10500: Makes the Stream thread list resizable

2020-11-05 Thread GitBox
vvcephei merged pull request #9543: URL: https://github.com/apache/kafka/pull/9543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (KAFKA-10500) Add API to Start and Stop Stream Threads

2020-11-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-10500: -- Assignee: Walker Carlson > Add API to Start and Stop Stream Threads > ---

[GitHub] [kafka] kowshik commented on pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-05 Thread GitBox
kowshik commented on pull request #9561: URL: https://github.com/apache/kafka/pull/9561#issuecomment-722644136 I've rebased on top of #9559 now. So the build failure(s) should be gone. This is an automated message from the Ap

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518363490 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518371511 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ## @@ -60,6 +60,9 @@ public void onPartiti

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
wcarlson5 commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518371722 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsHandlerIntegrationTest.java ## @@ -0,0 +1,274 @@ +/* + * Licensed to the

[jira] [Assigned] (KAFKA-9331) Add option to terminate application when StreamThread(s) die

2020-11-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-9331: - Assignee: Walker Carlson > Add option to terminate application when StreamThread(s) die

[jira] [Assigned] (KAFKA-6943) Have option to shutdown KS cleanly if any threads crashes, or if all threads crash

2020-11-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-6943: - Assignee: Walker Carlson > Have option to shutdown KS cleanly if any threads crashes, or

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518384421 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-05 Thread GitBox
dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r518387030 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,360 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jsancio commented on a change in pull request #9512: KAFKA-10394: generate snapshot

2020-11-05 Thread GitBox
jsancio commented on a change in pull request #9512: URL: https://github.com/apache/kafka/pull/9512#discussion_r518396177 ## File path: core/src/main/scala/kafka/snapshot/KafkaSnapshotReader.scala ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] abbccdda commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
abbccdda commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518396407 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -89,10 +89,11 @@ public ResponseHeader toResponseHeader() {

[jira] [Created] (KAFKA-10687) Produce request should be bumped for new error code PRODUCE_FENCED

2020-11-05 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10687: --- Summary: Produce request should be bumped for new error code PRODUCE_FENCED Key: KAFKA-10687 URL: https://issues.apache.org/jira/browse/KAFKA-10687 Project: Kafka

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518414400 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -89,10 +89,11 @@ public ResponseHeader toResponseHeader() {

[GitHub] [kafka] rajinisivaram opened a new pull request #9567: MINOR: Always return partitions with diverging epochs in fetch response

2020-11-05 Thread GitBox
rajinisivaram opened a new pull request #9567: URL: https://github.com/apache/kafka/pull/9567 This is required to ensure that followers can truncate based on diverging epochs returned in fetch responses. ### Committer Checklist (excluded from commit message) - [ ] Verify design an

[GitHub] [kafka] hachikuji commented on pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
hachikuji commented on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-722690665 I got inspired to try and extend this to apply to all request types. I've updated the patch to remove the custom response logic in `FetchResponse` in favor of a general pattern

[jira] [Commented] (KAFKA-10678) Re-deploying Streams app causes rebalance and task migration

2020-11-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227067#comment-17227067 ] A. Sophie Blee-Goldman commented on KAFKA-10678: Thanks for opening a se

[jira] [Created] (KAFKA-10688) Handle accidental truncation of repartition topics as exceptional failure

2020-11-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10688: - Summary: Handle accidental truncation of repartition topics as exceptional failure Key: KAFKA-10688 URL: https://issues.apache.org/jira/browse/KAFKA-10688 Project:

[GitHub] [kafka] bbejeck commented on a change in pull request #9565: MINOR: Move upgraded docs from site to Kafka docs

2020-11-05 Thread GitBox
bbejeck commented on a change in pull request #9565: URL: https://github.com/apache/kafka/pull/9565#discussion_r518417041 ## File path: docs/js/templateData.js ## @@ -19,6 +19,6 @@ limitations under the License. var context={ "version": "26", "dotVersion": "2.6", -

[jira] [Created] (KAFKA-10689) Assignor can't determine number of partitions on FJK with upstream windowed repartition

2020-11-05 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-10689: -- Summary: Assignor can't determine number of partitions on FJK with upstream windowed repartition Key: KAFKA-10689 URL: https://issues.apache.org/jira/browse/KA

[jira] [Assigned] (KAFKA-10689) Assignor can't determine number of partitions on FJK with upstream windowed repartition

2020-11-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-10689: -- Assignee: A. Sophie Blee-Goldman > Assignor can't determine number of

[jira] [Updated] (KAFKA-10689) Assignor can't determine number of partitions on FJK with upstream windowed repartition

2020-11-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10689: --- Priority: Critical (was: Major) > Assignor can't determine number of partit

[jira] [Commented] (KAFKA-10689) Assignor can't determine number of partitions on FJK with upstream windowed repartition

2020-11-05 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227077#comment-17227077 ] A. Sophie Blee-Goldman commented on KAFKA-10689: It's a pretty obnoxious

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518433135 ## File path: clients/src/main/resources/common/message/EnvelopeRequest.json ## @@ -23,7 +23,7 @@ "fields": [ { "name": "RequestData", "type": "by

[GitHub] [kafka] hachikuji edited a comment on pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-05 Thread GitBox
hachikuji edited a comment on pull request #9563: URL: https://github.com/apache/kafka/pull/9563#issuecomment-722690665 I got inspired to try and extend this to apply to all message types. I've updated the patch to remove the custom response logic in `FetchResponse` in favor of a general p

[jira] [Commented] (KAFKA-10688) Handle accidental truncation of repartition topics as exceptional failure

2020-11-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227080#comment-17227080 ] Guozhang Wang commented on KAFKA-10688: --- Without KAFKA-3370, then we have to imple

[jira] [Updated] (KAFKA-10687) Produce request should be bumped for new error code PRODUCE_FENCED

2020-11-05 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10687: Issue Type: Bug (was: Improvement) > Produce request should be bumped for new error code PRODUCE_

[jira] [Comment Edited] (KAFKA-10688) Handle accidental truncation of repartition topics as exceptional failure

2020-11-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227080#comment-17227080 ] Guozhang Wang edited comment on KAFKA-10688 at 11/5/20, 11:50 PM:

[GitHub] [kafka] junrao merged pull request #9561: KAFKA-10624: For FeatureZNodeStatus, use sealed trait instead of Enumeration

2020-11-05 Thread GitBox
junrao merged pull request #9561: URL: https://github.com/apache/kafka/pull/9561 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10604) The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-11-05 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227084#comment-17227084 ] Guozhang Wang commented on KAFKA-10604: --- I personally would prefer not a KIP for t

[jira] [Resolved] (KAFKA-10624) [Easy] FeatureZNodeStatus should use sealed trait instead of Enumeration

2020-11-05 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10624. - Fix Version/s: 2.8.0 Resolution: Fixed merged the PR to trunk. > [Easy] FeatureZNodeStatus shoul

[GitHub] [kafka] junrao commented on pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-05 Thread GitBox
junrao commented on pull request #8826: URL: https://github.com/apache/kafka/pull/8826#issuecomment-722728533 @chia7712 : Thanks for the updated PR. Did that fix the issue since I still saw the same WARN when running kafka-topics.sh. --

[GitHub] [kafka] ableegoldman opened a new pull request #9568: KAFKA-10689: fix windowed FKJ topology and put checks in assignor to avoid infinite loops

2020-11-05 Thread GitBox
ableegoldman opened a new pull request #9568: URL: https://github.com/apache/kafka/pull/9568 Two pieces: 1) Fix bug in StreamSinkNode#writeToTopology to make sure it always calls the `addSink` overload with the specific topic name, when it exists, so that this topic gets tracked in the

[jira] [Created] (KAFKA-10690) Produce-response delay caused by lagging replica fetch which blocks in-sync one

2020-11-05 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-10690: Summary: Produce-response delay caused by lagging replica fetch which blocks in-sync one Key: KAFKA-10690 URL: https://issues.apache.org/jira/browse/KAFKA-10690 Proje

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-05 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r518478117 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -567,10 +589,34 @@ void runLoop() {

[GitHub] [kafka] chia7712 commented on pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-11-05 Thread GitBox
chia7712 commented on pull request #8826: URL: https://github.com/apache/kafka/pull/8826#issuecomment-722781536 > Did that fix the issue since I still saw the same WARN when running kafka-topics.sh. my bad :( This is

  1   2   >