[GitHub] [kafka] chia7712 commented on pull request #9328: Minor: Add deleteDir for streams quickstart test

chia7712 commented on pull request #9328: URL: https://github.com/apache/kafka/pull/9328#issuecomment-709904546 Maybe we should clean the folder before testing archetype? I just worry the clean is not executed if the job is aborted.

[GitHub] [kafka] rajinisivaram commented on pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

rajinisivaram commented on pull request #9434: URL: https://github.com/apache/kafka/pull/9434#issuecomment-709919899 @hachikuji Thanks for the reviews. Test failure not related (`kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault`). Merging to trunk and 2.7. -

[GitHub] [kafka] rajinisivaram merged pull request #9434: MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

rajinisivaram merged pull request #9434: URL: https://github.com/apache/kafka/pull/9434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] soarez commented on pull request #9000: KAFKA-10036 Improve handling and documentation of Suppliers

soarez commented on pull request #9000: URL: https://github.com/apache/kafka/pull/9000#issuecomment-709937235 @mjsax rebased now. Can you give this another look? This is an automated message from the Apache Git Service. To re

[jira] [Commented] (KAFKA-10526) Explore performance impact of leader fsync deferral

[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215353#comment-17215353 ] Sagar Rao commented on KAFKA-10526: --- hey [~hachikuji], is it something that I can pick

[jira] [Comment Edited] (KAFKA-10526) Explore performance impact of leader fsync deferral

[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215353#comment-17215353 ] Sagar Rao edited comment on KAFKA-10526 at 10/16/20, 11:36 AM: ---

[GitHub] [kafka] dajac commented on a change in pull request #9417: MINOR: Fix flaky testQuotaMetric

dajac commented on a change in pull request #9417: URL: https://github.com/apache/kafka/pull/9417#discussion_r506363762 ## File path: core/src/main/scala/kafka/server/ClientQuotaManager.scala ## @@ -360,8 +360,14 @@ class ClientQuotaManager(private val config: ClientQuotaManag

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

scanterog commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-710022885 > @scanterog I've rekicked the build I think this is ready to merge :P This is an automated message from

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-710030951 @hachikuji I'm now passing in the coordinator epoch and ignoring attempts to unload state if the epoch is old than what's loaded. I've also added a test. One thing I didn't und

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-710044807 > One thing I didn't understand was why I needed to change `AbstractFetcherManagerTest`. Stupid me, that was because I turned up the logging. I'll revert that.

[GitHub] [kafka] rhauch merged pull request #8918: MINOR: Use debug level logging for noisy log messages in Connect

rhauch merged pull request #8918: URL: https://github.com/apache/kafka/pull/8918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch merged pull request #9425: KAFKA-10600: Connect should not add error to connector validation values for properties not in connector’s ConfigDef

rhauch merged pull request #9425: URL: https://github.com/apache/kafka/pull/9425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (KAFKA-10600) Connect adds error to property in validation result if connector does not define the property

[ https://issues.apache.org/jira/browse/KAFKA-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-10600: - Fix Version/s: 2.6.1 2.5.2 2.7.0 Reviewer

[GitHub] [kafka] rajinisivaram opened a new pull request #9450: MINOR: Use `PartitionResponse.errorMessage` in exceptions in KafkaProducer

rajinisivaram opened a new pull request #9450: URL: https://github.com/apache/kafka/pull/9450 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] vvcephei commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

vvcephei commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r506543174 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -2023,13 +2022,13 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

vvcephei commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r506551647 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1037,24 +1037,52 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] vvcephei commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

vvcephei commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506567159 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ## @@ -52,8 +53,11 @@ public void onPartiti

[GitHub] [kafka] mimaison commented on pull request #9313: [mm2] Fix consumer/producer properties override

mimaison commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-710160841 Test failures are not related, merging to trunk This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] mimaison merged pull request #9313: [mm2] Fix consumer/producer properties override

mimaison merged pull request #9313: URL: https://github.com/apache/kafka/pull/9313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215507#comment-17215507 ] Matthias J. Sax commented on KAFKA-10472: - Yes, Confluence. Found your account a

[GitHub] [kafka] ableegoldman commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

ableegoldman commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506616155 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -409,9 +396,18 @@ public GroupAss

[GitHub] [kafka] ableegoldman commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

ableegoldman commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506618643 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -409,9 +396,18 @@ public GroupAss

[GitHub] [kafka] ableegoldman commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

ableegoldman commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506618949 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ## @@ -52,8 +53,11 @@ public void onPar

[GitHub] [kafka] ableegoldman commented on a change in pull request #9446: MINOR: distinguish between missing source topics and internal assignment errors

ableegoldman commented on a change in pull request #9446: URL: https://github.com/apache/kafka/pull/9446#discussion_r506622465 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java ## @@ -52,8 +53,11 @@ public void onPar

[GitHub] [kafka] guozhangwang commented on pull request #9426: MINOR: Fix flaky shouldRejectNonExistentStoreName

guozhangwang commented on pull request #9426: URL: https://github.com/apache/kafka/pull/9426#issuecomment-710289562 LGTM！ This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r506636227 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -19,33 +19,51 @@ import org.apache.kafka.common.record.Records; import ja

[GitHub] [kafka] hachikuji commented on a change in pull request #9418: KAFKA-10601; Add support for append linger to Raft implementation

hachikuji commented on a change in pull request #9418: URL: https://github.com/apache/kafka/pull/9418#discussion_r506638105 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r506650384 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -622,16 +613,42 @@ void runOnce() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r506650596 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateRestoreThread.java ## @@ -0,0 +1,316 @@ +/* + * Licensed to the

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r506651183 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateRestoreThread.java ## @@ -0,0 +1,316 @@ +/* + * Licensed to the

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r506651391 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -93,16 +95,14 @@ private final Set locked

[GitHub] [kafka] shadikajevand commented on pull request #9359: kafka-10273 Connect Converters should produce actionable error messages

shadikajevand commented on pull request #9359: URL: https://github.com/apache/kafka/pull/9359#issuecomment-710427430 @rhauch Hi I have updated the PR. Please review when you have time. Thanks! This is an automated message fro

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506681706 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506681748 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-710503810 @junrao Thank you for the review! I've address the comments and the PR is ready for review again. This is an auto

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506681887 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506681928 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,359 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] junrao commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

junrao commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506696396 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,393 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r506730195 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,393 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (KAFKA-8370) Kafka Connect should check for existence of internal topics before attempting to create them

[ https://issues.apache.org/jira/browse/KAFKA-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215685#comment-17215685 ] Randall Hauch commented on KAFKA-8370: -- We'll have to test this, but it appears that

[jira] [Resolved] (KAFKA-8370) Kafka Connect should check for existence of internal topics before attempting to create them

[ https://issues.apache.org/jira/browse/KAFKA-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8370. -- Resolution: Won't Fix As mentioned above, we never can avoid the race condition of two Connect

[jira] [Created] (KAFKA-10616) StreamThread killed by "IllegalStateException: The processor is already closed"

Sophie Blee-Goldman created KAFKA-10616: --- Summary: StreamThread killed by "IllegalStateException: The processor is already closed" Key: KAFKA-10616 URL: https://issues.apache.org/jira/browse/KAFKA-10616

[GitHub] [kafka] ramesh-muthusamy commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

ramesh-muthusamy commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r506801679 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -577,15 +596,14

[GitHub] [kafka] ramesh-muthusamy commented on a change in pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

ramesh-muthusamy commented on a change in pull request #9319: URL: https://github.com/apache/kafka/pull/9319#discussion_r506803017 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -260,7 +259,7 @

[GitHub] [kafka] ramesh-muthusamy commented on pull request #9319: KAFKA-10413 Allow even distribution of lost/new tasks when more than one worker j…

ramesh-muthusamy commented on pull request #9319: URL: https://github.com/apache/kafka/pull/9319#issuecomment-710752887 @rhauch I have incorporated the review comments, please help in reviewing the changes. This is an auto