huxihx commented on pull request #9225:
URL: https://github.com/apache/kafka/pull/9225#issuecomment-706983935
@zaahirlaher Duplicates could not be avoided with the randomly-selecting
strategy as well. Besides, it could happen that some events would not be chosen
to be sent at all. Looping
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-706985770
@ijuma Please take some time to review.
This is an automated message from the Apache Git Service.
To respond to th
cadonna commented on a change in pull request #8988:
URL: https://github.com/apache/kafka/pull/8988#discussion_r502525264
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateRestoreThread.java
##
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apach
[
https://issues.apache.org/jira/browse/KAFKA-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212338#comment-17212338
]
Shaik Zakir Hussain commented on KAFKA-10477:
-
Thanks [~rhauch] for helping
dongjinleekr opened a new pull request #9414:
URL: https://github.com/apache/kafka/pull/9414
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade no
[
https://issues.apache.org/jira/browse/KAFKA-10585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee reassigned KAFKA-10585:
---
Assignee: Dongjin Lee
> Kafka Streams should clean up the state store directory from cleanu
lct45 commented on pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#issuecomment-707127859
One test failing:
testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup
This is an automated messa
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212398#comment-17212398
]
Robert Martin commented on KAFKA-10582:
---
We are running MM2 as a standalone cluste
dajac commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r503249872
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1203,14 +1261,28 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metrics
[
https://issues.apache.org/jira/browse/KAFKA-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212400#comment-17212400
]
Jonathan Miles commented on KAFKA-8656:
---
KIP link should be
[https://cwiki.apache.
vvcephei merged pull request #9408:
URL: https://github.com/apache/kafka/pull/9408
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
vvcephei commented on pull request #9408:
URL: https://github.com/apache/kafka/pull/9408#issuecomment-707205474
Merged to trunk and cherry-picked to 2.7 and 2.6
This is an automated message from the Apache Git Service.
To res
Randall Hauch created KAFKA-10600:
-
Summary: Connect adds error to property in validation result if
connector does not define the property
Key: KAFKA-10600
URL: https://issues.apache.org/jira/browse/KAFKA-10600
rhauch merged pull request #9375:
URL: https://github.com/apache/kafka/pull/9375
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10600:
--
Description:
Kafka Connect's {{AbstractHerder.generateResult(...)}} method is responsible
for
abbccdda commented on a change in pull request #9412:
URL: https://github.com/apache/kafka/pull/9412#discussion_r503411583
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -494,8 +495,14 @@ class KafkaServer(val config: KafkaConfig, time: Time =
Time.SYST
junrao commented on pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#issuecomment-707238957
@RamanVerma : Thanks for addressing the comments. Did you push the new
commits?
This is an automated message from
kowshik commented on pull request #9412:
URL: https://github.com/apache/kafka/pull/9412#issuecomment-707241757
@abbccdda Sorry for the confusion. Upon second look, I feel we can abandon
this PR containing the fix.
I was looking at the code again, and it seems the requirement is already
kowshik edited a comment on pull request #9412:
URL: https://github.com/apache/kafka/pull/9412#issuecomment-707241757
@abbccdda Sorry for the confusion. Upon second look, I feel we can abandon
this PR containing the fix.
I was looking at the code again, and it seems the requirement is al
[
https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Coates updated KAFKA-10494:
Affects Version/s: 2.7.0
> Streams: enableSendingOldValues should not call parent if node is itsel
[
https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Coates updated KAFKA-10494:
Priority: Blocker (was: Major)
> Streams: enableSendingOldValues should not call parent if node i
[
https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Coates reassigned KAFKA-10494:
---
Assignee: Andy Coates
> Streams: enableSendingOldValues should not call parent if node is i
[
https://issues.apache.org/jira/browse/KAFKA-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Coates updated KAFKA-10494:
Fix Version/s: 2.7.0
> Streams: enableSendingOldValues should not call parent if node is itself
>
kowshik closed pull request #9412:
URL: https://github.com/apache/kafka/pull/9412
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10598.
--
Resolution: Fixed
> KafkaStreams reports inappropriate error message for IQ
>
[
https://issues.apache.org/jira/browse/KAFKA-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212546#comment-17212546
]
Nikolay Izhikov commented on KAFKA-10592:
-
Hello, [~rndgstn]
I run {{test_perfo
vvcephei commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-707271073
Thanks for the PR, @dongjinleekr !
Just a couple of meta-questions:
1. Should we have some tests for this change?
2. I think that right now, we'd be leaving behind som
[
https://issues.apache.org/jira/browse/KAFKA-6642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212568#comment-17212568
]
Matthias J. Sax commented on KAFKA-6642:
This ticket is close as duplicate alread
abbccdda commented on a change in pull request #9409:
URL: https://github.com/apache/kafka/pull/9409#discussion_r503443796
##
File path: core/src/main/scala/kafka/admin/FeatureCommand.scala
##
@@ -0,0 +1,350 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212583#comment-17212583
]
Matthias J. Sax commented on KAFKA-8318:
Sessions are merged here:
[https://gith
[
https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212587#comment-17212587
]
Matthias J. Sax commented on KAFKA-10472:
-
[~hqt] – Thanks for your interest. No
big-andy-coates opened a new pull request #9415:
URL: https://github.com/apache/kafka/pull/9415
fixes: https://issues.apache.org/jira/browse/KAFKA-10494
Nodes that are materialized should not forward requests to
`enableSendingOldValues` to parent nodes, as they themselves can handle
scanterog commented on a change in pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#discussion_r503489280
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java
##
@@ -52,10 +52,10 @@ public void testClusterConfi
kowshik commented on a change in pull request #9409:
URL: https://github.com/apache/kafka/pull/9409#discussion_r503494114
##
File path: core/src/main/scala/kafka/admin/FeatureCommand.scala
##
@@ -0,0 +1,350 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
hachikuji merged pull request #8891:
URL: https://github.com/apache/kafka/pull/8891
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10143.
-
Fix Version/s: (was: 2.6.1)
Resolution: Fixed
> Add integration testing ensur
[
https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10143:
Issue Type: Improvement (was: Bug)
> Add integration testing ensuring that the reassignme
[
https://issues.apache.org/jira/browse/KAFKA-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212643#comment-17212643
]
Chris Egerton commented on KAFKA-10574:
---
Thanks [~rhauch]. Really appreciate the b
Jason Gustafson created KAFKA-10601:
---
Summary: Add linger semantics to raft
Key: KAFKA-10601
URL: https://issues.apache.org/jira/browse/KAFKA-10601
Project: Kafka
Issue Type: Sub-task
Lev Zemlyanov created KAFKA-10602:
-
Summary: DLQ Reporter throws NPE when reporting from different
thread
Key: KAFKA-10602
URL: https://issues.apache.org/jira/browse/KAFKA-10602
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lev Zemlyanov updated KAFKA-10602:
--
Description:
The Elasticsearch connector uses separate threads to report errant records
using
[
https://issues.apache.org/jira/browse/KAFKA-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lev Zemlyanov updated KAFKA-10602:
--
Description:
If a connector uses separate threads to report errant records using the
ErrantRe
big-andy-coates commented on pull request #9415:
URL: https://github.com/apache/kafka/pull/9415#issuecomment-707352917
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pl
guozhangwang opened a new pull request #9416:
URL: https://github.com/apache/kafka/pull/9416
When a coordinator module is being elected / resigned, our log entry is
usually associated with a background scheduler on loading / unloading entries
and hence it is unclear at the exact time when
guozhangwang commented on pull request #9416:
URL: https://github.com/apache/kafka/pull/9416#issuecomment-707375065
cc @abbccdda @cadonna for reviews.
This is an automated message from the Apache Git Service.
To respond to th
splett2 opened a new pull request #9417:
URL: https://github.com/apache/kafka/pull/9417
### What
`ClientQuotaManager.updateQuota` updates `quotaCallback` before updating
metric configs.
`ClientQuotaManager.quota()` performs an unlocked call to `quotaLimit()`, so
we can run into a cas
guozhangwang commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503567593
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -193,8 +193,9 @@ private void updateFollowerHighWatermark(
) {
guozhangwang commented on a change in pull request #9396:
URL: https://github.com/apache/kafka/pull/9396#discussion_r503574736
##
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java
##
@@ -0,0 +1,494 @@
+/*
+ * Licensed
hachikuji opened a new pull request #9418:
URL: https://github.com/apache/kafka/pull/9418
The main purpose of this patch is to add `quorum.linger.ms` behavior to the
raft implementation. This gives users a powerful knob to tune the impact of
fsync. When an append is accepted from the stat
hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503578114
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -193,8 +193,9 @@ private void updateFollowerHighWatermark(
) {
hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503578710
##
File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java
##
@@ -103,6 +103,16 @@
*/
void updateHighWatermark(LogOffsetMetadata
hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503578816
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -985,6 +986,8 @@ private boolean handleFetchResponse(
R
hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503578710
##
File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java
##
@@ -103,6 +103,16 @@
*/
void updateHighWatermark(LogOffsetMetadata
guozhangwang commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503585228
##
File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedLog.java
##
@@ -103,6 +103,16 @@
*/
void updateHighWatermark(LogOffsetMetad
[
https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212729#comment-17212729
]
Ismael Juma commented on KAFKA-9915:
[~dajac] should this KIP be in the release plan?
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r503568832
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -931,6 +1033,62 @@ public synchronized boolean close(final long timeo
junrao commented on a change in pull request #9353:
URL: https://github.com/apache/kafka/pull/9353#discussion_r503597917
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1907,6 +1915,20 @@ class KafkaController(val config: KafkaConfig,
}
AndreyBozhko commented on pull request #9413:
URL: https://github.com/apache/kafka/pull/9413#issuecomment-707409947
Checks fail due to unrelated
`kafka.server.DynamicBrokerConfigTest#testPasswordConfigEncoderSecretChange`
test.
hachikuji commented on a change in pull request #9352:
URL: https://github.com/apache/kafka/pull/9352#discussion_r503605087
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -985,6 +986,8 @@ private boolean handleFetchResponse(
R
mjsax commented on pull request #9415:
URL: https://github.com/apache/kafka/pull/9415#issuecomment-707425889
Thanks for the PR @big-andy-coates! -- The PR should be against `trunk`
though -- I could not just update the base branch (would pull is other
commits). Can you update the PR and op
xvrl commented on a change in pull request #9367:
URL: https://github.com/apache/kafka/pull/9367#discussion_r503621422
##
File path: clients/src/main/java/org/apache/kafka/common/utils/ConfigUtils.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
huxihx merged pull request #9218:
URL: https://github.com/apache/kafka/pull/9218
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-707439275
@ijuma Thanks for the review, merging to trunk.
This is an automated message from the Apache Git Service.
To respon
[
https://issues.apache.org/jira/browse/KAFKA-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10603:
-
Summary: Re-design KStream.process() and K*.transform*() operations (was:
Re-design )
> Re-des
John Roesler created KAFKA-10603:
Summary: Re-design
Key: KAFKA-10603
URL: https://issues.apache.org/jira/browse/KAFKA-10603
Project: Kafka
Issue Type: New Feature
Reporter: John
[
https://issues.apache.org/jira/browse/KAFKA-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10603:
-
Description:
After the implementation of KIP-478, we have the ability to reconsider all
these A
[
https://issues.apache.org/jira/browse/KAFKA-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10603:
-
Labels: needs-kip (was: )
> Re-design KStream.process() and K*.transform*() operations
> --
[
https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212807#comment-17212807
]
John Roesler commented on KAFKA-10536:
--
Decided to make this future work instead:
[
https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10536.
--
Resolution: Fixed
> KIP-478: Implement KStream changes
> --
>
splett2 commented on a change in pull request #9386:
URL: https://github.com/apache/kafka/pull/9386#discussion_r503664955
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1371,6 +1492,45 @@ class ConnectionQuotas(config: KafkaConfig, time: Time,
metric
dongjinleekr commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-707498871
Hi @vvcephei,
1. Sure. I added some validations in `StateDirectoryTest`.
- If `StateDirectory#clean` is called, the empty `appDir` is also deleted.
(see `State
[
https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212849#comment-17212849
]
Ilia Pasynkov commented on KAFKA-8318:
--
[~mjsax], thank you for your help!
> Sessio
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-707526684
Hello @mimaison @ryannedolan this PR does not contain any functional change,
it should be straightforward to review. Thanks for your time.
--
[
https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10343:
Description: We need to add ApiVersion constraints test based on IBP to
remind future developer bu
[
https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen reassigned KAFKA-10343:
---
Assignee: Boyang Chen
> Remove 2.7 IBP for redirection enablement
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Boyang Chen updated KAFKA-10343:
Summary: Add IBP based ApiVersion constraint tests (was: Remove 2.7 IBP
for redirection enablemen
[
https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-9915:
---
Component/s: core
> Throttle Create Topic, Create Partition and Delete Topic Operations
> ---
[
https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212874#comment-17212874
]
David Jacot commented on KAFKA-9915:
[~ijuma] Are you referring to [this
one|https:/
[
https://issues.apache.org/jira/browse/KAFKA-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-9915:
---
Fix Version/s: 2.7.0
> Throttle Create Topic, Create Partition and Delete Topic Operations
>
abbccdda opened a new pull request #9419:
URL: https://github.com/apache/kafka/pull/9419
Per requirement from KIP-590, we need to add IBP as part of the
ApiVersionResponse consideration. All redirected RPCs need to take IBP into
consideration when getting a future bump. This PR ensures to
80 matches
Mail list logo
