[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500806583 ## File path: config/tools-log4j2.properties ## @@ -12,10 +12,14 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500807752 ## File path: config/log4j2.properties ## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500821253 ## File path: config/connect-log4j2.properties ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [kafka] ankit-kumar-25 commented on pull request #9326: KAFKA-10460: ReplicaListValidator format checking is incomplete

ankit-kumar-25 commented on pull request #9326: URL: https://github.com/apache/kafka/pull/9326#issuecomment-704776962 @viktorsomogyi, the tests are passing after the last commit. Can you please review it? This is an automate

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500829824 ## File path: config/connect-log4j2.properties ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500830940 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java ## @@ -60,67 +66,62 @@ @GET

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-704786154 The latest test failures do not seem related to this PR: * JDK 8: `org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector` * JDK 11: `org.a

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-704786154 The latest test failures do not seem related to this PR: * JDK 8: `org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector` * JDK 11:

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500838684 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java ## @@ -63,7 +63,7 @@ import static org.junit.As

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500840081 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java ## @@ -60,67 +66,62 @@ @GET

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500849730 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -556,7 +557,7 @@ class ControllerIntegrationTest extends

[jira] [Commented] (KAFKA-9628) Replace Produce request/response with automated protocol

[ https://issues.apache.org/jira/browse/KAFKA-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209407#comment-17209407 ] Chia-Ping Tsai commented on KAFKA-9628: --- [~mimaison] Are you working on this issue?

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-704786154 The test failures in the latest CI runs do not seem related to this PR: * JDK 8: `org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector`

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500870442 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java ## @@ -81,7 +81,6 @@ public void setUp() { props.put(Strea

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500882458 ## File path: core/src/test/scala/unit/kafka/utils/LogCaptureContext.scala ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-9296) Correlation id for response () does not match request ()

[ https://issues.apache.org/jira/browse/KAFKA-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209432#comment-17209432 ] nandini commented on KAFKA-9296: https://issues.apache.org/jira/browse/KAFKA-4669 - This

[GitHub] [kafka] jeqo commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

jeqo commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r500889276 ## File path: streams/src/test/java/org/apache/kafka/test/ReadOnlySessionStoreStub.java ## @@ -82,11 +118,15 @@ public boolean hasNext() { pu

[GitHub] [kafka] voffcheg109 commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

voffcheg109 commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-704845072 @ableegoldman, I've made changes following you suggestions, but I got some strange errors, which don't reproduce locally. I think would be enough to retrigger builds. Is there

[jira] [Commented] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209466#comment-17209466 ] Vaibhav Jaimini commented on KAFKA-9981: [~qq619618919] I also faced the same iss

[jira] [Commented] (KAFKA-4759) Add support for subnet masks in SimpleACLAuthorizer

[ https://issues.apache.org/jira/browse/KAFKA-4759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209471#comment-17209471 ] Rafa G. commented on KAFKA-4759: [~takebayashi] I've opened a new PR in GitHub but build

[GitHub] [kafka] rgo commented on pull request #9387: KAFKA-4759: Acl authorizer subnet support

rgo commented on pull request #9387: URL: https://github.com/apache/kafka/pull/9387#issuecomment-704867384 Hi @takebayashi, could you review this? Thanks! :) This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] cadonna commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

cadonna commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r500832713 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9378: MINOR: ACLs for secured cluster system tests

rajinisivaram commented on a change in pull request #9378: URL: https://github.com/apache/kafka/pull/9378#discussion_r500981702 ## File path: tests/kafkatest/services/security/kafka_acls.py ## @@ -93,11 +97,13 @@ def add_cluster_acl(self, kafka, principal, force_use_zk_connect

[jira] [Created] (KAFKA-10581) Ability to filter events at Kafka broker based on Kafka header value

Bhukailas Reddy created KAFKA-10581: --- Summary: Ability to filter events at Kafka broker based on Kafka header value Key: KAFKA-10581 URL: https://issues.apache.org/jira/browse/KAFKA-10581 Project: K

[GitHub] [kafka] nizhikov commented on pull request #9196: KAFKA-10402: Upgrade system tests to python3

nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-704951233 Hello @guozhangwang , @mimaison This PR ready to be merged. Can you, please, do it? This is an aut

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209558#comment-17209558 ] Paweł Wilczyński commented on KAFKA-9747: - [https://rmoff.net/2019/11/22/common-m

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r501043518 ## File path: core/src/test/scala/unit/kafka/utils/LogCaptureContext.scala ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r500882458 ## File path: core/src/test/scala/unit/kafka/utils/LogCaptureContext.scala ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r501046635 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -2063,10 +2063,21 @@ class PlaintextAdminIntegration

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r501048158 ## File path: core/src/main/scala/kafka/utils/Log4jController.scala ## @@ -20,62 +20,73 @@ package kafka.utils import java.util import java.util.Loca

[GitHub] [kafka] ijuma commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

ijuma commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-704966543 @tombentley Thanks for the explanation. I have reverted this change for now: https://github.com/apache/kafka/commit/75e53585255a0c2737dee84ddbad39094c5e8500 ---

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r501054972 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java ## @@ -133,20 +134,18 @@ public Respo

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-704971958 Thanks for the update @ijuma, I'll prepare a KIP for 3.0. This is an automated message from the Apache Git Serv

[GitHub] [kafka] dongjinleekr commented on a change in pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on a change in pull request #7898: URL: https://github.com/apache/kafka/pull/7898#discussion_r501060061 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java ## @@ -60,67 +66,62 @@ @GET

[GitHub] [kafka] dongjinleekr commented on pull request #8130: MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc.

dongjinleekr commented on pull request #8130: URL: https://github.com/apache/kafka/pull/8130#issuecomment-705037008 @mjsax The failing test is now fixed with commit 9f7a73f and mistakenly removed method is reverted in commit 6972309. Also, rebased onto the latest trunk. @guozhangwang Th

[jira] [Commented] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209647#comment-17209647 ] Sagar Rao commented on KAFKA-10559: --- [~ableegoldman], i looked at the code today.. I s

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

wcarlson5 commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r501124504 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] hachikuji merged pull request #9376: MINOR: Remove `TargetVoters` from `DescribeQuorum`

hachikuji merged pull request #9376: URL: https://github.com/apache/kafka/pull/9376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji merged pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

hachikuji merged pull request #9280: URL: https://github.com/apache/kafka/pull/9280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10186. - Fix Version/s: 2.7.0 Resolution: Fixed > Aborting transaction with pending data s

[GitHub] [kafka] guozhangwang commented on pull request #9196: KAFKA-10402: Upgrade system tests to python3

guozhangwang commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-705058498 Merged to trunk, kudos to @nizhikov for the contribution! This is an automated message from the Apache Git Se

[GitHub] [kafka] guozhangwang merged pull request #9196: KAFKA-10402: Upgrade system tests to python3

guozhangwang merged pull request #9196: URL: https://github.com/apache/kafka/pull/9196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

hachikuji commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r501158001 ## File path: clients/src/main/java/org/apache/kafka/common/errors/TransactionTimeOutException.java ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] rondagostino commented on pull request #9378: MINOR: ACLs for secured cluster system tests

rondagostino commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-705060101 @rajinisivaram Thanks for the insightful feedback -- I think the latest commit does much at address the clarity/refactoring issue as well as make the extra ACLs optional such

[GitHub] [kafka] hachikuji commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

hachikuji commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r501168361 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2336,6 +2335,11 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] junrao commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

junrao commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705068372 @kowshik : There are 27 system test failures with this PR. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-10-07--001.1602079476--kowshik--

[GitHub] [kafka] hachikuji commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

hachikuji commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r501170471 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2083,8 +2083,8 @@ class KafkaApis(val requestChannel: RequestChannel, def sen

[GitHub] [kafka] abbccdda commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

abbccdda commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r501155923 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1198,18 +1209,23 @@ boolean canBumpEpoch()

[jira] [Commented] (KAFKA-10122) Consumer should allow heartbeat during rebalance as well

[ https://issues.apache.org/jira/browse/KAFKA-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209685#comment-17209685 ] Guozhang Wang commented on KAFKA-10122: --- This ticket is resolved as a result of KA

[jira] [Resolved] (KAFKA-10122) Consumer should allow heartbeat during rebalance as well

[ https://issues.apache.org/jira/browse/KAFKA-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10122. --- Fix Version/s: 2.6.1 2.7.0 Resolution: Fixed > Consumer should all

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059 @junrao Thanks for the links! I had a look at the links. I found 27 test failures in both links. I compared the individual test failures and found that they have all failed on the

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059 @junrao Thanks for the links! I had a look at the links. I found 27 test failures in both links. I compared the individual test failures and found that they have all failed

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059 @junrao Thanks for the links! I had a look at the links. I found similar stats in both links, with exactly 27 test failures in both links. I compared the individual test fa

[GitHub] [kafka] junrao commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

junrao commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-705079102 @kowshik : Thanks for following up. I will merged this PR as it is since the system test failures are not new. Also, in Scala, we prefer sealed traits over Enumeration since

[GitHub] [kafka] ableegoldman commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

ableegoldman commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705081376 Don't worry about the build, looks like only some unrelated known flaky tests in `kafka.api` caused it to fail.

[GitHub] [kafka] junrao merged pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

junrao merged pull request #9001: URL: https://github.com/apache/kafka/pull/9001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-10028) Implement write path for feature versioning scheme

[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10028. - Fix Version/s: 2.7.0 Resolution: Fixed merged the PR to trunk > Implement write path for feature

[GitHub] [kafka] ableegoldman commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

ableegoldman commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705083522 Ping @mjsax for merging responsibility. Can you cherrypick it back to 2.6 as well? This is an automated mess

[jira] [Updated] (KAFKA-10338) Support PEM format for SSL certificates and private key

[ https://issues.apache.org/jira/browse/KAFKA-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-10338: --- Description: We currently support only file-based JKS/PKCS12 format for SSL key stores and

[jira] [Created] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

Robert Martin created KAFKA-10582: - Summary: Mirror Maker 2 not replicating new topics until restart Key: KAFKA-10582 URL: https://issues.apache.org/jira/browse/KAFKA-10582 Project: Kafka Iss

[GitHub] [kafka] voffcheg109 opened a new pull request #9389: KAFKA-7334: Suggest changing config for state.dir in case of FileNotFoundException

voffcheg109 opened a new pull request #9389: URL: https://github.com/apache/kafka/pull/9389 When state.dir is left at default configuration, there is a chance that certain files under the state directory are cleaned by OS since the default dir starts with /tmp/kafka-streams. I've ad

[jira] [Updated] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Martin updated KAFKA-10582: -- Description: We are using Mirror Maker 2 from the 2.5.1 release for replication on some clust

[jira] [Updated] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Martin updated KAFKA-10582: -- Description: We are using Mirror Maker 2 from the 2.5.1 release for replication on some clust

[GitHub] [kafka] voffcheg109 commented on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

voffcheg109 commented on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705089696 @mjsax, can you merge this pr? @ableegoldman, I've also created pr for 2.6 - https://github.com/apache/kafka/pull/9389 ---

[GitHub] [kafka] thake commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-705090582 @vvcephei This PR should fix the NPE mentioned in KAFKA-10515. Somehow there are some failing tests that are totally unrelated. Can someone review this PR?

[GitHub] [kafka] voffcheg109 removed a comment on pull request #9380: KAFKA-7334: Suggest changing config for state.dir in case of FileNotF…

voffcheg109 removed a comment on pull request #9380: URL: https://github.com/apache/kafka/pull/9380#issuecomment-705089696 @mjsax, can you merge this pr? @ableegoldman, I've also created pr for 2.6 - https://github.com/apache/kafka/pull/9389 ---

[GitHub] [kafka] voffcheg109 closed pull request #9389: KAFKA-7334: Suggest changing config for state.dir in case of FileNotFoundException

voffcheg109 closed pull request #9389: URL: https://github.com/apache/kafka/pull/9389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9382: KAFKA-10554; Perform follower truncation based on diverging epochs in Fetch response

rajinisivaram commented on a change in pull request #9382: URL: https://github.com/apache/kafka/pull/9382#discussion_r501199512 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -432,14 +455,22 @@ abstract class AbstractFetcherThread(name: String,

[jira] [Assigned] (KAFKA-9497) Brokers start up even if SASL provider is not loaded and throw NPE when clients connect

[ https://issues.apache.org/jira/browse/KAFKA-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram reassigned KAFKA-9497: - Assignee: Ron Dagostino (was: Rajini Sivaram) > Brokers start up even if SASL provider

[jira] [Resolved] (KAFKA-9497) Brokers start up even if SASL provider is not loaded and throw NPE when clients connect

[ https://issues.apache.org/jira/browse/KAFKA-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-9497. --- Resolution: Duplicate > Brokers start up even if SASL provider is not loaded and throw NPE wh

[jira] [Assigned] (KAFKA-10520) InitProducerId may be blocked if least loaded node is not ready to send

[ https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram reassigned KAFKA-10520: -- Assignee: Rajini Sivaram > InitProducerId may be blocked if least loaded node is not

[jira] [Commented] (KAFKA-10520) InitProducerId may be blocked if least loaded node is not ready to send

[ https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209737#comment-17209737 ] Rajini Sivaram commented on KAFKA-10520: [~ableegoldman] Yes, will try and get t

[GitHub] [kafka] hachikuji commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

hachikuji commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r501204644 ## File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala ## @@ -555,11 +555,11 @@ class TransactionsTest extends KafkaServerTestHarn

[GitHub] [kafka] guozhangwang commented on pull request #9247: KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted

guozhangwang commented on pull request #9247: URL: https://github.com/apache/kafka/pull/9247#issuecomment-705111866 Merged to trunk, thanks @DOJI45 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #9247: KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted

guozhangwang merged pull request #9247: URL: https://github.com/apache/kafka/pull/9247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10362. --- Fix Version/s: 2.7.0 Resolution: Fixed > When resuming Streams active task with EOS,

[GitHub] [kafka] lct45 commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

lct45 commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501225751 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -212,6 +213,7 @@ public void configure(f

[GitHub] [kafka] mjsax merged pull request #9385: KAFKA-9274: fix incorrect default value for `task.timeout.ms` config

mjsax merged pull request #9385: URL: https://github.com/apache/kafka/pull/9385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mcdonagj commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

mcdonagj commented on pull request #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-705153525 @cmccabe, is there any update on the status of this issue? This is an automated message from the Apache Git Servi

[jira] [Resolved] (KAFKA-9930) Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

[ https://issues.apache.org/jira/browse/KAFKA-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adem Efe Gencer resolved KAFKA-9930. Resolution: Fixed > Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionExcep

[jira] [Created] (KAFKA-10583) Thread-safety of AdminClient is not documented

Adem Efe Gencer created KAFKA-10583: --- Summary: Thread-safety of AdminClient is not documented Key: KAFKA-10583 URL: https://issues.apache.org/jira/browse/KAFKA-10583 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-10584) IndexSearchType should use sealed trait instead of Enumeration

Jun Rao created KAFKA-10584: --- Summary: IndexSearchType should use sealed trait instead of Enumeration Key: KAFKA-10584 URL: https://issues.apache.org/jira/browse/KAFKA-10584 Project: Kafka Issue T

[GitHub] [kafka] mjsax commented on a change in pull request #9368: KAFKA-9274: Add timeout handling for state restore and StandbyTasks

mjsax commented on a change in pull request #9368: URL: https://github.com/apache/kafka/pull/9368#discussion_r501306055 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -148,7 +148,7 @@ public void update(final Set topic

[GitHub] [kafka] mjsax commented on a change in pull request #9368: KAFKA-9274: Add timeout handling for state restore and StandbyTasks

mjsax commented on a change in pull request #9368: URL: https://github.com/apache/kafka/pull/9368#discussion_r501307743 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -625,11 +670,16 @@ private void restoreChang

[GitHub] [kafka] rondagostino commented on pull request #9378: MINOR: ACLs for secured cluster system tests

rondagostino commented on pull request #9378: URL: https://github.com/apache/kafka/pull/9378#issuecomment-705196327 @rajinisivaram I ran some tests locally and found some issues, which I fixed with an additional commit. I'll kick off a system test run -- I think we should run everything j

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501322300 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r501326680 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static fina

[GitHub] [kafka] lct45 commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

lct45 commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r501329620 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -212,6 +213,7 @@ public void configure(f

[GitHub] [kafka] jeqo commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

jeqo commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r501334888 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java ## @@ -270,25 +335,32 @@ public void close() {

[GitHub] [kafka] jeqo commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

jeqo commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r501336253 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java ## @@ -359,7 +431,11 @@ private void getNextSegmentItera

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r50133 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -212,6 +213,7 @@ public void conf

[GitHub] [kafka] xvrl commented on pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

xvrl commented on pull request #9366: URL: https://github.com/apache/kafka/pull/9366#issuecomment-705225637 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

ableegoldman commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r501346943 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java ## @@ -359,7 +431,11 @@ private void getNextSegm

[GitHub] [kafka] guozhangwang commented on a change in pull request #9388: KAFKA-10562: Properly invoke new StateStoreContext init

guozhangwang commented on a change in pull request #9388: URL: https://github.com/apache/kafka/pull/9388#discussion_r501347228 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -83,14 +85,40 @@ this.valueSerde

[GitHub] [kafka] guozhangwang merged pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

guozhangwang merged pull request #9373: URL: https://github.com/apache/kafka/pull/9373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

guozhangwang commented on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-705233561 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] mikebin commented on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

mikebin commented on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-705235323 Thank you all! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

ableegoldman commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705240588 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] ableegoldman commented on pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

ableegoldman commented on pull request #9139: URL: https://github.com/apache/kafka/pull/9139#issuecomment-705241380 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209929#comment-17209929 ] Sophie Blee-Goldman commented on KAFKA-10559: - Exactly, just rethrow the Tim

  1   2   >