rondagostino commented on a change in pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#discussion_r499595845
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4160,15 +4231,18 @@ void handleFailure(Throwable throw
Fleshgrinder commented on a change in pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#discussion_r499643570
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4160,15 +4231,18 @@ void handleFailure(Throwable throw
rondagostino commented on a change in pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#discussion_r499647441
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4160,15 +4231,18 @@ void handleFailure(Throwable throw
bbejeck commented on pull request #9099:
URL: https://github.com/apache/kafka/pull/9099#issuecomment-703675565
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
bbejeck commented on pull request #9099:
URL: https://github.com/apache/kafka/pull/9099#issuecomment-703675276
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
Fleshgrinder commented on a change in pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#discussion_r499643570
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4160,15 +4231,18 @@ void handleFailure(Throwable throw
Fleshgrinder commented on a change in pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#discussion_r499654983
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4160,15 +4231,18 @@ void handleFailure(Throwable throw
bbejeck commented on a change in pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#discussion_r499670799
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,10 +633,20 @@ public final void ad
vvcephei commented on pull request #9369:
URL: https://github.com/apache/kafka/pull/9369#issuecomment-703701703
Thanks for the PR @Fleshgrinder ,
The code change looks good to me. Should we have some tests for this?
Thanks!
-John
---
Fleshgrinder commented on pull request #9369:
URL: https://github.com/apache/kafka/pull/9369#issuecomment-703703414
> The code change looks good to me. Should we have some tests for this?
Always I'd say. 😊
This is an
Fleshgrinder opened a new pull request #9374:
URL: https://github.com/apache/kafka/pull/9374
This bug was detected as part of #9370 and @rondagostino and I decided that
this should be fixed right away and not until the other PR eventually gets
merged (or not). I am not only properly handli
Fleshgrinder commented on a change in pull request #9374:
URL: https://github.com/apache/kafka/pull/9374#discussion_r499687848
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4166,10 +4167,22 @@ public DescribeUserScramCredential
lkokhreidze commented on a change in pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#discussion_r499691112
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,10 +633,20 @@ public final voi
lkokhreidze commented on a change in pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#discussion_r499692083
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,10 +633,20 @@ public final voi
RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r499715151
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -244,7 +244,8 @@ class Log(@volatile private var _dir: File,
val producerIdExpirat
Chris Egerton created KAFKA-10574:
-
Summary: Infinite loop in SimpleHeaderConverter and Values classes
Key: KAFKA-10574
URL: https://issues.apache.org/jira/browse/KAFKA-10574
Project: Kafka
I
[
https://issues.apache.org/jira/browse/KAFKA-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208163#comment-17208163
]
Chris Egerton edited comment on KAFKA-10574 at 10/5/20, 4:18 PM:
-
RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r499718784
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -4447,9 +4504,10 @@ class LogTest {
private def recoverAndCheck(config: LogConf
[
https://issues.apache.org/jira/browse/KAFKA-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208163#comment-17208163
]
Chris Egerton commented on KAFKA-10574:
---
This can be reproduced by adding the foll
RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r499724455
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -2882,11 +2953,8 @@ class LogTest {
records.foreach(segment.append _)
segm
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499729181
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apac
RamanVerma commented on a change in pull request #9364:
URL: https://github.com/apache/kafka/pull/9364#discussion_r499731061
##
File path: core/src/test/scala/unit/kafka/log/LogTest.scala
##
@@ -3073,9 +3139,8 @@ class LogTest {
// check if recovery was attempted. Even if
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499732219
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsRebalanceListener.java
##
@@ -54,6 +54,8 @@ public void onPartiti
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499735461
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -616,7 +616,7 @@ public void
shouldThrowExceptionSettingUncaught
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499737675
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -529,8 +541,7 @@ public void run() {
C0urante opened a new pull request #9375:
URL: https://github.com/apache/kafka/pull/9375
[Jira](https://issues.apache.org/jira/browse/KAFKA-10574)
The special byte sequence `0xEF, 0xBF, 0xBF`, when parsed as a UTF-8 string,
causes the `StringCharacterIterator` to return `CharacterIte
C0urante commented on pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#issuecomment-703756981
@rhauch @kkonstantine can one of you take a look?
This is an automated message from the Apache Git Service.
To re
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499739384
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -436,6 +496,8 @@ private void maybeSetError() {
}
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499739935
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -550,6 +561,10 @@ void runLoop() {
// u
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499740251
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final
Thre
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499741079
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##
@@ -82,11 +83,21 @@ public Subscript
lkokhreidze commented on a change in pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#discussion_r485886423
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java
##
@@ -0,0 +1,242 @@
+
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208194#comment-17208194
]
Sagar Rao commented on KAFKA-10559:
---
hey [~ableegoldman], I can pick this one if neede
[
https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-7334:
---
Labels: newbie (was: )
> Suggest changing config for state.dir in case of FileNotFou
kkonstantine commented on a change in pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#discussion_r499750739
##
File path:
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java
##
@@ -73,6 +76,15 @@
INT_LIST.add(-987654321);
}
C0urante commented on a change in pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#discussion_r499754411
##
File path:
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java
##
@@ -73,6 +76,15 @@
INT_LIST.add(-987654321);
}
+
C0urante commented on a change in pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#discussion_r499754411
##
File path:
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java
##
@@ -73,6 +76,15 @@
INT_LIST.add(-987654321);
}
+
C0urante commented on pull request #9375:
URL: https://github.com/apache/kafka/pull/9375#issuecomment-703775022
Thanks @kkonstantine, I've added a comment and addressed the Checkstyle
issues.
This is an automated message fro
[
https://issues.apache.org/jira/browse/KAFKA-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10436:
-
Component/s: streams
> Implement KIP-478 Topology changes
> --
>
[
https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10437:
-
Component/s: streams-test-utils
> KIP-478: Implement test-utils changes
> --
[
https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10437:
-
Component/s: (was: streams-test-utils)
> KIP-478: Implement test-utils changes
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10437:
-
Component/s: streams
> KIP-478: Implement test-utils changes
> -
[
https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10535:
-
Component/s: streams
> KIP-478: Implement StateStoreContext and Record
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10535:
-
Fix Version/s: 2.7.0
> KIP-478: Implement StateStoreContext and Record
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10536:
-
Component/s: streams
> KIP-478: Implement KStream changes
> --
>
[
https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10535.
--
Resolution: Fixed
> KIP-478: Implement StateStoreContext and Record
>
[
https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10536:
-
Fix Version/s: 2.7.0
> KIP-478: Implement KStream changes
> --
>
[
https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10437:
-
Fix Version/s: 2.7.0
> KIP-478: Implement test-utils changes
> -
[
https://issues.apache.org/jira/browse/KAFKA-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10537:
-
Component/s: streams
> Convert KStreamImpl filters to new PAPI
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10542:
-
Component/s: streams
> Convert KTable maps to new PAPI
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10543:
-
Component/s: streams
> Convert KTable joins to new PAPI
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10541:
-
Component/s: streams
> Convert KTable filters to new PAPI
> --
>
[
https://issues.apache.org/jira/browse/KAFKA-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10540:
-
Component/s: streams
> Convert KStream aggregations to new PAPI
> --
[
https://issues.apache.org/jira/browse/KAFKA-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10539:
-
Component/s: streams
> Convert KStreamImpl joins to new PAPI
> -
[
https://issues.apache.org/jira/browse/KAFKA-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10538:
-
Component/s: streams
> Convert KStreamImpl maps to new PAPI
> --
[
https://issues.apache.org/jira/browse/KAFKA-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10544:
-
Component/s: streams
> Convert KTable aggregations to new PAPI
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10546:
-
Component/s: streams
> KIP-478: Deprecate old PAPI
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10562:
-
Component/s: streams
> Delegate the store wrappers to the new init method
>
[
https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10562:
-
Summary: KIP-478: Delegate the store wrappers to the new init method (was:
Delegate the store w
[
https://issues.apache.org/jira/browse/KAFKA-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-10530.
--
Resolution: Duplicate
Closing now, since this seems like a duplicate report, and visual code
[
https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208231#comment-17208231
]
Sophie Blee-Goldman commented on KAFKA-10555:
-
Just to clarify, I do agree w
[
https://issues.apache.org/jira/browse/KAFKA-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-9585.
--
Resolution: Cannot Reproduce
> Flaky Test:
> LagFetchIntegrationTest#shouldFetchLagsDuringReba
junrao commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499753420
##
File path: core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala
##
@@ -185,7 +185,7 @@ class BrokerEndPointTest {
"endpoints":["CLIENT:/
bbejeck commented on pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#issuecomment-703803731
@lkokhreidze, thanks for the quick update. I'll make another pass soon.
This is an automated message from the Apac
soondenana commented on pull request #9347:
URL: https://github.com/apache/kafka/pull/9347#issuecomment-703805880
There was an error when building `streams.examples`:
```
[2020-10-05T08:40:05.722Z] [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-archetype-plugin:3.2.
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208257#comment-17208257
]
Sophie Blee-Goldman commented on KAFKA-10559:
-
[~sagarrao] Yeah, go ahead! T
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman reassigned KAFKA-10559:
---
Assignee: Sagar Rao
> Don't shutdown the entire app upon TimeoutException d
piotrrzysko commented on pull request #9371:
URL: https://github.com/apache/kafka/pull/9371#issuecomment-703823226
Hi @stanislavkozlovski, would you mind taking a look at this PR?
This is an automated message from the Apache
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499810462
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -272,6 +281,161 @@ class KafkaController(val config: KafkaConfig,
}
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499811265
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -272,6 +281,161 @@ class KafkaController(val config: KafkaConfig,
}
}
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499811752
##
File path: core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala
##
@@ -185,7 +185,7 @@ class BrokerEndPointTest {
"endpoints":["CLIENT:
rhauch merged pull request #9347:
URL: https://github.com/apache/kafka/pull/9347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499812076
##
File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala
##
@@ -0,0 +1,580 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499816373
##
File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala
##
@@ -0,0 +1,580 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499816619
##
File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala
##
@@ -0,0 +1,580 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dima5rr commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-703838454
Hi @guozhangwang can you trigger new build, looks like flaky tests?
This is an automated message from the Apache G
[
https://issues.apache.org/jira/browse/KAFKA-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch updated KAFKA-10531:
--
Fix Version/s: 2.5.2
2.7.0
> KafkaBasedLog can sleep for negative values
>
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499836489
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final
Threa
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499838819
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apach
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499842547
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -436,6 +496,8 @@ private void maybeSetError() {
}
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499842547
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -436,6 +496,8 @@ private void maybeSetError() {
}
vvcephei commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499843780
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -616,7 +616,7 @@ public void
shouldThrowExceptionSettingUncaughtE
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r499847021
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
##
@@ -715,7 +747,58 @@ class ControllerIntegrationTest extends
Zo
vvcephei commented on pull request #9323:
URL: https://github.com/apache/kafka/pull/9323#issuecomment-703867815
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei commented on pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#issuecomment-703867931
Cherry-picked to 2.6
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei commented on pull request #8353:
URL: https://github.com/apache/kafka/pull/8353#issuecomment-703869908
cherry-picked to 2.5
This is an automated message from the Apache Git Service.
To respond to the message, please
kowshik commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-703873486
@junrao Thanks for the review! I've addressed the latest comments in
e55358fd1a00f12ef98fc4d2d649a297ddf146da .
T
kowshik edited a comment on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-703873486
@junrao Thanks for the review! I've addressed the latest comments in
e55358fd1a00f12ef98fc4d2d649a297ddf146da . The PR is ready for another pass.
-
vvcephei commented on pull request #8353:
URL: https://github.com/apache/kafka/pull/8353#issuecomment-703874939
Cherry-picked to 2.4 and 2.3
This is an automated message from the Apache Git Service.
To respond to the message,
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499868891
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apac
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499871031
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -436,6 +496,8 @@ private void maybeSetError() {
}
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r499871426
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final
Thre
hachikuji opened a new pull request #9376:
URL: https://github.com/apache/kafka/pull/9376
This field is leftover from the early days of the KIP when it covered
reassignment. Since the API is not exposed yet, should be no harm updating the
first version.
### Committer Checklist (excl
[
https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208316#comment-17208316
]
Sophie Blee-Goldman commented on KAFKA-5998:
[~sandeep.lakdaw...@gmail.com] a
hachikuji merged pull request #9349:
URL: https://github.com/apache/kafka/pull/9349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji opened a new pull request #9377:
URL: https://github.com/apache/kafka/pull/9377
To avoid confusion since is only used by `TestRaftServer`, this PR moves
`RaftRequestHandler` to the `tools` package.
### Committer Checklist (excluded from commit message)
- [ ] Verify desig
[
https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208344#comment-17208344
]
Kyle Leiby commented on KAFKA-7421:
---
Hi all, we've been encountering a similar deadlock
guozhangwang commented on pull request #9377:
URL: https://github.com/apache/kafka/pull/9377#issuecomment-703906935
LGTM!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
guozhangwang merged pull request #9342:
URL: https://github.com/apache/kafka/pull/9342
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bbejeck commented on a change in pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#discussion_r499908753
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java
##
@@ -0,0 +1,256 @@
+/*
+
1 - 100 of 131 matches
Mail list logo
