[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201977#comment-17201977 ] David Jacot commented on KAFKA-8266: [~chia7712] I will take a look at this. I wonder

[jira] [Assigned] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-8266: -- Assignee: David Jacot > Improve > `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisr

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201980#comment-17201980 ] Chia-Ping Tsai commented on KAFKA-8266: --- {quote} I will take a look at this. I wond

[GitHub] [kafka] dajac commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494810769 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -844,4 +851,72 @@ class TopicCommandWithAdminClientTest extend

[GitHub] [kafka] dajac commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494815168 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -69,16 +71,26 @@ object TopicCommand extends Logging { else if (opts.hasDeleteOp

[GitHub] [kafka] dajac commented on pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on pull request #9334: URL: https://github.com/apache/kafka/pull/9334#issuecomment-698784923 @rajinisivaram Thanks for your comments. I have updated the PR and answered your questions. This is an automated me

[jira] [Commented] (KAFKA-10523) Allow to provide producer ID

2020-09-25 Thread Luigi Berrettini (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201992#comment-17201992 ] Luigi Berrettini commented on KAFKA-10523: -- I saw that an ID can be provided fo

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
rajinisivaram commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494837556 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -69,16 +71,26 @@ object TopicCommand extends Logging { else if (opts.has

[GitHub] [kafka] dajac commented on pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-25 Thread GitBox
dajac commented on pull request #8897: URL: https://github.com/apache/kafka/pull/8897#issuecomment-698811607 @hachikuji Thanks for your suggestions. I have incorporated them. This is an automated message from the Apache Git S

[GitHub] [kafka] dajac commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494856451 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -69,16 +71,26 @@ object TopicCommand extends Logging { else if (opts.hasDeleteOp

[jira] [Commented] (KAFKA-10425) Documentation switches to a random page on clicking the left navigation bar hide/expand button

2020-09-25 Thread Shadi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202022#comment-17202022 ] Shadi commented on KAFKA-10425: --- [~sanjayyr] Hi, I can't reproduce this. What browser are

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-25 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-698835897 @ijuma any chance you could trigger a CI build? Thanks! This is an automated message from the Apache Git Servic

[GitHub] [kafka] fredsh2k commented on pull request #9335: Update quickstart.html

2020-09-25 Thread GitBox
fredsh2k commented on pull request #9335: URL: https://github.com/apache/kafka/pull/9335#issuecomment-698870391 kafka_2.12-2.4.0 ok, thanks for the help :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] fredsh2k closed pull request #9335: Update quickstart.html

2020-09-25 Thread GitBox
fredsh2k closed pull request #9335: URL: https://github.com/apache/kafka/pull/9335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

2020-09-25 Thread Ilia Pasynkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilia Pasynkov reassigned KAFKA-8318: Assignee: Ilia Pasynkov > Session Window Aggregations generate an extra tombstone > --

[GitHub] [kafka] mimaison commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-25 Thread GitBox
mimaison commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-698229647 @scanterog Thanks for the PR. Can you add a test for the changes? This is an automated message from the Apache Gi

[GitHub] [kafka] guozhangwang commented on pull request #9337: KAFKA-10519; Add missing unit test for `VotedState`

2020-09-25 Thread GitBox
guozhangwang commented on pull request #9337: URL: https://github.com/apache/kafka/pull/9337#issuecomment-698706077 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] abbccdda commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-25 Thread GitBox
abbccdda commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494062676 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLogTest.java ## @@ -370,6 +365,23 @@ public void testReadOutOfRangeOffset() { Isola

[GitHub] [kafka] hachikuji commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-25 Thread GitBox
hachikuji commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494494327 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -310,10 +310,10 @@ public LogFetchInfo read(long startOffset, Isolation isolati

[GitHub] [kafka] ijuma commented on pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-25 Thread GitBox
ijuma commented on pull request #9331: URL: https://github.com/apache/kafka/pull/9331#issuecomment-698233595 Unrelated flaky test failures: ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup Build / JDK 15 /

[GitHub] [kafka] vvcephei commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-25 Thread GitBox
vvcephei commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r494369894 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Proces

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-09-25 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] mimaison commented on pull request #9335: Update quickstart.html

2020-09-25 Thread GitBox
mimaison commented on pull request #9335: URL: https://github.com/apache/kafka/pull/9335#issuecomment-698388310 Which version of Kafka are you using? Since 2.6, `--bootstrap-server` is the recommended flag. `--broker-list` is now deprecated and will be removed in the next major versi

[GitHub] [kafka] vvcephei merged pull request #9316: MINOR: clarify variables for skipping idempotent source updates

2020-09-25 Thread GitBox
vvcephei merged pull request #9316: URL: https://github.com/apache/kafka/pull/9316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ijuma merged pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-25 Thread GitBox
ijuma merged pull request #9331: URL: https://github.com/apache/kafka/pull/9331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vvcephei commented on pull request #9316: MINOR: clarify variables for skipping idempotent source updates

2020-09-25 Thread GitBox
vvcephei commented on pull request #9316: URL: https://github.com/apache/kafka/pull/9316#issuecomment-698378699 Test failure was unrelated. ``` Build / JDK 15 / org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication ``` ---

[GitHub] [kafka] hachikuji merged pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
hachikuji merged pull request #9100: URL: https://github.com/apache/kafka/pull/9100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494520245 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
hachikuji commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-698458937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mimaison merged pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-25 Thread GitBox
mimaison merged pull request #8295: URL: https://github.com/apache/kafka/pull/8295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-25 Thread GitBox
viktorsomogyi commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r494261046 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means a

[GitHub] [kafka] asdaraujo commented on a change in pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-09-25 Thread GitBox
asdaraujo commented on a change in pull request #9281: URL: https://github.com/apache/kafka/pull/9281#discussion_r494670714 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1686,9 +1686,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolea

[GitHub] [kafka] ijuma merged pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-25 Thread GitBox
ijuma merged pull request #9206: URL: https://github.com/apache/kafka/pull/9206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] luigiberrettini commented on pull request #3743: KAFKA-5494: enable idempotence with max.in.flight.requests.per.connection > 1

2020-09-25 Thread GitBox
luigiberrettini commented on pull request #3743: URL: https://github.com/apache/kafka/pull/3743#issuecomment-698379057 I saw that the [Sender](https://github.com/apache/kafka/blob/2.6.0/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java#L602) checks for a `Errors

[GitHub] [kafka] apovzner commented on pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-25 Thread GitBox
apovzner commented on pull request #9317: URL: https://github.com/apache/kafka/pull/9317#issuecomment-698128538 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] guozhangwang commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-25 Thread GitBox
guozhangwang commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-698710912 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4188/ triggered This is an automated messa

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-25 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-698359953 Thanks @abbccdda and @dajac for the reviews! This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] vvcephei commented on pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-25 Thread GitBox
vvcephei commented on pull request #8181: URL: https://github.com/apache/kafka/pull/8181#issuecomment-698385372 Hey @MicahRam , I'm ready to merge this now, but there are some merge conflicts. Can you rebase this PR against the current trunk? Thanks! --

[GitHub] [kafka] ijuma edited a comment on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-09-25 Thread GitBox
ijuma edited a comment on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529 @hachikuji Do we intend the various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
rajinisivaram commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494510121 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -69,16 +71,26 @@ object TopicCommand extends Logging { else if (opts.has

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-25 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r494424452 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-09-25 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-698414958 Any updates :)? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-25 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-698237578 Unrelated flaky failures: ``` Build / JDK 15 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateBelowLimit | 5 sec | 1 -- | -- | -- Bu

[GitHub] [kafka] guozhangwang commented on a change in pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-09-25 Thread GitBox
guozhangwang commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r494747319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java ## @@ -60,6 +60,34 @@ public void prepar

[GitHub] [kafka] apovzner commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-25 Thread GitBox
apovzner commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r494034591 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1447,13 +1454,33 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metr

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494480847 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-698083970 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` it is flaky on trunk branch also so it is unr

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-25 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494170995 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-25 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r494182608 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means an except

[GitHub] [kafka] asdaraujo commented on pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-09-25 Thread GitBox
asdaraujo commented on pull request #9281: URL: https://github.com/apache/kafka/pull/9281#issuecomment-698644188 > Please also update the documentation, I think it's worth to note that in case of `listeners` it's not allowed but for `advertised.listeners` it is for the LB use-case. > Ot

[GitHub] [kafka] cadonna commented on pull request #9328: Minor: Add deleteDir for streams quickstart test

2020-09-25 Thread GitBox
cadonna commented on pull request #9328: URL: https://github.com/apache/kafka/pull/9328#issuecomment-698151176 @mumrah, error message ``` [2020-09-24T01:46:33.204Z] Cleaning up test-streams-archetype No such property: deleteDir for class: groovy.lang.Binding ``` in build

[GitHub] [kafka] fredsh2k commented on pull request #9335: Update quickstart.html

2020-09-25 Thread GitBox
fredsh2k commented on pull request #9335: URL: https://github.com/apache/kafka/pull/9335#issuecomment-698870391 kafka_2.12-2.4.0 ok, thanks for the help :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-09-25 Thread GitBox
ijuma commented on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529 @hachikuji Do we intend to various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-25 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-698835897 @ijuma any chance you could trigger a CI build? Thanks! This is an automated message from the Apache Git Servic

[GitHub] [kafka] fredsh2k closed pull request #9335: Update quickstart.html

2020-09-25 Thread GitBox
fredsh2k closed pull request #9335: URL: https://github.com/apache/kafka/pull/9335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] dajac commented on pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on pull request #9334: URL: https://github.com/apache/kafka/pull/9334#issuecomment-698784923 @rajinisivaram Thanks for your comments. I have updated the PR and answered your questions. This is an automated me

[GitHub] [kafka] dajac commented on pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-25 Thread GitBox
dajac commented on pull request #8897: URL: https://github.com/apache/kafka/pull/8897#issuecomment-698811607 @hachikuji Thanks for your suggestions. I have incorporated them. This is an automated message from the Apache Git S

[GitHub] [kafka] dajac commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
dajac commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494810769 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -844,4 +851,72 @@ class TopicCommandWithAdminClientTest extend

[GitHub] [kafka] rajinisivaram merged pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-25 Thread GitBox
rajinisivaram merged pull request #9334: URL: https://github.com/apache/kafka/pull/9334 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-10516) Implement Topic Command changes

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202224#comment-17202224 ] David Jacot commented on KAFKA-10516: - Done by this PR: https://github.com/apache/ka

[jira] [Updated] (KAFKA-10516) Implement Topic Command changes

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10516: Fix Version/s: 2.7.0 > Implement Topic Command changes > --- > >

[jira] [Resolved] (KAFKA-10516) Implement Topic Command changes

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10516. - Resolution: Fixed > Implement Topic Command changes > --- > >

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-25 Thread GitBox
scanterog commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-698983392 @mimaison just added it. Let me know if there's anything else to fix. Thanks! This is an automated message from

[jira] [Updated] (KAFKA-10364) Use Token Bucket for all quotas

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10364: Parent: (was: KAFKA-9915) Issue Type: Improvement (was: Sub-task) > Use Token Bucket

[jira] [Updated] (KAFKA-10364) Use Token Bucket for all quotas

2020-09-25 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10364: Description: KIP-599 has introduced the Token Bucket algorithm to throttle controller mutations. W

[GitHub] [kafka] dajac commented on a change in pull request #9302: KAFKA-10149: Allow auto preferred leader election when partitions are reassigning

2020-09-25 Thread GitBox
dajac commented on a change in pull request #9302: URL: https://github.com/apache/kafka/pull/9302#discussion_r495068017 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1067,10 +1067,7 @@ class KafkaController(val config: KafkaConfig, // ch

[jira] [Created] (KAFKA-10528) Make output of AK various tools consistent in case of errors

2020-09-25 Thread David Jacot (Jira)
David Jacot created KAFKA-10528: --- Summary: Make output of AK various tools consistent in case of errors Key: KAFKA-10528 URL: https://issues.apache.org/jira/browse/KAFKA-10528 Project: Kafka I

[GitHub] [kafka] hachikuji commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
hachikuji commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-699017504 @chia7712 To clarify, were you going to mention this in `docs/upgrade.html`? This is an automated message from t

[GitHub] [kafka] hachikuji merged pull request #9337: KAFKA-10519; Add missing unit test for `VotedState`

2020-09-25 Thread GitBox
hachikuji merged pull request #9337: URL: https://github.com/apache/kafka/pull/9337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-25 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-699018740 Hello, @guozhangwang Can you, please, share the results of the tests run? This is an automated message fr

[jira] [Resolved] (KAFKA-10519) Unit tests for VotedState

2020-09-25 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10519. - Resolution: Fixed > Unit tests for VotedState > - > >

[GitHub] [kafka] hachikuji edited a comment on pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-25 Thread GitBox
hachikuji edited a comment on pull request #8897: URL: https://github.com/apache/kafka/pull/8897#issuecomment-699022589 Two flaky test failures: - https://issues.apache.org/jira/browse/KAFKA-10405 - https://issues.apache.org/jira/browse/KAFKA-8266 ---

[GitHub] [kafka] hachikuji merged pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-25 Thread GitBox
hachikuji merged pull request #8897: URL: https://github.com/apache/kafka/pull/8897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #8897: MINOR; Use the automated protocol for the Consumer Protocol's subscriptions and assignments

2020-09-25 Thread GitBox
hachikuji commented on pull request #8897: URL: https://github.com/apache/kafka/pull/8897#issuecomment-699022589 Two flaky tests: - https://issues.apache.org/jira/browse/KAFKA-10405 - https://issues.apache.org/jira/browse/KAFKA-8266 --

[GitHub] [kafka] chia7712 commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-699025146 @dajac @hachikuji Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-699025599 > To clarify, were you going to mention this in docs/upgrade.html? will copy that This is an automated mes

[GitHub] [kafka] dajac commented on pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-25 Thread GitBox
dajac commented on pull request #9318: URL: https://github.com/apache/kafka/pull/9318#issuecomment-699026162 @chia7712 Sorry for the delay... I will take another look on Monday. This is an automated message from the Apache Gi

[GitHub] [kafka] guozhangwang commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-25 Thread GitBox
guozhangwang commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-699034902 Only one test failed this time, and honestly I'm not sure if it is related to your PR or not, here you go: ``` Module: kafkatest.tests.streams.streams_broker_dow

[GitHub] [kafka] ableegoldman commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-25 Thread GitBox
ableegoldman commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-699059908 @guozhangwang I think this needs to be cherrypicked back to 2.6 This is an automated message from the Apache

[GitHub] [kafka] hachikuji commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-25 Thread GitBox
hachikuji commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-699081923 @ableegoldman I agree it would be useful to have a test case. If you have time, maybe you can help out in a follow-up? -

[jira] [Updated] (KAFKA-7590) GETTING HUGE MESSAGE STRUCTURE THROUGH JMS CONNECTOR

2020-09-25 Thread Addison Huddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Addison Huddy updated KAFKA-7590: - Description: Message (was: Message -

[jira] [Commented] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-09-25 Thread James Yuzawa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202351#comment-17202351 ] James Yuzawa commented on KAFKA-10470: -- I also noticed the lack of buffer reuse in

[jira] [Comment Edited] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-09-25 Thread James Yuzawa (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202351#comment-17202351 ] James Yuzawa edited comment on KAFKA-10470 at 9/25/20, 6:36 PM: --

[jira] [Deleted] (KAFKA-7590) GETTING HUGE MESSAGE STRUCTURE THROUGH JMS CONNECTOR

2020-09-25 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao deleted KAFKA-7590: --- > GETTING HUGE MESSAGE STRUCTURE THROUGH JMS CONNECTOR > >

[GitHub] [kafka] mjsax commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-25 Thread GitBox
mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-699151989 Thanks for the patch @big-andy-coates! This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] mjsax merged pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-25 Thread GitBox
mjsax merged pull request #9156: URL: https://github.com/apache/kafka/pull/9156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-25 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-699186863 Hello, @guozhangwang I ran a failed test locally and it passes. Test passed in my previous runs, also. You can take a look at the report I share in ticket - https://

[GitHub] [kafka] ableegoldman commented on a change in pull request #9295: MINOR: standardize rebalance related logging for easy discovery & debugging

2020-09-25 Thread GitBox
ableegoldman commented on a change in pull request #9295: URL: https://github.com/apache/kafka/pull/9295#discussion_r495292893 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -769,24 +771,27 @@ public void handle(S

[GitHub] [kafka] ableegoldman commented on pull request #9339: MINOR: add docs for 2.7 TRACE-level e2e latency metrics

2020-09-25 Thread GitBox
ableegoldman commented on pull request #9339: URL: https://github.com/apache/kafka/pull/9339#issuecomment-699225846 @vvcephei @mjsax @guozhangwang This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] ableegoldman opened a new pull request #9339: MINOR: add docs for 2.7 TRACE-level e2e latency metrics

2020-09-25 Thread GitBox
ableegoldman opened a new pull request #9339: URL: https://github.com/apache/kafka/pull/9339 Add the extended e2e latency metrics to the upgrade guide for 2.7. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] ahuang98 opened a new pull request #9340: Improving Fetch Session Caching for KAFKA-9401

2020-09-25 Thread GitBox
ahuang98 opened a new pull request #9340: URL: https://github.com/apache/kafka/pull/9340 WIP - Does not follow original cache eviction logic of waiting `evictionMs` before allowing smaller session to be evicted by a larger session. Working on reverting those changes. All WIP comments below

[GitHub] [kafka] guozhangwang merged pull request #9295: MINOR: standardize rebalance related logging for easy discovery & debugging

2020-09-25 Thread GitBox
guozhangwang merged pull request #9295: URL: https://github.com/apache/kafka/pull/9295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] nym3r0s commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-25 Thread GitBox
nym3r0s commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-699364431 > > > @ableegoldman I agree it would be useful to have a test case. If you have time, maybe you can help out in a follow-up? @hachikuji @ableegoldman - I'm so sorry

[GitHub] [kafka] nym3r0s edited a comment on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-09-25 Thread GitBox
nym3r0s edited a comment on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-699364431 > > > @ableegoldman I agree it would be useful to have a test case. If you have time, maybe you can help out in a follow-up? @hachikuji @ableegoldman - I'm so

[GitHub] [kafka] MicahRam commented on pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-25 Thread GitBox
MicahRam commented on pull request #8181: URL: https://github.com/apache/kafka/pull/8181#issuecomment-699394946 @vvcephei I rebased. Checks are failing as far as I can tell it's wasn't me and they've been failing. Let me know if you think otherwise. ---

[GitHub] [kafka] jacky1193610322 commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-25 Thread GitBox
jacky1193610322 commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-699438281 I got a thought, there is a scenario that A leader can see its followers, but cannot see Zookeeper, and then the leader will be fenced when it attempts to shink isr or exp

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-25 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-699440096 @hachikuji the ```docs/upgrade.html``` is updated :) This is an automated message from the Apache Git Service. To