[jira] [Commented] (KAFKA-10460) ReplicaListValidator format checking is incomplete

2020-09-22 Thread Robin Palotai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199897#comment-17199897 ] Robin Palotai commented on KAFKA-10460: --- Thanks [~akumar], that would be nice. >

[jira] [Assigned] (KAFKA-10460) ReplicaListValidator format checking is incomplete

2020-09-22 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Kumar reassigned KAFKA-10460: --- Assignee: Ankit Kumar > ReplicaListValidator format checking is incomplete > --

[GitHub] [kafka] nizhikov commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-22 Thread GitBox
nizhikov commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696559508 @mjsax These tests are broken with the 7e7bb184d2abe34280a7f0eb0f0d9fc0e32389f2 Line logging only generationId - https://github.com/apache/kafka/commit/7e7bb184d2abe34280a

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-22 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-696565610 test this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] dajac commented on a change in pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9301: URL: https://github.com/apache/kafka/pull/9301#discussion_r492540150 ## File path: core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala ## @@ -179,17 +179,23 @@ class DynamicConnectionQuotaTest extend

[GitHub] [kafka] showuon commented on pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-22 Thread GitBox
showuon commented on pull request #9301: URL: https://github.com/apache/kafka/pull/9301#issuecomment-696577916 @dajac , thanks for the comments. I've updated in this commit: https://github.com/apache/kafka/pull/9301/commits/8e2714c6b4d0b73c36893c365998380cfaf724f6. Thanks. --

[GitHub] [kafka] dajac commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r492570653 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1414,7 +1420,8 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics:

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696622982 @ijuma I've fixed an infinite loop, could you trigger the build again pleast? This is an automated message from

[GitHub] [kafka] tombentley edited a comment on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
tombentley edited a comment on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696622982 @ijuma I've fixed an infinite loop, could you trigger the build again please? This is an automated messa

[GitHub] [kafka] chia7712 opened a new pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 opened a new pull request #9318: URL: https://github.com/apache/kafka/pull/9318 issue: https://issues.apache.org/jira/browse/KAFKA-10497 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

[jira] [Commented] (KAFKA-10497) Convert group/transaction coordinator metadata schemas to use generated protocol

2020-09-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199989#comment-17199989 ] Chia-Ping Tsai commented on KAFKA-10497: [~hachikuji] I have submitted a PR (htt

[jira] [Commented] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-22 Thread Magnus Edenhill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1716#comment-1716 ] Magnus Edenhill commented on KAFKA-10507: - librdkafka will only send ApiVersionR

[GitHub] [kafka] ramesh-muthusamy opened a new pull request #9319: Allow even distribution of lost/new tasks when more than one worker j…

2020-09-22 Thread GitBox
ramesh-muthusamy opened a new pull request #9319: URL: https://github.com/apache/kafka/pull/9319 Allow even distribution of lost/new tasks when more than one worker joins the group at the same time Issue description: Existing issue 1 description : When more than one worker joins t

[jira] [Commented] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2020-09-22 Thread Gowtham (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1724#comment-1724 ] Gowtham commented on KAFKA-7870:   {code:java} o.a.k.c.FetchSessionHandler pool-18-thread

[jira] [Commented] (KAFKA-10413) rebalancing leads to unevenly balanced connectors

2020-09-22 Thread rameshkrishnan muthusamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200015#comment-17200015 ] rameshkrishnan muthusamy commented on KAFKA-10413: -- We have PR opened o

[jira] [Comment Edited] (KAFKA-10413) rebalancing leads to unevenly balanced connectors

2020-09-22 Thread rameshkrishnan muthusamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193402#comment-17193402 ] rameshkrishnan muthusamy edited comment on KAFKA-10413 at 9/22/20, 11:28 AM: -

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492661437 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val MetricsGr

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492662801 ## File path: core/src/main/resources/common/message/GroupMetadataValue.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492663086 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val MetricsGr

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492661437 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val MetricsGr

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696066 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val Metric

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696416 ## File path: core/src/main/resources/common/message/GroupMetadataValue.json ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
viktorsomogyi commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492704280 ## File path: core/src/test/scala/unit/kafka/utils/JsonTest.scala ## @@ -40,25 +40,34 @@ class JsonTest { def testJsonParse(): Unit = { val jn

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
viktorsomogyi commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492727120 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means a

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
viktorsomogyi commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492740825 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means a

[GitHub] [kafka] vvcephei commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
vvcephei commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-696752069 Thanks, @ableegoldman ! There was only one unrelated test failure: `Build / JDK 11 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQu

[GitHub] [kafka] vvcephei merged pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
vvcephei merged pull request #8892: URL: https://github.com/apache/kafka/pull/8892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-22 Thread GitBox
vvcephei commented on pull request #9262: URL: https://github.com/apache/kafka/pull/9262#issuecomment-696760191 Test failure unrelated: `Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup` --

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492811318 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means an except

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492813256 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means an except

[GitHub] [kafka] ijuma commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
ijuma commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696784359 @tombentley `testDescribeConfigsForLog4jLogLevels` is failing. This is an automated message from the Apache Git Serv

[GitHub] [kafka] ijuma commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-22 Thread GitBox
ijuma commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-696784662 Can you also rebase please so that the PR builder runs? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492821097 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,16 +234,17 @@ private[log] object LogValidator extends Logging { val firstBat

[GitHub] [kafka] ijuma commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492823279 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -279,14 +280,15 @@ private[log] object LogValidator extends Logging { val firstBat

[GitHub] [kafka] chia7712 commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492834735 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,16 +234,17 @@ private[log] object LogValidator extends Logging { val first

[jira] [Resolved] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10507. - Resolution: Won't Do > Limit the set of APIs returned in pre-authentication ApiVersions

[jira] [Commented] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200172#comment-17200172 ] Jason Gustafson commented on KAFKA-10507: - [~edenhill] It was more of a suggesti

[jira] [Updated] (KAFKA-10510) Reassigning partitions should not allow increasing RF of a partition unless configured with it

2020-09-22 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski updated KAFKA-10510: Description: Kafka should have some validations in place against increasing the RF

[GitHub] [kafka] vvcephei merged pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-22 Thread GitBox
vvcephei merged pull request #9262: URL: https://github.com/apache/kafka/pull/9262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-22 Thread GitBox
mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-696823406 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492865230 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,17 +234,16 @@ private[log] object LogValidator extends Logging { val firstBat

[GitHub] [kafka] chia7712 commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492872408 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,17 +234,16 @@ private[log] object LogValidator extends Logging { val first

[GitHub] [kafka] abbccdda commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-22 Thread GitBox
abbccdda commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r492896997 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala ## @@ -3882,6 +3942,21 @@ class GroupCoordinatorTest { Awai

[GitHub] [kafka] piotrrzysko commented on pull request #9315: KAFKA-10496: Removed relying on external DNS servers in tests

2020-09-22 Thread GitBox
piotrrzysko commented on pull request #9315: URL: https://github.com/apache/kafka/pull/9315#issuecomment-696860022 @jolshan @mumrah @dajac Could you please take look at this PR? This is an automated message from the Apache G

[GitHub] [kafka] abbccdda commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-22 Thread GitBox
abbccdda commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492941448 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -1566,6 +1566,7 @@ public void shouldCheckpoint

[GitHub] [kafka] guozhangwang commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-22 Thread GitBox
guozhangwang commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492944504 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -217,12 +217,12 @@ public StateStore

[GitHub] [kafka] hachikuji merged pull request #9130: KAFKA-10492; Core Kafka Raft Implementation (KIP-595)

2020-09-22 Thread GitBox
hachikuji merged pull request #9130: URL: https://github.com/apache/kafka/pull/9130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] guozhangwang commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-22 Thread GitBox
guozhangwang commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492950073 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamFlatTransformValues.java ## @@ -44,19 +45,18 @@ public KStreamFl

[jira] [Resolved] (KAFKA-10492) Core Raft implementation

2020-09-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10492. - Resolution: Fixed > Core Raft implementation > > >

[GitHub] [kafka] avocader closed pull request #9227: KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale.

2020-09-22 Thread GitBox
avocader closed pull request #9227: URL: https://github.com/apache/kafka/pull/9227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] avocader opened a new pull request #9320: KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale.

2020-09-22 Thread GitBox
avocader opened a new pull request #9320: URL: https://github.com/apache/kafka/pull/9320 The `org.apache.kafka.connect.data.Values#parse` method parses integers, which are larger than `Long.MAX_VALUE` as `double` with `Schema.FLOAT64_SCHEMA`. That means we are losing precision for th

[GitHub] [kafka] ableegoldman commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-22 Thread GitBox
ableegoldman commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696925826 Original system test run was aborted for some reason. Kicked off a new set: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4182/ -

[jira] [Created] (KAFKA-10511) Fix minor behavior difference in `MockLog`

2020-09-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10511: --- Summary: Fix minor behavior difference in `MockLog` Key: KAFKA-10511 URL: https://issues.apache.org/jira/browse/KAFKA-10511 Project: Kafka Issue Type:

[GitHub] [kafka] gmunozfe commented on pull request #9309: KAFKA-10503: MockProducer doesn't throw ClassCastException when no

2020-09-22 Thread GitBox
gmunozfe commented on pull request #9309: URL: https://github.com/apache/kafka/pull/9309#issuecomment-696995620 @mjsax @guozhangwang @leonardge could you review? thanks! This is an automated message from the Apache Git Servic

[GitHub] [kafka] jeqo opened a new pull request #9321: fix: add missing default implementations

2020-09-22 Thread GitBox
jeqo opened a new pull request #9321: URL: https://github.com/apache/kafka/pull/9321 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[jira] [Created] (KAFKA-10512) JmxTool Can Crash on Unmarshall Error

2020-09-22 Thread Matthew Wong (Jira)
Matthew Wong created KAFKA-10512: Summary: JmxTool Can Crash on Unmarshall Error Key: KAFKA-10512 URL: https://issues.apache.org/jira/browse/KAFKA-10512 Project: Kafka Issue Type: Bug

[GitHub] [kafka] mattwong949 opened a new pull request #9322: KAFKA-10512: Prevent JmxTool Crashing on Unmarshall Error

2020-09-22 Thread GitBox
mattwong949 opened a new pull request #9322: URL: https://github.com/apache/kafka/pull/9322 The JMXTool will query for all metrics when not supplied an "--object-name" arg. However, some MBean objects can contain attributes that cannot be serialized, thus crashing the JMXTool before report

[jira] [Created] (KAFKA-10513) Newly added partitions are not assigned to running static consumer

2020-09-22 Thread Marlon Ou (Jira)
Marlon Ou created KAFKA-10513: - Summary: Newly added partitions are not assigned to running static consumer Key: KAFKA-10513 URL: https://issues.apache.org/jira/browse/KAFKA-10513 Project: Kafka

[GitHub] [kafka] huxihx commented on pull request #9218: MINOR: Fix shouldNotResetEpochHistoryHeadIfUndefinedPassed

2020-09-22 Thread GitBox
huxihx commented on pull request #9218: URL: https://github.com/apache/kafka/pull/9218#issuecomment-697095836 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-22 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r493160927 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AlterConfigsUtil.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Assigned] (KAFKA-8653) Regression in JoinGroup v0 rebalance timeout handling

2020-09-22 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Cheng reassigned KAFKA-8653: -- Assignee: James Cheng (was: Jason Gustafson) > Regression in JoinGroup v0 rebalance timeout h

[jira] [Assigned] (KAFKA-8653) Regression in JoinGroup v0 rebalance timeout handling

2020-09-22 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Cheng reassigned KAFKA-8653: -- Assignee: (was: James Cheng) > Regression in JoinGroup v0 rebalance timeout handling > ---

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492661437 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val MetricsGr

[GitHub] [kafka] dajac commented on a change in pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9301: URL: https://github.com/apache/kafka/pull/9301#discussion_r492540150 ## File path: core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala ## @@ -179,17 +179,23 @@ class DynamicConnectionQuotaTest extend

[GitHub] [kafka] mjsax commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-22 Thread GitBox
mjsax commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r492360815 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Processor

[GitHub] [kafka] avocader closed pull request #9227: KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale.

2020-09-22 Thread GitBox
avocader closed pull request #9227: URL: https://github.com/apache/kafka/pull/9227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-22 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-696383217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] vvcephei commented on pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-22 Thread GitBox
vvcephei commented on pull request #9262: URL: https://github.com/apache/kafka/pull/9262#issuecomment-696760191 Test failure unrelated: `Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup` --

[GitHub] [kafka] mjsax commented on a change in pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-22 Thread GitBox
mjsax commented on a change in pull request #9251: URL: https://github.com/apache/kafka/pull/9251#discussion_r492434090 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -25,6 +25,11 @@ * A window store that only supports read

[GitHub] [kafka] showuon commented on pull request #9301: KAFKA-10482: Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-22 Thread GitBox
showuon commented on pull request #9301: URL: https://github.com/apache/kafka/pull/9301#issuecomment-696577916 @dajac , thanks for the comments. I've updated in this commit: https://github.com/apache/kafka/pull/9301/commits/8e2714c6b4d0b73c36893c365998380cfaf724f6. Thanks. --

[GitHub] [kafka] dajac commented on a change in pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-22 Thread GitBox
dajac commented on a change in pull request #9317: URL: https://github.com/apache/kafka/pull/9317#discussion_r492570653 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1414,7 +1420,8 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics:

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-22 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696528358 > So the previous behavior would have caused the updated configuration to be persisted, but it wouldn't take effect until the broker was restarted. Is that right? You do g

[GitHub] [kafka] ijuma merged pull request #9299: MINOR: Use `Map.forKeyValue` to avoid tuple allocation in Scala 2.13

2020-09-22 Thread GitBox
ijuma merged pull request #9299: URL: https://github.com/apache/kafka/pull/9299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r492696066 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -997,189 +997,52 @@ object GroupMetadataManager { val Metric

[GitHub] [kafka] vvcephei merged pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-22 Thread GitBox
vvcephei merged pull request #9262: URL: https://github.com/apache/kafka/pull/9262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-22 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-696467921 @mjsax , sorry, I found you're online now. So could you take a look again for the long pending PR? It's 2nd review, so it should be easier. Thanks. -

[GitHub] [kafka] piotrrzysko commented on pull request #9315: KAFKA-10496: Removed relying on external DNS servers in tests

2020-09-22 Thread GitBox
piotrrzysko commented on pull request #9315: URL: https://github.com/apache/kafka/pull/9315#issuecomment-696860022 @jolshan @mumrah @dajac Could you please take look at this PR? This is an automated message from the Apache G

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492382332 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -77,13 +86,8 @@ public

[GitHub] [kafka] ijuma commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
ijuma commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492821097 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,16 +234,17 @@ private[log] object LogValidator extends Logging { val firstBat

[GitHub] [kafka] abbccdda commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

2020-09-22 Thread GitBox
abbccdda commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r491655717 ## File path: clients/src/main/java/org/apache/kafka/common/errors/TransactionTimeoutException.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-696522007 rebase to run JMH again. This patch is still a benefit to validation :) This is an automated message from the Apa

[GitHub] [kafka] mjsax commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-22 Thread GitBox
mjsax commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696464404 @nizhikov @ableegoldman Do we know when this broke? What was the old log line and what is the new one? Triggered system test run: https://jenkins.confluent.io/job/system-test

[GitHub] [kafka] vvcephei merged pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
vvcephei merged pull request #8892: URL: https://github.com/apache/kafka/pull/8892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on a change in pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-22 Thread GitBox
chia7712 commented on a change in pull request #9206: URL: https://github.com/apache/kafka/pull/9206#discussion_r492834735 ## File path: core/src/main/scala/kafka/log/LogValidator.scala ## @@ -234,16 +234,17 @@ private[log] object LogValidator extends Logging { val first

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696622982 @ijuma I've fixed an infinite loop, could you trigger the build again pleast? This is an automated message from

[GitHub] [kafka] vvcephei commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
vvcephei commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492436680 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -77,13 +86,8 @@ public sta

[GitHub] [kafka] abbccdda commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-22 Thread GitBox
abbccdda commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492941448 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -1566,6 +1566,7 @@ public void shouldCheckpoint

[GitHub] [kafka] tombentley edited a comment on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
tombentley edited a comment on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696622982 @ijuma I've fixed an infinite loop, could you trigger the build again please? This is an automated messa

[GitHub] [kafka] nizhikov commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-22 Thread GitBox
nizhikov commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696559508 @mjsax These tests are broken with the 7e7bb184d2abe34280a7f0eb0f0d9fc0e32389f2 Line logging only generationId - https://github.com/apache/kafka/commit/7e7bb184d2abe34280a

[GitHub] [kafka] hachikuji merged pull request #9130: KAFKA-10492; Core Kafka Raft Implementation (KIP-595)

2020-09-22 Thread GitBox
hachikuji merged pull request #9130: URL: https://github.com/apache/kafka/pull/9130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] guozhangwang commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-22 Thread GitBox
guozhangwang commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492944504 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -217,12 +217,12 @@ public StateStore

[GitHub] [kafka] abbccdda commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-22 Thread GitBox
abbccdda commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r492896997 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala ## @@ -3882,6 +3942,21 @@ class GroupCoordinatorTest { Awai

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

2020-09-22 Thread GitBox
chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-696523232 ``` Build / JDK 15 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] Build / JDK 8 / kafka.api.ConsumerBounceTest

[GitHub] [kafka] vvcephei commented on pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-22 Thread GitBox
vvcephei commented on pull request #8892: URL: https://github.com/apache/kafka/pull/8892#issuecomment-696752069 Thanks, @ableegoldman ! There was only one unrelated test failure: `Build / JDK 11 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQu

[GitHub] [kafka] gmunozfe commented on pull request #9309: KAFKA-10503: MockProducer doesn't throw ClassCastException when no

2020-09-22 Thread GitBox
gmunozfe commented on pull request #9309: URL: https://github.com/apache/kafka/pull/9309#issuecomment-696995620 @mjsax @guozhangwang @leonardge could you review? thanks! This is an automated message from the Apache Git Servic

[GitHub] [kafka] mjsax merged pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-22 Thread GitBox
mjsax merged pull request #9251: URL: https://github.com/apache/kafka/pull/9251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-22 Thread GitBox
mjsax commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-696823406 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-22 Thread GitBox
ableegoldman commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696925826 Original system test run was aborted for some reason. Kicked off a new set: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4182/ -

[GitHub] [kafka] mjsax commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-22 Thread GitBox
mjsax commented on pull request #9251: URL: https://github.com/apache/kafka/pull/9251#issuecomment-696467547 Thanks for the PR @showuon! This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] ijuma commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-22 Thread GitBox
ijuma commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696784359 @tombentley `testDescribeConfigsForLog4jLogLevels` is failing. This is an automated message from the Apache Git Serv

  1   2   >