showuon commented on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694694817
@apovzner @rajinisivaram , could you review this PR? thanks.
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198190#comment-17198190
]
Oleg Osipov commented on KAFKA-7500:
Hello!
I have a question about the cross-clust
cadonna commented on pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#issuecomment-694720082
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
JunHe77 commented on pull request #8489:
URL: https://github.com/apache/kafka/pull/8489#issuecomment-694721961
@junrao @cmccabe Ping... is there any way we can help you merge this?
Thanks.
This is an automated message from
dajac commented on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694722444
@showuon Could we also use the title of the jira as title of this PR?
This is an automated message from the Apache G
dajac commented on a change in pull request #9302:
URL: https://github.com/apache/kafka/pull/9302#discussion_r490794812
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1067,10 +1067,7 @@ class KafkaController(val config: KafkaConfig,
// ch
huxihx commented on pull request #9218:
URL: https://github.com/apache/kafka/pull/9218#issuecomment-694743368
retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
cadonna opened a new pull request #9303:
URL: https://github.com/apache/kafka/pull/9303
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
cadonna commented on pull request #9303:
URL: https://github.com/apache/kafka/pull/9303#issuecomment-694761199
Call for review: @vvcephei
This is an automated message from the Apache Git Service.
To respond to the message, p
Bruno Cadonna created KAFKA-10500:
-
Summary: Add API to Start and Stop Stream Threads
Key: KAFKA-10500
URL: https://issues.apache.org/jira/browse/KAFKA-10500
Project: Kafka
Issue Type: Sub-ta
[
https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-10500:
--
Labels: needs-kip (was: )
> Add API to Start and Stop Stream Threads
> --
showuon commented on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694776599
> However I wonder if it would make sense to extract the part which waits
until we go back to the initial count out of `verifyConnectionRate` into a
dedicated helper method and to
mumrah commented on a change in pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#discussion_r490861713
##
File path:
clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##
@@ -273,22 +273,21 @@ public void testMultipleIPsWithDefaul
mumrah commented on pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#issuecomment-694805060
2.6 backport applied cleanly, kicked off a build here
https://ci-builds.apache.org/job/Kafka/job/kafka-2.6-jdk8/15/
2.5 had a conflict, and one test fails for me locally. I'l
mumrah edited a comment on pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#issuecomment-694805060
2.6 backport applied cleanly, kicked off a build here
https://ci-builds.apache.org/job/Kafka/job/kafka-2.6-jdk8/15/
~2.5 had a conflict, and one test fails for me loca
[
https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-10500:
--
Parent: (was: KAFKA-10015)
Issue Type: New Feature (was: Sub-task)
> Add API to S
showuon edited a comment on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694776599
> However I wonder if it would make sense to extract the part which waits
until we go back to the initial count out of `verifyConnectionRate` into a
dedicated helper method
[
https://issues.apache.org/jira/browse/KAFKA-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prateek Agarwal updated KAFKA-10499:
Affects Version/s: (was: 2.5.1)
2.6.0
> 4 Unit Tests are breaki
dajac commented on a change in pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#discussion_r490906826
##
File path:
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
##
@@ -202,6 +208,7 @@ class DynamicConnectionQuotaTest extends
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490933197
##
File path: clients/src/main/resources/common/message/ListOffsetResponse.json
##
@@ -48,7 +48,7 @@
"about": "The timestamp associated with the
showuon commented on a change in pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#discussion_r490939181
##
File path:
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
##
@@ -317,6 +325,12 @@ class DynamicConnectionQuotaTest exten
showuon commented on a change in pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#discussion_r490939387
##
File path:
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala
##
@@ -202,6 +208,7 @@ class DynamicConnectionQuotaTest extend
showuon commented on pull request #9301:
URL: https://github.com/apache/kafka/pull/9301#issuecomment-694860294
@dajac , thanks for the comments. I've updated in this commit:
https://github.com/apache/kafka/pull/9301/commits/22d240571de45b3ea3573c3428a6c17efe862092.
Thanks.
--
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490940439
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -910,136 +913,161 @@ class KafkaApis(val requestChannel: RequestChannel,
def handle
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490941989
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -2496,46 +2501,81 @@ public void
testGetOffsetByTi
mimaison commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490947807
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
##
@@ -2496,46 +2501,81 @@ public void
testGetOffsetByTi
mimaison commented on pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#issuecomment-694867857
@abbccdda I hope you had a good time off!
Thanks for the review. I pushed an update
This is an automated mess
lkokhreidze commented on pull request #9237:
URL: https://github.com/apache/kafka/pull/9237#issuecomment-694871160
hey @vvcephei @bbejeck any updates around this? would be great to make it
for the next bug release.
This is a
[
https://issues.apache.org/jira/browse/KAFKA-8690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198350#comment-17198350
]
Bruno Cadonna commented on KAFKA-8690:
--
https://ci-builds.apache.org/blue/organizati
Mykhailo Baluta created KAFKA-10501:
---
Summary: Log Cleaner never clean up some __consumer_offsets
partitions
Key: KAFKA-10501
URL: https://issues.apache.org/jira/browse/KAFKA-10501
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mykhailo Baluta updated KAFKA-10501:
Description:
Some __comsumer_offsets partitions contain "broken" messages in the second lo
vvcephei commented on pull request #9303:
URL: https://github.com/apache/kafka/pull/9303#issuecomment-694916455
The test failures were unrelated:
```
Build / JDK 8 /
org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testTaskStatuses
Build / JDK 11 /
kafka.a
vvcephei merged pull request #9303:
URL: https://github.com/apache/kafka/pull/9303
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
brbrown25 commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-694920689
@mimaison I've posted on the mailing list but not gotten any feedback. Is
there anything you'd recommend, here is my most recent posting
http://mail-archives.apache.org/mod_mbox
jolshan commented on a change in pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#discussion_r491037285
##
File path:
clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##
@@ -273,22 +273,21 @@ public void testMultipleIPsWithDefau
jolshan commented on a change in pull request #9294:
URL: https://github.com/apache/kafka/pull/9294#discussion_r491037285
##
File path:
clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##
@@ -273,22 +273,21 @@ public void testMultipleIPsWithDefau
chia7712 commented on a change in pull request #9223:
URL: https://github.com/apache/kafka/pull/9223#discussion_r491040089
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/record/RecordBatchBenchmarkSuite.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache
vgvineet4 commented on pull request #9254:
URL: https://github.com/apache/kafka/pull/9254#issuecomment-694948975
@vvcephei please have a look
This is an automated message from the Apache Git Service.
To respond to the message
mimaison commented on pull request #9057:
URL: https://github.com/apache/kafka/pull/9057#issuecomment-694952594
@brbrown25 I took a quick look at the KIP and replied to the thread on the
mailing list.
We do our best to review KIPs but sometimes it can take a little while. You
can bump
chia7712 commented on pull request #9284:
URL: https://github.com/apache/kafka/pull/9284#issuecomment-694954746
> Can you take a look at DynamicConnectionsQuotaTest? Looks like this patch
is causing it to fail.
The error message should be unrelate to this patch. Also, I loop it 5 tim
[
https://issues.apache.org/jira/browse/KAFKA-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198427#comment-17198427
]
Jason Gustafson commented on KAFKA-10497:
-
[~dajac] The schemas I'm referring to
abbccdda commented on a change in pull request #8725:
URL: https://github.com/apache/kafka/pull/8725#discussion_r491066687
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionEventSimulationTest.java
##
@@ -0,0 +1,147 @@
+/*
+ * Licensed
jsancio commented on a change in pull request #9299:
URL: https://github.com/apache/kafka/pull/9299#discussion_r491078577
##
File path: core/src/main/scala/kafka/utils/Implicits.scala
##
@@ -46,4 +47,21 @@ object Implicits {
}
+ /**
+ * Exposes `foreachKv` which maps
huangyiming created KAFKA-10502:
---
Summary: Threadlocal may can not set null,because it may create a
memory leak
Key: KAFKA-10502
URL: https://issues.apache.org/jira/browse/KAFKA-10502
Project: Kafka
huangyiminghappy opened a new pull request #9304:
URL: https://github.com/apache/kafka/pull/9304
Threadlocal may can not set null,because it may create a memory leak, you
can see the link:
https://stackoverflow.com/questions/12424838/threadlocal-remove,so I think
weather can invoke thr
ableegoldman commented on a change in pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#discussion_r491087153
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsAssignmentScaleTest.java
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed
hachikuji commented on a change in pull request #8897:
URL: https://github.com/apache/kafka/pull/8897#discussion_r491063152
##
File path:
clients/src/main/resources/common/message/ConsumerProtocolSubscriptionData.json
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Fou
hachikuji commented on a change in pull request #9302:
URL: https://github.com/apache/kafka/pull/9302#discussion_r491094781
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1067,10 +1067,7 @@ class KafkaController(val config: KafkaConfig,
/
hachikuji commented on a change in pull request #9302:
URL: https://github.com/apache/kafka/pull/9302#discussion_r491099373
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
##
@@ -444,6 +444,29 @@ class ControllerIntegrationTest extends
mjsax commented on a change in pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#discussion_r491102161
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -292,7 +291,7 @@ public synchronized void clean()
ableegoldman commented on a change in pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#discussion_r49110
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -306,59 +305,69 @@ public synchronized void
ableegoldman commented on a change in pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#discussion_r491108548
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -306,59 +305,69 @@ public synchronized void
vvcephei commented on a change in pull request #9262:
URL: https://github.com/apache/kafka/pull/9262#discussion_r491085819
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -292,7 +291,7 @@ public synchronized void clean
jolshan opened a new pull request #9305:
URL: https://github.com/apache/kafka/pull/9305
These tests were fragile, so we made a temporary fix
https://github.com/apache/kafka/pull/9294.
These changes need to be back-ported to previous versions.
---
shaikzakiriitm opened a new pull request #9306:
URL: https://github.com/apache/kafka/pull/9306
…NG JsonNodeType in JsonConverter.
From v2.10.0 onwards, in jackson lib, ObjectMapper.readTree(input) started
to return JsonNode of type MISSING for empty input, as mentioned in the issue:
jolshan opened a new pull request #9307:
URL: https://github.com/apache/kafka/pull/9307
These tests were fragile, so we made a temporary fix
https://github.com/apache/kafka/pull/9294
These changes need to be back-ported to previous versions.
The tests in question passed locall
shaikzakiriitm commented on pull request #9306:
URL: https://github.com/apache/kafka/pull/9306#issuecomment-695020619
@kkonstantine @rhauch Kindly take a look at the changes. Thanks!
This is an automated message from the Apac
ijuma commented on a change in pull request #9299:
URL: https://github.com/apache/kafka/pull/9299#discussion_r491149647
##
File path: core/src/main/scala/kafka/utils/Implicits.scala
##
@@ -46,4 +47,21 @@ object Implicits {
}
+ /**
+ * Exposes `foreachKv` which maps to
ijuma commented on a change in pull request #9299:
URL: https://github.com/apache/kafka/pull/9299#discussion_r491149798
##
File path: core/src/main/scala/kafka/utils/Implicits.scala
##
@@ -46,4 +47,21 @@ object Implicits {
}
+ /**
+ * Exposes `foreachKv` which maps to
abbccdda commented on a change in pull request #8725:
URL: https://github.com/apache/kafka/pull/8725#discussion_r491150125
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionSimulationCoordinator.java
##
@@ -0,0 +1,316 @@
+/*
+ * License
jsancio commented on a change in pull request #9299:
URL: https://github.com/apache/kafka/pull/9299#discussion_r491151232
##
File path: core/src/main/scala/kafka/utils/Implicits.scala
##
@@ -46,4 +47,21 @@ object Implicits {
}
+ /**
+ * Exposes `foreachKv` which maps
ijuma commented on a change in pull request #9299:
URL: https://github.com/apache/kafka/pull/9299#discussion_r491163592
##
File path: core/src/main/scala/kafka/utils/Implicits.scala
##
@@ -46,4 +47,21 @@ object Implicits {
}
+ /**
+ * Exposes `foreachKv` which maps to
[
https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mykhailo Baluta updated KAFKA-10501:
Description:
Some __consumer_offsets partitions contain "broken" messages in the second lo
[
https://issues.apache.org/jira/browse/KAFKA-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mykhailo Baluta updated KAFKA-10501:
Description:
Some __consumer_offsets partitions contain "broken" messages in the second lo
jolshan removed a comment on pull request #9307:
URL: https://github.com/apache/kafka/pull/9307#issuecomment-695070849
run tests please
This is an automated message from the Apache Git Service.
To respond to the message,
jolshan commented on pull request #9307:
URL: https://github.com/apache/kafka/pull/9307#issuecomment-695070849
run tests please
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/KAFKA-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198533#comment-17198533
]
Matthias J. Sax commented on KAFKA-10480:
-
What configs do you use for both para
[
https://issues.apache.org/jira/browse/KAFKA-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abuli Palagashvili resolved KAFKA-10480.
Resolution: Fixed
> Kafka streams application is being stuck
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198534#comment-17198534
]
Abuli Palagashvili commented on KAFKA-10480:
[~mjsax] thanks for attention,
abbccdda commented on a change in pull request #8725:
URL: https://github.com/apache/kafka/pull/8725#discussion_r491195879
##
File path:
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionSimulationCoordinator.java
##
@@ -0,0 +1,316 @@
+/*
+ * License
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198538#comment-17198538
]
Matthias J. Sax commented on KAFKA-10493:
-
Not sure if I fully understand (but t
[
https://issues.apache.org/jira/browse/KAFKA-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman resolved KAFKA-6127.
Resolution: Fixed
> Streams should never block infinitely
> ---
[
https://issues.apache.org/jira/browse/KAFKA-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-10480:
-
> Kafka streams application is being stuck
>
>
>
[
https://issues.apache.org/jira/browse/KAFKA-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-10480.
-
Resolution: Invalid
> Kafka streams application is being stuck
> ---
hachikuji commented on pull request #9284:
URL: https://github.com/apache/kafka/pull/9284#issuecomment-695118113
I see the failure consistently running this branch locally. Here is the
error I get from `testDynamicListenerConnectionQuota`:
```
java.util.concurrent.ExecutionExcepti
[
https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sophie Blee-Goldman updated KAFKA-9846:
---
Fix Version/s: (was: 2.7.0)
2.6.0
> Race condition can lead to
ableegoldman opened a new pull request #9308:
URL: https://github.com/apache/kafka/pull/9308
Some minor fixes that were found in the kafka-site PR review after the AK PR
had already been merged
This is an automated messa
ableegoldman commented on pull request #9308:
URL: https://github.com/apache/kafka/pull/9308#issuecomment-695125523
@mjsax @guozhangwang @vvcephei @abbccdda
This is an automated message from the Apache Git Service.
To respon
ableegoldman commented on pull request #9027:
URL: https://github.com/apache/kafka/pull/9027#issuecomment-695125496
Ping any of @mjsax @guozhangwang @vvcephei @abbccdda to cherrypick this
back to 2.6
This is an automated me
hachikuji commented on a change in pull request #9202:
URL: https://github.com/apache/kafka/pull/9202#discussion_r491240953
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -1402,23 +1403,18 @@ object GroupMetadataManager {
val
hachikuji commented on a change in pull request #9275:
URL: https://github.com/apache/kafka/pull/9275#discussion_r491241346
##
File path: core/src/main/scala/kafka/api/ApiVersion.scala
##
@@ -100,7 +100,9 @@ object ApiVersion {
// Introduced StopReplicaRequest V3 containin
ableegoldman commented on pull request #9295:
URL: https://github.com/apache/kafka/pull/9295#issuecomment-695141073
Unrelated `kafka.api.ConsumerBounceTest failed`
This is an automated message from the Apache Git Service.
To
kkonstantine commented on a change in pull request #9149:
URL: https://github.com/apache/kafka/pull/9149#discussion_r491251818
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -409,6 +410,9 @@ private boolean sendRecords(
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198650#comment-17198650
]
Pedro Gontijo commented on KAFKA-10493:
---
I see. My assumption was basically based
chia7712 commented on pull request #9284:
URL: https://github.com/apache/kafka/pull/9284#issuecomment-695164715
> I see the failure consistently running this branch locally
my bad. I looped tests with incorrect branch :(
I have fixed the failed test. @dongjinleekr @hachikuji pl
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198661#comment-17198661
]
Matthias J. Sax commented on KAFKA-10493:
-
Maybe [~vvcephei] can shed some light
[
https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198661#comment-17198661
]
Matthias J. Sax edited comment on KAFKA-10493 at 9/19/20, 5:48 AM:
---
87 matches
Mail list logo
