[GitHub] [kafka] cadonna commented on pull request #9191: KAFKA-10355: Throw error when source topic was deleted

2020-09-02 Thread GitBox
cadonna commented on pull request #9191: URL: https://github.com/apache/kafka/pull/9191#issuecomment-685407069 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-09-02 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-685408584 @guozhangwang @abbccdda ping ~ This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] omkreddy commented on a change in pull request #9236: MINOR: Log warn message with details when there's kerberos login issue

2020-09-02 Thread GitBox
omkreddy commented on a change in pull request #9236: URL: https://github.com/apache/kafka/pull/9236#discussion_r481854947 ## File path: clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java ## @@ -237,6 +238,7 @@ public LoginContext login() throws

[GitHub] [kafka] cnZach commented on a change in pull request #9236: MINOR: Log warn message with details when there's kerberos login issue

2020-09-02 Thread GitBox
cnZach commented on a change in pull request #9236: URL: https://github.com/apache/kafka/pull/9236#discussion_r481880310 ## File path: clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java ## @@ -237,6 +238,7 @@ public LoginContext login() throws L

[GitHub] [kafka] omkreddy commented on pull request #9236: MINOR: Log warn message with details when there's kerberos login issue

2020-09-02 Thread GitBox
omkreddy commented on pull request #9236: URL: https://github.com/apache/kafka/pull/9236#issuecomment-685444628 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r481920572 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -33,11 +33,11 @@ /** * Get the value of key from

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r481930378 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractMergedSortedCacheStoreIterator.java ## @@ -192,4 +192,3 @@ public void cl

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r481931127 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java ## @@ -117,12 +118,20 @@ public void openExisting(final Pro

[GitHub] [kafka] manijndl7 opened a new pull request #9244: Consolidate duplicated logic on reset tools

2020-09-02 Thread GitBox
manijndl7 opened a new pull request #9244: URL: https://github.com/apache/kafka/pull/9244 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-02 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-685493474 @guozhangwang @mjsax ready for another review. This is an automated message from the Apache Git Service. T

[jira] [Comment Edited] (KAFKA-6585) Consolidate duplicated logic on reset tools

2020-09-02 Thread Mani Jindal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188984#comment-17188984 ] Mani Jindal edited comment on KAFKA-6585 at 9/2/20, 9:30 AM: -

[GitHub] [kafka] huxihx merged pull request #9240: KAFKA-10456: Wrong description in kafka-console-producer.sh help

2020-09-02 Thread GitBox
huxihx merged pull request #9240: URL: https://github.com/apache/kafka/pull/9240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] huxihx commented on pull request #9240: KAFKA-10456: Wrong description in kafka-console-producer.sh help

2020-09-02 Thread GitBox
huxihx commented on pull request #9240: URL: https://github.com/apache/kafka/pull/9240#issuecomment-685535337 @omkreddy Thanks for the review, merging to trunk. This is an automated message from the Apache Git Service. To res

[jira] [Resolved] (KAFKA-10456) wrong description in kafka-console-producer.sh help

2020-09-02 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx resolved KAFKA-10456. Fix Version/s: 2.7.0 Resolution: Fixed > wrong description in kafka-console-producer.sh help >

[GitHub] [kafka] mimaison commented on pull request #8050: MINOR: Include call name in TimeoutException

2020-09-02 Thread GitBox
mimaison commented on pull request #8050: URL: https://github.com/apache/kafka/pull/8050#issuecomment-685557805 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] LMnet commented on a change in pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-09-02 Thread GitBox
LMnet commented on a change in pull request #8955: URL: https://github.com/apache/kafka/pull/8955#discussion_r481972046 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/serialization/Serdes.scala ## @@ -43,12 +43,6 @@ object Serdes extends LowP

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-09-02 Thread GitBox
LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-685598623 @chia7712 ok, I will check this. I think I know how to fix this. This is an automated message from the Apache Git Se

[jira] [Commented] (KAFKA-9440) Add ConsumerGroupCommand to delete static members

2020-09-02 Thread Sandeep Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189158#comment-17189158 ] Sandeep Kumar commented on KAFKA-9440: -- h4. [@Boyang Chen  |https://issues.apache.or

[GitHub] [kafka] LMnet opened a new pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
LMnet opened a new pull request #9245: URL: https://github.com/apache/kafka/pull/9245 This is a build fix after [KAFKA-10020](https://github.com/apache/kafka/pull/8955). It looks like scala 2.12 and 2.13 have different import shadowing algorithms. On 2.12 explicit import of `org.a

[GitHub] [kafka] LMnet commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-09-02 Thread GitBox
LMnet commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-685686014 @chia7712 I created a fix: https://github.com/apache/kafka/pull/9245 This is an automated message from the Apache Gi

[GitHub] [kafka] chia7712 commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
chia7712 commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685713654 > It looks like scala 2.12 and 2.13 have different import shadowing algorithms. On 2.12 explicit import of org.apache.kafka.streams.scala.serialization.Serdes has less priority t

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482078343 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -254,35 +257,43 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482079220 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +191,113 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482084851 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -311,13 +322,8 @@ private void putAnd

[GitHub] [kafka] mumrah opened a new pull request #9246: Minor: publish static analysis reports in PR builds

2020-09-02 Thread GitBox
mumrah opened a new pull request #9246: URL: https://github.com/apache/kafka/pull/9246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482127067 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -67,14 +70,22 @@ public Bytes peekNextKey() { pub

[GitHub] [kafka] bbejeck commented on pull request #9208: Minor init singleton list

2020-09-02 Thread GitBox
bbejeck commented on pull request #9208: URL: https://github.com/apache/kafka/pull/9208#issuecomment-685789082 @khaireddine120 can you rebase this PR against trunk? Then after the build we can get this merged. This is an aut

[GitHub] [kafka] bbejeck commented on pull request #9209: Minor enhance copy array

2020-09-02 Thread GitBox
bbejeck commented on pull request #9209: URL: https://github.com/apache/kafka/pull/9209#issuecomment-685789732 @khaireddine120 can you rebase this PR against trunk? Then after the build we can get this merged. This is an aut

[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon

2020-09-02 Thread GitBox
bbejeck commented on pull request #9207: URL: https://github.com/apache/kafka/pull/9207#issuecomment-685790819 @khaireddine120 can you rebase this PR against trunk? Then after the build we can get this merged. This is an aut

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482160020 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -150,13 +185,25 @@ * @return an iterator over windowed key-valu

[GitHub] [kafka] mimaison merged pull request #8798: KAFKA-10098: Remove unnecessary escaping in regular expression.

2020-09-02 Thread GitBox
mimaison merged pull request #8798: URL: https://github.com/apache/kafka/pull/8798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482160859 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -136,34 +174,64 @@ * * This iterator must be cl

[jira] [Resolved] (KAFKA-10098) Remove unnecessary escaping in regular expression in SaslAuthenticatorTest.java

2020-09-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10098. Fix Version/s: 2.7.0 Resolution: Fixed > Remove unnecessary escaping in regular exp

[GitHub] [kafka] mimaison commented on pull request #8798: KAFKA-10098: Remove unnecessary escaping in regular expression.

2020-09-02 Thread GitBox
mimaison commented on pull request #8798: URL: https://github.com/apache/kafka/pull/8798#issuecomment-685814537 Thanks for the PR @cancecen This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (KAFKA-10272) kafka-server-stop.sh fails on IBM i

2020-09-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10272. Fix Version/s: 2.7.0 Resolution: Fixed > kafka-server-stop.sh fails on IBM i >

[GitHub] [kafka] mimaison merged pull request #9023: KAFKA-10272: Add IBM i support to "stop" scripts

2020-09-02 Thread GitBox
mimaison merged pull request #9023: URL: https://github.com/apache/kafka/pull/9023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-02 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-685831526 @chia7712 It seems there are some compilation errors in jenkins? https://ci-builds.apache.org/job/Kafka/job/kafka-pr/view/change-requests/job/PR-8657/1/consoleFull `

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-685833800 > 00:31:51 [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-8657/streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/StreamToTableJoinScalaIntegrati

[GitHub] [kafka] mimaison merged pull request #8050: MINOR: Include call name in TimeoutException

2020-09-02 Thread GitBox
mimaison merged pull request #8050: URL: https://github.com/apache/kafka/pull/8050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-685837334 ```kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota``` pass on my local. retest this please -

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-685838009 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mimaison commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

2020-09-02 Thread GitBox
mimaison commented on pull request #9122: URL: https://github.com/apache/kafka/pull/9122#issuecomment-685841902 @nresare Good catch! The change looks good. Before merging I'd like to get this change tested in the CI pipeline. The Apache Jenkins setup just changed a few days ago and

[GitHub] [kafka] mimaison commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

2020-09-02 Thread GitBox
mimaison commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r482195986 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here. MM2

[GitHub] [kafka] ijuma commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
ijuma commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685846486 We should merge this to fix the build, but it seems suboptimal for our users too. cc @guozhangwang @mjsax @vvcephei ---

[GitHub] [kafka] nresare commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

2020-09-02 Thread GitBox
nresare commented on pull request #9122: URL: https://github.com/apache/kafka/pull/9122#issuecomment-685846761 @mimaison Thanks for having a look! I just rebased and pushed and it seems there are checks being kicked off as well 🎉 --

[GitHub] [kafka] mimaison commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-02 Thread GitBox
mimaison commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-685847906 Thanks @asdaraujo, I'll try to take another look later on this week. Can you rebase on trunk? to pick up a change (https://github.com/apache/kafka/commit/241e1447fae8b85b3b

[GitHub] [kafka] chia7712 commented on a change in pull request #9246: Minor: publish static analysis reports in PR builds

2020-09-02 Thread GitBox
chia7712 commented on a change in pull request #9246: URL: https://github.com/apache/kafka/pull/9246#discussion_r482211220 ## File path: Jenkinsfile ## @@ -31,6 +31,25 @@ def doValidation() { spotlessScalaCheck checkstyleMain checkstyleTest spotbugsMain rat \

[jira] [Resolved] (KAFKA-10129) Fail QA if there are javadoc warnings

2020-09-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10129. Resolution: Won't Fix > Fail QA if there are javadoc warnings > --

[GitHub] [kafka] chia7712 closed pull request #8840: KAFKA-10129 Fail QA if there are javadoc warnings

2020-09-02 Thread GitBox
chia7712 closed pull request #8840: URL: https://github.com/apache/kafka/pull/8840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 closed pull request #9185: MINOR: use the link of JDK 11 to replace the dynamic url when buildin…

2020-09-02 Thread GitBox
chia7712 closed pull request #9185: URL: https://github.com/apache/kafka/pull/9185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9215: KAFKA-10133: MM2 readme update on config

2020-09-02 Thread GitBox
ning2008wisc commented on a change in pull request #9215: URL: https://github.com/apache/kafka/pull/9215#discussion_r482214035 ## File path: connect/mirror/README.md ## @@ -141,7 +141,38 @@ nearby clusters. N.B. that the `--clusters` parameter is not technically required here.

[GitHub] [kafka] LMnet commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
LMnet commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685863455 @ijuma kafka users will not be affected by this, because shadowing conflict occurs only in the kafka internal packages. ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482234612 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -311,13 +322,8 @@ private void

[GitHub] [kafka] vvcephei commented on a change in pull request #9191: KAFKA-10355: Throw error when source topic was deleted

2020-09-02 Thread GitBox
vvcephei commented on a change in pull request #9191: URL: https://github.com/apache/kafka/pull/9191#discussion_r482250207 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/HandlingSourceTopicDeletionTest.java ## @@ -0,0 +1,109 @@ +/* + * License

[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
vvcephei commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685893240 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
vvcephei commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685893473 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
vvcephei commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685895615 Thanks for the reviews, all. I also took a look at the builds, and they seem fine apart from the flaky tests. Th

[GitHub] [kafka] vvcephei merged pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
vvcephei merged pull request #9245: URL: https://github.com/apache/kafka/pull/9245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #9245: MINOR: Fix build scala 2.12 build after KAFKA-10020

2020-09-02 Thread GitBox
vvcephei commented on pull request #9245: URL: https://github.com/apache/kafka/pull/9245#issuecomment-685897537 Ok, I just merged this. Sorry for breaking the build, all. And thanks @mumrah for getting the PR builds working again! --

[GitHub] [kafka] vvcephei commented on pull request #8955: KAFKA-10020: Create a new version of a scala Serdes without name clash (KIP-616)

2020-09-02 Thread GitBox
vvcephei commented on pull request #8955: URL: https://github.com/apache/kafka/pull/8955#issuecomment-685904266 Thanks for pointing that out, @chia7712 , and sorry for breaking the build. This is an automated message from the

[GitHub] [kafka] DOJI45 opened a new pull request #9247: KAFKA-10362: When resuming Streams active task with EOS, the checkpoint file is deleted

2020-09-02 Thread GitBox
DOJI45 opened a new pull request #9247: URL: https://github.com/apache/kafka/pull/9247 What was the issue? https://issues.apache.org/jira/browse/KAFKA-10362 Deleted the checkpoint file before the transition from SUSPENDED state to RESTORING state ### Committer Checklist (e

[GitHub] [kafka] lct45 opened a new pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

2020-09-02 Thread GitBox
lct45 opened a new pull request #9248: URL: https://github.com/apache/kafka/pull/9248 Updated number of expected messages ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Commented] (KAFKA-8764) LogCleanerManager endless loop while compacting/cleaning segments

2020-09-02 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189628#comment-17189628 ] James Cheng commented on KAFKA-8764: [~junrao], in the comment https://issues.apache

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-09-02 Thread Sharath Bhat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189629#comment-17189629 ] Sharath Bhat commented on KAFKA-10362: -- Hi [~guozhang],  I worked on the bug and h

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482297669 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,127 @@ public voi

[GitHub] [kafka] asdaraujo commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-09-02 Thread GitBox
asdaraujo commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-685935118 Thanks, @mimaison . I've rebased it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-02 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482324434 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,127 @@ public void proce

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

2020-09-02 Thread GitBox
vvcephei commented on pull request #9234: URL: https://github.com/apache/kafka/pull/9234#issuecomment-685944151 Thanks, all! This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [kafka] vvcephei commented on pull request #9234: MINOR: Record all poll invocations

2020-09-02 Thread GitBox
vvcephei commented on pull request #9234: URL: https://github.com/apache/kafka/pull/9234#issuecomment-685946978 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] rondagostino commented on pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-09-02 Thread GitBox
rondagostino commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-685957655 System test run was successful except for 2 known flaky tests. https://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-09-02--001.159907492

[GitHub] [kafka] nresare commented on pull request #9122: KAFKA-10314: KafkaStorageException on reassignment when offline log d…

2020-09-02 Thread GitBox
nresare commented on pull request #9122: URL: https://github.com/apache/kafka/pull/9122#issuecomment-685964373 Trying to navigate the tests, it seems they are related to flakiness in other parts of the overall test suite. Is it possible to re-trigger tests? ---

[jira] [Commented] (KAFKA-8764) LogCleanerManager endless loop while compacting/cleaning segments

2020-09-02 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189684#comment-17189684 ] Jun Rao commented on KAFKA-8764: [~wushujames]: Yes, reassigned replica can have the same

[jira] [Assigned] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

2020-09-02 Thread Oleksandr Bondarenko (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Bondarenko reassigned KAFKA-10409: Assignee: Oleksandr Bondarenko > Refactor Kafka Streams RocksDb iterators

[GitHub] [kafka] rondagostino commented on pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

2020-09-02 Thread GitBox
rondagostino commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-685977755 Test failures are flakes/unrelated to this PR, no overlaps across JDKs. This is an automated message from the

[GitHub] [kafka] vvcephei commented on pull request #9221: KAFKA-10436: Implement KIP-478 Topology changes

2020-09-02 Thread GitBox
vvcephei commented on pull request #9221: URL: https://github.com/apache/kafka/pull/9221#issuecomment-685985893 Note: this is part 3 of KIP-478. Part 1: #9004 Part 2: #9148 This is an automated message from the Apache G

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-09-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189711#comment-17189711 ] Matthias J. Sax commented on KAFKA-10362: - [~DOJI], even if the ticket was not a

[GitHub] [kafka] ableegoldman commented on a change in pull request #9239: Adding reverse iterator usage for sliding windows processing (extending KIP-450)

2020-09-02 Thread GitBox
ableegoldman commented on a change in pull request #9239: URL: https://github.com/apache/kafka/pull/9239#discussion_r482435367 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -180,41 +217,225 @@ public voi

[GitHub] [kafka] ableegoldman commented on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

2020-09-02 Thread GitBox
ableegoldman commented on pull request #9248: URL: https://github.com/apache/kafka/pull/9248#issuecomment-686044360 One unrelated test failed: `Build / JDK 8 / testNoConnectionLimitsByDefault – kafka.network.ConnectionQuotasTest` Also, why are there so many different builds now?

[GitHub] [kafka] ableegoldman edited a comment on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

2020-09-02 Thread GitBox
ableegoldman edited a comment on pull request #9248: URL: https://github.com/apache/kafka/pull/9248#issuecomment-686044360 One unrelated test failed: `Build / JDK 8 / testNoConnectionLimitsByDefault – kafka.network.ConnectionQuotasTest` Also, why are there so many different builds

[jira] [Updated] (KAFKA-10323) NullPointerException during rebalance

2020-09-02 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10323: -- Labels: newbie (was: ) > NullPointerException during rebalance >

[jira] [Updated] (KAFKA-10273) Connect Converters should produce actionable error messages

2020-09-02 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10273: -- Labels: newbie (was: ) > Connect Converters should produce actionable error messages > --

[jira] [Comment Edited] (KAFKA-10366) TimeWindowedDeserializer doesn't allow users to set a custom window size

2020-09-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189725#comment-17189725 ] Matthias J. Sax edited comment on KAFKA-10366 at 9/2/20, 9:58 PM:

[jira] [Commented] (KAFKA-10366) TimeWindowedDeserializer doesn't allow users to set a custom window size

2020-09-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189725#comment-17189725 ] Matthias J. Sax commented on KAFKA-10366: - SGTM. And no worries about naming. It

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482524622 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -150,13 +185,25 @@ * @return an iterator over windowed

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482526159 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java ## @@ -117,12 +118,20 @@ public void openExisting(f

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482525737 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -136,34 +174,64 @@ * * This iterator mu

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r480473830 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -67,14 +70,22 @@ public Bytes peekNextKey() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r482528601 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java ## @@ -338,25 +452,36 @@ public synchronized void

[GitHub] [kafka] guozhangwang merged pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

2020-09-02 Thread GitBox
guozhangwang merged pull request #9138: URL: https://github.com/apache/kafka/pull/9138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vvcephei commented on pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

2020-09-02 Thread GitBox
vvcephei commented on pull request #9248: URL: https://github.com/apache/kafka/pull/9248#issuecomment-686058224 Yep, that looks like the only test that failed. Thanks, @ableegoldman . Yes, the checks output leaves something to be desired. I don't know how easy/possible it is to impro

[GitHub] [kafka] vvcephei merged pull request #9248: MINOR: Patch for KStreamAggregationIntegrationTest.shouldAggregateSlidingWindows

2020-09-02 Thread GitBox
vvcephei merged pull request #9248: URL: https://github.com/apache/kafka/pull/9248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang merged pull request #9232: KAFKA-9924: Add remaining property-based RocksDB metrics as described in KIP-607

2020-09-02 Thread GitBox
guozhangwang merged pull request #9232: URL: https://github.com/apache/kafka/pull/9232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-09-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189767#comment-17189767 ] Matthias J. Sax commented on KAFKA-10448: - Just added you to the wiki. {quote}Ne

[GitHub] [kafka] mjsax commented on pull request #9244: Consolidate duplicated logic on reset tools

2020-09-02 Thread GitBox
mjsax commented on pull request #9244: URL: https://github.com/apache/kafka/pull/9244#issuecomment-686152827 @brary Wanna help reviewing this PR? This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] guozhangwang commented on pull request #9234: MINOR: Record all poll invocations

2020-09-02 Thread GitBox
guozhangwang commented on pull request #9234: URL: https://github.com/apache/kafka/pull/9234#issuecomment-686177562 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-09-02 Thread satya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189790#comment-17189790 ] satya commented on KAFKA-10448: --- Thank you. I submitted the KIP-669. Please let me know if

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-02 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r482678606 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -288,17 +288,17 @@ public void comp

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-02 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r482678606 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -288,17 +288,17 @@ public void comp

[jira] [Commented] (KAFKA-10362) When resuming Streams active task with EOS, the checkpoint file should be deleted

2020-09-02 Thread Sharath Bhat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189831#comment-17189831 ] Sharath Bhat commented on KAFKA-10362: -- Hi [~ipasynkov],  Can I continue work on t

[GitHub] [kafka] brary commented on pull request #9244: Consolidate duplicated logic on reset tools

2020-09-02 Thread GitBox
brary commented on pull request #9244: URL: https://github.com/apache/kafka/pull/9244#issuecomment-686244886 > @brary Wanna help reviewing this PR? Sure @mjsax, would be happy to pitch in. This is an automated message

  1   2   >