[jira] [Commented] (KAFKA-10266) Fix connector configs in docs to mention the correct default value inherited from worker configs

2020-07-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167681#comment-17167681 ] Luke Chen commented on KAFKA-10266: --- [PR: https://github.com/apache/kafka/pull/9104|h

[GitHub] [kafka] ijuma commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
ijuma commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-665828744 What were the throughput numbers? I assume you meant the connsumer perf test, not console consumer. This is an auto

[GitHub] [kafka] abbccdda merged pull request #9081: KAFKA-10309: KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-07-30 Thread GitBox
abbccdda merged pull request #9081: URL: https://github.com/apache/kafka/pull/9081 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mumrah commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
mumrah commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-665845747 @ijuma you're right, i meant the consumer perf test. I updated my comment to clarify This is an automated message

[GitHub] [kafka] abbccdda commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-07-30 Thread GitBox
abbccdda commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r462453975 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,71 @@ default AlterClientQuotasResult alterClientQuotas(

[GitHub] [kafka] abbccdda closed pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for non validation calls

2020-07-30 Thread GitBox
abbccdda closed pull request #8940: URL: https://github.com/apache/kafka/pull/8940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] hachikuji commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
hachikuji commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-665938546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon opened a new pull request #9104: KAFKA-10266: Update the connector config header.converter

2020-07-30 Thread GitBox
showuon opened a new pull request #9104: URL: https://github.com/apache/kafka/pull/9104 After my update, the original wrong statement will be removed. > By default, the SimpleHeaderConverter is used to . And it'll be replaced with the following, with hyperlink to the worker c

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-30 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r462489390 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -2090,6 +2093,12 @@ case class ReplicaLeaderElection( callback: ElectLeade

[GitHub] [kafka] apovzner commented on a change in pull request #9072: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

2020-07-30 Thread GitBox
apovzner commented on a change in pull request #9072: URL: https://github.com/apache/kafka/pull/9072#discussion_r462645570 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] guozhangwang commented on pull request #9095: KAFKA-10321: fix infinite blocking for global stream thread startup

2020-07-30 Thread GitBox
guozhangwang commented on pull request #9095: URL: https://github.com/apache/kafka/pull/9095#issuecomment-665967044 LGTM. Please feel free to merge and cherry-pick. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] showuon commented on pull request #9104: KAFKA-10266: Update the connector config header.converter

2020-07-30 Thread GitBox
showuon commented on pull request #9104: URL: https://github.com/apache/kafka/pull/9104#issuecomment-666170759 @kkonstantine , could you help review this PR to correct the documentation. Thanks. This is an automated message

[GitHub] [kafka] abbccdda merged pull request #9095: KAFKA-10321: fix infinite blocking for global stream thread startup

2020-07-30 Thread GitBox
abbccdda merged pull request #9095: URL: https://github.com/apache/kafka/pull/9095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mumrah edited a comment on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
mumrah edited a comment on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-665795947 I ran the consumer perf test (at @hachikuji's suggestion) and took a profile. Throughput was around 500MB/s on trunk and on this branch ![image](https://user-images.g

[GitHub] [kafka] abbccdda merged pull request #9012: KAFKA-10270: A broker to controller channel manager

2020-07-30 Thread GitBox
abbccdda merged pull request #9012: URL: https://github.com/apache/kafka/pull/9012 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] kkonstantine commented on pull request #8854: KAFKA-10146, KAFKA-9066: Retain metrics for failed tasks (#8502)

2020-07-30 Thread GitBox
kkonstantine commented on pull request #8854: URL: https://github.com/apache/kafka/pull/8854#issuecomment-665952918 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] abbccdda commented on pull request #9095: KAFKA-10321: fix infinite blocking for global stream thread startup

2020-07-30 Thread GitBox
abbccdda commented on pull request #9095: URL: https://github.com/apache/kafka/pull/9095#issuecomment-665999727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] abbccdda opened a new pull request #9103: Add redirection for (Incremental)AlterConfig

2020-07-30 Thread GitBox
abbccdda opened a new pull request #9103: URL: https://github.com/apache/kafka/pull/9103 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] abbccdda commented on pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for non validation calls

2020-07-30 Thread GitBox
abbccdda commented on pull request #8940: URL: https://github.com/apache/kafka/pull/8940#issuecomment-666091752 Will close this PR as the KIP-590 requirement changes This is an automated message from the Apache Git Service. T

[GitHub] [kafka] mumrah opened a new pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-07-30 Thread GitBox
mumrah opened a new pull request #9100: URL: https://github.com/apache/kafka/pull/9100 WIP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] junrao commented on a change in pull request #9072: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

2020-07-30 Thread GitBox
junrao commented on a change in pull request #9072: URL: https://github.com/apache/kafka/pull/9072#discussion_r462624834 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] dielhennr opened a new pull request #9101: KAFKA-10325: KIP-649 implementation

2020-07-30 Thread GitBox
dielhennr opened a new pull request #9101: URL: https://github.com/apache/kafka/pull/9101 This is the initial implementation of [KIP-649](https://cwiki.apache.org/confluence/pages/resumedraft.action?draftId=158869615&draftShareId=c349fbe8-7aa8-4fde-a8e4-8d719cda3b9a&;) which implements dyn

[GitHub] [kafka] guozhangwang commented on a change in pull request #9095: KAFKA-10321: fix infinite blocking for global stream thread startup

2020-07-30 Thread GitBox
guozhangwang commented on a change in pull request #9095: URL: https://github.com/apache/kafka/pull/9095#discussion_r462589015 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java ## @@ -173,6 +178,18 @@ public boolean stillR

[jira] [Commented] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2020-07-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167720#comment-17167720 ] Bruno Cadonna commented on KAFKA-7540: -- https://builds.apache.org/job/kafka-pr-jdk11

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2020-07-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167726#comment-17167726 ] Bruno Cadonna commented on KAFKA-9013: -- https://builds.apache.org/job/kafka-pr-jdk8-

[jira] [Commented] (KAFKA-10255) Fix flaky testOneWayReplicationWithAutorOffsetSync1 test

2020-07-30 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167727#comment-17167727 ] Bruno Cadonna commented on KAFKA-10255: --- https://builds.apache.org/job/kafka-pr-jd

[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

2020-07-30 Thread GitBox
cadonna commented on pull request #9087: URL: https://github.com/apache/kafka/pull/9087#issuecomment-666202514 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] chia7712 commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

2020-07-30 Thread GitBox
chia7712 commented on pull request #9087: URL: https://github.com/apache/kafka/pull/9087#issuecomment-666205937 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] dajac commented on a change in pull request #9072: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

2020-07-30 Thread GitBox
dajac commented on a change in pull request #9072: URL: https://github.com/apache/kafka/pull/9072#discussion_r462846252 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] mimaison commented on pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-30 Thread GitBox
mimaison commented on pull request #9007: URL: https://github.com/apache/kafka/pull/9007#issuecomment-666239450 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mimaison commented on pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-30 Thread GitBox
mimaison commented on pull request #9007: URL: https://github.com/apache/kafka/pull/9007#issuecomment-666256788 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-07-30 Thread GitBox
cadonna commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r462881933 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java ## @@ -668,6 +671,9 @@ private void checkKeyValueStore

[GitHub] [kafka] cadonna commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-07-30 Thread GitBox
cadonna commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r462882926 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetrics.java ## @@ -443,6 +447,25 @@ public static Sensor su

[GitHub] [kafka] cadonna commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

2020-07-30 Thread GitBox
cadonna commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r462883347 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/StateStoreMetricsTest.java ## @@ -327,6 +327,38 @@ public void shouldG

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-30 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-666310163 @dajac Ok, I've removed the `Optional` to `Option` changes This is an automated message from the Apache Git Servi

[GitHub] [kafka] cadonna commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

2020-07-30 Thread GitBox
cadonna commented on pull request #9087: URL: https://github.com/apache/kafka/pull/9087#issuecomment-666311943 Java 14 failed due to the following failing test: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true] ```

[jira] [Created] (KAFKA-10327) Make flush after some count of putted records in SinkTask

2020-07-30 Thread Pavel Kuznetsov (Jira)
Pavel Kuznetsov created KAFKA-10327: --- Summary: Make flush after some count of putted records in SinkTask Key: KAFKA-10327 URL: https://issues.apache.org/jira/browse/KAFKA-10327 Project: Kafka

[GitHub] [kafka] chia7712 commented on pull request #9087: HOTFIX: Set session timeout and heartbeat interval to default to decrease flakiness

2020-07-30 Thread GitBox
chia7712 commented on pull request #9087: URL: https://github.com/apache/kafka/pull/9087#issuecomment-666325276 ```EosBetaUpgradeIntegrationTest``` pass on my local. retest this please This is an automated message from the Ap

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-07-30 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-666325552 ```EosBetaUpgradeIntegrationTest``` is flaky... retest this please This is an automated message from the Apache G

[GitHub] [kafka] mimaison commented on pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-30 Thread GitBox
mimaison commented on pull request #9007: URL: https://github.com/apache/kafka/pull/9007#issuecomment-666353178 Failures look unrelated: - org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true] FAILED - org.apache.kafka.connect.mi

[GitHub] [kafka] mimaison merged pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

2020-07-30 Thread GitBox
mimaison merged pull request #9007: URL: https://github.com/apache/kafka/pull/9007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10120) DescribeLogDirsResult exposes internal classes

2020-07-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10120. Fix Version/s: 2.7 Resolution: Fixed > DescribeLogDirsResult exposes internal class

[GitHub] [kafka] mimaison commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
mimaison commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r462989546 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -345,15 +342,24 @@ private void wai

[jira] [Assigned] (KAFKA-10048) Possible data gap for a consumer after a failover when using MM2

2020-07-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10048: -- Assignee: Andre Araujo > Possible data gap for a consumer after a failover when using

[jira] [Assigned] (KAFKA-10048) Possible data gap for a consumer after a failover when using MM2

2020-07-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10048: -- Assignee: (was: Mickael Maison) > Possible data gap for a consumer after a failov

[jira] [Assigned] (KAFKA-10048) Possible data gap for a consumer after a failover when using MM2

2020-07-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-10048: -- Assignee: Mickael Maison > Possible data gap for a consumer after a failover when usi

[GitHub] [kafka] mumrah commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
mumrah commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-666374043 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463026843 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] showuon commented on a change in pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
showuon commented on a change in pull request #9029: URL: https://github.com/apache/kafka/pull/9029#discussion_r463028636 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -345,15 +342,24 @@ private void wait

[GitHub] [kafka] showuon commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
showuon commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-666395292 @mimaison , thanks for your good suggestion! I've updated in this commit: https://github.com/apache/kafka/pull/9029/commits/8bc4a543dda6ddd90d752f7e6a64c63d85a1de3f. Thanks. ---

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463036048 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-30 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-666398632 > 2 system test failures in the latest PR those 2 failed tests are flaky on my local and there are issue/PR related to them. @junrao @ijuma @hachikuji @rajinisivaram

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463039985 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,254 @@ +/* + * Licensed to the A

[GitHub] [kafka] dajac commented on pull request #9091: MINOR; Make KafkaAdminClientTest.testDescribeLogDirsPartialFailure and KafkaAdminClientTest.testAlterReplicaLogDirsPartialFailure test more reli

2020-07-30 Thread GitBox
dajac commented on pull request #9091: URL: https://github.com/apache/kafka/pull/9091#issuecomment-666402566 rebased to fix conflicts. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] ijuma commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-30 Thread GitBox
ijuma commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-666403581 @junrao Thanks for the summary. With regards to the thread pool option, would this be used for completion of delayed operations for the group coordinator only? When it comes to tuni

[GitHub] [kafka] ijuma commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-30 Thread GitBox
ijuma commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r463044371 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int, }

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463046306 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463047237 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463056420 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] dajac commented on a change in pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

2020-07-30 Thread GitBox
dajac commented on a change in pull request #9092: URL: https://github.com/apache/kafka/pull/9092#discussion_r463056307 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,7 +103,7 @@ object DynamicConfig { .define(ProducerByteRateOverrideProp,

[GitHub] [kafka] vvcephei merged pull request #9097: KAFKA-10319: Skip unknown offsets when computing sum of changelog offsets

2020-07-30 Thread GitBox
vvcephei merged pull request #9097: URL: https://github.com/apache/kafka/pull/9097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] rajinisivaram commented on pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

2020-07-30 Thread GitBox
rajinisivaram commented on pull request #9092: URL: https://github.com/apache/kafka/pull/9092#issuecomment-666428695 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] rajinisivaram commented on pull request #9092: KAFKA-10163; Define `controller_mutation_rate` as a Double instead of a Long

2020-07-30 Thread GitBox
rajinisivaram commented on pull request #9092: URL: https://github.com/apache/kafka/pull/9092#issuecomment-666429262 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463063406 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-30 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r463066191 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-30 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r463066323 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463073842 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463076565 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463077196 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463078058 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463083346 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463083821 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463088582 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463088582 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463091437 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

2020-07-30 Thread GitBox
lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r463092579 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,428 @@ +/* + * Licensed to th

[jira] [Commented] (KAFKA-10283) Consolidate client-level and consumer-level assignment within ClientState

2020-07-30 Thread highluck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168029#comment-17168029 ] highluck commented on KAFKA-10283: -- [~guozhang] Can I pick this issue? Is there any s

[GitHub] [kafka] mimaison commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
mimaison commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-666512651 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-07-30 Thread GitBox
vvcephei commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r463128398 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,23 +181,39 @@ void openDB(final ProcessorContext

[GitHub] [kafka] vvcephei commented on a change in pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

2020-07-30 Thread GitBox
vvcephei commented on a change in pull request #9098: URL: https://github.com/apache/kafka/pull/9098#discussion_r463128398 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -181,23 +181,39 @@ void openDB(final ProcessorContext

[GitHub] [kafka] mimaison commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-07-30 Thread GitBox
mimaison commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r463097918 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -367,14 +406,37 @@ public void testO

[GitHub] [kafka] mimaison commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
mimaison commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-666526465 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mumrah commented on pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
mumrah commented on pull request #9008: URL: https://github.com/apache/kafka/pull/9008#issuecomment-666531948 These test failures are known flaky tests which already have jira tickets This is an automated message from the Apa

[GitHub] [kafka] highluck opened a new pull request #9105: MINOR: closable object Memory leak prevention

2020-07-30 Thread GitBox
highluck opened a new pull request #9105: URL: https://github.com/apache/kafka/pull/9105 closable object Memory leak prevention ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] mumrah merged pull request #9008: KAFKA-9629 Use generated protocol for Fetch API

2020-07-30 Thread GitBox
mumrah merged pull request #9008: URL: https://github.com/apache/kafka/pull/9008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10283) Consolidate client-level and consumer-level assignment within ClientState

2020-07-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168100#comment-17168100 ] Guozhang Wang commented on KAFKA-10283: --- Sure [~high.lee]. I'd suggest you get fam

[GitHub] [kafka] abbccdda commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-30 Thread GitBox
abbccdda commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-666590526 @mimaison Could you rebase? This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-10328) MockConsumer behaves differently than KafkaConsumer

2020-07-30 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-10328: Summary: MockConsumer behaves differently than KafkaConsumer Key: KAFKA-10328 URL: https://issues.apache.org/jira/browse/KAFKA-10328 Project: Kafka Issue Type: Bug

[GitHub] [kafka] rhauch opened a new pull request #9106: KAFKA-10146, KAFKA-9066: Retain metrics for failed taskss (#8502)

2020-07-30 Thread GitBox
rhauch opened a new pull request #9106: URL: https://github.com/apache/kafka/pull/9106 Targets the `2.4` branch. See #8854 for the similar PR for the `2.5` branch, which is currently blocked by the 2.5.1 release effort. This backports the KAFKA-9066 / #8502 changes to retain metrics

[jira] [Commented] (KAFKA-10322) InMemoryWindowStore restore keys format incompatibility (lack of sequenceNumber in keys on topic)

2020-07-30 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168155#comment-17168155 ] Sophie Blee-Goldman commented on KAFKA-10322: - Hey [~tbradlo] Thanks for th

[jira] [Commented] (KAFKA-10146) Backport KAFKA-9066 to 2.5 and 2.4 branches

2020-07-30 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168157#comment-17168157 ] Randall Hauch commented on KAFKA-10146: --- Since the 2.5.1 release is still ongoing,

[GitHub] [kafka] rhauch commented on pull request #9106: KAFKA-10146, KAFKA-9066: Retain metrics for failed tasks (backport to 2.4)

2020-07-30 Thread GitBox
rhauch commented on pull request #9106: URL: https://github.com/apache/kafka/pull/9106#issuecomment-11491 @kkonstantine, here is a PR for the `2.4` branch that is a cherry-pick of the same one commit from #8854 that you've already approved.

[jira] [Created] (KAFKA-10329) Enable connector context in logs by default

2020-07-30 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10329: - Summary: Enable connector context in logs by default Key: KAFKA-10329 URL: https://issues.apache.org/jira/browse/KAFKA-10329 Project: Kafka Issue Type: Imp

[jira] [Commented] (KAFKA-10322) InMemoryWindowStore restore keys format incompatibility (lack of sequenceNumber in keys on topic)

2020-07-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168167#comment-17168167 ] Tomasz Bradło commented on KAFKA-10322: --- Hi [~ableegoldman]  I don't know what is

[GitHub] [kafka] abbccdda commented on a change in pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

2020-07-30 Thread GitBox
abbccdda commented on a change in pull request #9096: URL: https://github.com/apache/kafka/pull/9096#discussion_r463260878 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -163,6 +183,7 @@ private boolean allSubs

[GitHub] [kafka] mimaison merged pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-30 Thread GitBox
mimaison merged pull request #9029: URL: https://github.com/apache/kafka/pull/9029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-07-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168214#comment-17168214 ] Mickael Maison commented on KAFKA-10017: A couple of more failures: - https://bu

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-07-30 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-666701712 @abbccdda Done! This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-10322) InMemoryWindowStore restore keys format incompatibility (lack of sequenceNumber in keys on topic)

2020-07-30 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168231#comment-17168231 ] Sophie Blee-Goldman commented on KAFKA-10322: - Ok, I dug into this a big fur

[jira] [Commented] (KAFKA-10137) Clean-up retain Duplicate logic in Window Stores

2020-07-30 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168234#comment-17168234 ] Sophie Blee-Goldman commented on KAFKA-10137: - I think there's actually a re

  1   2   >