[
https://issues.apache.org/jira/browse/KAFKA-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152523#comment-17152523
]
Stanislav Kozlovski commented on KAFKA-7304:
Given that this Jira is for repo
dajac commented on pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#issuecomment-654671084
Investigating this.
This is an automated message from the Apache Git Service.
To respond to the message, please log
rajinisivaram commented on a change in pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#discussion_r450706026
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -786,6 +809,29 @@ private void handleAbortedSends(List
response
Rajini Sivaram created KAFKA-10243:
--
Summary: ConcurrentModificationException while processing
connection setup timeouts
Key: KAFKA-10243
URL: https://issues.apache.org/jira/browse/KAFKA-10243
Projec
omkreddy commented on pull request #8885:
URL: https://github.com/apache/kafka/pull/8885#issuecomment-654729182
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rajinisivaram commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654729231
@ijuma @hachikuji Thank you, I guess we need a KIP anyway even for renaming
`NOT_LEADER_FOR_PARTITION`. We can discuss the options during KIP discussion.
My only concern ab
dongjinleekr commented on pull request #8150:
URL: https://github.com/apache/kafka/pull/8150#issuecomment-654736525
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, plea
dongjinleekr edited a comment on pull request #8150:
URL: https://github.com/apache/kafka/pull/8150#issuecomment-649403477
Rebased onto the latest trunk and I reviewed the problem more carefully and
here is the summary:
1. As @kkonstantine stated, [the default value of `retries` conf
dajac opened a new pull request #8990:
URL: https://github.com/apache/kafka/pull/8990
This PR fixes a bug introduced in https://github.com/apache/kafka/pull/8683/.
While processing connection set up timeouts, we are iterating through the
connecting nodes to process timeouts and we di
rajinisivaram commented on pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#issuecomment-654748250
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rajinisivaram commented on a change in pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#discussion_r450752852
##
File path:
clients/src/test/java/org/apache/kafka/clients/ClusterConnectionStatesTest.java
##
@@ -365,4 +367,48 @@ public void testExponentialConn
dajac commented on a change in pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#discussion_r450756672
##
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##
@@ -440,6 +441,20 @@ public boolean isConnectionSetupTimeout(Str
dajac commented on pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#issuecomment-654752598
@rajinisivaram Thanks for the review. I just pushed an update that addresses
your feedback.
This is an automated me
rajinisivaram commented on pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#issuecomment-654755355
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
mimaison commented on pull request #8984:
URL: https://github.com/apache/kafka/pull/8984#issuecomment-654782138
@huxihx As @dajac mentioned, I also envisioned doing this check on the
broker side.
I actually initially hit this issue with a 3rd party client and just
included the kafka
[
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152701#comment-17152701
]
Adam Bellemare commented on KAFKA-9168:
---
This would be incredibly useful for improv
ijuma commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r450843637
##
File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala
##
@@ -148,5 +148,39 @@ class TimeIndexTest {
idx.close()
}
-}
+ /**
+ * I
ijuma commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r450844571
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we will reco
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654842200
Renaming the error code name has no compatibility implications so in theory
it could be done without a KIP. We could make this really boring and safe and
call it `NOT_LEADER_OR_FOLL
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654843181
If you both agree that the name above is reasonable, I would suggest sending
a follow up to the KIP-320 thread covering what we've learned and how we're
addressing it. It would be g
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654844522
One issue is that the exception `NotLeaderForPartitionException` is in a
public package. We could introduce a subclass, alwayys throw the subclass and
deprecate `NotLeaderForPartiti
dongjinleekr removed a comment on pull request #7204:
URL: https://github.com/apache/kafka/pull/7204#issuecomment-653769037
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the messa
rajinisivaram commented on pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#issuecomment-654860922
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, plea
dongjinleekr commented on pull request #7204:
URL: https://github.com/apache/kafka/pull/7204#issuecomment-654863820
@mimaison Hi. I updated the PR and submitted the
[KIP](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866169).
I know that you must be on working frenzy
dongjinleekr commented on pull request #7204:
URL: https://github.com/apache/kafka/pull/7204#issuecomment-654864266
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, pleas
dongjinleekr removed a comment on pull request #7204:
URL: https://github.com/apache/kafka/pull/7204#issuecomment-654864266
Retest this please
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/KAFKA-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tom Bentley reassigned KAFKA-10241:
---
Assignee: Tom Bentley
> Pursue a better way to cover ignorable RPC fields
> --
[
https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria Bialas reassigned KAFKA-6453:
--
Assignee: (was: Victoria Bialas)
> Reconsider timestamp propagation semantics
> --
mimaison commented on pull request #7204:
URL: https://github.com/apache/kafka/pull/7204#issuecomment-654883342
In the meantime, someone else had submitted a KIP for this change:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109. I
see both KIPs have active threads
[
https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152765#comment-17152765
]
Victoria Bialas commented on KAFKA-6453:
Hi [~mjsax], I tried to re-assign this t
[
https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victoria Bialas reassigned KAFKA-6453:
--
Assignee: Victoria Bialas
> Reconsider timestamp propagation semantics
> -
rajinisivaram commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654897593
@ijuma Sounds good to me. Will see what @hachikuji thinks as well.
This is an automated message from the Apa
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654900194
Also cc @edenhill as this affects non Java clients too.
This is an automated message from the Apache Git Service.
To
vvcephei commented on a change in pull request #8962:
URL: https://github.com/apache/kafka/pull/8962#discussion_r450513288
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -270,8 +270,11 @@ public void handleAssignment(fin
huxihx commented on pull request #7711:
URL: https://github.com/apache/kafka/pull/7711#issuecomment-654901088
@junrao Sorry for the long delay. Please review this patch again.
This is an automated message from the Apache Git
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654904651
We may also want to deprecate the error and exception for
ReplicaNotAvailable since it would not serve any purpose, I think.
---
ijuma edited a comment on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654904651
We may also want to deprecate the error and exception for
ReplicaNotAvailable since it would not serve any purpose (apart from clients
retaining compatibility with some broke
edenhill commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654911887
Renaming to NOT_LEADER_OR_FOLLOWER and reusing that error code in place of
REPLICA_NOT_AVAILABLE sounds like a good idea. :+1:
--
cmccabe commented on pull request #8985:
URL: https://github.com/apache/kafka/pull/8985#issuecomment-654912275
good find, @dajac! LGTM pending Jenkins
This is an automated message from the Apache Git Service.
To respond to t
huxihx commented on pull request #8984:
URL: https://github.com/apache/kafka/pull/8984#issuecomment-654913649
@mimaison @dajac If that's the case, I agree to move the logic into broker
side. However, I suggest we keep the current refinement in `TopicCommand` and
`ConfigCommand` since these
[
https://issues.apache.org/jira/browse/KAFKA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152797#comment-17152797
]
John Roesler commented on KAFKA-10243:
--
Hey all, it seems like this is fixing a reg
cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450921851
##
File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java
##
@@ -92,6 +93,8 @@
private final Time time;
+final TrogdorMetrics
cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450505811
##
File path:
tools/src/main/java/org/apache/kafka/trogdor/coordinator/Coordinator.java
##
@@ -70,6 +70,8 @@
private final Time time;
+final T
vvcephei commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-654916732
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152805#comment-17152805
]
David Jacot commented on KAFKA-10243:
-
[~vvcephei] This only affects trunk AFAIK.
>
akatona84 commented on a change in pull request #8019:
URL: https://github.com/apache/kafka/pull/8019#discussion_r450931353
##
File path: README.md
##
@@ -48,6 +48,13 @@ Change the log4j setting in either
`clients/src/test/resources/log4j.properties`
./gradlew clients:t
Chia-Ping Tsai created KAFKA-10244:
--
Summary: An new java interface to replace
'kafka.common.MessageReader'
Key: KAFKA-10244
URL: https://issues.apache.org/jira/browse/KAFKA-10244
Project: Kafka
vvcephei commented on pull request #8987:
URL: https://github.com/apache/kafka/pull/8987#issuecomment-654946672
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
hachikuji commented on a change in pull request #8934:
URL: https://github.com/apache/kafka/pull/8934#discussion_r450960971
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1218,17 +1218,20 @@ public void assign(Collection
partit
vvcephei commented on a change in pull request #8987:
URL: https://github.com/apache/kafka/pull/8987#discussion_r450961919
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -251,7 +252,7 @@ void restoreAl
vvcephei commented on pull request #8987:
URL: https://github.com/apache/kafka/pull/8987#issuecomment-654951589
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/KAFKA-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152831#comment-17152831
]
David Jacot commented on KAFKA-9630:
[~mimaison] Are you working on this one? If not,
rajinisivaram commented on pull request #8990:
URL: https://github.com/apache/kafka/pull/8990#issuecomment-654954129
@dajac Thanks for the fix - wow, green build, haven't seen that in a while!
Merging to trunk.
This is an au
rajinisivaram merged pull request #8990:
URL: https://github.com/apache/kafka/pull/8990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-10243.
Reviewer: Rajini Sivaram
Resolution: Fixed
> ConcurrentModificationException while p
[
https://issues.apache.org/jira/browse/KAFKA-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152837#comment-17152837
]
Mickael Maison commented on KAFKA-9630:
---
No I have not started yet, so go for it!
[
https://issues.apache.org/jira/browse/KAFKA-9630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-9630:
--
Assignee: David Jacot (was: Mickael Maison)
> Replace OffsetsForLeaderEpoch request/response
hachikuji commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654959200
`NOT_LEADER_OR_FOLLOWER` sounds good to me. If we're looking to attach the
change to a KIP, then KIP-392 might be a better option.
-
[
https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152848#comment-17152848
]
Dima R commented on KAFKA-10017:
Hi [~ableegoldman],
I just found that
shouldUpgradeF
hachikuji commented on a change in pull request #8934:
URL: https://github.com/apache/kafka/pull/8934#discussion_r450978217
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1218,17 +1218,20 @@ public void assign(Collection
partit
ijuma commented on pull request #8979:
URL: https://github.com/apache/kafka/pull/8979#issuecomment-654965817
KIP-392 sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152848#comment-17152848
]
Dima R edited comment on KAFKA-10017 at 7/7/20, 4:09 PM:
-
Hi [~a
vvcephei commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r450979875
##
File path:
streams/src/test/java/org/apache/kafka/test/InternalMockProcessorContext.java
##
@@ -193,6 +194,11 @@ public InternalMockProcessorContext(fi
[
https://issues.apache.org/jira/browse/KAFKA-10243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152856#comment-17152856
]
John Roesler commented on KAFKA-10243:
--
Thanks, [~dajac] !
> ConcurrentModificatio
vvcephei commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-654971292
Thanks, @chia7712 , your response makes sense.
This is an automated message from the Apache Git Service.
To respo
hachikuji commented on a change in pull request #8934:
URL: https://github.com/apache/kafka/pull/8934#discussion_r450978217
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##
@@ -1218,17 +1218,20 @@ public void assign(Collection
partit
vvcephei commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-654972949
I'm sure you did this locally, but I'm running the system tests one more
time, just to be on the safe side before merging:
https://jenkins.confluent.io/job/system-test-kafka-br
cadonna commented on a change in pull request #8987:
URL: https://github.com/apache/kafka/pull/8987#discussion_r450989016
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -251,7 +252,7 @@ void restoreAll
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152866#comment-17152866
]
Di Campo edited comment on KAFKA-4273 at 7/7/20, 4:27 PM:
--
Thank
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152866#comment-17152866
]
Di Campo commented on KAFKA-4273:
-
Thanks Matthias.
In my case I want an emit-on-change
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152866#comment-17152866
]
Di Campo edited comment on KAFKA-4273 at 7/7/20, 4:27 PM:
--
Thank
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152866#comment-17152866
]
Di Campo edited comment on KAFKA-4273 at 7/7/20, 4:28 PM:
--
Thank
[
https://issues.apache.org/jira/browse/KAFKA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler reassigned KAFKA-10215:
Assignee: John Roesler
> MockProcessorContext doesn't work with SessionStores
> -
[
https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152888#comment-17152888
]
John Roesler commented on KAFKA-10226:
--
Hi [~wdaehn] ,
Thanks for the report, and
C0urante commented on a change in pull request #8928:
URL: https://github.com/apache/kafka/pull/8928#discussion_r451008207
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java
##
@@ -76,6 +78,15 @@ public void setup() {
dajac commented on pull request #8984:
URL: https://github.com/apache/kafka/pull/8984#issuecomment-654993589
@huxihx I am not against improving the command line but I think that the
approach that you are proposing in this PR is a bit risky for the future.
Please, take a look at my previous
Johnny-Malizia commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451015408
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we
[
https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152909#comment-17152909
]
Sophie Blee-Goldman commented on KAFKA-10017:
-
Hey [~dima5rr]
This test ass
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r451021225
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -243,18 +242,24 @@ public void handleAssignmen
abbccdda commented on a change in pull request #8986:
URL: https://github.com/apache/kafka/pull/8986#discussion_r451022144
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -460,15 +463,21 @@ boolean joinGroupIfNeede
[
https://issues.apache.org/jira/browse/KAFKA-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152912#comment-17152912
]
Guozhang Wang commented on KAFKA-10229:
---
Thanks, please feel free to update this t
dhruvilshah3 commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451024024
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we wi
junrao commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451024109
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we will rec
[
https://issues.apache.org/jira/browse/KAFKA-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152915#comment-17152915
]
Dhruvil Shah commented on KAFKA-10207:
--
Hmm, this seems pretty strange. Do you know
junrao commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451024109
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we will rec
vvcephei commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-655012979
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
vvcephei commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-655013091
Test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152928#comment-17152928
]
Matthias J. Sax commented on KAFKA-4273:
I see. I guess it's safe. Not sure how p
[
https://issues.apache.org/jira/browse/KAFKA-10226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152932#comment-17152932
]
Werner Daehn commented on KAFKA-10226:
--
As I am using the Kafka Client there are no
vvcephei commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-655019753
Looks good!
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-07--001.1594143314--chia7712--KAFKA-10191--4268ab25b/report.html
---
[
https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152944#comment-17152944
]
Clément MATHIEU commented on KAFKA-4273:
It would be useful. Incidentally, I have
mjsax merged pull request #8980:
URL: https://github.com/apache/kafka/pull/8980
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152947#comment-17152947
]
ASF GitHub Bot commented on KAFKA-10222:
huxihx opened a new pull request #272:
[
https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152949#comment-17152949
]
ASF GitHub Bot commented on KAFKA-10222:
mjsax merged pull request #272:
URL: ht
[
https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152948#comment-17152948
]
ASF GitHub Bot commented on KAFKA-10222:
mjsax commented on pull request #272:
U
vvcephei commented on pull request #8913:
URL: https://github.com/apache/kafka/pull/8913#issuecomment-655022914
Merged. Thanks, @chia7712 !
This is an automated message from the Apache Git Service.
To respond to the message,
vvcephei merged pull request #8913:
URL: https://github.com/apache/kafka/pull/8913
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Johnny-Malizia commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451040852
##
File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala
##
@@ -148,5 +148,39 @@ class TimeIndexTest {
idx.close()
}
-}
+ /*
Johnny-Malizia commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451043580
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we
vvcephei commented on pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#issuecomment-655026893
```
00:05:04.438 > Task :streams:compileTestJava
00:05:04.438
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13@2/streams/src/test/java/org/apache/kafka/test/No
1 - 100 of 152 matches
Mail list logo
