[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149170#comment-17149170 ] Manikumar commented on KAFKA-10220: --- looks like this got introduced in [https://github

[GitHub] [kafka] ijuma commented on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-07-01 Thread GitBox
ijuma commented on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-652240876 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149192#comment-17149192 ] Tom Bentley commented on KAFKA-10220: - [~omkreddy] I'm happy to fix it, but Luke is

[GitHub] [kafka] dajac commented on a change in pull request #8604: KIP-597: MirrorMaker2 internal topics Formatters

2020-07-01 Thread GitBox
dajac commented on a change in pull request #8604: URL: https://github.com/apache/kafka/pull/8604#discussion_r448178095 ## File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala ## @@ -560,20 +561,18 @@ class LoggingMessageFormatter extends MessageFormatter with Lazy

[GitHub] [kafka] highluck closed pull request #8912: KIP-446: Add changelog topic configuration to KTable suppress

2020-07-01 Thread GitBox
highluck closed pull request #8912: URL: https://github.com/apache/kafka/pull/8912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] highluck opened a new pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-07-01 Thread GitBox
highluck opened a new pull request #8965: URL: https://github.com/apache/kafka/pull/8965 KAFKA-8147: Add changelog topic configuration to KTable suppress ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

[GitHub] [kafka] highluck commented on pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-07-01 Thread GitBox
highluck commented on pull request #8965: URL: https://github.com/apache/kafka/pull/8965#issuecomment-652259344 @mjsax Should I do it like this way? thank you! This is an automated message from the Apache Git Service. T

[jira] [Commented] (KAFKA-10220) NPE when describing resources

2020-07-01 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149206#comment-17149206 ] Luke Chen commented on KAFKA-10220: --- [~tombentley], I'll submit a PR for your review l

[jira] [Created] (KAFKA-10222) Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-01 Thread huxihx (Jira)
huxihx created KAFKA-10222: -- Summary: Incorrect methods show up in 0.10 Kafka Streams docs Key: KAFKA-10222 URL: https://issues.apache.org/jira/browse/KAFKA-10222 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10222) Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-01 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxihx updated KAFKA-10222: --- Description: In 0.10 Kafka Streams doc([http://kafka.apache.org/0100/javadoc/index.html?org/apache/kafka/st

[GitHub] [kafka] showuon opened a new pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon opened a new pull request #8966: URL: https://github.com/apache/kafka/pull/8966 Add null check for configurationKey to avoid NPE, and add test for it. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[GitHub] [kafka] showuon commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-652275690 @huxihx @tombentley , could you help review this PR? Thanks. This is an automated message from the Apache Git Serv

[GitHub] [kafka] skaundinya15 commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-07-01 Thread GitBox
skaundinya15 commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r448066943 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -74,22 +76,28 @@ private final ClusterResourceListeners clusterRe

[GitHub] [kafka] tombentley commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
tombentley commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448208882 ## File path: core/src/test/scala/unit/kafka/server/AdminManagerTest.scala ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Created] (KAFKA-10223) ReplicaNotAvailableException must be retriable to handle reassignments

2020-07-01 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10223: -- Summary: ReplicaNotAvailableException must be retriable to handle reassignments Key: KAFKA-10223 URL: https://issues.apache.org/jira/browse/KAFKA-10223 Project: K

[GitHub] [kafka] showuon commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-652289242 hi @tombentley , thanks for the comments. I've updated in this commit: https://github.com/apache/kafka/pull/8966/commits/ea249ab061fa2db7ba40963ff032c85a3919ecdb. Thanks. --

[GitHub] [kafka] showuon commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448219612 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -355,8 +355,8 @@ class AdminManager(val config: KafkaConfig, def createRespon

[GitHub] [kafka] tombentley commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
tombentley commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448222519 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -354,10 +354,13 @@ class AdminManager(val config: KafkaConfig, } de

[jira] [Commented] (KAFKA-10222) Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149228#comment-17149228 ] ASF GitHub Bot commented on KAFKA-10222: huxihx commented on pull request #272:

[jira] [Commented] (KAFKA-10222) Incorrect methods show up in 0.10 Kafka Streams docs

2020-07-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149227#comment-17149227 ] ASF GitHub Bot commented on KAFKA-10222: huxihx opened a new pull request #272:

[jira] [Commented] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149278#comment-17149278 ] Amit commented on KAFKA-9247: - Still having this issue : -- org.apache.zookeeper.ZooKeeper.m

[GitHub] [kafka] showuon commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448262108 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -354,10 +354,13 @@ class AdminManager(val config: KafkaConfig, } def c

[GitHub] [kafka] showuon commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448262108 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -354,10 +354,13 @@ class AdminManager(val config: KafkaConfig, } def c

[jira] [Comment Edited] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149278#comment-17149278 ] Amit edited comment on KAFKA-9247 at 7/1/20, 10:16 AM: --- Still havin

[jira] [Commented] (KAFKA-10172) [Kafka connect] connectors, tasks metrics doubled

2020-07-01 Thread Viktor Utkin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149298#comment-17149298 ] Viktor Utkin commented on KAFKA-10172: -- Sure, sorry for delay, please give me some

[jira] [Commented] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149299#comment-17149299 ] Ismael Juma commented on KAFKA-9247: An old version of ZooKeeper in your classpath is

[GitHub] [kafka] tombentley commented on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-07-01 Thread GitBox
tombentley commented on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-652335281 All the test failures are in `org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]`, which looks to be unrelated. But I'

[GitHub] [kafka] tombentley commented on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-07-01 Thread GitBox
tombentley commented on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-652358496 @ijuma rebased, if you want to test again. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] omkreddy commented on pull request #8949: KAFKA-10214: fix flaky zookeeper_tls_test.py

2020-07-01 Thread GitBox
omkreddy commented on pull request #8949: URL: https://github.com/apache/kafka/pull/8949#issuecomment-652366530 ZK system tests passed. Merging to trunk and 2.6. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] omkreddy closed pull request #8949: KAFKA-10214: fix flaky zookeeper_tls_test.py

2020-07-01 Thread GitBox
omkreddy closed pull request #8949: URL: https://github.com/apache/kafka/pull/8949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10214) fix flaky zookeeper_tls_test.py

2020-07-01 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-10214. --- Fix Version/s: 2.6.0 Resolution: Fixed Issue resolved by pull request 8949 [https://github.co

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149437#comment-17149437 ] Bradley Peterson commented on KAFKA-9062: - I have just a question -- would these

[GitHub] [kafka] omkreddy commented on pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
omkreddy commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-652419884 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add a retry system test curl commands

2020-07-01 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652423581 Looks like that one worked: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.1593607328--vvcephei--minor-vagrant-curl-retry--85

[GitHub] [kafka] chia7712 commented on pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py

2020-07-01 Thread GitBox
chia7712 commented on pull request #8944: URL: https://github.com/apache/kafka/pull/8944#issuecomment-652435776 ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka.streams.integration.EosBetaUpgradeIntegrat

[GitHub] [kafka] showuon commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

2020-07-01 Thread GitBox
showuon commented on a change in pull request #8966: URL: https://github.com/apache/kafka/pull/8966#discussion_r448393135 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -354,10 +354,12 @@ class AdminManager(val config: KafkaConfig, } def c

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652450271 Looks like there are related failures: ``` org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldCleanUpTaskStateDirectoriesThatAreNotCurrentlyLocked org

[GitHub] [kafka] VinceMu opened a new pull request #8967: KAFKA-6520: Add DISCONNECTED state to Kafka Streams

2020-07-01 Thread GitBox
VinceMu opened a new pull request #8967: URL: https://github.com/apache/kafka/pull/8967 Work in progress, appreciate any feedback on my initial approach. Adding a disconnect status to Kafka streams. This is achieved by introducing by recording fetch disconnectedExceptions in Fetche

[GitHub] [kafka] VinceMu commented on pull request #8967: KAFKA-6520: Add DISCONNECTED state to Kafka Streams

2020-07-01 Thread GitBox
VinceMu commented on pull request #8967: URL: https://github.com/apache/kafka/pull/8967#issuecomment-652464135 @mjsax @guozhangwang , would appreciate any feedback This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-07-01 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149490#comment-17149490 ] Vince Mu commented on KAFKA-6520: - Created a work in progress PR. > When a Kafka Stream

[jira] [Comment Edited] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149509#comment-17149509 ] Amit edited comment on KAFKA-9247 at 7/1/20, 3:10 PM: -- My ~/.bashrc

[jira] [Commented] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149509#comment-17149509 ] Amit commented on KAFKA-9247: - My ~/.bashrc file i'm using ubuntu 20 i'm using apache-zookee

[GitHub] [kafka] rhauch merged pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-07-01 Thread GitBox
rhauch merged pull request #8858: URL: https://github.com/apache/kafka/pull/8858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-10153) Error Reporting in Connect Documentation

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10153: -- Fix Version/s: 2.7.0 2.6.0 > Error Reporting in Connect Documentation > ---

[jira] [Resolved] (KAFKA-10153) Error Reporting in Connect Documentation

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-10153. --- Reviewer: Randall Hauch Resolution: Fixed > Error Reporting in Connect Documentation >

[GitHub] [kafka] rhauch commented on pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-07-01 Thread GitBox
rhauch commented on pull request #7496: URL: https://github.com/apache/kafka/pull/7496#issuecomment-652482529 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ableegoldman commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652494651 EosBetaUpgradeIntegrationTest still failed a few times on the PR builds, but it seems to be actual flakiness and not a new bug in eos-beta. I'll try and tighten up the test a

[GitHub] [kafka] abbccdda commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
abbccdda commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448457381 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -100,13 +100,19 @@ public InternalTopicMa

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149530#comment-17149530 ] Sophie Blee-Goldman commented on KAFKA-9062:  [~thebearmayor] I think you cou

[GitHub] [kafka] abbccdda commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
abbccdda commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448460197 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void shou

[GitHub] [kafka] dajac opened a new pull request #8968: KAFKA-10164; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part II, Admin Changes)

2020-07-01 Thread GitBox
dajac opened a new pull request #8968: URL: https://github.com/apache/kafka/pull/8968 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149532#comment-17149532 ] Sophie Blee-Goldman commented on KAFKA-9062: Sorry, I didn't actually answer

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149541#comment-17149541 ] Bradley Peterson commented on KAFKA-9062: - [~ableegoldman] great, thanks. That bu

[GitHub] [kafka] hachikuji commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
hachikuji commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652518999 @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the Raft implementation, but we need to initialize the max valu

[GitHub] [kafka] hachikuji edited a comment on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
hachikuji edited a comment on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652518999 @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the prototype Raft implementation, but we need to initia

[jira] [Updated] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2020-07-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9009: --- Affects Version/s: 2.6.0 2.5.0 > Flaky Test > kafka.integration.MetricsDuring

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2020-07-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149560#comment-17149560 ] Boyang Chen commented on KAFKA-9009: Failed again:[https://builds.apache.org/job/kaf

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448505615 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, add

[GitHub] [kafka] abbccdda commented on pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
abbccdda commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652554760 Failed tests should be non-related as we only change on system test run. This is an automated message from the Ap

[GitHub] [kafka] junrao commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
junrao commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448527321 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, addingRe

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652566225 Thanks @kkonstantine and @abbccdda ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei merged pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
vvcephei merged pull request #8961: URL: https://github.com/apache/kafka/pull/8961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652566866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448531033 ## File path: tests/kafkatest/services/streams.py ## @@ -48,6 +48,15 @@ class StreamsTestBaseService(KafkaPathResolverMixin, JmxMixin, Service):

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652572009 The existing `streams_upgrade_test.py` passes: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.1593623647--vvcephei--kafka-

[GitHub] [kafka] guozhangwang commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652573659 > @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the prototype Raft implementation, but we need to initiali

[GitHub] [kafka] guozhangwang commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652591278 > There's a bit of a chicken-and-egg problem here, since we can't add the downgrade tests _yet_, but what I can do is to create the tickets to both fix the known downgrade is

[GitHub] [kafka] rhauch merged pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-07-01 Thread GitBox
rhauch merged pull request #7496: URL: https://github.com/apache/kafka/pull/7496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9018. -- Resolution: Fixed > Kafka Connect - throw clearer exceptions on serialisation errors >

[GitHub] [kafka] Wavez opened a new pull request #8969: Update introduction.html - fixed grammar

2020-07-01 Thread GitBox
Wavez opened a new pull request #8969: URL: https://github.com/apache/kafka/pull/8969 fixed grammar *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *S

[GitHub] [kafka] hachikuji opened a new pull request #8970: MINOR: Improve logging around initial log loading

2020-07-01 Thread GitBox
hachikuji opened a new pull request #8970: URL: https://github.com/apache/kafka/pull/8970 Users often get confused after an unclean shutdown when log recovery takes a long time. This patch attempts to make the logging clearer and provide a simple indication of loading progress. ###

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448569922 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, add

[GitHub] [kafka] guozhangwang commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448569679 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -38,107 +37,128 @@ import org.apache.kafka.streams.kstr

[jira] [Created] (KAFKA-10224) The license term about jersey is not correct

2020-07-01 Thread jaredli2020 (Jira)
jaredli2020 created KAFKA-10224: --- Summary: The license term about jersey is not correct Key: KAFKA-10224 URL: https://issues.apache.org/jira/browse/KAFKA-10224 Project: Kafka Issue Type: Bug

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448581607 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -38,107 +37,128 @@ import org.apache.kafka.streams.kstream.

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448583306 ## File path: tests/kafkatest/services/streams.py ## @@ -48,6 +48,15 @@ class StreamsTestBaseService(KafkaPathResolverMixin, JmxMixin, Service):

[GitHub] [kafka] vvcephei opened a new pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-01 Thread GitBox
vvcephei opened a new pull request #8971: URL: https://github.com/apache/kafka/pull/8971 Most of the values in the metadata upgrade test matrix are just testing the upgrade/downgrade path between two previous releases. This is unnecessary. We run the tests for all supported branches, s

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448584762 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -189,54 +189,6 @@ def test_upgrade_downgrade_brokers(self, from_version, to_vers

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448586796 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ijuma opened a new pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma opened a new pull request #8972: URL: https://github.com/apache/kafka/pull/8972 This includes important fixes. Netty is required by ZooKeeper if TLS is enabled. I verified that the netty jars were changed from 4.1.48 to 4.1.50 with this PR, `find . -name '*netty*'`:

[GitHub] [kafka] rajinisivaram commented on pull request #8959: MINOR: Fix log entry in FetchSessionHandler to specify throttle correctly

2020-07-01 Thread GitBox
rajinisivaram commented on pull request #8959: URL: https://github.com/apache/kafka/pull/8959#issuecomment-652624512 @dajac @omkreddy @cmccabe Thanks for the review, merging to trunk. This is an automated message from the Apa

[GitHub] [kafka] rajinisivaram merged pull request #8959: MINOR: Fix log entry in FetchSessionHandler to specify throttle correctly

2020-07-01 Thread GitBox
rajinisivaram merged pull request #8959: URL: https://github.com/apache/kafka/pull/8959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-01 Thread GitBox
vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-652625710 Oh, I realized this could plausibly impact the broker test also, so I kicked off a test of the whole file: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4008/

[GitHub] [kafka] vvcephei commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448598854 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment(fin

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-652633092 Alright I checked this out and pulled in this fix to add retries to the failing curl commands: let's give this yet another try: https://jenkins.confluent.io/job/system-test-k

[GitHub] [kafka] ableegoldman edited a comment on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
ableegoldman edited a comment on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-652633092 Alright I checked this out and pulled in [this fix](https://github.com/apache/kafka/pull/8961) to add retries to the failing curl commands: let's give this yet another

[jira] [Commented] (KAFKA-4090) JVM runs into OOM if (Java) client uses a SSL port without setting the security protocol

2020-07-01 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149702#comment-17149702 ] David Mollitor commented on KAFKA-4090: --- [~adupriez] Any thoughts on this? > JVM r

[GitHub] [kafka] C0urante opened a new pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once

2020-07-01 Thread GitBox
C0urante opened a new pull request #8973: URL: https://github.com/apache/kafka/pull/8973 [Jira](https://issues.apache.org/jira/browse/KAFKA-10218) We added a `canReadConfigs` field to the `DistributedHerder` a while back that gets set to `false` if the herder fails to catch up to the

[jira] [Resolved] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya resolved KAFKA-9893. -- Resolution: Implemented > Configurable TCP connection timeout and improve the initial m

[jira] [Reopened] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya reopened KAFKA-9678: -- > Introduce bounded exponential backoff in clients > --

[jira] [Resolved] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya resolved KAFKA-9678. -- Resolution: Duplicate > Introduce bounded exponential backoff in clients >

[GitHub] [kafka] guozhangwang commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448653507 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] guozhangwang commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652681930 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] omkreddy merged pull request #8969: MINOR: Update introduction.html

2020-07-01 Thread GitBox
omkreddy merged pull request #8969: URL: https://github.com/apache/kafka/pull/8969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652701636 > * Need to write the checkpoint when recycling a standby: although we do preserve the changelog offsets when recycling a task, and should therefore write the offsets when th

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448680586 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEm

[GitHub] [kafka] guozhangwang commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652708018 > 2\. But just opening a rocksdb store creates a `rocksdb` base dir in the task directory, so the `taskDirIsEmpty` check always fails and we always throw TaskCorrupted even i

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448680662 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEm

[GitHub] [kafka] guozhangwang commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652709044 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448681797 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

  1   2   >