[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask (Kafka Streams 2.5.0)

2020-06-28 Thread Brian Forkan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147236#comment-17147236 ] Brian Forkan commented on KAFKA-10205: -- Hi John, Thanks for your response. I have

[jira] [Updated] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2020-06-28 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10195: --- Attachment: (was: image-2020-06-24-10-47-44-733.png) > Move offset management codes from Consume

[jira] [Updated] (KAFKA-10195) Move offset management codes from ConsumerCoordinator to a new class

2020-06-28 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-10195: --- Description: ConsumerCoordinator has 2 main functions: # partitions assignment # offset management

[GitHub] [kafka] dengziming opened a new pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

2020-06-28 Thread GitBox
dengziming opened a new pull request #8941: URL: https://github.com/apache/kafka/pull/8941 We are adding new feature to `ConsumerCoordinator` and it's becoming more and more complex, the offset management code in `ConsumerCoordinator` can be moved to a new class because "offset managem

[GitHub] [kafka] sasukerui opened a new pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata

2020-06-28 Thread GitBox
sasukerui opened a new pull request #8942: URL: https://github.com/apache/kafka/pull/8942 in the method handleTopicMetadataRequest it has been determined whether authorizedTopics is empty,no need to judge again in the getTopicMetadata method,the method getTopicMetadata should be removed t

[GitHub] [kafka] ijuma commented on pull request #8917: KAFKA-10180: Fix security_config caching.

2020-06-28 Thread GitBox
ijuma commented on pull request #8917: URL: https://github.com/apache/kafka/pull/8917#issuecomment-650784438 We need this in 2.6 to ensure we have passing system tests, so I cherry-picked it to that branch. This is an automa

[GitHub] [kafka] ijuma commented on pull request #8942: modify the judgment condition in KafkaApis getTopicMetadata

2020-06-28 Thread GitBox
ijuma commented on pull request #8942: URL: https://github.com/apache/kafka/pull/8942#issuecomment-650784697 Thanks for the PR. Is this causing incorrect behavior or is it just a clean-up? Please note that PRs should target the master branch. --

[GitHub] [kafka] ijuma commented on pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

2020-06-28 Thread GitBox
ijuma commented on pull request #8941: URL: https://github.com/apache/kafka/pull/8941#issuecomment-650784884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on a change in pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

2020-06-28 Thread GitBox
ijuma commented on a change in pull request #8937: URL: https://github.com/apache/kafka/pull/8937#discussion_r446667029 ## File path: tools/src/main/java/org/apache/kafka/trogdor/workload/ConnectionStressWorker.java ## @@ -192,7 +191,6 @@ public boolean tryConnect() {

[GitHub] [kafka] ijuma commented on pull request #8915: MINOR; Iterate over the partitions only once when building LeaderAndIsrRequest

2020-06-28 Thread GitBox
ijuma commented on pull request #8915: URL: https://github.com/apache/kafka/pull/8915#issuecomment-650785446 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

2020-06-28 Thread GitBox
ijuma commented on pull request #8916: URL: https://github.com/apache/kafka/pull/8916#issuecomment-650785430 This is internal, so doesn't need a KIP. But I think there's a PR that does this already: https://github.com/apache/kafka/pull/7226/files Can you check @dajac? -

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-28 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650786185 Latest system test results. Down to 15 failures. http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-06-28--001.1593338982--chia7712--fix_8334_

[GitHub] [kafka] ijuma commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611

2020-06-28 Thread GitBox
ijuma commented on pull request #8893: URL: https://github.com/apache/kafka/pull/8893#issuecomment-650788296 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #8911: inLock is redundant in ControllerEventManager

2020-06-28 Thread GitBox
ijuma commented on pull request #8911: URL: https://github.com/apache/kafka/pull/8911#issuecomment-650788436 Thanks for the PR. The lock is necessary. Check `clearAndPut` for an example. This is an automated message from the

[GitHub] [kafka] ijuma closed pull request #8911: inLock is redundant in ControllerEventManager

2020-06-28 Thread GitBox
ijuma closed pull request #8911: URL: https://github.com/apache/kafka/pull/8911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma edited a comment on pull request #8911: inLock is redundant in ControllerEventManager

2020-06-28 Thread GitBox
ijuma edited a comment on pull request #8911: URL: https://github.com/apache/kafka/pull/8911#issuecomment-650788436 Thanks for the PR. The lock is necessary. Check `clearAndPut` for an example. Happy to discuss further, if this is unclear. -

[GitHub] [kafka] abbccdda commented on a change in pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for topic resource changes

2020-06-28 Thread GitBox
abbccdda commented on a change in pull request #8940: URL: https://github.com/apache/kafka/pull/8940#discussion_r446710038 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -263,7 +267,7 @@ public void testGenerateClientId() {

[GitHub] [kafka] goriunov commented on pull request #8196: KAFKA-9478: Remove zombie partition reassignments from ZooKeeper

2020-06-28 Thread GitBox
goriunov commented on pull request #8196: URL: https://github.com/apache/kafka/pull/8196#issuecomment-650835792 Do we have any progress on this issue ? This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] jiameixie opened a new pull request #8943: KAFKA-10196: Add missing '--version' option to producer-performance

2020-06-28 Thread GitBox
jiameixie opened a new pull request #8943: URL: https://github.com/apache/kafka/pull/8943 Option '--version' is missing in producer-performance. This patch is to add this option to display kafka version. Change-Id: Icfbdecfe56fb51439ec83d7ef7dc48ace3116ca2 Signed-off-by: Jiamei

[GitHub] [kafka] dengziming commented on pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

2020-06-28 Thread GitBox
dengziming commented on pull request #8941: URL: https://github.com/apache/kafka/pull/8941#issuecomment-650863226 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (KAFKA-10196) Add missing '--version' option to Kafka command producer-performance

2020-06-28 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147509#comment-17147509 ] Boyang Chen commented on KAFKA-10196: - Why do we need to display version from the co

[jira] [Commented] (KAFKA-10196) Add missing '--version' option to Kafka command producer-performance

2020-06-28 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147517#comment-17147517 ] jiamei xie commented on KAFKA-10196: [~bchen225242] Below is the output of kafka-pro

[GitHub] [kafka] ivanyu commented on pull request #8196: KAFKA-9478: Remove zombie partition reassignments from ZooKeeper

2020-06-28 Thread GitBox
ivanyu commented on pull request #8196: URL: https://github.com/apache/kafka/pull/8196#issuecomment-650910889 @goriunov TBH, I'm not actively working on this (mostly because ZooKeeper reassignment API is kind of a legacy now). --

[GitHub] [kafka] abbccdda commented on pull request #8941: KAFKA-10195: Move offset management code out of ConsumerCoordinator

2020-06-28 Thread GitBox
abbccdda commented on pull request #8941: URL: https://github.com/apache/kafka/pull/8941#issuecomment-650917644 Thanks for the refactoring. TBH, I'm not fully convinced this refactoring is simplifying the logical connections between internal classes. What is the goal for this refactoring?

[jira] [Created] (KAFKA-10209) fix flaky connect_rest_test.py

2020-06-28 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10209: -- Summary: fix flaky connect_rest_test.py Key: KAFKA-10209 URL: https://issues.apache.org/jira/browse/KAFKA-10209 Project: Kafka Issue Type: Bug

[GitHub] [kafka] chia7712 opened a new pull request #8944: KAFKA-10209 fix flaky connect_rest_test.py

2020-06-28 Thread GitBox
chia7712 opened a new pull request #8944: URL: https://github.com/apache/kafka/pull/8944 There are two new configs introduced by 371f14c3c12d2e341ac96bd52393b43a10acfa84 and 1c4eb1a5757df611735cfac9b709e0d80d0da4b3 so we have to update the expected configs in connect_rest_test.py i

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-28 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650923843 connect_rest_test.py is traced by #8944 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] pierDipi closed pull request #6348: KAFKA-5511 ConfigKeyBuilder for ConfigDef

2020-06-28 Thread GitBox
pierDipi closed pull request #6348: URL: https://github.com/apache/kafka/pull/6348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t