[jira] [Created] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-15 Thread Pavol Ipoth (Jira)
Pavol Ipoth created KAFKA-10160: --- Summary: Kafka MM2 consumer configuration Key: KAFKA-10160 URL: https://issues.apache.org/jira/browse/KAFKA-10160 Project: Kafka Issue Type: Bug Affects Ve

[jira] [Created] (KAFKA-10161) Update Documentation

2020-06-15 Thread David Jacot (Jira)
David Jacot created KAFKA-10161: --- Summary: Update Documentation Key: KAFKA-10161 URL: https://issues.apache.org/jira/browse/KAFKA-10161 Project: Kafka Issue Type: Sub-task Reporter:

[jira] [Created] (KAFKA-10162) Update Rate implementation to cope with spiky workload

2020-06-15 Thread David Jacot (Jira)
David Jacot created KAFKA-10162: --- Summary: Update Rate implementation to cope with spiky workload Key: KAFKA-10162 URL: https://issues.apache.org/jira/browse/KAFKA-10162 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-10163) Implement Broker side changes

2020-06-15 Thread David Jacot (Jira)
David Jacot created KAFKA-10163: --- Summary: Implement Broker side changes Key: KAFKA-10163 URL: https://issues.apache.org/jira/browse/KAFKA-10163 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10164) Implement Admin side changes

2020-06-15 Thread David Jacot (Jira)
David Jacot created KAFKA-10164: --- Summary: Implement Admin side changes Key: KAFKA-10164 URL: https://issues.apache.org/jira/browse/KAFKA-10164 Project: Kafka Issue Type: Sub-task R

[GitHub] [kafka] jiameixie commented on pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-15 Thread GitBox
jiameixie commented on pull request #8836: URL: https://github.com/apache/kafka/pull/8836#issuecomment-643961078 > In the new code we may not trigger `onPartitionsRevoked` anymore although `onPartitionsAssigned` is always triggered, so we can no longer rely on them to measure the latency.

[GitHub] [kafka] chia7712 commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-15 Thread GitBox
chia7712 commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-644004973 ```StoreUpgradeIntegrationTest#shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi``` is traced by https://issues.apache.org/jira/browse/KAFKA-10151 ---

[GitHub] [kafka] chia7712 edited a comment on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-15 Thread GitBox
chia7712 edited a comment on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-644004973 ```StoreUpgradeIntegrationTest#shouldMigratePersistentKeyValueStoreToTimestampedKeyValueStoreUsingPapi``` is traced by https://issues.apache.org/jira/browse/KAFKA-10151

[GitHub] [kafka] chia7712 commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-15 Thread GitBox
chia7712 commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-644005216 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Updated] (KAFKA-8835) Update documentation for URP changes in KIP-352

2020-06-15 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-8835: --- Issue Type: Task (was: Improvement) > Update documentation for URP changes in KIP-35

[jira] [Updated] (KAFKA-8835) Update documentation for URP changes in KIP-352

2020-06-15 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-8835: --- Priority: Trivial (was: Major) > Update documentation for URP changes in KIP-352 > -

[GitHub] [kafka] showuon commented on pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-15 Thread GitBox
showuon commented on pull request #8646: URL: https://github.com/apache/kafka/pull/8646#issuecomment-644030596 Thanks for the suggestion, @guozhangwang , I removed the listeners. I agree we can fix it in this way first, and keep monitoring it. Thanks. -

[GitHub] [kafka] chia7712 commented on a change in pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-15 Thread GitBox
chia7712 commented on a change in pull request #8836: URL: https://github.com/apache/kafka/pull/8836#discussion_r440078358 ## File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala ## @@ -45,40 +45,47 @@ object ConsumerPerformance extends LazyLogging { val to

[GitHub] [kafka] cadonna opened a new pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
cadonna opened a new pull request #8872: URL: https://github.com/apache/kafka/pull/8872 Without this fix the log message is ``` task [0_2] Transitioning state manager for ACTIVE task 0_2 to ACTIVE ``` but it should probably be ``` task [0_2] Transitioning state ma

[GitHub] [kafka] cadonna commented on a change in pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
cadonna commented on a change in pull request #8872: URL: https://github.com/apache/kafka/pull/8872#discussion_r440139800 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -509,11 +509,12 @@ void transitionTaskTyp

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2020-06-15 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135815#comment-17135815 ] Ryanne Dolan commented on KAFKA-10160: -- Agree this is a bug. This property is hard-

[GitHub] [kafka] cadonna commented on pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
cadonna commented on pull request #8872: URL: https://github.com/apache/kafka/pull/8872#issuecomment-644104290 Call for review: @ableegoldman @guozhangwang This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cadonna commented on a change in pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
cadonna commented on a change in pull request #8872: URL: https://github.com/apache/kafka/pull/8872#discussion_r440139800 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -509,11 +509,12 @@ void transitionTaskTyp

[jira] [Commented] (KAFKA-10159) MirrorSourceConnector don`t work on connect-distributed.sh

2020-06-15 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135817#comment-17135817 ] Ryanne Dolan commented on KAFKA-10159: -- I think you are missing target.cluster.boot

[GitHub] [kafka] cadonna opened a new pull request #8873: Avoid WARN log message when re-init from checkpoint skipped

2020-06-15 Thread GitBox
cadonna opened a new pull request #8873: URL: https://github.com/apache/kafka/pull/8873 When a re-initialisation from checkpoint is skipped the following log messages appear in the logs. ``` DEBUG stream-thread [EosTest-a2c3b21b-7af1-4dce-a3e0-6dc10932e5a2-StreamThread-1] task [

[GitHub] [kafka] cadonna commented on pull request #8873: Avoid WARN log message when re-init from checkpoint skipped

2020-06-15 Thread GitBox
cadonna commented on pull request #8873: URL: https://github.com/apache/kafka/pull/8873#issuecomment-644109233 Call for review: @ableegoldman @guozhangwang @mjsax This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-15 Thread GitBox
dajac commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r440028429 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java ## @@ -572,16 +572,18 @@ public synchronized void removeReporter(MetricsRepor

[GitHub] [kafka] abbccdda commented on pull request #8831: KAFKA-8657:Client-side automatic topic creation on Producer

2020-06-15 Thread GitBox
abbccdda commented on pull request #8831: URL: https://github.com/apache/kafka/pull/8831#issuecomment-644109922 @jiameixie Let's continue the discussion on mailing thread to get KIP-487 approved first. This is an automated m

[GitHub] [kafka] showuon edited a comment on pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-15 Thread GitBox
showuon edited a comment on pull request #8646: URL: https://github.com/apache/kafka/pull/8646#issuecomment-644030596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] bbejeck commented on pull request #6229: KAFKA-6786: Removing additional configs for StreamsBrokerDownResilienceTest

2020-06-15 Thread GitBox
bbejeck commented on pull request #6229: URL: https://github.com/apache/kafka/pull/6229#issuecomment-644170697 System test failed with `Failed while trying to discover tests: Didn't find any tests for symbol tests/kafkatest/tests/streams/streams_broker_down_resilience_test.py`. @sh-

[GitHub] [kafka] tombentley commented on pull request #8839: KIP-585: Documentation

2020-06-15 Thread GitBox
tombentley commented on pull request #8839: URL: https://github.com/apache/kafka/pull/8839#issuecomment-644176096 @kkonstantine @rhauch any chance this could be merged for 2.6, or is it too late now? This is an automated mes

[GitHub] [kafka] dajac commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-06-15 Thread GitBox
dajac commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-644192842 @tombentley I am not sure to follow what the `AppInfoParser` is doing here... Could you elaborate a bit more? Regarding option 2), I had a quick look at the implementation and

[jira] [Updated] (KAFKA-10109) kafka-acls.sh/AclCommand opens multiple AdminClients

2020-06-15 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley updated KAFKA-10109: Description: {{AclCommand.AclCommandService}} uses {{withAdminClient(opts: AclCommandOptions)(f:

[GitHub] [kafka] vvcephei commented on pull request #8865: MINOR: fix StreamsConfig parameter name variable

2020-06-15 Thread GitBox
vvcephei commented on pull request #8865: URL: https://github.com/apache/kafka/pull/8865#issuecomment-644211672 Looks like a compile warning: ``` 00:07:57.788 > Task :streams:compileJava 00:07:57.788 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/mai

[GitHub] [kafka] tombentley commented on pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-06-15 Thread GitBox
tombentley commented on pull request #8808: URL: https://github.com/apache/kafka/pull/8808#issuecomment-644211634 @dajac the problem happens when `--command-config` is given on the command line, and the config file defines a `client.id`. The `AppInfoParser` tries to register an MBean whose

[GitHub] [kafka] ableegoldman commented on a change in pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
ableegoldman commented on a change in pull request #8872: URL: https://github.com/apache/kafka/pull/8872#discussion_r440299033 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -509,11 +509,12 @@ void transitionTa

[GitHub] [kafka] guozhangwang commented on pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-15 Thread GitBox
guozhangwang commented on pull request #8646: URL: https://github.com/apache/kafka/pull/8646#issuecomment-644247677 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136012#comment-17136012 ] Sophie Blee-Goldman commented on KAFKA-10105: - Did you upgrade the clients a

[jira] [Updated] (KAFKA-9989) Wait for stable assignment StreamsUpgradeTest.test_metadata_upgrade

2020-06-15 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9989: --- Summary: Wait for stable assignment StreamsUpgradeTest.test_metadata_upgrade (was: StreamsUpgradeT

[jira] [Updated] (KAFKA-9989) Wait for stable assignment StreamsUpgradeTest.test_metadata_upgrade

2020-06-15 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9989: --- Description: After some discussion we believe there is room to improve the accuracy of this test, by

[jira] [Updated] (KAFKA-8362) LogCleaner gets stuck after partition move between log directories

2020-06-15 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-8362: Component/s: jbod > LogCleaner gets stuck after partition move between log directories > --

[jira] [Created] (KAFKA-10165) Percentiles metric leaking memory

2020-06-15 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10165: --- Summary: Percentiles metric leaking memory Key: KAFKA-10165 URL: https://issues.apache.org/jira/browse/KAFKA-10165 Project: Kafka Issue Type: B

[GitHub] [kafka] dongjinleekr commented on pull request #8117: KAFKA-8403: Suppress needs a Materialized variant

2020-06-15 Thread GitBox
dongjinleekr commented on pull request #8117: URL: https://github.com/apache/kafka/pull/8117#issuecomment-644277987 @vvcephei Here is the fix. The implementation you saw was the draft before the discussion - Now it is updated, with rebasing onto the latest trunk. Don't hesitate to talk to

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-06-15 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136069#comment-17136069 ] Guozhang Wang commented on KAFKA-10134: --- This is a bit weird to me -- discover of

[GitHub] [kafka] guozhangwang commented on pull request #8873: Avoid WARN log message when re-init from checkpoint skipped

2020-06-15 Thread GitBox
guozhangwang commented on pull request #8873: URL: https://github.com/apache/kafka/pull/8873#issuecomment-644280199 Cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] guozhangwang merged pull request #8873: Avoid WARN log message when re-init from checkpoint skipped

2020-06-15 Thread GitBox
guozhangwang merged pull request #8873: URL: https://github.com/apache/kafka/pull/8873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on a change in pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
guozhangwang commented on a change in pull request #8872: URL: https://github.com/apache/kafka/pull/8872#discussion_r440348339 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -509,11 +509,12 @@ void transitionTa

[GitHub] [kafka] guozhangwang commented on pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
guozhangwang commented on pull request #8872: URL: https://github.com/apache/kafka/pull/8872#issuecomment-644281735 Cherry-picked to 2.6. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] guozhangwang merged pull request #8872: Fix log message for transition from standby to active

2020-06-15 Thread GitBox
guozhangwang merged pull request #8872: URL: https://github.com/apache/kafka/pull/8872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-10104) Remove deprecated --zookeeper flags as specified in KIP-604

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136078#comment-17136078 ] Matthias J. Sax commented on KAFKA-10104: - It's for 3.0 (or maybe even 4.0), as

[jira] [Commented] (KAFKA-9681) Change whitelist/blacklist terms

2020-06-15 Thread sats (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136084#comment-17136084 ] sats commented on KAFKA-9681: - This Requires a KIP.  > Change whitelist/blacklist terms > --

[GitHub] [kafka] chia7712 opened a new pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox

[GitHub] [kafka] chia7712 commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox
chia7712 commented on pull request #8874: URL: https://github.com/apache/kafka/pull/8874#issuecomment-644293179 @cadonna @guozhangwang Could you take a look? This is an automated message from the Apache Git Service. To respon

[jira] [Created] (KAFKA-10166) Excessive TaskCorruptedException seen in soak

2020-06-15 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10166: --- Summary: Excessive TaskCorruptedException seen in soak Key: KAFKA-10166 URL: https://issues.apache.org/jira/browse/KAFKA-10166 Project: Kafka I

[GitHub] [kafka] mjsax commented on pull request #8855: DO NOT MERGE

2020-06-15 Thread GitBox
mjsax commented on pull request #8855: URL: https://github.com/apache/kafka/pull/8855#issuecomment-644312790 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (KAFKA-10166) Excessive TaskCorruptedException seen in test applications

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10166: Summary: Excessive TaskCorruptedException seen in test applications (was: Excessi

[jira] [Updated] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10166: Summary: Excessive TaskCorruptedException seen in testing (was: Excessive TaskCor

[jira] [Assigned] (KAFKA-10166) Excessive TaskCorruptedException seen in test applications

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10166: --- Assignee: Sophie Blee-Goldman > Excessive TaskCorruptedException seen in te

[jira] [Updated] (KAFKA-10166) Excessive TaskCorruptedException seen in test applications

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10166: Description: As the title indicates. Seen occasionally with ALOS (~20 times in two

[jira] [Assigned] (KAFKA-10166) Excessive TaskCorruptedException seen in test applications

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10166: --- Assignee: (was: Sophie Blee-Goldman) > Excessive TaskCorruptedException

[jira] [Updated] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

2020-06-15 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10166: Description: As the title indicates, long-running test applications with injected

[GitHub] [kafka] mjsax commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox
mjsax commented on pull request #8874: URL: https://github.com/apache/kafka/pull/8874#issuecomment-644328634 Thanks! Was just about to do a hotfix PR myself. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] thomasrockhu opened a new pull request #8875: Update to run coverage on Jenkins

2020-06-15 Thread GitBox
thomasrockhu opened a new pull request #8875: URL: https://github.com/apache/kafka/pull/8875 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of test

[GitHub] [kafka] guozhangwang merged pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox
guozhangwang merged pull request #8874: URL: https://github.com/apache/kafka/pull/8874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox
guozhangwang commented on pull request #8874: URL: https://github.com/apache/kafka/pull/8874#issuecomment-644329167 Ran checkstyle and spotbug locally and looks good. This is an automated message from the Apache Git Service.

[GitHub] [kafka] guozhangwang commented on pull request #8874: HOTFIX: checkstyle error in ProcessorStateManager

2020-06-15 Thread GitBox
guozhangwang commented on pull request #8874: URL: https://github.com/apache/kafka/pull/8874#issuecomment-644329675 To 2.6 as well. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] thomasrockhu closed pull request #8875: Update to run coverage on Jenkins

2020-06-15 Thread GitBox
thomasrockhu closed pull request #8875: URL: https://github.com/apache/kafka/pull/8875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rhauch commented on pull request #8839: KIP-585: Documentation

2020-06-15 Thread GitBox
rhauch commented on pull request #8839: URL: https://github.com/apache/kafka/pull/8839#issuecomment-644382512 @tombentley, yes we'll want to merge this and backport to the `2.6` branch. That branch is not yet frozen for documentation or tests. -

[GitHub] [kafka] ableegoldman closed pull request #8868: Revert "KAFKA-9983: KIP-613: add INFO level e2e latency metrics (#8697)"

2020-06-15 Thread GitBox
ableegoldman closed pull request #8868: URL: https://github.com/apache/kafka/pull/8868 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] benhannel commented on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-06-15 Thread GitBox
benhannel commented on pull request #4204: URL: https://github.com/apache/kafka/pull/4204#issuecomment-644416082 Perfect is the enemy of good. This issue has been unresolved for years because of idealism. This is an automate

[GitHub] [kafka] benhannel edited a comment on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

2020-06-15 Thread GitBox
benhannel edited a comment on pull request #4204: URL: https://github.com/apache/kafka/pull/4204#issuecomment-644416082 Perfect is the enemy of good. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

2020-06-15 Thread GitBox
michael-carter-instaclustr commented on pull request #8844: URL: https://github.com/apache/kafka/pull/8844#issuecomment-63698 Failing unit test kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles is unrelated to this pull request and is tracked by: https://issues.apache.o

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-15 Thread William Bottrell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136199#comment-17136199 ] William Bottrell commented on KAFKA-10062: -- Hi, [~psmolinski]. I'm looking into

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440473726 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -539,19 +537,18 @@ private void writeCheckpoint

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-15 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r440514740 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala ## @@ -307,8 +307,14 @@ class GroupCoordinatorConcurren

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-15 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r440514740 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala ## @@ -307,8 +307,14 @@ class GroupCoordinatorConcurren

[jira] [Created] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10167: - Summary: Streams EOS-Beta should not try to get end-offsets as read-committed Key: KAFKA-10167 URL: https://issues.apache.org/jira/browse/KAFKA-10167 Project: Kafka

[jira] [Commented] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136215#comment-17136215 ] Guozhang Wang commented on KAFKA-10167: --- The proposed solution is that even under

[jira] [Commented] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136216#comment-17136216 ] Guozhang Wang commented on KAFKA-10167: --- I've also thought about whether we need t

[GitHub] [kafka] guozhangwang opened a new pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-15 Thread GitBox
guozhangwang opened a new pull request #8876: URL: https://github.com/apache/kafka/pull/8876 Since admin client allows use to use flexible offset-spec, we can always set to use read-uncommitted regardless of the eos config. ### Committer Checklist (excluded from commit message) -

[jira] [Updated] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10167: Affects Version/s: 2.6.0 > Streams EOS-Beta should not try to get end-offsets as read-comm

[jira] [Updated] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10167: Fix Version/s: 2.6.0 > Streams EOS-Beta should not try to get end-offsets as read-committe

[jira] [Updated] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10167: Priority: Blocker (was: Major) > Streams EOS-Beta should not try to get end-offsets as re

[jira] [Updated] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10167: Component/s: streams > Streams EOS-Beta should not try to get end-offsets as read-committe

[GitHub] [kafka] junrao commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-15 Thread GitBox
junrao commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-644476784 @andrewchoi5 : Since the controller only checks KAFKA_STORAGE_ERROR in LeaderAndIsrResponse now, perhaps we can just log an error without sending an error code back for now.

[GitHub] [kafka] mjsax commented on a change in pull request #8876: KAFKA-10167: use the admin client to read end-offset

2020-06-15 Thread GitBox
mjsax commented on a change in pull request #8876: URL: https://github.com/apache/kafka/pull/8876#discussion_r440535836 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java ## @@ -834,6 +855,13 @@ public AlterClientQuotasResult alterClientQu

[jira] [Assigned] (KAFKA-10167) Streams EOS-Beta should not try to get end-offsets as read-committed

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10167: --- Assignee: Guozhang Wang > Streams EOS-Beta should not try to get end-offsets as rea

[GitHub] [kafka] andrewchoi5 commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-06-15 Thread GitBox
andrewchoi5 commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-644482079 Thanks, @junrao . Removed the population of responseMap with the `ERROR` code. This is an automated message

[GitHub] [kafka] junrao commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-15 Thread GitBox
junrao commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r440539291 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -595,8 +595,10 @@ private[log] class Cleaner(val id: Int, log.replaceSegments(List(

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136232#comment-17136232 ] Matthias J. Sax commented on KAFKA-10062: - The testing is done using `TopologyTe

[GitHub] [kafka] mjsax commented on pull request #8871: MINOR: code cleanup for inconsistent naming

2020-06-15 Thread GitBox
mjsax commented on pull request #8871: URL: https://github.com/apache/kafka/pull/8871#issuecomment-644483903 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-15 Thread GitBox
mjsax commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-644484131 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8865: MINOR: fix StreamsConfig parameter name variable

2020-06-15 Thread GitBox
mjsax commented on pull request #8865: URL: https://github.com/apache/kafka/pull/8865#issuecomment-644485931 Not sure if changing KIP-295 would be a good call. We made a mistake and can be honest about it. I'll do a quick KIP. --

[jira] [Created] (KAFKA-10168) Rename public StreamsConfig variable

2020-06-15 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-10168: --- Summary: Rename public StreamsConfig variable Key: KAFKA-10168 URL: https://issues.apache.org/jira/browse/KAFKA-10168 Project: Kafka Issue Type: Improv

[jira] [Assigned] (KAFKA-10168) Rename public StreamsConfig variable

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10168: --- Assignee: Matthias J. Sax > Rename public StreamsConfig variable >

[jira] [Updated] (KAFKA-10168) Rename public StreamsConfig variable

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10168: Description: All Kafka Streams configuration parameter are exposed via public variables th

[jira] [Updated] (KAFKA-10168) Rename public StreamsConfig variable

2020-06-15 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10168: Description: All Kafka Streams configuration parameter are exposed via public variables th

[jira] [Created] (KAFKA-10169) KafkaException: Failing batch since transaction was aborted

2020-06-15 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10169: --- Summary: KafkaException: Failing batch since transaction was aborted Key: KAFKA-10169 URL: https://issues.apache.org/jira/browse/KAFKA-10169 Project: Ka

[GitHub] [kafka] mjsax commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
mjsax commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440554249 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -714,13 +696,20 @@ void shutdown(final boolean clean)

[GitHub] [kafka] mjsax commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
mjsax commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440555142 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -215,91 +215,54 @@ public void handleAssignment(final

[GitHub] [kafka] mjsax commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
mjsax commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-644498795 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440555458 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -215,91 +215,54 @@ public void handleAssignmen

[GitHub] [kafka] mjsax commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
mjsax commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440555142 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -215,91 +215,54 @@ public void handleAssignment(final

[GitHub] [kafka] satishbellapu opened a new pull request #8877: KAFKA-9194: Missing documentation for replicaMaxWaitTimeMs config value

2020-06-15 Thread GitBox
satishbellapu opened a new pull request #8877: URL: https://github.com/apache/kafka/pull/8877 Looks it is a typo, the actual key supposed to be this #replicaFetchWaitMaxTimeMs(replica.fetch.wait.max.ms) instead of that the docs have this #replicaMaxWaitTimeMs ### Committer Checklist

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-15 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r440555918 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -714,13 +696,20 @@ void shutdown(final boolean

  1   2   >