[GitHub] [kafka] tombentley commented on pull request #8866: HOTFIX: fix compile error in o.a.k.c.u.TopicAdminTest

tombentley commented on pull request #8866: URL: https://github.com/apache/kafka/pull/8866#issuecomment-643586508 Sorry about breaking the build. Thanks @chia7712. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kkonstantine commented on pull request #8866: HOTFIX: Fix compile error in TopicAdminTest

kkonstantine commented on pull request #8866: URL: https://github.com/apache/kafka/pull/8866#issuecomment-643587843 The few test failures were not relevant. Merging to fix the build anyways. This is an automated message from

[GitHub] [kafka] kkonstantine merged pull request #8866: HOTFIX: Fix compile error in TopicAdminTest

kkonstantine merged pull request #8866: URL: https://github.com/apache/kafka/pull/8866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] tombentley commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

tombentley commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-643589445 @ableegoldman sorry about that. A fix has now been committed to trunk. Thanks to @chia7712. This is an automat

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134694#comment-17134694 ] James Cheng commented on KAFKA-10105: - Would any of you be able to provide a repro c

[GitHub] [kafka] ronatartifact commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

ronatartifact commented on pull request #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-643636943 As a new user, I am a bit concerned about warnings that appear in logs. Warnings usually indicate that the software found something questionable but not fatal. In most

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439751751 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java ## @@ -149,6 +155,16 @@

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439751792 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439752541 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -296,36 +314,6 @@ public AuthenticationException authenti

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439756327 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -554,6 +571,7 @@ private void doSend(ClientRequest clientRequest, boo

[GitHub] [kafka] d8tltanc commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-643656181 Thanks for the feedback @rajinisivaram I've modified the patch per your suggestions. Please take your time and let me know if we can start testing. ---

[GitHub] [kafka] ijuma commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

ijuma commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643656844 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

ijuma commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643657017 Do you have a link to the release notes of both projects? Generally good to include that. This is an automated mess

[GitHub] [kafka] ijuma commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

ijuma commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643656958 Thanks for the PR @akatona84. I think it's fine to use 9.4.27, the reason we downgraded Jetty was due to an incompatibility with Jersey so that shouldn't be an issue in this case.

[GitHub] [kafka] aakashnshah commented on a change in pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

aakashnshah commented on a change in pull request #8858: URL: https://github.com/apache/kafka/pull/8858#discussion_r439761095 ## File path: docs/connect.html ## @@ -258,6 +258,29 @@ REST API GET /- return basic information about the Kafka Connect cluster such as the

[GitHub] [kafka] sh-abhi commented on pull request #6229: KAFKA-6786: Removing additional configs for StreamsBrokerDownResilienceTest

sh-abhi commented on pull request #6229: URL: https://github.com/apache/kafka/pull/6229#issuecomment-643666073 @bbejeck just had some difficulty rebasing correctly with `trunk` so that we can squash our commits. However, if this isn't a concern, feel free to merge this should the system te

[GitHub] [kafka] bbejeck commented on pull request #6229: KAFKA-6786: Removing additional configs for StreamsBrokerDownResilienceTest

bbejeck commented on pull request #6229: URL: https://github.com/apache/kafka/pull/6229#issuecomment-643670725 Kicked off system test https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3961/ This is an automat

[GitHub] [kafka] ableegoldman opened a new pull request #8868: Revert "KAFKA-9983: KIP-613: add INFO level e2e latency metrics (#8697)"

ableegoldman opened a new pull request #8868: URL: https://github.com/apache/kafka/pull/8868 This reverts commit 83c616f70694637627edb6b1215738c78b74a50d. The percentiles metrics seem to be leaking memory and caused our soak applications to hit OOM and crash several times. We should

[GitHub] [kafka] fml2 opened a new pull request #8869: feat: Allow to specify a time zone when converting a timestamp to string

fml2 opened a new pull request #8869: URL: https://github.com/apache/kafka/pull/8869 This implements the proposal from [KAFKA-9781]. TimeZone matters when converting a date to a string (and vice versa). ### Committer Checklist (excluded from commit message) - [ ] Verify desi

[GitHub] [kafka] C0urante commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

C0urante commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643702246 @ijuma yep, the PR can be found here: https://github.com/apache/kafka/pull/8369. Based on the comments in it, the changes in that PR can be reverted once we upgrade to Jet

[GitHub] [kafka] farmdawgnation commented on pull request #5002: KAFKA-6725: Addition of isClosing to SinkTaskContext

farmdawgnation commented on pull request #5002: URL: https://github.com/apache/kafka/pull/5002#issuecomment-643707807 Closing since this has been dormant for awhile and the relevant KIP never garnered any support. This is an

[GitHub] [kafka] farmdawgnation closed pull request #5002: KAFKA-6725: Addition of isClosing to SinkTaskContext

farmdawgnation closed pull request #5002: URL: https://github.com/apache/kafka/pull/5002 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r439786166 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -161,6 +162,9 @@ private KafkaMbean removeAttribute(KafkaMetric

[GitHub] [kafka] apovzner commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

apovzner commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r439786379 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1287,15 +1309,97 @@ class ConnectionQuotas(config: KafkaConfig, time: Time) exte

[jira] [Commented] (KAFKA-9953) support multiple consumerGroupCoordinators in TransactionManager

[ https://issues.apache.org/jira/browse/KAFKA-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135011#comment-17135011 ] Boyang Chen commented on KAFKA-9953: Thanks for reporting the use case [~jwijgerd] .