[jira] [Updated] (KAFKA-10153) Error Reporting in Connect Documentation

2020-06-12 Thread Aakash Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aakash Shah updated KAFKA-10153: Summary: Error Reporting in Connect Documentation (was: Documentation for the Errant Record Repor

[GitHub] [kafka] aakashnshah opened a new pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-06-12 Thread GitBox
aakashnshah opened a new pull request #8858: URL: https://github.com/apache/kafka/pull/8858 Adds a section for Error Reporting in Connect. This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Updated] (KAFKA-10153) Error Reporting in Connect Documentation

2020-06-12 Thread Aakash Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aakash Shah updated KAFKA-10153: Description: Add documentation for error reporting in Kafka Connect. (was: Add documentation for

[GitHub] [kafka] aakashnshah commented on pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-06-12 Thread GitBox
aakashnshah commented on pull request #8858: URL: https://github.com/apache/kafka/pull/8858#issuecomment-643105390 @rhauch @wicknicks I've added a section in the User Guide section of the Kafka Connect documentation for error reporting in Connect. As of now it is quite sparse and high leve

[GitHub] [kafka] chia7712 commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
chia7712 commented on a change in pull request #8857: URL: https://github.com/apache/kafka/pull/8857#discussion_r439254292 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -143,13 +142,17 @@ class FinalizedFeatureChangeListener(zkClient:

[GitHub] [kafka] akatona84 opened a new pull request #8859: MINOR: Upgrading jersey and jetty versions

2020-06-12 Thread GitBox
akatona84 opened a new pull request #8859: URL: https://github.com/apache/kafka/pull/8859 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] tombentley commented on pull request #8839: KIP-585: Documentation

2020-06-12 Thread GitBox
tombentley commented on pull request #8839: URL: https://github.com/apache/kafka/pull/8839#issuecomment-643123172 @kkonstantine thanks for those, and I can confirm that I _did_ test the docs locally. This is an automated mes

[GitHub] [kafka] kowshik commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
kowshik commented on a change in pull request #8857: URL: https://github.com/apache/kafka/pull/8857#discussion_r439256273 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -143,13 +142,17 @@ class FinalizedFeatureChangeListener(zkClient:

[GitHub] [kafka] kowshik commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
kowshik commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643125081 @chia7712 Could you please help trigger a CI run? This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] akatona84 commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

2020-06-12 Thread GitBox
akatona84 commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643125088 @ijuma jersey came out with 2.31 and it is depending on 9.4.27.v20200227 jetty. Testing with 9.4.26.v20200117 is still in progress, I'm not sure what the difference is be

[GitHub] [kafka] akatona84 commented on pull request #8859: MINOR: Upgrading jersey and jetty versions

2020-06-12 Thread GitBox
akatona84 commented on pull request #8859: URL: https://github.com/apache/kafka/pull/8859#issuecomment-643125670 cc @viktorsomogyi This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] chia7712 commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
chia7712 commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643126635 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] kowshik commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
kowshik commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643132488 @chia7712 I think CI is not triggering. I'd appreciate the help if you could trigger it again. This is an automat

[GitHub] [kafka] chia7712 commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
chia7712 commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643139314 @kowshik Is this CI not working for this PR? https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2932/console

[GitHub] [kafka] chia7712 commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
chia7712 commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643142648 CI comes back :) This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mumrah commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-12 Thread GitBox
mumrah commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-643238928 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-12 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r439445841 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPositi

[GitHub] [kafka] junrao commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
junrao commented on a change in pull request #8857: URL: https://github.com/apache/kafka/pull/8857#discussion_r439460747 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -143,10 +142,13 @@ class FinalizedFeatureChangeListener(zkClient:

[GitHub] [kafka] vvcephei commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-12 Thread GitBox
vvcephei commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-643318499 All the test failures were `kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles` This is an automat

[GitHub] [kafka] vvcephei merged pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-12 Thread GitBox
vvcephei merged pull request #8764: URL: https://github.com/apache/kafka/pull/8764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] rhauch commented on a change in pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-06-12 Thread GitBox
rhauch commented on a change in pull request #8858: URL: https://github.com/apache/kafka/pull/8858#discussion_r439467273 ## File path: docs/connect.html ## @@ -258,6 +258,29 @@ REST API GET /- return basic information about the Kafka Connect cluster such as the versi

[GitHub] [kafka] rhauch commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-12 Thread GitBox
rhauch commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-64780 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-9450) Decouple inner state flushing from committing

2020-06-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-9450: Assignee: Guozhang Wang > Decouple inner state flushing from committing >

[GitHub] [kafka] bellemare commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-12 Thread GitBox
bellemare commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-64967 Thanks John! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] rhauch closed pull request #7224: KAFKA-8391, KAFKA-8661: Improve flaky Connect rebalance integration tests

2020-06-12 Thread GitBox
rhauch closed pull request #7224: URL: https://github.com/apache/kafka/pull/7224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] guozhangwang commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
guozhangwang commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439493219 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] chia7712 commented on pull request #8853: KAFKA-10147 MockAdminClient#describeConfigs(Collection

2020-06-12 Thread GitBox
chia7712 commented on pull request #8853: URL: https://github.com/apache/kafka/pull/8853#issuecomment-643346554 the failed build is traced by #8857 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-12 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r439510121 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPositi

[GitHub] [kafka] vvcephei commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-12 Thread GitBox
vvcephei commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-643355565 Np, Thanks for the fix, @bellemare ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439520870 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439522753 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -440,41 +402,35 @@ boolean tryToCompleteRestor

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439522978 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] guozhangwang commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
guozhangwang commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439523641 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439524659 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] vvcephei commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-06-12 Thread GitBox
vvcephei commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r439525305 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1069,6 +1069,13 @@ private HeartbeatRespon

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439529480 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] vvcephei commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-12 Thread GitBox
vvcephei commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-643382356 Cherry-picked to 2.6 and 2.5 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
mjsax commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439538197 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -528,7 +521,8 @@ private void maybeScheduleCheckpoint(

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439545899 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439549676 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -528,7 +521,8 @@ private void maybeScheduleChec

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-06-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134412#comment-17134412 ] Ismael Juma commented on KAFKA-10134: - [~ableegoldman] [~guozhang] Any idea? > High

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439550755 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -528,7 +521,8 @@ private void maybeScheduleChec

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439551380 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -66,11 +66,11 @@ * */ enum State {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439552656 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -66,11 +66,11 @@ * */ enum State {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
guozhangwang commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439553465 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -220,12 +215,18 @@ public void handleAssignmen

[GitHub] [kafka] kowshik commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
kowshik commented on a change in pull request #8857: URL: https://github.com/apache/kafka/pull/8857#discussion_r439551027 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -143,10 +142,13 @@ class FinalizedFeatureChangeListener(zkClient:

[GitHub] [kafka] abbccdda commented on a change in pull request #8846: [WIP] KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-12 Thread GitBox
abbccdda commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r439549625 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439555399 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -239,54 +240,15 @@ public void handleAssignmen

[jira] [Assigned] (KAFKA-10157) Multiple tests failed due to "Failed to process feature ZK node change event"

2020-06-12 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam reassigned KAFKA-10157: Assignee: Kowshik Prakasam > Multiple tests failed due to "Failed to process feat

[GitHub] [kafka] junrao commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
junrao commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643400398 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] junrao commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
junrao commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643400552 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] abbccdda commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
abbccdda commented on a change in pull request #8857: URL: https://github.com/apache/kafka/pull/8857#discussion_r439556229 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -143,10 +142,15 @@ class FinalizedFeatureChangeListener(zkClient:

[GitHub] [kafka] guozhangwang commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643401987 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643402127 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: [WIP] KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r439565657 ## File path: clients/src/main/java/org/apache/kafka/common/utils/GeometricProgression.java ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] vvcephei commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
vvcephei commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439532197 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -112,10 +112,19 @@ public void completeRestoration

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439585848 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -112,10 +112,19 @@ public void completeRestora

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439586118 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -66,11 +66,11 @@ * */ enum State {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439586398 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -219,13 +214,19 @@ public void handleAssignmen

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
rajinisivaram commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439579612 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -34,19 +36,22 @@ * */ final class ClusterConnect

[GitHub] [kafka] abbccdda commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-12 Thread GitBox
abbccdda commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r439565299 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -514,65 +554,81 @@ private boolean ch

[GitHub] [kafka] ableegoldman commented on a change in pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
ableegoldman commented on a change in pull request #8856: URL: https://github.com/apache/kafka/pull/8856#discussion_r439606939 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -952,58 +951,11 @@ public void shouldNotC

[GitHub] [kafka] andrewchoi5 opened a new pull request #8860: Change the level of logging on not being unable to process the fetch.

2020-06-12 Thread GitBox
andrewchoi5 opened a new pull request #8860: URL: https://github.com/apache/kafka/pull/8860 `Change the level of logging on not being unable to process the fetch request to trace level.` Make the unknown fetch session message trace level to not cause confusion. There exists a fixed

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439609952 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -158,9 +165,16 @@ public InetAddress currentAddress(String

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439611544 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -34,19 +36,22 @@ * */ final class ClusterConnectionSt

[GitHub] [kafka] mjsax commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
mjsax commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643456981 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
mjsax commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643456810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439621170 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -34,19 +36,22 @@ * */ final class ClusterConnectionSt

[GitHub] [kafka] mimaison merged pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-06-12 Thread GitBox
mimaison merged pull request #8312: URL: https://github.com/apache/kafka/pull/8312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439632475 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -103,6 +103,12 @@ Utils.join(SecurityProtocol.names()

[GitHub] [kafka] kowshik commented on pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
kowshik commented on pull request #8857: URL: https://github.com/apache/kafka/pull/8857#issuecomment-643475095 @apovzner Can you go ahead and merge this PR? The latest failures in CI are unrelated. This is an automated messa

[GitHub] [kafka] ableegoldman opened a new pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-12 Thread GitBox
ableegoldman opened a new pull request #8861: URL: https://github.com/apache/kafka/pull/8861 Turns out there are a number of checkstyle suppressions that aren't being actively used. Did a quick scan by removing everything and running checkstyle, then left in only those that produced an err

[GitHub] [kafka] ableegoldman commented on pull request #8861: MINOR: clean up unused checkstyle suppressions for Streams

2020-06-12 Thread GitBox
ableegoldman commented on pull request #8861: URL: https://github.com/apache/kafka/pull/8861#issuecomment-643484888 Non-urgent, but some nice cleanup after I noticed how many suppressions aren't necessary anymore @vvcephei @mjsax @guozhangwang

[GitHub] [kafka] junrao merged pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

2020-06-12 Thread GitBox
junrao merged pull request #8857: URL: https://github.com/apache/kafka/pull/8857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439646696 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +345,37 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439646696 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,6 +345,37 @@ private NodeConnectionState nodeState(St

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488049 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-10157) Multiple tests failed due to "Failed to process feature ZK node change event"

2020-06-12 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam resolved KAFKA-10157. -- Resolution: Fixed > Multiple tests failed due to "Failed to process feature ZK node ch

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439647104 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -786,6 +808,26 @@ private void handleAbortedSends(List responses) {

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488438 test this please This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488134 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang removed a comment on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang removed a comment on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488049 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488618 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643488996 test this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] tommyacin opened a new pull request #8862: Dev/t toacin/2 4 1 mirror maker

2020-06-12 Thread GitBox
tommyacin opened a new pull request #8862: URL: https://github.com/apache/kafka/pull/8862 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] ableegoldman edited a comment on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
ableegoldman edited a comment on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643490477 @guozhangwang one of the failing tests is pretty much permanently broken, still waiting on this PR to be merged: https://github.com/apache/kafka/pull/8853 Until

[GitHub] [kafka] ableegoldman commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
ableegoldman commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643490477 @guozhangwang one of the failing tests is pretty much permanently broken, still waiting on this PR to be merged: https://github.com/apache/kafka/pull/8853 --

[GitHub] [kafka] mjsax commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
mjsax commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643492691 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8856: KAFKA-10150: task state transitions/management and committing cleanup

2020-06-12 Thread GitBox
mjsax commented on pull request #8856: URL: https://github.com/apache/kafka/pull/8856#issuecomment-643492619 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-6733) Support of printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-06-12 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134552#comment-17134552 ] Badai Aqrandista commented on KAFKA-6733: - [~Matzz] Do you still want to work on

[jira] [Assigned] (KAFKA-6574) Support Headers in console-consumer and console-producer

2020-06-12 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badai Aqrandista reassigned KAFKA-6574: --- Assignee: Badai Aqrandista > Support Headers in console-consumer and console-produce

[GitHub] [kafka] d8tltanc commented on a change in pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-12 Thread GitBox
d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r439663059 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -786,6 +808,26 @@ private void handleAbortedSends(List responses) {

[GitHub] [kafka] ableegoldman commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
ableegoldman commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643509124 Will do This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
ableegoldman commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643518513 Alright, ran the full suite locally. The one test still fail (as expected) but otherwise green @guozhangwang : ``` kafka.admin.ReassignPartitionsUnitTest > testModi

[GitHub] [kafka] ableegoldman edited a comment on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
ableegoldman edited a comment on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643518513 Alright, ran the full suite locally. The one test still fail (as expected) but otherwise green @guozhangwang : ``` kafka.admin.ReassignPartitionsUnitTest > testM

[GitHub] [kafka] guozhangwang commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-643519678 Cherry-pick to 2.6. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] guozhangwang merged pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-12 Thread GitBox
guozhangwang merged pull request #8849: URL: https://github.com/apache/kafka/pull/8849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10158: -- Summary: Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress Key: KAFKA-10158 URL: https://issues.apache.or

[jira] [Updated] (KAFKA-10158) Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10158: --- Description: Altering the assignments is a async request so it is possible that the reassign

[GitHub] [kafka] chia7712 commented on pull request #8838: KAFKA-10158 Fix flaky kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-06-12 Thread GitBox
chia7712 commented on pull request #8838: URL: https://github.com/apache/kafka/pull/8838#issuecomment-643521238 > Could you link the patch to the JIRA and give a summary of the failure, and why this wait for reassignment would fix the problem? done. https://issues.apache.org/jira/bro

  1   2   >