[GitHub] [kafka] omkreddy commented on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-06 Thread GitBox
omkreddy commented on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-640014947 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-9712) Reflections library 0.9.12 introduced in 2.5 causes regression scanning for plugins on plugin_path

2020-06-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9712: -- Assignee: Matthias J. Sax (was: Nigel Liang) > Reflections library 0.9.12 introduced

[jira] [Assigned] (KAFKA-9712) Reflections library 0.9.12 introduced in 2.5 causes regression scanning for plugins on plugin_path

2020-06-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9712: -- Assignee: Nigel Liang (was: Matthias J. Sax) > Reflections library 0.9.12 introduced

[jira] [Resolved] (KAFKA-9840) Consumer should not use OffsetForLeaderEpoch without current epoch validation

2020-06-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9840. Fix Version/s: 2.6.0 Resolution: Fixed > Consumer should not use OffsetForLeaderEpoc

[jira] [Commented] (KAFKA-10094) In MirrorSourceConnector replace two-step assignment with single call

2020-06-06 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127142#comment-17127142 ] Jakob Homan commented on KAFKA-10094: - Patch accepted and merged. > In MirrorSource

[jira] [Commented] (KAFKA-8180) Deleting large number of topics can block the controller for the time it takes to delete all of them

2020-06-06 Thread James Cheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127196#comment-17127196 ] James Cheng commented on KAFKA-8180: Do we know if this has been fixed in recent vers

[jira] [Resolved] (KAFKA-10094) In MirrorSourceConnector replace two-step assignment with single call

2020-06-06 Thread Jakob Homan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan resolved KAFKA-10094. - Resolution: Fixed > In MirrorSourceConnector replace two-step assignment with single call >

[jira] [Commented] (KAFKA-5514) KafkaConsumer ignores default values in Properties object because of incorrect use of Properties object.

2020-06-06 Thread Will LaForst (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127377#comment-17127377 ] Will LaForst commented on KAFKA-5514: - I think the misuse of propertlies can be linke

[GitHub] [kafka] omkreddy closed pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-06 Thread GitBox
omkreddy closed pull request #8717: URL: https://github.com/apache/kafka/pull/8717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10033) AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing topic

2020-06-06 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-10033. --- Fix Version/s: 2.7.0 Resolution: Fixed > AdminClient should throw UnknownTopicOrPartitionExce

[GitHub] [kafka] abbccdda commented on a change in pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
abbccdda commented on a change in pull request #8820: URL: https://github.com/apache/kafka/pull/8820#discussion_r436278473 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -107,6 +107,9 @@ private boolean commitNeeded

[jira] [Updated] (KAFKA-9851) Revoking Connect tasks due to connectivity issues should also clear running assignment

2020-06-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9851: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-06 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r436278818 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinMaterializationIntegrationTest.java ## @@ -94,15 +101,

[GitHub] [kafka] guozhangwang commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
guozhangwang commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640080856 test this This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] bellemare commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-06 Thread GitBox
bellemare commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-640080864 Updated KTableKTableForeignKeyJoinScenarioTest from (String,String) to (Integer,String). This would have caught this particular bug. Reverted the JSON-related test since it's no

[GitHub] [kafka] guozhangwang commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
guozhangwang commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640080953 okay to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
guozhangwang commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640081002 okay to test This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Resolved] (KAFKA-9851) Revoking Connect tasks due to connectivity issues should also clear running assignment

2020-06-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9851. --- Resolution: Fixed > Revoking Connect tasks due to connectivity issues should

[jira] [Updated] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-7833: --- Labels: newbie (was: ) > StreamsBuilder should throw an exception if addGlobalStore and addS

[GitHub] [kafka] abbccdda commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-06-06 Thread GitBox
abbccdda commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r436283473 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -100,11 +103,11 @@ public InternalTopicMa

[GitHub] [kafka] mtillu commented on pull request #8797: Fixing KAFKA-10094

2020-06-06 Thread GitBox
mtillu commented on pull request #8797: URL: https://github.com/apache/kafka/pull/8797#issuecomment-640097211 > Thanks for the contribution! Can we please follow the guidelines as described here for future contributions? > > https://cwiki.apache.org/confluence/display/KAFKA/Contribut

[GitHub] [kafka] lbradstreet commented on a change in pull request #8807: KAFKA-10106: log time taken to handle LeaderAndIsr request

2020-06-06 Thread GitBox
lbradstreet commented on a change in pull request #8807: URL: https://github.com/apache/kafka/pull/8807#discussion_r436289337 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1242,131 +1243,138 @@ class ReplicaManager(val config: KafkaConfig,

[jira] [Created] (KAFKA-10113) LogTruncationException sets fetch offsets incorrectly

2020-06-06 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10113: --- Summary: LogTruncationException sets fetch offsets incorrectly Key: KAFKA-10113 URL: https://issues.apache.org/jira/browse/KAFKA-10113 Project: Kafka I

[GitHub] [kafka] hachikuji opened a new pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-06 Thread GitBox
hachikuji opened a new pull request #8822: URL: https://github.com/apache/kafka/pull/8822 This patch fixes a bug in the constructor of `LogTruncationException`. We were passing the divergent offsets to the super constructor as the fetch offsets. There is no way to fix this without breaking

[GitHub] [kafka] mjsax commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
mjsax commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640112555 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
mjsax commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640112530 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-06 Thread GitBox
mjsax commented on pull request #8803: URL: https://github.com/apache/kafka/pull/8803#issuecomment-640113151 Java 8 and Java 11 failed with env issue. Java 14 passed. This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-06 Thread GitBox
mjsax commented on pull request #8803: URL: https://github.com/apache/kafka/pull/8803#issuecomment-640113179 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax opened a new pull request #8823: MINOR: fix HTML markup

2020-06-06 Thread GitBox
mjsax opened a new pull request #8823: URL: https://github.com/apache/kafka/pull/8823 Call for review @bbejeck This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9891: --- Fix Version/s: 2.5.1 2.6.0 > Invalid state store content after task migrat

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-06-06 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127456#comment-17127456 ] John Roesler commented on KAFKA-10091: -- Sure thing, Guozhang! I’m a little hazy on

[GitHub] [kafka] mjsax merged pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
mjsax merged pull request #8820: URL: https://github.com/apache/kafka/pull/8820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-06 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10097: --- Assignee: Boyang Chen > Avoid getting null map for task checkpoint > --

[GitHub] [kafka] mjsax commented on pull request #8820: KAFKA-10097: Internalize checkpoint data

2020-06-06 Thread GitBox
mjsax commented on pull request #8820: URL: https://github.com/apache/kafka/pull/8820#issuecomment-640138817 Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] wlaforest opened a new pull request #8824: Kafka 5514: KafkaConsumer ignores default values in Properties object because of incorrect use of Properties object.

2020-06-06 Thread GitBox
wlaforest opened a new pull request #8824: URL: https://github.com/apache/kafka/pull/8824 KafkaConsumer (and some other classes like KafkaProducer) does not respect defaults in Properties objects. This is because a process translates the Properties to a Map in the Utils class which uses t

[jira] [Commented] (KAFKA-8180) Deleting large number of topics can block the controller for the time it takes to delete all of them

2020-06-06 Thread Gwen Shapira (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127471#comment-17127471 ] Gwen Shapira commented on KAFKA-8180: - [~dajac] merged some performance improvements

[jira] [Updated] (KAFKA-10097) Avoid passing task checkpoint file externally

2020-06-06 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10097: Summary: Avoid passing task checkpoint file externally (was: Avoid getting null map for task chec

[jira] [Resolved] (KAFKA-10097) Avoid passing task checkpoint file externally

2020-06-06 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10097. - Resolution: Fixed > Avoid passing task checkpoint file externally >

[jira] [Commented] (KAFKA-5514) KafkaConsumer ignores default values in Properties object because of incorrect use of Properties object.

2020-06-06 Thread Will LaForst (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127488#comment-17127488 ] Will LaForst commented on KAFKA-5514: - See pull request: [https://github.com/apache/k

[GitHub] [kafka] abbccdda commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-06 Thread GitBox
abbccdda commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436318626 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -852,14 +835,28 @@ public void onFailure(RuntimeExcepti

[jira] [Comment Edited] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-06 Thread Rob Meng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127500#comment-17127500 ] Rob Meng edited comment on KAFKA-7833 at 6/7/20, 4:30 AM: -- I'm l

[jira] [Commented] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-06 Thread Rob Meng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127500#comment-17127500 ] Rob Meng commented on KAFKA-7833: - I'm looking for my first issue to tackle. It sounds li

[GitHub] [kafka] kkonstantine commented on pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-06 Thread GitBox
kkonstantine commented on pull request #8805: URL: https://github.com/apache/kafka/pull/8805#issuecomment-640156075 Recent build history: jdk8 and jdk14 green jdk11 two on `org.apache.kafka.streams.integration.QueryableStateIntegrationTest` which is unrelated. Adding another

[GitHub] [kafka] ijuma commented on pull request #8807: KAFKA-10106: log time taken to handle LeaderAndIsr request

2020-06-06 Thread GitBox
ijuma commented on pull request #8807: URL: https://github.com/apache/kafka/pull/8807#issuecomment-640157773 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on a change in pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`

2020-06-06 Thread GitBox
ijuma commented on a change in pull request #8802: URL: https://github.com/apache/kafka/pull/8802#discussion_r436325309 ## File path: clients/src/main/resources/common/message/FetchRequest.json ## @@ -49,7 +49,7 @@ "fields": [ { "name": "ReplicaId", "type": "int32", "ve

[jira] [Commented] (KAFKA-8180) Deleting large number of topics can block the controller for the time it takes to delete all of them

2020-06-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127513#comment-17127513 ] Ismael Juma commented on KAFKA-8180: This too: [https://github.com/apache/kafka/pull/

[GitHub] [kafka] robin5540 opened a new pull request #8825: KAFKA-7833: Add name conflict check in StreamsGraphNode

2020-06-06 Thread GitBox
robin5540 opened a new pull request #8825: URL: https://github.com/apache/kafka/pull/8825 *Summary of testing strategy (including rationale) * Added a test that attempts to call `.addStateStore` with the same `StoreBuilder`, which builds two stores of the same name. ### Committer

[jira] [Commented] (KAFKA-7833) StreamsBuilder should throw an exception if addGlobalStore and addStateStore is called for the same store builder

2020-06-06 Thread Rob Meng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127522#comment-17127522 ] Rob Meng commented on KAFKA-7833: - PR: [https://github.com/apache/kafka/pull/8825] > Str