[jira] [Updated] (KAFKA-10043) Some parameters will be overwritten which was configured in consumer.config where running "ConsumerPerformance.scala"

2020-05-26 Thread tigertan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tigertan updated KAFKA-10043: - Fix Version/s: 2.6.0 > Some parameters will be overwritten which was configured in consumer.config > w

[jira] [Commented] (KAFKA-10041) Kafka upgrade fails from 1.1 to 2.4/2.5/trunk fails due to failure in ZooKeeper

2020-05-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116761#comment-17116761 ] Ismael Juma commented on KAFKA-10041: - The upgrade notes for Kafka mention this issu

[jira] [Comment Edited] (KAFKA-10041) Kafka upgrade fails from 1.1 to 2.4/2.5/trunk fails due to failure in ZooKeeper

2020-05-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116761#comment-17116761 ] Ismael Juma edited comment on KAFKA-10041 at 5/26/20, 1:54 PM: ---

[jira] [Updated] (KAFKA-10044) Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-05-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10044: --- Labels: need-kip (was: need-kip needs) > Deprecate ConsumerConfig#addDeserializerToConfig(P

[jira] [Updated] (KAFKA-10044) Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-05-26 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10044: --- Labels: need-kip needs (was: ) > Deprecate ConsumerConfig#addDeserializerToConfig(Propertie

[jira] [Created] (KAFKA-10044) Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer)

2020-05-26 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10044: -- Summary: Deprecate ConsumerConfig#addDeserializerToConfig(Properties, Deserializer, Deserializer) and ProducerConfig#addSerializerToConfig(Properties, Serializer, Serializer) Key: KAFKA-10044

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116792#comment-17116792 ] Bill Bejeck commented on KAFKA-10017: - [https://builds.apache.org/job/kafka-pr-jdk11

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116796#comment-17116796 ] Bill Bejeck commented on KAFKA-10017: - [https://builds.apache.org/job/kafka-pr-jdk14

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-26 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116798#comment-17116798 ] Bill Bejeck commented on KAFKA-10017: - [https://builds.apache.org/job/kafka-pr-jdk14

[jira] [Comment Edited] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-26 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098935#comment-17098935 ] Jun Wang edited comment on KAFKA-8120 at 5/26/20, 3:07 PM: --- Ste

[jira] [Comment Edited] (KAFKA-8120) Getting NegativeArraySizeException when using Kafka Connect to send data to Kafka

2020-05-26 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098935#comment-17098935 ] Jun Wang edited comment on KAFKA-8120 at 5/26/20, 3:07 PM: --- Ste

[jira] [Updated] (KAFKA-9130) Allow listing consumer groups per state

2020-05-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9130: - Fix Version/s: (was: 2.6.0) > Allow listing consumer groups per state > -

[jira] [Updated] (KAFKA-9130) Allow listing consumer groups per state

2020-05-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9130: - Fix Version/s: 2.6.0 > Allow listing consumer groups per state >

[jira] [Commented] (KAFKA-8770) Either switch to or add an option for emit-on-change

2020-05-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116908#comment-17116908 ] Randall Hauch commented on KAFKA-8770: -- Just a quick note: I've changed  [https://cw

[jira] [Comment Edited] (KAFKA-8770) Either switch to or add an option for emit-on-change

2020-05-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116908#comment-17116908 ] Randall Hauch edited comment on KAFKA-8770 at 5/26/20, 5:36 PM: ---

[jira] [Comment Edited] (KAFKA-8770) Either switch to or add an option for emit-on-change

2020-05-26 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116908#comment-17116908 ] Randall Hauch edited comment on KAFKA-8770 at 5/26/20, 5:36 PM: ---

[jira] [Assigned] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-26 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10017: Assignee: Matthias J. Sax (was: John Roesler) > Flaky Test EosBetaUpgradeIntegrationTest

[jira] [Assigned] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-26 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-10017: Assignee: John Roesler > Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlp

[jira] [Commented] (KAFKA-9821) Partition may skip assignment with static members and incremental rebalances

2020-05-26 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116943#comment-17116943 ] Sophie Blee-Goldman commented on KAFKA-9821: This issue is fixed for Streams

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2020-05-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116948#comment-17116948 ] Guozhang Wang commented on KAFKA-9897: -- https://github.com/apache/kafka/pull/8568 h

[jira] [Resolved] (KAFKA-9898) Flaky Test StoreQueryIntegrationTest.shouldQueryAllStalePartitionStores

2020-05-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9898. -- Fix Version/s: 2.6.0 Resolution: Fixed > Flaky Test StoreQueryIntegrationTest.shouldQuer

[jira] [Assigned] (KAFKA-9898) Flaky Test StoreQueryIntegrationTest.shouldQueryAllStalePartitionStores

2020-05-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-9898: Assignee: Guozhang Wang > Flaky Test StoreQueryIntegrationTest.shouldQueryAllStalePartitio

[jira] [Commented] (KAFKA-9898) Flaky Test StoreQueryIntegrationTest.shouldQueryAllStalePartitionStores

2020-05-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116950#comment-17116950 ] Guozhang Wang commented on KAFKA-9898: -- I'd mark it as resolved by https://github.co

[jira] [Created] (KAFKA-10045) Kafka Connect Connection leak to Kafka Brokers when using dead letter queue

2020-05-26 Thread rameshkrishnan muthusamy (Jira)
rameshkrishnan muthusamy created KAFKA-10045: Summary: Kafka Connect Connection leak to Kafka Brokers when using dead letter queue Key: KAFKA-10045 URL: https://issues.apache.org/jira/browse/KAFKA-1004

[jira] [Commented] (KAFKA-10045) Kafka Connect Connection leak to Kafka Brokers when using dead letter queue

2020-05-26 Thread rameshkrishnan muthusamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116987#comment-17116987 ] rameshkrishnan muthusamy commented on KAFKA-10045: -- I am working on the

[jira] [Assigned] (KAFKA-9945) TopicCommand should support --if-exists and --if-not-exists when --bootstrap-server is used

2020-05-26 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar reassigned KAFKA-9945: - Assignee: Vinoth Chandar > TopicCommand should support --if-exists and --if-not-exists w

[jira] [Commented] (KAFKA-10007) Kafka consumer offset reset despite recent group activity

2020-05-26 Thread Raman Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117039#comment-17117039 ] Raman Gupta commented on KAFKA-10007: - Just happened to me again on a completely dif

[jira] [Updated] (KAFKA-10004) ConfigCommand fails to find default broker configs without ZK

2020-05-26 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-10004: - Summary: ConfigCommand fails to find default broker configs without ZK (was: KAFKA-10004: Confi

[jira] [Comment Edited] (KAFKA-10007) Kafka consumer offset reset despite recent group activity

2020-05-26 Thread Raman Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117039#comment-17117039 ] Raman Gupta edited comment on KAFKA-10007 at 5/26/20, 8:59 PM: ---

[jira] [Commented] (KAFKA-10045) Kafka Connect Connection leak to Kafka Brokers when using dead letter queue

2020-05-26 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117148#comment-17117148 ] Chris Egerton commented on KAFKA-10045: --- [~ramkrish1489] this sounds similar to  h

[jira] [Created] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

2020-05-26 Thread John Roesler (Jira)
John Roesler created KAFKA-10046: Summary: Deprecated PartitionGrouper config is ignored Key: KAFKA-10046 URL: https://issues.apache.org/jira/browse/KAFKA-10046 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-05-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117158#comment-17117158 ] Matthias J. Sax commented on KAFKA-9891: Even if two instances run on the same se

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117161#comment-17117161 ] Matthias J. Sax commented on KAFKA-6520: Would be great if [~guozhang] and/or [~h

[jira] [Commented] (KAFKA-10007) Kafka consumer offset reset despite recent group activity

2020-05-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117178#comment-17117178 ] Ismael Juma commented on KAFKA-10007: - Thanks for the report. Could it be KAFKA-9543

[GitHub] [kafka] abbccdda closed pull request #8729: KC-276: Enhanced raft exception handling

2020-05-26 Thread GitBox
abbccdda closed pull request #8729: URL: https://github.com/apache/kafka/pull/8729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] wj1918 commented on pull request #8727: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-26 Thread GitBox
wj1918 commented on pull request #8727: URL: https://github.com/apache/kafka/pull/8727#issuecomment-634061154 @kkonstantine please review. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] hachikuji commented on pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-26 Thread GitBox
hachikuji commented on pull request #8701: URL: https://github.com/apache/kafka/pull/8701#issuecomment-634162460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rhauch commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
rhauch commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430667093 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java ## @@ -63,7 +67,7 @@ * @param config the worker con

[GitHub] [kafka] kkonstantine commented on pull request #8118: KAFKA-9472: Remove deleted tasks from status store

2020-05-26 Thread GitBox
kkonstantine commented on pull request #8118: URL: https://github.com/apache/kafka/pull/8118#issuecomment-633636275 jdk11 succeeded, and previously jdk8 The rest of the failures are flaky. This is an automated message fro

[GitHub] [kafka] kkonstantine merged pull request #8118: KAFKA-9472: Remove deleted Connect tasks from status store

2020-05-26 Thread GitBox
kkonstantine merged pull request #8118: URL: https://github.com/apache/kafka/pull/8118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-26 Thread GitBox
C0urante commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r430058102 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/PredicatedTransformation.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] guozhangwang commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-634135761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion

2020-05-26 Thread GitBox
ijuma commented on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-633805226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang commented on a change in pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-05-26 Thread GitBox
guozhangwang commented on a change in pull request #8549: URL: https://github.com/apache/kafka/pull/8549#discussion_r430034971 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1415,8 +1419,10 @@ public void handleRe

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-26 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-633763929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] gharris1727 commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
gharris1727 commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430761599 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633730773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] abbccdda commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-05-26 Thread GitBox
abbccdda commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r430737606 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -0,0 +1,232 @@ +package kafka.server + +import java.util.concurre

[GitHub] [kafka] mimaison commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-26 Thread GitBox
mimaison commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r430721875 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"), USE_ALL_DNS_IPS("use

[jira] [Created] (KAFKA-10047) Unnecessary widening of (int to long) scope in FloatSerializer

2020-05-26 Thread Guru Tahasildar (Jira)
Guru Tahasildar created KAFKA-10047: --- Summary: Unnecessary widening of (int to long) scope in FloatSerializer Key: KAFKA-10047 URL: https://issues.apache.org/jira/browse/KAFKA-10047 Project: Kafka

[GitHub] [kafka] viktorsomogyi commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-05-26 Thread GitBox
viktorsomogyi commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-633909772 @ijuma @omkreddy would you please have a look at this? This is an automated message from the Apache Git Serv

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
rajinisivaram commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r430299529 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -1742,6 +1746,12 @@ class SocketServerTest { selector =

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-05-26 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-634134203 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac opened a new pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-05-26 Thread GitBox
dajac opened a new pull request #8724: URL: https://github.com/apache/kafka/pull/8724 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r430778603 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] chia7712 commented on a change in pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-26 Thread GitBox
chia7712 commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r430420853 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -573,18 +573,6 @@ private void maybeOverrideClientId(Map

[GitHub] [kafka] guozhangwang commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-633667548 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] nresare commented on pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-26 Thread GitBox
nresare commented on pull request #8605: URL: https://github.com/apache/kafka/pull/8605#issuecomment-634019994 @chia7712 did you get around to update the PR with a variant that removes the no-longer-used `addDeserializerToConfig()` method? -

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634347693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r430787299 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -42,48 +41,36 @@ import static org.

[GitHub] [kafka] ijuma commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
ijuma commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-633725248 @rajinisivaram What's the implication of not removing the completed receive in `doClose`? This is an automated mess

[GitHub] [kafka] ijuma opened a new pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-26 Thread GitBox
ijuma opened a new pull request #8728: URL: https://github.com/apache/kafka/pull/8728 - Avoid tuple allocations by using `foreachEntry` and `update` methods - Use `empty` instead of `apply` to avoid unnecessary array allocation ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] ijuma commented on a change in pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
ijuma commented on a change in pull request #8709: URL: https://github.com/apache/kafka/pull/8709#discussion_r429653946 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -120,14 +119,6 @@ class DelayedFetch(delayMs: Long, accumulatedSize

[GitHub] [kafka] chia7712 closed pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-05-26 Thread GitBox
chia7712 closed pull request #8685: URL: https://github.com/apache/kafka/pull/8685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r430826643 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -186,9 +192,19 @@ private void validateNoActiveConsumers(final String groupId,

[GitHub] [kafka] abbccdda commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-26 Thread GitBox
abbccdda commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-633753970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] hachikuji merged pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-26 Thread GitBox
hachikuji merged pull request #8701: URL: https://github.com/apache/kafka/pull/8701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-05-26 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r430348986 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -34,7 +34,7 @@ object Json { * Parse a JSON string into a JsonValue if possible. `None` is

[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-26 Thread GitBox
d8tltanc commented on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-634304819 closed due to https://github.com/apache/kafka/pull/8628 This is an automated message from the Apache Git Service.

[GitHub] [kafka] guozhangwang commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-634133973 `streams:test-utils:checkstyleMain` failed. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430753853 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCode(

[GitHub] [kafka] viktorsomogyi commented on pull request #5620: KAFKA-1880: Add support for checking binary/source compatibility

2020-05-26 Thread GitBox
viktorsomogyi commented on pull request #5620: URL: https://github.com/apache/kafka/pull/5620#issuecomment-634040488 @cmccabe just checking back, would you please let me know if you have time ro review this or shall we postpone it? -

[GitHub] [kafka] chia7712 commented on pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-05-26 Thread GitBox
chia7712 commented on pull request #8685: URL: https://github.com/apache/kafka/pull/8685#issuecomment-634167948 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] pgwhalen commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
pgwhalen commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-633703760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] mjsax commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
mjsax commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634329391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax commented on pull request #8395: Added doc for KIP-535 and updated it for KIP-562

2020-05-26 Thread GitBox
mjsax commented on pull request #8395: URL: https://github.com/apache/kafka/pull/8395#issuecomment-634332833 Merged to `trunk` and cherry-picked to `2.5`. Thanks for the PR @brary! Can you also do a PR against `kafka-site` repository so we can get this updates into the web page right

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430590488 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-633733992 Only known flaky EOS tests are failing: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka

[GitHub] [kafka] guozhangwang removed a comment on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-26 Thread GitBox
guozhangwang removed a comment on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-634135838 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] d8tltanc closed pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-26 Thread GitBox
d8tltanc closed pull request #8615: URL: https://github.com/apache/kafka/pull/8615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-05-26 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r429593151 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -0,0 +1,232 @@ +package kafka.server + +import java.util.concurren

[GitHub] [kafka] hachikuji commented on pull request #7886: KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility

2020-05-26 Thread GitBox
hachikuji commented on pull request #7886: URL: https://github.com/apache/kafka/pull/7886#issuecomment-634362859 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-633667449 Before this patch, the client.id set in the config file would be overridden. This is an automated message fro

[GitHub] [kafka] ijuma commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-26 Thread GitBox
ijuma commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-633684708 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma edited a comment on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
ijuma edited a comment on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634126643 Makes sense, let me review this one as it stands then. This is an automated message from the Apache Git Servi

[GitHub] [kafka] rhauch commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
rhauch commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r429975231 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-634339348 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mimaison commented on pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-05-26 Thread GitBox
mimaison commented on pull request #8238: URL: https://github.com/apache/kafka/pull/8238#issuecomment-634249266 @hachikuji Yes I think it's better this way. I'll update the KIP This is an automated message from the Apache Git

[GitHub] [kafka] pgwhalen commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
pgwhalen commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r430608121 ## File path: streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountProcessorDemo.java ## @@ -93,8 +93,6 @@ public void proc

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-26 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r428949769 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -550,19 +584,22 @@ class ReplicaManager(val config: KafkaConfig, * Append messa

[GitHub] [kafka] rajinisivaram commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
rajinisivaram commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-633934633 @ijuma By not updating `completedReceives` when the channel is closed, we retain a reference to the channel until the next `poll()`. In terms of receives themselves, there i

[GitHub] [kafka] cemo commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-26 Thread GitBox
cemo commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-634010610 @mjarvie when this fix will be released? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on pull request #8726: MINOR: Remove unused `Json.legacyEncodeAsString`

2020-05-26 Thread GitBox
ijuma commented on pull request #8726: URL: https://github.com/apache/kafka/pull/8726#issuecomment-634290104 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] hachikuji commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-26 Thread GitBox
hachikuji commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-633682056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] mumrah commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
mumrah commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430482879 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SYSTEM

[GitHub] [kafka] wj1918 opened a new pull request #8727: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-26 Thread GitBox
wj1918 opened a new pull request #8727: URL: https://github.com/apache/kafka/pull/8727 Bug fix only, [JIRA]( https://issues.apache.org/jira/browse/KAFKA-8120) 1. The Outer loop Issue, at Original line 134 of FileStreamSourceTask.java while (readerCopy.ready()) { Since the

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r430089754 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -678,7 +701,8 @@ ErrorHandlingMetrics errorHandlingMetr

[GitHub] [kafka] MuqadderIqbal commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

2020-05-26 Thread GitBox
MuqadderIqbal commented on pull request #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-633726540 Hi all, very pleased to see the contributors/maintainers taking a longer but safer approach in getting this fixed on Windows. Much appreciated! Can someone please look into

[GitHub] [kafka] hachikuji commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
hachikuji commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634124729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-26 Thread GitBox
ijuma commented on pull request #8728: URL: https://github.com/apache/kafka/pull/8728#issuecomment-634194854 `foreachEntry` doesn't exist in Scala 2.12, so will have to revert that change. This is an automated message from t

  1   2   >