[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-21 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631921191 retest this, please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Created] (KAFKA-10028) KIP-584: Implement write path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10028: Summary: KIP-584: Implement write path for versioning scheme for features Key: KAFKA-10028 URL: https://issues.apache.org/jira/browse/KAFKA-10028 Project: Kaf

[jira] [Updated] (KAFKA-10027) Implement read path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10027: - Summary: Implement read path for versioning scheme for features (was: KIP-584: Implemen

[jira] [Updated] (KAFKA-10027) Implement read path for feature versioning scheme

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10027: - Summary: Implement read path for feature versioning scheme (was: Implement read path fo

[jira] [Updated] (KAFKA-10028) Implement write path for feature versioning scheme

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10028: - Summary: Implement write path for feature versioning scheme (was: Implement write path

[jira] [Updated] (KAFKA-10028) Implement write path for versioning scheme for features

2020-05-21 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-10028: - Summary: Implement write path for versioning scheme for features (was: KIP-584: Impleme

[GitHub] [kafka] chia7712 commented on a change in pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8701: URL: https://github.com/apache/kafka/pull/8701#discussion_r428495190 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -180,6 +180,17 @@ object RollParams { } } +sealed trait LogStartIncrementCause Review co

[GitHub] [kafka] chia7712 commented on a change in pull request #8692: KAFKA-10018: Change command line tools from /bin/sh to /bin/bash

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8692: URL: https://github.com/apache/kafka/pull/8692#discussion_r428496868 ## File path: bin/zookeeper-server-stop.sh ## @@ -1,4 +1,4 @@ -#!/bin/sh Review comment: Should we apply this change to ```zookeeper-shell.sh``` fo

[GitHub] [kafka] chia7712 commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-21 Thread GitBox
chia7712 commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r428499696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -835,9 +836,9 @@ * @param topic the topic name * @p

[GitHub] [kafka] showuon commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-05-21 Thread GitBox
showuon commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r428519103 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void shouldAppl

[GitHub] [kafka] showuon commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-05-21 Thread GitBox
showuon commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r428519103 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void shouldAppl

[GitHub] [kafka] jiameixie commented on a change in pull request #8692: KAFKA-10018: Change command line tools from /bin/sh to /bin/bash

2020-05-21 Thread GitBox
jiameixie commented on a change in pull request #8692: URL: https://github.com/apache/kafka/pull/8692#discussion_r428527359 ## File path: bin/zookeeper-server-stop.sh ## @@ -1,4 +1,4 @@ -#!/bin/sh Review comment: @chia7712 Yes, I modified just now. -

[jira] [Created] (KAFKA-10029) Selector.completedReceives should not be modified when channel is closed

2020-05-21 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10029: -- Summary: Selector.completedReceives should not be modified when channel is closed Key: KAFKA-10029 URL: https://issues.apache.org/jira/browse/KAFKA-10029 Project:

[jira] [Created] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
Dima R created KAFKA-10030: -- Summary: Throw exception while fetching a key from a single partition Key: KAFKA-10030 URL: https://issues.apache.org/jira/browse/KAFKA-10030 Project: Kafka Issue Type:

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428579361 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -236,6 +244,8 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] dima5rr opened a new pull request #8704: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr opened a new pull request #8704: URL: https://github.com/apache/kafka/pull/8704 StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is not correct behaviour in multi-threaded env where state store partitions are distributed among several Strea

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428580805 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,26 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] dima5rr closed pull request #8704: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr closed pull request #8704: URL: https://github.com/apache/kafka/pull/8704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428581576 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -37,7 +37,16 @@ public RemoveMember

[GitHub] [kafka] rajinisivaram opened a new pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-21 Thread GitBox
rajinisivaram opened a new pull request #8705: URL: https://github.com/apache/kafka/pull/8705 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428583883 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3647,7 +3679,7 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585120 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -41,7 +41,7 @@ import org.apache.kafka.common.request

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585373 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class PlaintextAdminIntegrationTe

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428585617 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class PlaintextAdminIntegrationTe

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428586730 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class PlaintextAdminIntegrationTe

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428587018 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class PlaintextAdminIntegrationTe

[GitHub] [kafka] dima5rr opened a new pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
dima5rr opened a new pull request #8706: URL: https://github.com/apache/kafka/pull/8706 StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is not correct behaviour in multi-threaded env where state store partitions are distributed among several Strea

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428588172 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1147,6 +1175,16 @@ class PlaintextAdminIntegrationTes

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632027791 @abbccdda Updated, call for review, thanks! This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428589350 ## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ## @@ -1017,47 +1017,71 @@ class PlaintextAdminIntegrationTe

[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- External issue URL: https://github.com/apache/kafka/pull/8706 > Throw exception while fetching a key from a

[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- External issue URL: (was: https://github.com/apache/kafka/pull/8706) > Throw exception while fetching a ke

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428618604 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -63,12 +59,7 @@ public String version() { @Overr

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428621073 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -63,12 +59,7 @@ public String version() { @Overr

[GitHub] [kafka] wj1918 commented on a change in pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 commented on a change in pull request #8612: URL: https://github.com/apache/kafka/pull/8612#discussion_r428622562 ## File path: connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceTask.java ## @@ -77,91 +68,34 @@ public void start(Map props) {

[GitHub] [kafka] wj1918 edited a comment on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
wj1918 edited a comment on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate commit of refactoring and bug fix. Major change block of FileStreamSourceTask.java

[jira] [Updated] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Dima R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dima R updated KAFKA-10030: --- Description: StreamThreadStateStoreProvider#stores throws exception whenever taskId is not found, which is

[GitHub] [kafka] nresare opened a new pull request #8707: Simplify KafkaConsumer constructor logic

2020-05-21 Thread GitBox
nresare opened a new pull request #8707: URL: https://github.com/apache/kafka/pull/8707 This mirrors how the KafkaProducer constructors are organised and reduce code duplication. More specifically this PR makes the following changes without changing any behaviour or public API:

[jira] [Commented] (KAFKA-10029) Selector.completedReceives should not be modified when channel is closed

2020-05-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113165#comment-17113165 ] Ismael Juma commented on KAFKA-10029: - Good catch. Is this a recent regression? > S

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-21 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-632073022 @nizhikov Thanks. Can you update the KIP and start the voting on it? This is an automated message from the Apache Gi

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-21 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-632087277 @ijuma [KIP-573](https://cwiki.apache.org/confluence/display/KAFKA/KIP-573%3A+Enable+TLSv1.3+by+default) updated. Actually, I'm started one ([link](https://mail-archives.apac

[GitHub] [kafka] lbradstreet opened a new pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion

2020-05-21 Thread GitBox
lbradstreet opened a new pull request #8708: URL: https://github.com/apache/kafka/pull/8708 We unnecessarily iterate the versions list each time we lookup lastVersion, including in the hotpath Log.appendAsFollower. Given that allVersions is a constant, this is unnecessary. See the profile

[GitHub] [kafka] lbradstreet closed pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion

2020-05-21 Thread GitBox
lbradstreet closed pull request #8708: URL: https://github.com/apache/kafka/pull/8708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] lbradstreet commented on pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion

2020-05-21 Thread GitBox
lbradstreet commented on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-632110111 Temporarily closing this. I'm surprised that we actually see latestVersion being called here. This is an auto

[jira] [Commented] (KAFKA-10029) Selector.completedReceives should not be modified when channel is closed

2020-05-21 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113226#comment-17113226 ] Rajini Sivaram commented on KAFKA-10029: [~ijuma] It was a regression in 2.5.0 i

[GitHub] [kafka] lbradstreet removed a comment on pull request #8708: MINOR: avoid unnecessary list iteration in ApiVersion.lastVersion

2020-05-21 Thread GitBox
lbradstreet removed a comment on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-632110111 Temporarily closing this. I'm surprised that we actually see latestVersion being called here. This is

[jira] [Assigned] (KAFKA-9980) Text encoding bug prevents correctly setting client quotas for default entities

2020-05-21 Thread Brian Byrne (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Byrne reassigned KAFKA-9980: -- Assignee: Brian Byrne (was: Cheng Tan) > Text encoding bug prevents correctly setting client

[jira] [Commented] (KAFKA-9980) Text encoding bug prevents correctly setting client quotas for default entities

2020-05-21 Thread Brian Byrne (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113260#comment-17113260 ] Brian Byrne commented on KAFKA-9980: Updated patch here: https://github.com/apache/ka

[GitHub] [kafka] cmccabe commented on pull request #8658: KAFKA-9980: Fix client quotas default entity name handling in broker.

2020-05-21 Thread GitBox
cmccabe commented on pull request #8658: URL: https://github.com/apache/kafka/pull/8658#issuecomment-632144774 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] chia7712 commented on pull request #8703: MINOR: add a getOrCreate function to KRPC collections

2020-05-21 Thread GitBox
chia7712 commented on pull request #8703: URL: https://github.com/apache/kafka/pull/8703#issuecomment-632170085 What is the purpose of this new method? Should we add ```getOrCreate``` to ```ImplicitLinkedHashMultiCollection``` as well? -

[GitHub] [kafka] rhauch merged pull request #8653: MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics

2020-05-21 Thread GitBox
rhauch merged pull request #8653: URL: https://github.com/apache/kafka/pull/8653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 commented on pull request #8707: Simplify KafkaConsumer constructor logic

2020-05-21 Thread GitBox
chia7712 commented on pull request #8707: URL: https://github.com/apache/kafka/pull/8707#issuecomment-632182363 It seems #8605 is duplicate to this issue. This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] rajinisivaram commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-21 Thread GitBox
rajinisivaram commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-632186914 Test failures unrelated, merging to trunk. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] rajinisivaram merged pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-21 Thread GitBox
rajinisivaram merged pull request #8650: URL: https://github.com/apache/kafka/pull/8650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vvcephei commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-21 Thread GitBox
vvcephei commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428764142 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAnd

[GitHub] [kafka] rnpridgeon commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-21 Thread GitBox
rnpridgeon commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428760555 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-21 Thread GitBox
chia7712 commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-632196447 How about making a collection copy of ```completedReceives``` when traversing ```completedReceives```? This is

[GitHub] [kafka] abbccdda commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
abbccdda commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r428745517 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,26 @@ private boolean dependsOnSpecificNode(C

[GitHub] [kafka] hachikuji commented on pull request #8651: kafkatest: Deploy VerifiableClient in constructor to avoid test timeouts

2020-05-21 Thread GitBox
hachikuji commented on pull request #8651: URL: https://github.com/apache/kafka/pull/8651#issuecomment-632223688 Link to tests: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-05-20--001.1589989080--edenhill--verifclt_deploy--227c13b64/report.html

[GitHub] [kafka] hachikuji merged pull request #8651: kafkatest: Deploy VerifiableClient in constructor to avoid test timeouts

2020-05-21 Thread GitBox
hachikuji merged pull request #8651: URL: https://github.com/apache/kafka/pull/8651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion

2020-05-21 Thread GitBox
ijuma commented on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-632234746 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] rajinisivaram commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-21 Thread GitBox
rajinisivaram commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-632241769 @chia7712 I was tempted to do that initially, but that is not the pattern we use for everything else in Selector and it has always been this way (for several years), so addi

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-05-21 Thread Andrew Garrett (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113414#comment-17113414 ] Andrew Garrett commented on KAFKA-9747: --- I'm seeing similar behavior, getting rando

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-21 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632246270 @abbccdda Thanks so much for the timely and detailed comments, I will update soon. This is an automated messag

[GitHub] [kafka] abbccdda commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-05-21 Thread GitBox
abbccdda commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-632246269 @ijuma will ping Jason for another review This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] nresare commented on pull request #8707: Simplify KafkaConsumer constructor logic

2020-05-21 Thread GitBox
nresare commented on pull request #8707: URL: https://github.com/apache/kafka/pull/8707#issuecomment-632248424 @chia7712 what an interesting coincidence that our changes looks almost identical although I can assure you that they have been developed completely independently --

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-21 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428812516 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] bbejeck closed pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates

2020-05-21 Thread GitBox
bbejeck closed pull request #8637: URL: https://github.com/apache/kafka/pull/8637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates

2020-05-21 Thread GitBox
bbejeck commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-632249736 >I think it's best to close this PR and also the ticker (either as "not a problem" or "won't fix")? ack Th

[GitHub] [kafka] nresare commented on pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-21 Thread GitBox
nresare commented on pull request #8605: URL: https://github.com/apache/kafka/pull/8605#issuecomment-632250830 @ijuma please note that this diff has changed fundamentally since you reviewed it, and it now modifies KafkaConsumer and not KafkaProducer. I would like to endorse this PR.

[GitHub] [kafka] bbejeck commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-21 Thread GitBox
bbejeck commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428815724 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndM

[GitHub] [kafka] nresare commented on pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-21 Thread GitBox
nresare commented on pull request #8605: URL: https://github.com/apache/kafka/pull/8605#issuecomment-632253490 Please note that `addDeserializerToConfig(Properties, Deserializer, Deserializer)` is now only used in test cases and can be removed along with the two tests of that method. ---

[GitHub] [kafka] hachikuji commented on a change in pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-21 Thread GitBox
hachikuji commented on a change in pull request #8701: URL: https://github.com/apache/kafka/pull/8701#discussion_r428819911 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -180,6 +180,17 @@ object RollParams { } } +sealed trait LogStartIncrementCause Review c

[GitHub] [kafka] chia7712 commented on pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-21 Thread GitBox
chia7712 commented on pull request #8605: URL: https://github.com/apache/kafka/pull/8605#issuecomment-632256376 @nresare This "coincidence" is more favorite than "approved" :) This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
mjsax commented on a change in pull request #8706: URL: https://github.com/apache/kafka/pull/8706#discussion_r428831152 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -332,6 +332,7 @@ private Properties streamsConf

[GitHub] [kafka] kkonstantine commented on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-21 Thread GitBox
kkonstantine commented on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-632265994 @wj1918 thanks for opening a PR! I'd definitely recommend fleshing out the bugfix in a separate PR from the rest of the refactoring since the latter does not seem triv

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-632265933 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Assigned] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10030: --- Assignee: Dima R > Throw exception while fetching a key from a single partition > -

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

2020-05-21 Thread GitBox
mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-632267029 @vinothchandar @brary for review This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (KAFKA-10030) Throw exception while fetching a key from a single partition

2020-05-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113449#comment-17113449 ] Matthias J. Sax commented on KAFKA-10030: - Thanks for the bug report and PR! – I

[GitHub] [kafka] xinzhuxiansheng commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox
xinzhuxiansheng commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-632275998 > > > test this please I just added a unit test to validate the code This is an automated m

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288255 test this jenkins This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-21 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288176 `test this` is actually a keyword to trigger jenkins job :) But thank you. This is an automated messa

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-21 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-632288310 Incorporated @kkonstantine's more recent suggestions, and further changed `TopicAdmin` to use existing `TopicConfig` constants rather than string literals. Rebased to pick

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-21 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-632288718 FYI: previous builds had no failures related to Connect. This is an automated message from the Apache Git Service.

[GitHub] [kafka] rhauch merged pull request #8379: KAFKA-9780: Deprecate commit records without record metadata

2020-05-21 Thread GitBox
rhauch merged pull request #8379: URL: https://github.com/apache/kafka/pull/8379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Resolved] (KAFKA-9780) Deprecate commit records without record metadata

2020-05-21 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9780. -- Reviewer: Randall Hauch Resolution: Fixed Merged to `trunk` after [KIP-586|https://cwiki

[GitHub] [kafka] rhauch commented on pull request #6284: KAFKA-6755: Allow literal value for MaskField SMT

2020-05-21 Thread GitBox
rhauch commented on pull request #6284: URL: https://github.com/apache/kafka/pull/6284#issuecomment-632301873 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on pull request #6284: KAFKA-6755: Allow literal value for MaskField SMT

2020-05-21 Thread GitBox
rhauch commented on pull request #6284: URL: https://github.com/apache/kafka/pull/6284#issuecomment-632302071 Rebased on latest `trunk` to correct a conflict in the `docs/connect.html` file. This is an automated message from

[GitHub] [kafka] abbccdda commented on pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-21 Thread GitBox
abbccdda commented on pull request #8677: URL: https://github.com/apache/kafka/pull/8677#issuecomment-632305083 Have updated the PR with my current understanding of the proposal @vvcephei @ableegoldman , the part that needs more discussion is on the case for `prepareRepartitionTopics` whic

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-21 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-632308200 Since the vote passed, can we flesh out the PR to include more tests that exercise TLS 1.3? A few things to think about: 1. Unit tests like the ones included in the PR current

[GitHub] [kafka] rhauch commented on a change in pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-21 Thread GitBox
rhauch commented on a change in pull request #8620: URL: https://github.com/apache/kafka/pull/8620#discussion_r428877515 ## File path: checkstyle/import-control.xml ## @@ -362,6 +362,7 @@ + Review comment: FYI: this new dependency has no tr

[GitHub] [kafka] rhauch commented on pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-21 Thread GitBox
rhauch commented on pull request #8620: URL: https://github.com/apache/kafka/pull/8620#issuecomment-632309635 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-21 Thread GitBox
rhauch commented on pull request #8620: URL: https://github.com/apache/kafka/pull/8620#issuecomment-632309779 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-21 Thread GitBox
rhauch commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-632312121 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-21 Thread GitBox
rhauch commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-632311965 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kkonstantine commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-21 Thread GitBox
kkonstantine commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-632317445 2/3 build green, yet a failure that seems unrelated but happened during a connect IT. Given that I'll rerun once more. -

[GitHub] [kafka] kkonstantine commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-21 Thread GitBox
kkonstantine commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-632317517 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] kkonstantine commented on a change in pull request #8118: KAFKA-9472: Remove deleted tasks from status store

2020-05-21 Thread GitBox
kkonstantine commented on a change in pull request #8118: URL: https://github.com/apache/kafka/pull/8118#discussion_r428455039 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TaskStatus.java ## @@ -61,5 +61,16 @@ public TaskStatus(ConnectorTaskId i

[GitHub] [kafka] C0urante commented on a change in pull request #8118: KAFKA-9472: Remove deleted tasks from status store

2020-05-21 Thread GitBox
C0urante commented on a change in pull request #8118: URL: https://github.com/apache/kafka/pull/8118#discussion_r428897363 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TaskStatus.java ## @@ -61,5 +61,16 @@ public TaskStatus(ConnectorTaskId id, S

  1   2   >